Re: [FFmpeg-devel] patch for hevc decoder

2014-11-11 Thread Mickaël Raulet
Looks good to me. Looks like an evil bitstream. Mickaël > Le 11 nov. 2014 à 03:54, Timothy Gu a écrit : > > Hi, > > On Monday, November 10, 2014, WeiChangjiang > wrote: > >> Hi guys, >> The attached is a very minor fix for hevc decoder. For big negative >> motion vector, namely, mv_y, the

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread wm4
On Tue, 11 Nov 2014 08:31:24 +0100 Lukasz Marek wrote: > TODO: bump minor version, update doc/APIchanges > > Function allows to create string containing object's serialized options. > Such string may be passed back to av_set_options_string() in order to restore > options. > > Signed-off-by: Lu

Re: [FFmpeg-devel] Resubmit patch01 - RE: [patch 2/4] Fix bug for POWERLE: libavcodec/ppc/me_cmp.c

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 02:15:49PM +0800, rongyan wrote: > Hi, > Thanks for your patience and review. > New patch please find in the attachment. This is the first of two. > The fate test result is here: > > Regards, > Rong Yan > > >

Re: [FFmpeg-devel] patch for hevc decoder

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 09:04:41AM +0100, Mickaël Raulet wrote: > Looks good to me. Looks like an evil bitstream. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong. signatur

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:23AM +0100, Lukasz Marek wrote: > TODO: bump minor version, update doc/APIchanges > > New function allows to check if option is set to its default > > Signed-off-by: Lukasz Marek LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FA

Re: [FFmpeg-devel] [PATCH 7/9] libavcodec/options_table: set min to -1 for timecode_frame_start

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:29AM +0100, Lukasz Marek wrote: > timecode_frame_start is set to -1 in avcodec_get_context_defaults3() > AVOptions API complains about it. > > Signed-off-by: Lukasz Marek > --- > libavcodec/options_table.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGT

Re: [FFmpeg-devel] [PATCH 8/9] bavcodec/options_table: add pixel_format and video_size options

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:30AM +0100, Lukasz Marek wrote: > Adding these options simplify ffm format implementation based on AVOption API. > > Signed-off-by: Lukasz Marek > --- > libavcodec/options_table.h | 2 ++ > 1 file changed, 2 insertions(+) should be ok if needed [...] -- Michael

Re: [FFmpeg-devel] [PATCH 4/9] ffmpeg_opt: allow to force codec in new_output_stream

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:26AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > ffmpeg_opt.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c > index 77ef0c4..1b3f73a 100644 > --- a/ffmpeg_opt.c > +

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 00:19:26 +0530, Binathi Bingi encoded: > Hi there, > > Please find the attached patch with modifications. [...] > From 091b4a02c9325bea32b7f745d028ea72c8e1537e Mon Sep 17 00:00:00 2001 > From: Binathi Bingi > Date: Tue, 4 Nov 2014 21:42:07 +0530 > Subject: [PATCH] Resto

Re: [FFmpeg-devel] [PATCH 5/9] ffmpeg_opt: use codec private context in ffserver streams

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:27AM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > ffmpeg_opt.c | 48 > 1 file changed, 32 insertions(+), 16 deletions(-) Iam not sure metadata or a dedicated field wouldnt be better than using the

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 11:02:32 +0100, wm4 encoded: > On Tue, 11 Nov 2014 08:31:24 +0100 > Lukasz Marek wrote: > > > TODO: bump minor version, update doc/APIchanges > > > > Function allows to create string containing object's serialized options. > > Such string may be passed back to av_set_o

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:25AM +0100, Lukasz Marek wrote: > TODO: bump micro > > Signed-off-by: Lukasz Marek > --- > libavformat/ffmdec.c | 41 - > libavformat/ffmenc.c | 27 +-- > 2 files changed, 61 insertions(+), 7 deletions(

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:31:24AM +0100, Lukasz Marek wrote: > TODO: bump minor version, update doc/APIchanges > > Function allows to create string containing object's serialized options. > Such string may be passed back to av_set_options_string() in order to restore > options. > > Signed-off-b

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

2014-11-11 Thread TOYAMA Shin-ichi
Nicolas George wrote in <20141110140122.ga22...@phare.normalesup.org> >Thanks for the patch. See comments below. O.K. I've finished to revise the patch. Please see attached. >The update for the documentation is missing. Added short description to doc/decoders.texi. >> + if (strncmp(p, "ifo:",

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 08:31:23 +0100, Lukasz Marek encoded: > TODO: bump minor version, update doc/APIchanges > > New function allows to check if option is set to its default > > Signed-off-by: Lukasz Marek > --- > libavutil/opt.c| 127 > +++

Re: [FFmpeg-devel] [PATCH] Fixes for the Icecast protocol

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:47:01AM +0100, Marvin Scholz wrote: > > > On 11 Nov 2014, at 0:56, Timothy Gu wrote: > > > Real name please. > > Changed the patches to used my realname now. > > > These are two unrelated changes and should therefore be split into two > > patches. > > Splitted them

Re: [FFmpeg-devel] [PATCH 5/9] ffmpeg_opt: use codec private context in ffserver streams

2014-11-11 Thread Lukasz Marek
On 11.11.2014 08:31, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- ffmpeg_opt.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) Thanks for the hint with opt_target() It is indeed simpler and cleaner. Updated patch attached. Fol

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Stefano Sabatini
On date Tuesday 2014-11-11 08:31:24 +0100, Lukasz Marek encoded: > TODO: bump minor version, update doc/APIchanges > > Function allows to create string containing object's serialized options. > Such string may be passed back to av_set_options_string() in order to restore > options. > > Signed-of

Re: [FFmpeg-devel] [PATCH 5/9] ffmpeg_opt: use codec private context in ffserver streams

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 04:41:17PM +0100, Lukasz Marek wrote: > On 11.11.2014 08:31, Lukasz Marek wrote: > >Signed-off-by: Lukasz Marek > >--- > > ffmpeg_opt.c | 48 > > 1 file changed, 32 insertions(+), 16 deletions(-) > > Thanks for the hint wit

Re: [FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 11:41:53PM +0900, TOYAMA Shin-ichi wrote: > Nicolas George wrote in <20141110140122.ga22...@phare.normalesup.org> > >Thanks for the patch. See comments below. > > O.K. I've finished to revise the patch. > Please see attached. > > >The update for the documentation is missin

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as maintainer for Icecast protocol

2014-11-11 Thread epirat07
From: Marvin Scholz --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 90a4013..ef120e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -497,6 +497,7 @@ Protocols: libssh.c Lukasz Marek mms*.c

[FFmpeg-devel] [PATCH] lavc/options: set all codec options to defaults

2014-11-11 Thread Lukasz Marek
avcodec_get_context_defaults3() sets only specific options to default the values. This commit force all options to be set to the defaults. This improves effectiveness of new ffm format. In particular it fixes "bt" option being out of range when context is created for non-video media type. (it is

Re: [FFmpeg-devel] [PATCH] lavc/options: set all codec options to defaults

2014-11-11 Thread Lukasz Marek
On 11.11.2014 18:30, Lukasz Marek wrote: avcodec_get_context_defaults3() sets only specific options to default the values. This commit force all options to be set to the defaults. This improves effectiveness of new ffm format. In particular it fixes "bt" option being out of range when context is

Re: [FFmpeg-devel] Resubmit patch02 - [patch 4/4] Fix bug forPOWERLE: libswscale/ppc/swscale_altivec.c

2014-11-11 Thread Michael Niedermayer
[...] > @@ -140,31 +180,15 @@ static void hScale_altivec_real(SwsContext *c, int16_t > *dst, int dstW, > for (i = 0; i < dstW; i++) { > register int srcPos = filterPos[i]; > > -vector unsigned char src_v0 = vec_ld(srcPos, src); > -ve

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as maintainer for Icecast protocol

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 06:24:20PM +0100, epira...@gmail.com wrote: > From: Marvin Scholz > > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB DNS cache poisoning attacks, popular search

[FFmpeg-devel] [PATCHv2] vf_interlace: Add SIMD for lowpass filter

2014-11-11 Thread Kieran Kunhya
--- libavfilter/interlace.h | 59 + libavfilter/vf_interlace.c | 55 +-- libavfilter/x86/Makefile| 2 + libavfilter/x86/vf_interlace.asm| 75 + libavfilter/x86/vf_interlace

Re: [FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

2014-11-11 Thread Lukasz Marek
On 11.11.2014 15:45, Stefano Sabatini wrote: +if (o->default_val.str) +av_parse_video_rate(&q, o->default_val.str); you should check the return value here as well for consistency. Alternatively you can place an assert(). I dont agree. Assert cannot be placed. Return value

Re: [FFmpeg-devel] ffmpeg git hooks

2014-11-11 Thread Michael Niedermayer
Hi roots@vlc On Mon, Nov 10, 2014 at 12:04:25PM +0100, Michael Niedermayer wrote: > Hi > > Are the hooks which are used for ffmpeg git publically visible > somewhere ? > iam asking as we would like to submit patches to fix some issues > in them. > For example we would like to add tests/fate/*.mak

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Binathi Bingi
Hi there, Updated patch. Please let me know if there are any other changes needed. I meant FFmpeg version 2.4, by "2.4 level". In case Daemon mode is made default, and user launches FFserver in debug mode, in that case, FFserver would be prevented from forking, forcing foreground mode. I am not

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Binathi Bingi
Hi there, Updated patch. Please let me know if there are any other changes needed. I meant FFmpeg version 2.4, by "2.4 level". In case Daemon mode is made default, and user launches FFserver in debug mode, in that case, FFserver would be prevented from forking, forcing foreground mode. I am not

Re: [FFmpeg-devel] ffmpeg git hooks

2014-11-11 Thread Jean-Baptiste Kempf
Hello, Done. On 11 Nov, Michael Niedermayer wrote : > Hi roots@vlc > > On Mon, Nov 10, 2014 at 12:04:25PM +0100, Michael Niedermayer wrote: > > Hi > > > > Are the hooks which are used for ffmpeg git publically visible > > somewhere ? > > iam asking as we would like to submit patches to fix some

Re: [FFmpeg-devel] ffmpeg git hooks

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 08:35:08PM +0100, Jean-Baptiste Kempf wrote: > Hello, > > Done. Thanks! [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out of college or go to community college in order to

[FFmpeg-devel] [PATCH] lavu/opt: fix av_opt_get function

2014-11-11 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavutil/opt.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 7786472..1d8e4b4 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -715,6 +715,10 @@ int av_opt_get(void *obj, const char *nam

Re: [FFmpeg-devel] [PATCH 2/9] lavu/opt: introduce av_opt_serialize()

2014-11-11 Thread Lukasz Marek
On 11.11.2014 17:19, Stefano Sabatini wrote: We have already av_get_opt() which serializes the value. Also we should probably escape the values. I saw that function, but don't remember why I didn't use. I was wrong obviously. BTW, I found few bugs in it, sent separate patch for it. Updated pa

Re: [FFmpeg-devel] [PATCH 1/4] lavu/opt: check for NULL before parsing

2014-11-11 Thread Lukasz Marek
On 09.11.2014 23:22, Lukasz Marek wrote: set_string_binary crashes with called with val=NULL Signed-off-by: Lukasz Marek --- libavutil/opt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Pushed whole patchset ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] avcodec/dvbsubdec: Fix 8bit non_mod case

2014-11-11 Thread Michael Niedermayer
On Thu, Jul 31, 2014 at 02:43:30PM +0200, Michael Niedermayer wrote: > Untested, i failed to find a sample which triggers this case > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dvbsubdec.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) applied if someone st

Re: [FFmpeg-devel] [PATCH] ffplay: signal the frame queue before closing audio

2014-11-11 Thread Marton Balint
On Mon, 10 Nov 2014, Marton Balint wrote: Fixed regression caused by 631ac655c00e978e19d05dab572bc1ffd6078c63 when ffplay does not quit if the audio thread is blocked. Signed-off-by: Marton Balint --- ffplay.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Hello Michael, Please me

Re: [FFmpeg-devel] [PATCH 5/9] ffmpeg_opt: use codec private context in ffserver streams

2014-11-11 Thread Lukasz Marek
On 11.11.2014 18:03, Michael Niedermayer wrote: On Tue, Nov 11, 2014 at 04:41:17PM +0100, Lukasz Marek wrote: On 11.11.2014 08:31, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- ffmpeg_opt.c | 48 1 file changed, 32 insertions(+), 16 del

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-11 Thread Lukasz Marek
On 11.11.2014 14:46, Michael Niedermayer wrote: the muxer might run in a seperate thread from the encoder, priv_data could change while its being accessed, iam not sure if that would cause some race here or not Wouldn't it regard AVCodecContext.variables too? Also i dont think its guranteed t

Re: [FFmpeg-devel] [PATCH 9/9] lavf/ffm: use AVOption API to store/restore stream properties

2014-11-11 Thread Lukasz Marek
On 11.11.2014 08:31, Lukasz Marek wrote: This is a generic solution that will not reqiore modifications when new options are added. This also fixes problem with current implementation when qmin or qmax=-1. Only 8 bits was sent and read back as 255. Fixes #1275 Fixes #1461 Signed-off-by: Lukasz

Re: [FFmpeg-devel] [PATCH] lavf/webmdashenc: Representation IDs should be unique.

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 10:02:05AM -0800, Vignesh Venkatasubramanian wrote: > According to the DASH spec, Representation IDs should be unique > across all adaptation sets. Fixing that and updating the fate > reference file to reflect this change. > > Signed-off-by: Vignesh Venkatasubramanian > --

Re: [FFmpeg-devel] [PATCH] lavu/opt: fix av_opt_get function

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 09:18:44PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > libavutil/opt.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live

Re: [FFmpeg-devel] [PATCH] ffplay: signal the frame queue before closing audio

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 11:29:29PM +0100, Marton Balint wrote: > > On Mon, 10 Nov 2014, Marton Balint wrote: > > >Fixed regression caused by 631ac655c00e978e19d05dab572bc1ffd6078c63 when > >ffplay > >does not quit if the audio thread is blocked. > > > >Signed-off-by: Marton Balint > >--- > >ffp

Re: [FFmpeg-devel] Bypass video H264 IP UDP Multicast over FLV RTMP

2014-11-11 Thread Steven Liu
> On Nov 5, 2014, at 4:36 PM, Dang Duc Hung wrote: > > Hi > > I’m using FFmpeg to convert UDP video to RTMP like that > > ffmpeg -i "udp://x.x.x.x:xxx -vcodec copy -acodec aac -strict -2 -b:a 32k -ac > 1 -ar 32000 -f flv "rtmp://x.x.x.x/ app=testtv playpath=high" > > And then convert RTMP ou

Re: [FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 11:59:32PM +0100, Lukasz Marek wrote: > On 11.11.2014 14:46, Michael Niedermayer wrote: > >the muxer might run in a seperate thread from the encoder, priv_data > >could change while its being accessed, iam not sure if that would > >cause some race here or not > > Wouldn't i

Re: [FFmpeg-devel] [PATCH 5/9] ffmpeg_opt: use codec private context in ffserver streams

2014-11-11 Thread Michael Niedermayer
On Tue, Nov 11, 2014 at 11:57:40PM +0100, Lukasz Marek wrote: > On 11.11.2014 18:03, Michael Niedermayer wrote: > >On Tue, Nov 11, 2014 at 04:41:17PM +0100, Lukasz Marek wrote: > >>On 11.11.2014 08:31, Lukasz Marek wrote: > >>>Signed-off-by: Lukasz Marek > >>>--- > >>> ffmpeg_opt.c | 48 +

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Reynaldo H. Verdejo Pinochet
Hello On 11/11/2014 04:16 PM, Binathi Bingi wrote: [..] Updated patch. Please let me know if there are any other changes needed. [..] Hello Binathi. Thanks for your continuous attention to this matter. Appreciated. Your patch does no longer apply cleanly, you need to rebase it on top of a rec

Re: [FFmpeg-devel] [PATCH 9/9] lavf/ffm: use AVOption API to store/restore stream properties

2014-11-11 Thread Michael Niedermayer
On Wed, Nov 12, 2014 at 12:02:07AM +0100, Lukasz Marek wrote: > On 11.11.2014 08:31, Lukasz Marek wrote: > >This is a generic solution that will not reqiore modifications when new > >options are added. > >This also fixes problem with current implementation when qmin or qmax=-1. > >Only 8 bits was

Re: [FFmpeg-devel] [PATCH 1/2] x86/flacdsp: separate decoder and encoder dsp initialization

2014-11-11 Thread Michael Niedermayer
On Mon, Nov 10, 2014 at 05:37:28PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/flacdsp_init.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a r

[FFmpeg-devel] Need help: getting error when trans-coding HD input

2014-11-11 Thread Linuxbot B
Hi, Getting error when trans-coding HD input stream.help me resolve this problem.. Source : HDTV signal from mumudvb .. root@s1:/iptv/trans# /usr/local/bin/ffmpeg -analyzeduration 200 -i "http://127.0.0.1:8700/bysid/5305"; -vf "yadif=0:-1:0,scale=1024:576" -c:v libx264 -crf 23 -threads 2

Re: [FFmpeg-devel] [PATCH 6/9] ffserver_config: handle codec private options

2014-11-11 Thread Reynaldo H. Verdejo Pinochet
Hi Lukasz On 11/11/2014 04:31 AM, Lukasz Marek wrote: This commit allows to set codec's private option. As side effect this commit also improves preset support. s/this commit also/, it/ [..] +static int ffserver_save_avoption(AVCodecContext *ctx, const char *opt, const char *arg, +

[FFmpeg-devel] Resubmit patch - [patch 4/4] Fix bugforPOWERLE: libswscale/ppc/swscale_altivec.c

2014-11-11 Thread rongyan
Hi, Again, thanks for your patience and review. New patch please find in the attachment. The fate test results on both LE and BE are as follows: Regards, Rong Yan -- The world has enough for everyone's need, but not enough for everyone's greed. --