On Wed, Nov 12, 2014 at 12:02:07AM +0100, Lukasz Marek wrote: > On 11.11.2014 08:31, Lukasz Marek wrote: > >This is a generic solution that will not reqiore modifications when new > >options are added. > >This also fixes problem with current implementation when qmin or qmax=-1. > >Only 8 bits was sent and read back as 255. > > > >Fixes #1275 > >Fixes #1461 > > > >Signed-off-by: Lukasz Marek <lukasz.m.lu...@gmail.com> > >--- > > libavformat/ffmdec.c | 20 +++++++++++++++ > > libavformat/ffmenc.c | 70 > > +++++++++++++++------------------------------------- > > 2 files changed, 40 insertions(+), 50 deletions(-) > > Updated version attached.
not related to this patch specifically but please test fate-opt under valgrind it seems one of the patches adds a memleak ==16696== 4 bytes in 1 blocks are definitely lost in loss record 1 of 6 ==16696== at 0x4C2A6C5: memalign (vg_replace_malloc.c:727) ==16696== by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876) ==16696== by 0x40FC2D: av_malloc (mem.c:95) ==16696== by 0x402022: set_string_binary (opt.c:142) ==16696== by 0x40617F: av_opt_set_defaults2 (opt.c:1235) ==16696== by 0x405ED1: av_opt_set_defaults (opt.c:1175) ==16696== by 0x40809C: main (opt.c:1986) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 3 "Rare item" - "Common item with rare defect or maybe just a lie" "Professional" - "'Toy' made in china, not functional except as doorstop" "Experts will know" - "The seller hopes you are not an expert"
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
