On Tue, Nov 11, 2014 at 08:47:01AM +0100, Marvin Scholz wrote: > > > On 11 Nov 2014, at 0:56, Timothy Gu wrote: > > > Real name please. > > Changed the patches to used my realname now. > > > These are two unrelated changes and should therefore be split into two > > patches. > > Splitted them up into two different patches > > >> - if (NOT_EMPTY(s->content_type)) > >> - av_dict_set(&opt_dict, "content_type", s->content_type, 0); > >> + av_dict_set(&opt_dict, "content_type", s->content_type, 0); > > > > > > This change LGTM. > > Changed it, since this would break my later check if no content-type > was set by the user. > > >> + av_dict_set(&opt_dict, "send_expect_100", "1", 0); > > > > > > Not sure about this one. > > Why not? This is needed for proper error reporting. Modified it, > so that it is only used for non-legacy PUT requests. It would > work with SOURCE requests too, but only because the http > implementation of ffmpeg isn't that strict about it and it's > better not to rely on this in my opinion. > >
> icecast.c | 2 ++ > 1 file changed, 2 insertions(+) > c3240c5e70de5419c98b935c1e90309b0ffd0b56 > 0001-Icecast-always-send-a-content-type.patch > From 7793d03db264e16ada19f8bc772e1be15466ce34 Mon Sep 17 00:00:00 2001 > From: Marvin Scholz <epira...@gmail.com> > Date: Tue, 11 Nov 2014 01:51:23 +0100 > Subject: [PATCH 1/2] Icecast: always send a content-type ...] > icecast.c | 1 + > 1 file changed, 1 insertion(+) > a088cfcaa43eff68f216567ca0cd78a4e3dc8f3a > 0002-Icecast-Use-100-continue-if-possible-for-proper-erro.patch > From dd8853c36b84aa738521e4b80d43877b5a8a0bbc Mon Sep 17 00:00:00 2001 > From: Marvin Scholz <epira...@gmail.com> > Date: Tue, 11 Nov 2014 02:10:22 +0100 > Subject: [PATCH 2/2] Icecast: Use 100-continue if possible for proper error > handling patches applied btw maybe you want to send a patch which adds you to the MAINTAINERs file for icecast ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
