Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Carl Eugen Hoyos
2016-10-18 13:11 GMT+02:00 Moritz Barsnick : > On Tue, Oct 18, 2016 at 00:21:42 +0200, Carl Eugen Hoyos wrote: >> In any case, your second patch is acceptable, should not have >> any adversary effects and we have significantly worse cosmetic >> patches in our tree, so it is ok imo. > > I only see o

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Moritz Barsnick
On Mon, Oct 17, 2016 at 23:23:31 +0200, Michael Behrisch wrote: > My main reason is that we are compiling with different compilers for > different platforms If you're trying to keep ffmpeg more portable, you could at least try the real-life thing and actually attempt to build with Sun Studio or ne

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Moritz Barsnick
On Tue, Oct 18, 2016 at 00:21:42 +0200, Carl Eugen Hoyos wrote: > In any case, your second patch is acceptable, should not have > any adversary effects and we have significantly worse cosmetic > patches in our tree, so it is ok imo. I only see one patch - did I miss one? - , and if that's the one

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Carl Eugen Hoyos
2016-10-18 0:17 GMT+02:00 Michael Behrisch : > I am not claiming that -Wpedantic is the only way to achieve this. > I only think it helps or at least I assume that was the intention > when it was invented. ("If gcc does it this way, it must be a good idea.") This is an extremely unconvincing arg

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Behrisch
Hi Ronald, Am 17.10.2016 um 23:45 schrieb Ronald S. Bultje: > Hi Michael, > > On Mon, Oct 17, 2016 at 5:23 PM, Michael Behrisch wrote: > >> Hi Ronald, >> >> Am 17.10.2016 um 21:37 schrieb Ronald S. Bultje: >>> Hi Michael, >>> >>> On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch >>> wrote: >>>

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Ronald S. Bultje
Hi Michael, On Mon, Oct 17, 2016 at 5:23 PM, Michael Behrisch wrote: > Hi Ronald, > > Am 17.10.2016 um 21:37 schrieb Ronald S. Bultje: > > Hi Michael, > > > > On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch > > wrote: > > > >> Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > >>> On Mon,

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Behrisch
Hi Ronald, Am 17.10.2016 um 21:37 schrieb Ronald S. Bultje: > Hi Michael, > > On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch > wrote: > >> Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: >>> On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: On Mon, 17 Oct 2016 13:09:36 +0200 Mich

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Ronald S. Bultje
Hi Michael, On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch wrote: > Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > > On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: > >> On Mon, 17 Oct 2016 13:09:36 +0200 > >> Michael Niedermayer wrote: > >> > >>> On Mon, Oct 17, 2016 at 10:07:42

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Behrisch
Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: >> On Mon, 17 Oct 2016 13:09:36 +0200 >> Michael Niedermayer wrote: >> >>> On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: Le sextidi 26 vendémiaire, an CCXXV, Michael Ni

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: > On Mon, 17 Oct 2016 13:09:36 +0200 > Michael Niedermayer wrote: > > > On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: > > > Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > > > > probably, yes > > > >

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread wm4
On Mon, 17 Oct 2016 13:09:36 +0200 Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: > > Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > > > probably, yes > > > > I would have said exactly the opposite. It is nothing but a waste

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Clément Bœsch
On Mon, Oct 17, 2016 at 12:11:08AM +0200, Michael Behrisch wrote: > Am 16.10.2016 um 23:24 schrieb Clément Bœsch: > > On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: > >> Hi all, > >> first of all thanks for providing this great library. > >> > >> Today my pull request https://git

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: > Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > > probably, yes > > I would have said exactly the opposite. It is nothing but a waste of time > and a pollution of the history. My idea here is to maximize the nu

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Nicolas George
Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > probably, yes I would have said exactly the opposite. It is nothing but a waste of time and a pollution of the history. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-16 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 12:11:08AM +0200, Michael Behrisch wrote: > Am 16.10.2016 um 23:24 schrieb Clément Bœsch: > > On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: > >> Hi all, > >> first of all thanks for providing this great library. > >> > >> Today my pull request https://git

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-16 Thread Ronald S. Bultje
Hi, On Sun, Oct 16, 2016 at 6:11 PM, Michael Behrisch wrote: > Am 16.10.2016 um 23:24 schrieb Clément Bœsch: > > On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: > >> Hi all, > >> first of all thanks for providing this great library. > >> > >> Today my pull request https://githu

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-16 Thread Michael Behrisch
Am 16.10.2016 um 23:24 schrieb Clément Bœsch: > On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: >> Hi all, >> first of all thanks for providing this great library. >> >> Today my pull request https://github.com/FFmpeg/FFmpeg/pull/237 has been >> rejected which tried to remove the

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-16 Thread Clément Bœsch
On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: > Hi all, > first of all thanks for providing this great library. > > Today my pull request https://github.com/FFmpeg/FFmpeg/pull/237 has been > rejected which tried to remove the comma at the end of enumerator lists > which trigger

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-16 Thread wm4
On Sun, 16 Oct 2016 21:51:32 +0200 Nicolas George wrote: > Le quintidi 25 vendémiaire, an CCXXV, Michael Behrisch a écrit : > > Today my pull request https://github.com/FFmpeg/FFmpeg/pull/237 has been > > rejected which tried to remove the comma at the end of enumerator lists > > which triggers a

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-16 Thread Nicolas George
Le quintidi 25 vendémiaire, an CCXXV, Michael Behrisch a écrit : > Today my pull request https://github.com/FFmpeg/FFmpeg/pull/237 has been > rejected which tried to remove the comma at the end of enumerator lists > which triggers a warning when compiling with gcc and -Wpedantic. I still > think it