Hi, On Sun, Oct 16, 2016 at 6:11 PM, Michael Behrisch <o...@behrisch.de> wrote:
> Am 16.10.2016 um 23:24 schrieb Clément Bœsch: > > On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: > >> Hi all, > >> first of all thanks for providing this great library. > >> > >> Today my pull request https://github.com/FFmpeg/FFmpeg/pull/237 has > been > >> rejected which tried to remove the comma at the end of enumerator lists > >> which triggers a warning when compiling with gcc and -Wpedantic. I still > >> think it could be a good idea to remove this, especially in the cases > >> where the enumerator list already ends in some _NB item, which seems to > >> be the final one "forever", but I am here to learn :-). > > > > The enum with a final _NB (or similar) entry are the only ones where > > removing the comma is relevant. > > So would a patch removing only those have a chance of being accepted? Honestly, I don't think too many people on this list care about -Wpendantic. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
