Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Timothy Gu
On Wed Dec 31 2014 at 10:01:38 AM Reimar Döffinger wrote: > > Interestingly, the --pkg-config=/bin/true workaround needs you to be > careful to actually put libraries in --extra-libs, not --extra-ldflags or > the check will fail for static libraries, which is not completely > obvious/100% matching

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Timothy Gu
On Wed Dec 31 2014 at 5:02:28 AM Reimar Döffinger wrote: > > I don't care much, but I still find not having to use pkg-config > somewhat more convenient in a cross-compilation environment where > you don't want to install all dependencies just to make it work with > pkg-config (or alternatively ma

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Nicolas George
Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : > That might sound minor, but I consider that more than worth a few extra > lines of configure code. This is definitely worth a few extra lines of code, but I believe the best place to put them is not configure. Do we agree that (1) we

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Jean-Baptiste Kempf
On 31 Dec, Reimar Döffinger wrote : > I don't care much, but I still find not having to use pkg-config > somewhat more convenient in a cross-compilation environment where > you don't want to install all dependencies just to make it work with > pkg-config (or alternatively manually hack those files)

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Reimar Döffinger
On 31.12.2014, at 16:52, Nicolas George wrote: > Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : >> >> Also I'm not arguing it's impossible, I'm arguing it's inconvenient. >> It's something like 2-3 additional steps for each library. > > How do you usually install a library? You are

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Nicolas George
Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : > > How is that really a problem? You can just ./configure > > --prefix=$PWD/install (or wherever you fancy) from the library source > > directory > If you do that you end up with an unmaintainable mess where you have all > the files from

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Reimar Döffinger
On Wed, Dec 31, 2014 at 03:43:32PM +0100, Clément Bœsch wrote: > On Wed, Dec 31, 2014 at 02:57:43PM +0100, Reimar Döffinger wrote: > > On Wed, Dec 31, 2014 at 02:38:20PM +0100, Clément Bœsch wrote: > > > On Wed, Dec 31, 2014 at 02:23:54PM +0100, Reimar Döffinger wrote: > > > > On Wed, Dec 31, 2014

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Clément Bœsch
On Wed, Dec 31, 2014 at 02:57:43PM +0100, Reimar Döffinger wrote: > On Wed, Dec 31, 2014 at 02:38:20PM +0100, Clément Bœsch wrote: > > On Wed, Dec 31, 2014 at 02:23:54PM +0100, Reimar Döffinger wrote: > > > On Wed, Dec 31, 2014 at 02:09:42PM +0100, Nicolas George wrote: > > > > Le primidi 11 nivôse

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Reimar Döffinger
On Wed, Dec 31, 2014 at 02:38:20PM +0100, Clément Bœsch wrote: > On Wed, Dec 31, 2014 at 02:23:54PM +0100, Reimar Döffinger wrote: > > On Wed, Dec 31, 2014 at 02:09:42PM +0100, Nicolas George wrote: > > > Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : > > > > I don't care much, but I

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Reimar Döffinger
On Wed, Dec 31, 2014 at 02:23:06PM +0100, Clément Bœsch wrote: > On Wed, Dec 31, 2014 at 02:02:20PM +0100, Reimar Döffinger wrote: > [...] > > There is also a (minority) of projects with pkg-config files that > > cause undesirable side-effects which can hide errors. > > From my system: > > 1) SDL a

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Michael Niedermayer
On Wed, Dec 31, 2014 at 02:02:20PM +0100, Reimar Döffinger wrote: > On Wed, Dec 31, 2014 at 01:25:33PM +0100, Nicolas George wrote: > > Le primidi 11 nivôse, an CCXXIII, Carl Eugen Hoyos a écrit : > > > Attached patch fixes ticket #4197 for me. > > > > Installing pkg-config fixes ticket #4197 for

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Clément Bœsch
On Wed, Dec 31, 2014 at 02:23:54PM +0100, Reimar Döffinger wrote: > On Wed, Dec 31, 2014 at 02:09:42PM +0100, Nicolas George wrote: > > Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : > > > I don't care much, but I still find not having to use pkg-config > > > somewhat more convenient

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Reimar Döffinger
On Wed, Dec 31, 2014 at 02:09:42PM +0100, Nicolas George wrote: > Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : > > I don't care much, but I still find not having to use pkg-config > > somewhat more convenient in a cross-compilation environment where > > you don't want to install all

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Clément Bœsch
On Wed, Dec 31, 2014 at 02:02:20PM +0100, Reimar Döffinger wrote: [...] > There is also a (minority) of projects with pkg-config files that > cause undesirable side-effects which can hide errors. > From my system: > 1) SDL and apr add -D_GNU_SOURCE=1 > 2) fuse adds -D_FILE_OFFSET_BITS=64 > 3) xorg

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Clément Bœsch
On Wed, Dec 31, 2014 at 01:23:41PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4197 for me. > > Please merge, Carl Eugen > From 56ce16fd3f10c4259df7abbbcc1f9681f055564b Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Wed, 31 Dec 2014 13:20:58 +0100 > Subject:

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Nicolas George
Le primidi 11 nivôse, an CCXXIII, Reimar Döffinger a écrit : > I don't care much, but I still find not having to use pkg-config > somewhat more convenient in a cross-compilation environment where > you don't want to install all dependencies just to make it work with > pkg-config (or alternatively m

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Reimar Döffinger
On Wed, Dec 31, 2014 at 01:25:33PM +0100, Nicolas George wrote: > Le primidi 11 nivôse, an CCXXIII, Carl Eugen Hoyos a écrit : > > Attached patch fixes ticket #4197 for me. > > Installing pkg-config fixes ticket #4197 for you. > > I object to any useless obfuscation to configure. I don't care mu

Re: [FFmpeg-devel] [PATCH]Allow libspeex detection also without pkg-config

2014-12-31 Thread Nicolas George
Le primidi 11 nivôse, an CCXXIII, Carl Eugen Hoyos a écrit : > Attached patch fixes ticket #4197 for me. Installing pkg-config fixes ticket #4197 for you. I object to any useless obfuscation to configure. Regards, -- Nicolas George signature.asc Description: Digital signature _