Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 4:53 PM, Michael Niedermayer wrote: > On Sun, Aug 23, 2015 at 03:10:40PM -0400, Ganesh Ajjanagadde wrote: >> On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer >> wrote: >> > On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: >> >> This fixes a -Wabsolut

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 03:10:40PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer > wrote: > > On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: > >> This fixes a -Wabsolute-value reported by clang 3.5+ complaining about > >> misuse of fa

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 4:17 PM, James Almer wrote: > On 23/08/15 5:09 PM, Ganesh Ajjanagadde wrote: >> On Sun, Aug 23, 2015 at 3:42 PM, James Almer wrote: >>> On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: I notice one use in entire codebase (line 515 of avformat/dump.c), so it should

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread James Almer
On 23/08/15 5:09 PM, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 3:42 PM, James Almer wrote: >> On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: >>> I notice one use in entire codebase (line 515 of avformat/dump.c), so >>> it should be ok in my view. >> >> Nevermind, missed this. >> >> Not s

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 3:42 PM, James Almer wrote: > On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: >> I notice one use in entire codebase (line 515 of avformat/dump.c), so >> it should be ok in my view. > > Nevermind, missed this. > > Not sure how it works with msvc 2012 though, assuming the msd

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread James Almer
On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: > I notice one use in entire codebase (line 515 of avformat/dump.c), so > it should be ok in my view. Nevermind, missed this. Not sure how it works with msvc 2012 though, assuming the msdn link documentation is right.

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread James Almer
On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer > wrote: >> On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: >>> This fixes a -Wabsolute-value reported by clang 3.5+ complaining about >>> misuse of fabs() for integer absolut

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer wrote: > On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: >> This fixes a -Wabsolute-value reported by clang 3.5+ complaining about >> misuse of fabs() for integer absolute value. >> An additional benefit is the removal of fl

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: > This fixes a -Wabsolute-value reported by clang 3.5+ complaining about misuse > of fabs() for integer absolute value. > An additional benefit is the removal of floating point calculations. > Note that the behaviors are not exact