On Mon, 16. Aug 20:42, Michael Niedermayer wrote:
> On Sun, Aug 15, 2021 at 01:53:23PM -0400, Andriy Gelman wrote:
> > On Sun, 15. Aug 17:15, Michael Niedermayer wrote:
> > > On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote:
> > > > On Sun, 15. Aug 11:17, Nicolas George wrote:
> > > >
On Sun, Aug 15, 2021 at 01:53:23PM -0400, Andriy Gelman wrote:
> On Sun, 15. Aug 17:15, Michael Niedermayer wrote:
> > On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote:
> > > On Sun, 15. Aug 11:17, Nicolas George wrote:
> > > > Is it possible to add hooks in Patchwork to warn people au
On Sun, 15. Aug 16:04, Nicolas George wrote:
> Andriy Gelman (12021-08-15):
> > That sounds fine.
>
> See the attached code.
>
> I have tested it against the 2721 commits I have since the beginning of
> the year, it finds 56 to object, about half of them real problems, a few
> with unusually lon
On Sun, 15. Aug 17:15, Michael Niedermayer wrote:
> On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote:
> > On Sun, 15. Aug 11:17, Nicolas George wrote:
> > > Is it possible to add hooks in Patchwork to warn people automatically
> > > when their commit message does not match standards?
>
On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote:
> On Sun, 15. Aug 11:17, Nicolas George wrote:
> > Is it possible to add hooks in Patchwork to warn people automatically
> > when their commit message does not match standards?
> >
> > If it is possible, I volunteer to write it.
> >
>
Andriy Gelman (12021-08-15):
> That sounds fine.
See the attached code.
I have tested it against the 2721 commits I have since the beginning of
the year, it finds 56 to object, about half of them real problems, a few
with unusually long context (I set the limit at the last percentile) and
admitt
Lynne (12021-08-15):
> Oh, that's all fine. I was talking about the change to the developer manual,
> about adding patch descriptions. Sometimes, you just don't need any.
The change I proposed says: "then if necessary a body with details".
Do you think it would be better if the "if necessary" par
15 Aug 2021, 13:39 by geo...@nsup.org:
> Lynne (12021-08-15):
>
>> Could you acknowledge that at least some commits do not deserve
>> mandatory 3-line vapid comments?
>>
>
> I have no idea what you are talking about.
>
> The hook I am suggesting would catch:
>
> - cases without "context:" on the f
On Sun, 15. Aug 14:22, Nicolas George wrote:
> Andriy Gelman (12021-08-15):
> > Yes, nice idea.
> >
> > If the commit message is invalid I could add a warning similar to:
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210809102919.387-1-an...@khirnov.net/
> > and trigger an automated emai
Andriy Gelman (12021-08-15):
> Yes, nice idea.
>
> If the commit message is invalid I could add a warning similar to:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210809102919.387-1-an...@khirnov.net/
> and trigger an automated email to the author.
>
> Feel free to send me the parsing pa
On Sun, 15. Aug 11:17, Nicolas George wrote:
> Is it possible to add hooks in Patchwork to warn people automatically
> when their commit message does not match standards?
>
> If it is possible, I volunteer to write it.
>
Yes, nice idea.
If the commit message is invalid I could add a warning sim
Nicolas George:
> Michael Niedermayer (12021-08-15):
>> We could also add a fate test that checks the commit messages between
>> master (if == HEAD) and origin
>> iam not sure if people want this but it could eliminate some bad messages
>> before even reaching the mailing list (if the developer did
Michael Niedermayer (12021-08-15):
> We could also add a fate test that checks the commit messages between
> master (if == HEAD) and origin
> iam not sure if people want this but it could eliminate some bad messages
> before even reaching the mailing list (if the developer did run make fate)
I am
Lynne (12021-08-15):
> Could you acknowledge that at least some commits do not deserve
> mandatory 3-line vapid comments?
I have no idea what you are talking about.
The hook I am suggesting would catch:
- cases without "context:" on the first line, like:
[FFmpeg-devel] [PATCH] Handle AV_PIX_FM
15 Aug 2021, 11:49 by mich...@niedermayer.cc:
> On Sun, Aug 15, 2021 at 11:17:26AM +0200, Nicolas George wrote:
>
>> Is it possible to add hooks in Patchwork to warn people automatically
>> when their commit message does not match standards?
>>
>> If it is possible, I volunteer to write it.
>>
>
>
On Sun, Aug 15, 2021 at 11:17:26AM +0200, Nicolas George wrote:
> Is it possible to add hooks in Patchwork to warn people automatically
> when their commit message does not match standards?
>
> If it is possible, I volunteer to write it.
We could also add a fate test that checks the commit messag
Is it possible to add hooks in Patchwork to warn people automatically
when their commit message does not match standards?
If it is possible, I volunteer to write it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-de
17 matches
Mail list logo
