Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-24 Thread Tobias Rapp
On 15/09/2024 14:41, Anton Khirnov wrote: Quoting Antoni Bizoń (2024-09-13 15:20:16) Hello, I recently upgraded FFmpeg to version 6.1 in my web application and encountered a change while running my app's tests. After the upgrade, ffprobe reported an r_frame_rate of 60/1 instead of the expected

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-24 Thread Derek Buitenhuis
On 9/23/2024 4:34 PM, Vittorio Giovara wrote: > Should we schedule deprecation for one of the two fields? I agree it's > confusing for end users to check in two fields. Warning: Hot take. IMO r_frame_rate does more harm than good and should be nuked. Possibly avg_frame_rate should also be nuked,

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-24 Thread Derek Buitenhuis
On 9/24/2024 12:27 AM, Michael Niedermayer wrote: > An "average" is precissely one number (once the type of average is defined) > Maybe you are thinkin of "approximate" instead of "average" Which doesn't actually represent how it is set usually. Take one grep around libavformat/*.c and you'll see

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Michael Niedermayer
On Mon, Sep 23, 2024 at 09:56:52PM +0200, Anton Khirnov wrote: > Quoting Kieran Kunhya via ffmpeg-devel (2024-09-23 21:30:09) > > > On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > > > wrote: [...] > > I think the OP is correct here that the behaviour makes no sense. If > > someth

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Michael Niedermayer
On Mon, Sep 23, 2024 at 08:30:09PM +0100, Kieran Kunhya via ffmpeg-devel wrote: > > On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > > wrote: > >> > >> On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > >> > > >> > Quoting Antoni Bizoń (2024-09-23 10:09:51) > >> > > I underst

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Kieran Kunhya via ffmpeg-devel
On Mon, Sep 23, 2024 at 8:56 PM Anton Khirnov wrote: > > Quoting Kieran Kunhya via ffmpeg-devel (2024-09-23 21:30:09) > > > On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > > > wrote: > > >> > > >> On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > > >> > > > >> > Quoting An

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Anton Khirnov
Quoting Kieran Kunhya via ffmpeg-devel (2024-09-23 21:30:09) > > On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > > wrote: > >> > >> On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > >> > > >> > Quoting Antoni Bizoń (2024-09-23 10:09:51) > >> > > I understand that the r_fram

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Kieran Kunhya via ffmpeg-devel
> On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > wrote: >> >> On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: >> > >> > Quoting Antoni Bizoń (2024-09-23 10:09:51) >> > > I understand that the r_frame_rate is the lowest framerate with which >> > > all timestamps can be repr

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Vittorio Giovara
On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > > > > Quoting Antoni Bizoń (2024-09-23 10:09:51) > > > I understand that the r_frame_rate is the lowest framerate with which > > > all timestam

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Anton Khirnov
Quoting Kieran Kunhya via ffmpeg-devel (2024-09-23 16:45:30) > On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > > > > Quoting Antoni Bizoń (2024-09-23 10:09:51) > > > I understand that the r_frame_rate is the lowest framerate with which > > > all timestamps can be represented accurately. And

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Kieran Kunhya via ffmpeg-devel
On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > > Quoting Antoni Bizoń (2024-09-23 10:09:51) > > I understand that the r_frame_rate is the lowest framerate with which > > all timestamps can be represented accurately. And I know it is just a > > guess. But why did the logic behind the calcul

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Anton Khirnov
Quoting Antoni Bizoń (2024-09-23 10:09:51) > I understand that the r_frame_rate is the lowest framerate with which > all timestamps can be represented accurately. And I know it is just a > guess. But why did the logic behind the calculation change? Because you're most likely using a codec like H.2

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-23 Thread Antoni Bizoń
fr.num, (int64_t)fr.den * mul.num, INT_MAX); } else { st->r_frame_rate.num = st->time_base.den; st->r_frame_rate.den = st->time_base.num; Antoni Bizoń ________________ From: ffmpeg-devel on behalf of Anton Khirnov

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-15 Thread Anton Khirnov
Quoting Antoni Bizoń (2024-09-13 15:20:16) > Hello, > I recently upgraded FFmpeg to version 6.1 in my web application and > encountered a change while running my app's tests. After the upgrade, > ffprobe reported an r_frame_rate of 60/1 instead of the expected 30/1 > for two videos in my test suite

[FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-13 Thread Antoni Bizoń
Hello, I recently upgraded FFmpeg to version 6.1 in my web application and encountered a change while running my app's tests. After the upgrade, ffprobe reported an r_frame_rate of 60/1 instead of the expected 30/1 for two videos in my test suite. After investigating, I traced the issue to the f