Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-15 Thread KongQun Yang
Thanks for the review, uploaded patch v7 with two changes: 1. Use AVFormatContext as the logging context 2. Renamed the file from vpc.c/vpc.h to vpcc.c/vpcc.h Please take another look. -- KongQun Yang (KQ) On Tue, Jun 14, 2016 at 11:27 PM, Hendrik Leppkes wrote: > On Wed, Jun 15, 2016 at 3:25

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-15 Thread Ronald S. Bultje
Hi, On Tue, Jun 14, 2016 at 9:24 PM, KongQun Yang < kqyang-at-google@ffmpeg.org> wrote: > -- KongQun Yang (KQ) > > On Tue, Jun 14, 2016 at 6:13 PM, Ronald S. Bultje > wrote: > > > Hi, > > > > On Tue, Jun 14, 2016 at 7:34 PM, Hendrik Leppkes > > wrote: > > > > > On Wed, Jun 15, 2016 at 12:05

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread Hendrik Leppkes
On Wed, Jun 15, 2016 at 3:25 AM, KongQun Yang wrote: > -- KongQun Yang (KQ) > > On Tue, Jun 14, 2016 at 4:20 PM, Ronald S. Bultje > wrote: > >> Hi, >> >> On Tue, Jun 14, 2016 at 6:05 PM, Kongqun Yang >> wrote: >> >>> +default: >>> +av_log(NULL, AV_LOG_ERROR, "Unsupported color space

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread KongQun Yang
-- KongQun Yang (KQ) On Tue, Jun 14, 2016 at 4:34 PM, Hendrik Leppkes wrote: > On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang > wrote: > > Implemented according to the draft specification > > "VP Codec ISO Media File Format Binding": > > > http://www.webmproject.org/vp9/#draft-vp-codec-iso-medi

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread KongQun Yang
-- KongQun Yang (KQ) On Tue, Jun 14, 2016 at 4:20 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 14, 2016 at 6:05 PM, Kongqun Yang > wrote: > >> +default: >> +av_log(NULL, AV_LOG_ERROR, "Unsupported color space (%d)\n", >> + color_space); >> +return -1; >> >

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread KongQun Yang
-- KongQun Yang (KQ) On Tue, Jun 14, 2016 at 6:13 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 14, 2016 at 7:34 PM, Hendrik Leppkes > wrote: > > > On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang > > wrote: > > > Implemented according to the draft specification > > > "VP Codec ISO Media Fil

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread Ronald S. Bultje
Hi, On Tue, Jun 14, 2016 at 7:34 PM, Hendrik Leppkes wrote: > On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang > wrote: > > Implemented according to the draft specification > > "VP Codec ISO Media File Format Binding": > > > http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-format-bin

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread Hendrik Leppkes
On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang wrote: > Implemented according to the draft specification > "VP Codec ISO Media File Format Binding": > http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-format-binding > > '-strict -2' is required to use this feature. > Not sure I really

Re: [FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread Ronald S. Bultje
Hi, On Tue, Jun 14, 2016 at 6:05 PM, Kongqun Yang wrote: > +default: > +av_log(NULL, AV_LOG_ERROR, "Unsupported color space (%d)\n", > + color_space); > +return -1; > [..] > +default: > +av_log(NULL, AV_LOG_ERROR, "Unsupported pixel format (%d)\n",

[FFmpeg-devel] [PATCH v5] Add experimental support for vp9 in iso-bmff

2016-06-14 Thread Kongqun Yang
Implemented according to the draft specification "VP Codec ISO Media File Format Binding": http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-format-binding '-strict -2' is required to use this feature. Change-Id: Iaa7ddf5524b17e8d79cd1923b26f096d6e91 --- libavformat/Makefile |