> -Original Message-
> From: ffmpeg-devel On Behalf Of Nicolas
> George
> Sent: 2021年4月7日 18:06
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data
> AV_FRAME_DATA_BOUNDING_BOXES
>
> Andr
Andreas Rheinhardt (12021-04-07):
> Why a backup implementation?
Because:
> And a generic alignment of (say) 8 can be used as a fallback.
I believe using a pointer to VLA is more elegant than reimplementing the
compiler's feature using _Alignof and clumsy arithmetic, but it is
eventually for who
Nicolas George:
> Hendrik Leppkes (12021-04-07):
>> Unfortunately, this is not correct. I don't know about optimization
>> problems, but I do know that compilers we do support, which are C11
>> compliant (where VLAs are optional), do not implement them (just
>> confirmed this with a test, as well,
Hendrik Leppkes (12021-04-07):
> Unfortunately, this is not correct. I don't know about optimization
> problems, but I do know that compilers we do support, which are C11
> compliant (where VLAs are optional), do not implement them (just
> confirmed this with a test, as well, to make sure).
Too ba
On Tue, Apr 6, 2021 at 6:45 PM Nicolas George wrote:
>
> Guo, Yejun (12021-04-06):
> > compile error on ubuntu 18.04 with default setting:
> > error: ISO C90 forbids variable length array ‘boxes’ [-Werror=vla]
> > AVBoundingBox boxes[nb_bboxes];
>
> This warning is explicitly added by config
> -Original Message-
> From: ffmpeg-devel On Behalf Of Nicolas
> George
> Sent: 2021年4月7日 0:46
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data
> AV_FRAME_DATA_BOUNDING_BOXES
>
> Guo, Yejun
Guo, Yejun (12021-04-06):
> compile error on ubuntu 18.04 with default setting:
> error: ISO C90 forbids variable length array ‘boxes’ [-Werror=vla]
> AVBoundingBox boxes[nb_bboxes];
This warning is explicitly added by configure it, we do not have to keep
it if it hiders us.
If people agree
> -Original Message-
> From: Guo, Yejun
> Sent: 2021年4月5日 17:56
> To: FFmpeg development discussions and patches
> Subject: RE: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data
> AV_FRAME_DATA_BOUNDING_BOXES
>
>
>
> > -Original Message-
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Nicolas
> George
> Sent: 2021年4月4日 18:02
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data
> AV_FRAME_DATA_BOUNDING_BOXES
>
> Guo, Yejun (
Andreas Rheinhardt (12021-04-04):
> That's a variable-length array. That's a C99 feature we do not require.
We have used variable-length arrays in the past. We have eliminated them
from our code base not because lack of support, IIRC, but because they
have a tendency to ruin compiler optimization.
James Almer (12021-04-04):
> This solution is what was used for video_enc_params.h, so i agree it should
> be used here too. What's missing is a check for idx < nb_bbox before
> accessing the offset in question, so an inline function instead of a #define
> with a check for the above would be needed
James Almer:
> On 4/4/2021 7:01 AM, Nicolas George wrote:
>> Guo, Yejun (12021-04-01):
Is this allowed to be negative? Can/should this be size_t?
>>> There was a long discussion about size_t/int/uint32_t when I added
>>> struct AVRegionOfInterest in frame.h, and finally size_t is not chosen.
>
Nicolas George:
> Guo, Yejun (12021-04-01):
>>> Is this allowed to be negative? Can/should this be size_t?
>> There was a long discussion about size_t/int/uint32_t when I added
>> struct AVRegionOfInterest in frame.h, and finally size_t is not chosen.
>
> Then at least unsigned.
>
>> yes, we can
On 4/4/2021 7:01 AM, Nicolas George wrote:
Guo, Yejun (12021-04-01):
Is this allowed to be negative? Can/should this be size_t?
There was a long discussion about size_t/int/uint32_t when I added
struct AVRegionOfInterest in frame.h, and finally size_t is not chosen.
Then at least unsigned.
Guo, Yejun (12021-04-01):
> > Is this allowed to be negative? Can/should this be size_t?
> There was a long discussion about size_t/int/uint32_t when I added
> struct AVRegionOfInterest in frame.h, and finally size_t is not chosen.
Then at least unsigned.
> yes, we can add a version number (enum
> -Original Message-
> From: ffmpeg-devel On Behalf Of Guo,
> Yejun
> Sent: 2021年4月1日 19:32
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data
> AV_FRAME_DATA_BOUNDING_BOXES
>
>
>
> >
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: 2021年4月1日 16:13
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data
> AV_FRAME_DATA_BOUNDING_BOXES
>
> Quoting Guo,
Quoting Guo, Yejun (2021-03-26 09:09:29)
> Signed-off-by: Guo, Yejun
> ---
> doc/APIchanges | 2 ++
> libavutil/Makefile | 1 +
> libavutil/boundingbox.h | 79 +
> libavutil/frame.c | 1 +
> libavutil/frame.h | 7
> 5 file
Signed-off-by: Guo, Yejun
---
doc/APIchanges | 2 ++
libavutil/Makefile | 1 +
libavutil/boundingbox.h | 79 +
libavutil/frame.c | 1 +
libavutil/frame.h | 7
5 files changed, 90 insertions(+)
create mode 100644 libavutil
19 matches
Mail list logo
