> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Nicolas > George > Sent: 2021年4月7日 0:46 > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V6 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Guo, Yejun (12021-04-06): > > compile error on ubuntu 18.04 with default setting: > > error: ISO C90 forbids variable length array ‘boxes’ [-Werror=vla] > > AVBoundingBox boxes[nb_bboxes]; > > This warning is explicitly added by configure it, we do not have to keep > it if it hiders us. > > If people agree with my analysis that pointers to VLA used to compute > sizes and offsets in an isolated function are not a problem, unlike > actual VLAs on the stack, then we can just remove it. I do not think we > are at risk of adding VLAs by mistake.
I see, thanks. @Michael, any comment on this, thanks, '-Werror=vla' is enabled by 293e5423 in 2012. I can send a patch to remove this in configure for more comments. Then, I can update my detection patch set according to the result. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
