James Almer (12021-04-04):
> This solution is what was used for video_enc_params.h, so i agree it should
> be used here too. What's missing is a check for idx < nb_bbox before
> accessing the offset in question, so an inline function instead of a #define
> with a check for the above would be needed.

That may be a good idea, but please notice that this check would not be
there with just an array or a pointer. FFmpeg is C, not Java. We do not
HAVE to add the check.

> And since both are used as frame side data, it would be ideal that the
> signature for the public helpers on both are the same (The standard alloc,
> and the alloc + wrapping into frame side data ones).

I agree with this.

Regards,

-- 
  Nicolas George

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to