Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 8:31 PM, wm4 wrote: > On Thu, 29 Oct 2015 20:05:28 -0400 > Ganesh Ajjanagadde wrote: > >> More generally, how is this problem "easy to verify"? It may be >> included indirectly, etc. Since you seem to think it is easy, go ahead > > Indirect inclusion is IMHO not fine for s

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 8:31 PM, wm4 wrote: > On Thu, 29 Oct 2015 20:05:28 -0400 > Ganesh Ajjanagadde wrote: > >> More generally, how is this problem "easy to verify"? It may be >> included indirectly, etc. Since you seem to think it is easy, go ahead > > Indirect inclusion is IMHO not fine for s

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 8:13 PM, Hendrik Leppkes wrote: > On Fri, Oct 30, 2015 at 1:05 AM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 29, 2015 at 7:50 PM, Hendrik Leppkes wrote: >>> On Fri, Oct 30, 2015 at 12:08 AM, Ganesh Ajjanagadde >>> wrote: On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bu

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread wm4
On Thu, 29 Oct 2015 20:05:28 -0400 Ganesh Ajjanagadde wrote: > More generally, how is this problem "easy to verify"? It may be > included indirectly, etc. Since you seem to think it is easy, go ahead Indirect inclusion is IMHO not fine for such compat headers which define standard functions on s

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Michael Niedermayer
On Fri, Oct 30, 2015 at 12:50:46AM +0100, Hendrik Leppkes wrote: > On Fri, Oct 30, 2015 at 12:08 AM, Ganesh Ajjanagadde wrote: > > On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje > > wrote: > >> Hi, > >> > >> On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer > >> >>> wrote: > >> > >>> On

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Hendrik Leppkes
On Fri, Oct 30, 2015 at 1:05 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 29, 2015 at 7:50 PM, Hendrik Leppkes wrote: >> On Fri, Oct 30, 2015 at 12:08 AM, Ganesh Ajjanagadde >> wrote: >>> On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje >>> wrote: Hi, On Thu, Oct 29, 2015 at 8:

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 7:50 PM, Hendrik Leppkes wrote: > On Fri, Oct 30, 2015 at 12:08 AM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer >>> wrote: >>> On Thu, Oct 29, 2015 at 12:19

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Hendrik Leppkes
On Fri, Oct 30, 2015 at 12:08 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer >> wrote: >> >>> On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote: >>> > This is more concise

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer > wrote: > >> On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote: >> > This is more concise and conveys the intent better. >> > Furthermore, it is likely more pre

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 8:44 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Oct 29, 2015 at 8:32 AM, Ganesh Ajjanagadde > wrote: > >> On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer >> > >> wrote: >> > >> >> On Th

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ronald S. Bultje
Hi, On Thu, Oct 29, 2015 at 8:32 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer > >> wrote: > > > >> On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote: > >> > This

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer > wrote: > >> On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote: >> > This is more concise and conveys the intent better. >> > Furthermore, it is likely more pre

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ronald S. Bultje
Hi, On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer wrote: > On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote: > > This is more concise and conveys the intent better. > > Furthermore, it is likely more precise as well due to lack of floating > > point division. > > > > Sig

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Michael Niedermayer
On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote: > This is more concise and conveys the intent better. > Furthermore, it is likely more precise as well due to lack of floating > point division. > > Signed-off-by: Ganesh Ajjanagadde patchset tested on linux32, inux64, mingw32,

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 7:36 AM, wm4 wrote: > On Thu, 29 Oct 2015 07:27:20 -0400 > Ganesh Ajjanagadde wrote: > >> On Thu, Oct 29, 2015 at 5:43 AM, wm4 wrote: >> > On Thu, 29 Oct 2015 00:19:59 -0400 >> > Ganesh Ajjanagadde wrote: >> > >> >> This is more concise and conveys the intent better. >>

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread wm4
On Thu, 29 Oct 2015 07:27:20 -0400 Ganesh Ajjanagadde wrote: > On Thu, Oct 29, 2015 at 5:43 AM, wm4 wrote: > > On Thu, 29 Oct 2015 00:19:59 -0400 > > Ganesh Ajjanagadde wrote: > > > >> This is more concise and conveys the intent better. > >> Furthermore, it is likely more precise as well due

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 5:43 AM, wm4 wrote: > On Thu, 29 Oct 2015 00:19:59 -0400 > Ganesh Ajjanagadde wrote: > >> This is more concise and conveys the intent better. >> Furthermore, it is likely more precise as well due to lack of floating >> point division. >> >> Signed-off-by: Ganesh Ajjanagadd

Re: [FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-29 Thread wm4
On Thu, 29 Oct 2015 00:19:59 -0400 Ganesh Ajjanagadde wrote: > This is more concise and conveys the intent better. > Furthermore, it is likely more precise as well due to lack of floating > point division. > > Signed-off-by: Ganesh Ajjanagadde > --- These patches are all pretty similar. And li

[FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)

2015-10-28 Thread Ganesh Ajjanagadde
This is more concise and conveys the intent better. Furthermore, it is likely more precise as well due to lack of floating point division. Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index f91fb7b..148c21b