Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Anton Khirnov
Quoting Vittorio Giovara (2022-01-12 15:30:55) > This resulted in a dimmed tonemapping due to bad resulting luma > calculation. > > Found by: Derek Buitenhuis > > Signed-off-by: Vittorio Giovara > --- > libavfilter/vf_tonemap.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletion

Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Anton Khirnov
Quoting Vittorio Giovara (2022-01-12 14:43:39) > On Wed, Jan 12, 2022 at 10:47 AM Anton Khirnov wrote: > > > Quoting Vittorio Giovara (2022-01-11 18:48:27) > > > Pushing soon unless objections. Possibly backporting it to 5.0 too. > > > > Could you add a test? > > > > The filter works in floating

[FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Vittorio Giovara
This resulted in a dimmed tonemapping due to bad resulting luma calculation. Found by: Derek Buitenhuis Signed-off-by: Vittorio Giovara --- libavfilter/vf_tonemap.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tone

Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Vittorio Giovara
On Wed, Jan 12, 2022 at 10:51 AM Anton Khirnov wrote: > Quoting Vittorio Giovara (2022-01-05 16:15:06) > > This resulted in a dimmed tonemapping due to bad resulting luma > > calculation. > > > > Found by: Derek Buitenhuis > > > > Signed-off-by: Vittorio Giovara > > --- > > libavfilter/vf_tonem

Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Vittorio Giovara
On Wed, Jan 12, 2022 at 10:47 AM Anton Khirnov wrote: > Quoting Vittorio Giovara (2022-01-11 18:48:27) > > Pushing soon unless objections. Possibly backporting it to 5.0 too. > > Could you add a test? > The filter works in floating point space so it's a bit complex to do so. Maybe it could be op

Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Anton Khirnov
Quoting Vittorio Giovara (2022-01-05 16:15:06) > This resulted in a dimmed tonemapping due to bad resulting luma > calculation. > > Found by: Derek Buitenhuis > > Signed-off-by: Vittorio Giovara > --- > libavfilter/vf_tonemap.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-12 Thread Anton Khirnov
Quoting Vittorio Giovara (2022-01-11 18:48:27) > Pushing soon unless objections. Possibly backporting it to 5.0 too. Could you add a test? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-11 Thread Vittorio Giovara
On Wed, Jan 5, 2022 at 4:15 PM Vittorio Giovara wrote: > This resulted in a dimmed tonemapping due to bad resulting luma > calculation. > > Found by: Derek Buitenhuis > > Signed-off-by: Vittorio Giovara > --- > libavfilter/vf_tonemap.c | 10 +- > 1 file changed, 5 insertions(+), 5 delet

[FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-05 Thread Vittorio Giovara
This resulted in a dimmed tonemapping due to bad resulting luma calculation. Found by: Derek Buitenhuis Signed-off-by: Vittorio Giovara --- libavfilter/vf_tonemap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c

[FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes

2022-01-05 Thread Vittorio Giovara
This resulted in a dimmed tonemapping due to bad resulting luma calculation. Found by: Derek Buitenhuis Signed-off-by: Vittorio Giovara --- libavfilter/vf_tonemap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c in