Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-27 Thread Michael Niedermayer
On Sat, Jan 27, 2018 at 02:24:29AM +, Kieran Kunhya wrote: > On Sat, Jan 27, 2018 at 12:33 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Fri, Jan 26, 2018 at 08:04:39PM +, Kieran Kunhya wrote: > > > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > > > > > wrote

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Sat, Jan 27, 2018 at 12:33 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Fri, Jan 26, 2018 at 08:04:39PM +, Kieran Kunhya wrote: > > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > > > wrote: > > > > > On Sun, Jan 21, 2018 at 12:37:21PM +, Kieran Kunhya wrote: >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Michael Niedermayer
On Fri, Jan 26, 2018 at 08:04:39PM +, Kieran Kunhya wrote: > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > wrote: > > > On Sun, Jan 21, 2018 at 12:37:21PM +, Kieran Kunhya wrote: > > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > > > > > wrote: > > > > > > > Hi > > > >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 10:53 AM, Carl Eugen Hoyos wrote: > 2018-01-22 11:41 GMT+01:00 Marton Balint : > > > Your command line shows gcc 4.7. Maybe this is > > some compiler issue then? > > I can also reproduce the issue with vanilla gcc 6.3.0, > so I don't think this is a compiler issue. Do yo

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer wrote: > On Sun, Jan 21, 2018 at 12:37:21PM +, Kieran Kunhya wrote: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > > > wrote: > > > > > Hi > > > > > > > Patch updated. > > Some of the review comments I decided not to implement i

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-22 Thread Carl Eugen Hoyos
2018-01-22 11:41 GMT+01:00 Marton Balint : > Your command line shows gcc 4.7. Maybe this is > some compiler issue then? I can also reproduce the issue with vanilla gcc 6.3.0, so I don't think this is a compiler issue. Carl Eugen ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-22 Thread Marton Balint
On Mon, 22 Jan 2018, Carl Eugen Hoyos wrote: 2018-01-22 3:35 GMT+01:00 Marton Balint : On Mon, 22 Jan 2018, Carl Eugen Hoyos wrote: 2018-01-21 23:48 GMT+01:00 Kieran Kunhya : On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos wrote: 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : > On Sun

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-22 3:35 GMT+01:00 Marton Balint : > > > On Mon, 22 Jan 2018, Carl Eugen Hoyos wrote: > >> 2018-01-21 23:48 GMT+01:00 Kieran Kunhya : >>> >>> On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos >>> wrote: >>> 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 2:42

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Marton Balint
On Mon, 22 Jan 2018, Carl Eugen Hoyos wrote: 2018-01-21 23:48 GMT+01:00 Kieran Kunhya : On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos wrote: 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos > wrote: > >> 2018-01-21 15:34 GMT+01:00 Kieran

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Michael Niedermayer
On Sun, Jan 21, 2018 at 12:37:21PM +, Kieran Kunhya wrote: > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > wrote: > > > Hi > > > Patch updated. > Some of the review comments I decided not to implement in order to keep > closer to the spec. honestly, this reasoning makes no sense t

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 23:48 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos > wrote: > >> 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : >> > On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos >> > wrote: >> > >> >> 2018-01-21 15:34 GMT+01:00 Kieran Kunhya : >> >> >> >> >> >> Only

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos wrote: > 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : > > On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos > > wrote: > > > >> 2018-01-21 15:34 GMT+01:00 Kieran Kunhya : > >> >> > >> >> Only that I can not reproduce without your patch (and that I

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 23:06 GMT+01:00 Carl Eugen Hoyos : > 2018-01-21 22:45 GMT+01:00 Kieran Kunhya : >> Does this happen in single threaded mode? > > Also happens with "ffplay -threads 1" Also reproducible (sometimes) with --disable-pthreads. Carl Eugen ___ ffmp

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 22:45 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos > wrote: > >> 2018-01-21 15:34 GMT+01:00 Kieran Kunhya : >> >> >> >> Only that I can not reproduce without your patch (and that I have >> >> never seen this issue before). >> >> >> >> Carl Eugen >> >> >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos wrote: > 2018-01-21 15:34 GMT+01:00 Kieran Kunhya : > >> > >> Only that I can not reproduce without your patch (and that I have > >> never seen this issue before). > >> > >> Carl Eugen > >> > > I cannot reproduce this issue with ffplay on Ubuntu L

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 15:34 GMT+01:00 Kieran Kunhya : >> >> Only that I can not reproduce without your patch (and that I have >> never seen this issue before). >> >> Carl Eugen >> > I cannot reproduce this issue with ffplay on Ubuntu Linux. > I would recommend running "make distclean" and recompiling. My las

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
> > Only that I can not reproduce without your patch (and that I have > never seen this issue before). > > Carl Eugen > I cannot reproduce this issue with ffplay on Ubuntu Linux. I would recommend running "make distclean" and recompiling. Kieran ___ ffm

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 14:57 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 1:42 PM, Carl Eugen Hoyos > wrote: > >> 2018-01-21 14:33 GMT+01:00 Kieran Kunhya : >> > On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos >> > wrote: >> > >> >> 2018-01-21 14:22 GMT+01:00 Kieran Kunhya : >> >> >> >> Can you repr

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:42 PM, Carl Eugen Hoyos wrote: > 2018-01-21 14:33 GMT+01:00 Kieran Kunhya : > > On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos > > wrote: > > > >> 2018-01-21 14:22 GMT+01:00 Kieran Kunhya : > >> > >> Can you reproduce the following issue that I see here? > >> When te

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 14:33 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos > wrote: > >> 2018-01-21 14:22 GMT+01:00 Kieran Kunhya : >> >> Can you reproduce the following issue that I see here? >> When testing with ffplay, in ~50% of tries, videos look fine, >> in other cases, I

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos wrote: > 2018-01-21 14:22 GMT+01:00 Kieran Kunhya : > > Can you reproduce the following issue that I see here? > When testing with ffplay, in ~50% of tries, videos look fine, > in other cases, I get a monochrome unchanging image > and the followin

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 14:22 GMT+01:00 Kieran Kunhya : > I will be committing this patch soon. ? Can you reproduce the following issue that I see here? When testing with ffplay, in ~50% of tries, videos look fine, in other cases, I get a monochrome unchanging image and the following repeated error message:

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:08 PM, Carl Eugen Hoyos wrote: > 2018-01-21 14:03 GMT+01:00 Kieran Kunhya : > > On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos > > wrote: > > > >> 2018-01-21 13:37 GMT+01:00 Kieran Kunhya : > >> > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: > >> > > >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 14:03 GMT+01:00 Kieran Kunhya : > On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos > wrote: > >> 2018-01-21 13:37 GMT+01:00 Kieran Kunhya : >> > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: >> > >> >> Hi >> > >> > Patch updated. >> >> If you choose to ignore more than ha

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos wrote: > 2018-01-21 13:37 GMT+01:00 Kieran Kunhya : > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: > > > >> Hi > > > > Patch updated. > > If you choose to ignore more than half of the comments made, > please at least answer the re

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Carl Eugen Hoyos
2018-01-21 13:37 GMT+01:00 Kieran Kunhya : > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: > >> Hi > > Patch updated. If you choose to ignore more than half of the comments made, please at least answer the review to explain why you believe the comments were not helpful. > Some of the

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: > Hi Patch updated. Some of the review comments I decided not to implement in order to keep closer to the spec. Regards, Kieran Kunhya 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data _

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-01 Thread Michael Niedermayer
Hi On Fri, Dec 29, 2017 at 03:46:41PM +, Kieran Kunhya wrote: > $subj > > I'm not to happy about the s->block2 stuff, there are many ways of trying > to resolve this (e.g union), so review welcome. > > I will add DPCM support in a later (currently unfinished) patch. > > Kieran sorry for th

[FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2017-12-29 Thread Kieran Kunhya
$subj I'm not to happy about the s->block2 stuff, there are many ways of trying to resolve this (e.g union), so review welcome. I will add DPCM support in a later (currently unfinished) patch. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data _