2018-01-21 14:03 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > wrote: > >> 2018-01-21 13:37 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: >> > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: >> > >> >> Hi >> > >> > Patch updated. >> >> If you choose to ignore more than half of the comments made, >> please at least answer the review to explain why you >> believe the comments were not helpful. >> >> > Some of the review comments I decided not to implement >> > in order to keep closer to the spec. >> >> We have agreed in the past (on trac) that specifications >> are not necessarily written with the intention to allow >> writing good implementations, so I am not convinced >> this is a sufficient argumentation. >> > Ok, well I only did not implement a couple.
> The startcode one conflates studio start codes with mpeg4 start codes. (Looking up "conflate" did not help me here...) > The show_bits one I'd rather keep it as per the spec. You don't agree that the code gets more readable if you can reduce the number of commands by reordering? > The n&1 comment the compiler should be able to deal with Wishful thinking? > and not speed critical. I thought this is about readability... >> The patch does not apply (and is not trivial to fix), Carl Eugen >> > Patch depends on > [PATCH] simple_idct: Template functions to support an input bitdepth > parameter Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
