On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote:
> On Sun, Jan 21, 2018 at 12:37:21PM +0000, Kieran Kunhya wrote: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > <mich...@niedermayer.cc> > > wrote: > > > > > Hi > > > > > > > Patch updated. > > Some of the review comments I decided not to implement in order to keep > > closer to the spec. > > honestly, this reasoning makes no sense to me. > that spec does IIRC not even fully describe some parts in DPCM > > also all existing mpeg&h26x code we have was designed for speed > basically ignoring if its close to some spec implementation style or not > > I would prefer we try to make our code as good as we can and not try to > be similar to some specification or reference implementation. > except for maybe some niche codecs where performance totally doesnt matter > It does describe DPCM, just in an odd way. I am going to implement your ricing changes but for the record your passive aggressiveness to many developers is awful. Please learn to compromise. Kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
