On 12/14/24 00:39, Marth64 wrote:
This makes sense to me now.
I think it makes more sense to follow the A53
approach and be consistent.
May I suggest the following in the patch to also
improve readability in this crowded area of code:
- SCTE-20 section: as you are declaring `cap` to be
`s1->a53
On 12/14/24 04:12, Anton Khirnov wrote:
Quoting Scott Theisen (2024-12-14 04:06:45)
On 12/13/24 17:39, Marth64 wrote:
Hi Scott,
Thanks for sharing this. I had read your original email also
([RFC] libavcodec/mpeg12dec.c: CC data from skipped frames)
and was thinking about the statement. The pat
Quoting Scott Theisen (2024-12-14 04:06:45)
> On 12/13/24 17:39, Marth64 wrote:
> > Hi Scott,
> >
> > Thanks for sharing this. I had read your original email also
> > ([RFC] libavcodec/mpeg12dec.c: CC data from skipped frames)
> > and was thinking about the statement. The patch helps
> > visualize
This makes sense to me now.
I think it makes more sense to follow the A53
approach and be consistent.
May I suggest the following in the patch to also
improve readability in this crowded area of code:
- SCTE-20 section: as you are declaring `cap` to be
`s1->a53_buf_ref->data + old_size` now, the
On 12/13/24 17:39, Marth64 wrote:
Hi Scott,
Thanks for sharing this. I had read your original email also
([RFC] libavcodec/mpeg12dec.c: CC data from skipped frames)
and was thinking about the statement. The patch helps
visualize the issue a bit better.
I need to study this and test it to unders
Hi Scott,
Thanks for sharing this. I had read your original email also
([RFC] libavcodec/mpeg12dec.c: CC data from skipped frames)
and was thinking about the statement. The patch helps
visualize the issue a bit better.
I need to study this and test it to understand it better.
Meantime, I will app
In mpeg_decode_a53_cc() only the A/53 part 4 CC data ("GA94") is saved between
frames. The other formats incorrectly created a larger buffer than they use
since a705bcd763e344fac191e157ffeddc285388b7fa because they did not append to
the previous data.
A/53 and SCTE-20 specify a maximum of one CC
