Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-24 Thread Thomas Volkert
On 24.09.2014 13:16, Nicolas George wrote: Le primidi 1er vendémiaire, an CCXXIII, Thomas Volkert a écrit : There were enough votes declining this fast patch. That's okay. Yes, you are right. This patch could cause some confusion in the future. See https://trac.ffmpeg.org/ticket/3936 for the

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-24 Thread Nicolas George
Le primidi 1er vendémiaire, an CCXXIII, Thomas Volkert a écrit : > There were enough votes declining this fast patch. That's okay. > Yes, you are right. This patch could cause some confusion in the future. > > See https://trac.ffmpeg.org/ticket/3936 for the origin of this patch. > The idea/patch

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-22 Thread Thomas Volkert
Hello, On 22.09.2014 19:02, Nicolas George wrote: In general I can agree with that argument, but in this particular case I believe it does not apply for two reasons: First, the application will need some redesign anyway to make use of the merged-side-data hack. Definitely not - but this is n

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-22 Thread Nicolas George
Le primidi 1er vendémiaire, an CCXXIII, Michael Niedermayer a écrit : > i dont know details about the application/lib using this, this patch > was just the result of some investigation into why this other patch > was needed: > "[FFmpeg-devel] [PATCH 1/2] mux: make sure that the AV_PKT_DATA_H263_MB_

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 09:47:54PM +0200, wm4 wrote: > On Sun, 21 Sep 2014 21:37:14 +0200 > Michael Niedermayer wrote: > > > On Sun, Sep 21, 2014 at 09:23:18PM +0200, Nicolas George wrote: > > > Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > > > > This allows applications wh

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > user applications and libs which interface to FFmpeg or libavformat > through a URLProtocol or AVIOContext receive the AVPacket.data but > not AVPacket.side_data but the side data is often essential Yes, I know that. And this is

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 21:37:14 +0200 Michael Niedermayer wrote: > On Sun, Sep 21, 2014 at 09:23:18PM +0200, Nicolas George wrote: > > Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > > > This allows applications which interface through AVIOContext or > > > URLProtocol > > > to

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 09:23:18PM +0200, Nicolas George wrote: > Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > > This allows applications which interface through AVIOContext or URLProtocol > > to access side data. > > > > Based-on patch by: Thomas Volkert > > Signed-off-by

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 09:20:23PM +0200, wm4 wrote: > On Sun, 21 Sep 2014 21:15:11 +0200 > Michael Niedermayer wrote: > > > This allows applications which interface through AVIOContext or URLProtocol > > to access side data. > > > > Based-on patch by: Thomas Volkert > > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > This allows applications which interface through AVIOContext or URLProtocol > to access side data. > > Based-on patch by: Thomas Volkert > Signed-off-by: Michael Niedermayer Can you point to the discussion about this patch and

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 21:15:11 +0200 Michael Niedermayer wrote: > This allows applications which interface through AVIOContext or URLProtocol > to access side data. > > Based-on patch by: Thomas Volkert > Signed-off-by: Michael Niedermayer > --- > libavformat/avformat.h |1 + > libavformat/

[FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
This allows applications which interface through AVIOContext or URLProtocol to access side data. Based-on patch by: Thomas Volkert Signed-off-by: Michael Niedermayer --- libavformat/avformat.h |1 + libavformat/mux.c |6 ++ libavformat/version.h |4 ++-- 3 files changed, 9