Hello, On 22.09.2014 19:02, Nicolas George wrote:
In general I can agree with that argument, but in this particular case I believe it does not apply for two reasons: First, the application will need some redesign anyway to make use of the merged-side-data hack.
Definitely not - but this is no longer important for this case.
In the short run, I believe the work to do that may be less than a redesign to use the API properly, but only slightly. In the longer run, the application will be better with a proper design anyway, by far. Second, a 5-lines patch is ok as long as it does not create a maintenance burden. I believe this one very much does. Most critically, if someone endeavours to kill that ugly and fragile hack of merged-side-data, having it exposed to public API like that makes the task that much harder.
There were enough votes declining this fast patch. That's okay. Yes, you are right. This patch could cause some confusion in the future. See https://trac.ffmpeg.org/ticket/3936 for the origin of this patch. The idea/patch is no longer pursued. Best regards, Thomas. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
