Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-16 Thread Gyan Doshi
On 2024-03-16 02:02 pm, Marton Balint wrote: On Sat, 16 Mar 2024, Gyan Doshi wrote: 8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed at

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-16 Thread Marton Balint
On Sat, 16 Mar 2024, Gyan Doshi wrote: 8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed at https://github.com/streamlink/streamlink/issues

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: correct bitstream check

2024-03-15 Thread Gyan Doshi
8559cce3c3 made the bitstream check generic using a LUT. However, one of the comparisons which involves a bitwise AND and equality check is faulty due to operator precedence. First reported and analysed at https://github.com/streamlink/streamlink/issues/5876 Fixes #10908 --- libavformat/mpegtsen

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Always output a minimum of 32 packets.

2022-11-29 Thread Derek Buitenhuis
On 11/28/2022 10:25 PM, Marton Balint wrote: > This looks like a demuxer bug, which should be fixed in the demuxer, and > not in the muxer. +1. I had to re-read the commit message twice because I coulndn't figure out why the muxer would care about lavf specific demuxer probing. - Derek

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Always output a minimum of 32 packets.

2022-11-28 Thread Marton Balint
On Mon, 28 Nov 2022, James Almer wrote: From: Thierry Foucu Otherwise, if you just output a PAT/PMT and a single TS packets, the demuxer will not be able to detect TS. This looks like a demuxer bug, which should be fixed in the demuxer, and not in the muxer. Regards, Marton Signed-o

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Always output a minimum of 32 packets.

2022-11-28 Thread James Almer
From: Thierry Foucu Otherwise, if you just output a PAT/PMT and a single TS packets, the demuxer will not be able to detect TS. Signed-off-by: James Almer --- libavformat/mpegtsenc.c | 11 --- tests/ref/acodec/s302m | 4 ++-- tests/ref/lavf/ts | 4 ++-- 3 files changed, 8 inse

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add pcr_at_keyframe flag

2022-09-28 Thread Marton Balint
On Wed, 28 Sep 2022, Zhao Zhili wrote: From: Zhao Zhili Add PCR at keyframe can be undesirable when -pcr_period is specified. Add an flag to disable this behavior. Actually you are disabling the writing of random access indicators, not only PCRs. PCR's are just there because it is mandat

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: add pcr_at_keyframe flag

2022-09-27 Thread Zhao Zhili
From: Zhao Zhili Add PCR at keyframe can be undesirable when -pcr_period is specified. Add an flag to disable this behavior. Signed-off-by: Zhao Zhili --- doc/muxers.texi | 2 ++ libavformat/mpegtsenc.c | 8 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/mu

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Maksym Veremeyenko
On 08.11.2021 17:31, Kieran Kunhya wrote: [...] The positioning of the packet relative to the PCR matters. Also splice_time() is relative to the new PCR and timestamps which I don't think the mux here can guarantee? i could be wrong, but time_signal() carry splice_time() what carry pts_time th

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Kieran Kunhya
On Mon, 8 Nov 2021 at 15:17, Maksym Veremeyenko wrote: > On 08.11.2021 16:41, Kieran Kunhya wrote: > > On Mon, 8 Nov 2021 at 06:35, Maksym Veremeyenko > wrote: > > > >> Hi, > >> > >> Attached patch implement muxing SCTE-35 and EPG packets into mpegts > stream. > >> > > > > SCTE Markers need time

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Maksym Veremeyenko
On 08.11.2021 16:41, Kieran Kunhya wrote: On Mon, 8 Nov 2021 at 06:35, Maksym Veremeyenko wrote: Hi, Attached patch implement muxing SCTE-35 and EPG packets into mpegts stream. SCTE Markers need timestamping, no? SCTE markers has no timestamping, during reading at mpegts.c it timestamp

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-08 Thread Kieran Kunhya
On Mon, 8 Nov 2021 at 06:35, Maksym Veremeyenko wrote: > Hi, > > Attached patch implement muxing SCTE-35 and EPG packets into mpegts stream. > SCTE Markers need timestamping, no? Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Implement muxing SCTE-35 and EPG packets

2021-11-07 Thread Maksym Veremeyenko
Hi, Attached patch implement muxing SCTE-35 and EPG packets into mpegts stream. -- Maksym Veremeyenko From dc1b87f5e34c688bb3691767f8026a2815aab03e Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko Date: Mon, 8 Nov 2021 08:10:59 +0200 Subject: [PATCH] avformat/mpegtsenc: Implement muxing SCTE-

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Dont include adaptation field in teletext TS packets.

2021-11-06 Thread Marton Balint
On Thu, 21 Oct 2021, Alex Shumsky wrote: From ETSI EN 300 472 V1.3.1 (2003-05) Specification for conveying ITU-R System B Teletext in DVB bitstreams: 4.1 Transport Stream (TS) packet format The standard TS packet syntax and semantics are followed, noting the following constraint: - adaptat

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Dont include adaptation field in teletext TS packets.

2021-10-21 Thread Alex Shumsky
>From ETSI EN 300 472 V1.3.1 (2003-05) Specification for conveying ITU-R System >B Teletext in DVB bitstreams: 4.1 Transport Stream (TS) packet format The standard TS packet syntax and semantics are followed, noting the following constraint: - adaptation_field_control only the values "01" and "10

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-19 Thread Marton Balint
On Tue, 20 Apr 2021, zheng qian wrote: According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_id meets the condition: if (stream_id != 0xBC && // program_stream_map stream_id !

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-19 Thread Mao Hata
On 2021/04/20 1:36, zheng qian wrote: I'm working on ARIB related patches for mpegtsenc.c and later I would like to provide a patch to fix the bug of private_stream_2. In current situation, mpegts_write_pes() incorrectly writes private_stream_2 with actually a private_stream_1-like PES header th

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-19 Thread zheng qian
According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_id meets the condition: if (stream_id != 0xBC && // program_stream_map stream_id != 0xBE && // padding_stream stream_id != 0xB

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-19 Thread zheng qian
On Tue, Apr 20, 2021 at 12:44 AM Mao Hata wrote: > > The reason I created the patch was to fix the problem: when I transcode > a transport stream based on ARIB-STD-B24, the PTS/DTS is removed from > private_stream_1 streams, and, conversely, it is added to private_stream_2. > "ISO/IEC 13818-1 Tabl

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-19 Thread Mao Hata
On 2021/04/19 5:25, Marton Balint wrote: On Sat, 17 Apr 2021, Mao Hata wrote: According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. Which section describes this? Also keep in mind that code was added so that AV_CODEC_ID_

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-18 Thread Marton Balint
On Sat, 17 Apr 2021, Mao Hata wrote: According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. Which section describes this? Also keep in mind that code was added so that AV_CODEC_ID_SMPTE_KLV is handled in mpegts, and SMPT

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-17 Thread Mao Hata
According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. From c1663cbdbbd2178cb199e079ec9bb712d1d757d8 Mon Sep 17 00:00:00 2001 From: Mao Hata Date: Sat, 17 Apr 2021 19:55:22 +0900 Subject: [PATCH] avformat/mpegtsenc: private_str

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-04 Thread Marton Balint
On Sun, 4 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: On Sat, 3 Apr 2021, Andreas Rheinhardt wrote: Implements ticket #9113. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-04 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 3 Apr 2021, Andreas Rheinhardt wrote: > >> Implements ticket #9113. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/mpegtsenc.c | 18 +- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/libavformat/mpegtsenc.c b/liba

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-04 Thread Marton Balint
On Sat, 3 Apr 2021, Andreas Rheinhardt wrote: Implements ticket #9113. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 35c835c484..dbd3b

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-03 Thread Andreas Rheinhardt
stephen douglas: > ISO 639 language descriptors used by DVB are the 3 charecter variants hence > const char *language = lang && strlen(lang->value) >= 3 ? lang->value : > default_language;should beconst char *language = lang && strlen(lang->value) > > 3 ? lang->value : default_language; 1. Sto

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-02 Thread stephen douglas
ISO 639 language descriptors used by DVB are the 3 charecter variants hence const char *language = lang && strlen(lang->value) >= 3 ? lang->value : default_language;should beconst char *language = lang && strlen(lang->value) > 3 ? lang->value : default_language; On Saturday, 3 April 2021, 06

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-02 Thread Andreas Rheinhardt
Implements ticket #9113. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 35c835c484..dbd3bb148a 100644 --- a/libavformat/mpegtsenc.c +++ b/

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: use av_log_once for data stream warning

2020-04-22 Thread Gyan Doshi
On 23-04-2020 01:33 am, Marton Balint wrote: On Wed, 22 Apr 2020, Gyan Doshi wrote: --- libavformat/mpegtsenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4fe3d84c59..f2be6c6632 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: use av_log_once for data stream warning

2020-04-22 Thread Marton Balint
On Wed, 22 Apr 2020, Gyan Doshi wrote: --- libavformat/mpegtsenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4fe3d84c59..f2be6c6632 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: use av_log_once for data stream warning

2020-04-22 Thread Gyan Doshi
--- libavformat/mpegtsenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4fe3d84c59..f2be6c6632 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -238,6 +238,7 @@ typedef struct Mpeg

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: don't print warning for DVB text streams

2020-04-22 Thread Gyan Doshi
On 22-04-2020 01:21 am, Marton Balint wrote: On Mon, 20 Apr 2020, Gyan Doshi wrote: They can be demuxed by ffmpeg. --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index ccb631d746..3818001976 100644 --- a/l

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: don't print warning for DVB text streams

2020-04-21 Thread Marton Balint
On Mon, 20 Apr 2020, Gyan Doshi wrote: They can be demuxed by ffmpeg. --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index ccb631d746..3818001976 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtse

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: don't print warning for DVB text streams

2020-04-20 Thread Gyan Doshi
They can be demuxed by ffmpeg. --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index ccb631d746..3818001976 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -381,6 +381,10 @@ static int mpegt

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: warn users if codec isn't supported

2019-12-23 Thread Gyan
On 23-12-2019 08:45 pm, Limin Wang wrote: On Fri, Dec 20, 2019 at 04:55:12PM +0530, Gyan wrote: Regards, Gyan From fbbd221b089f3b272cfd712c3d4824dd86b4eac0 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 20 Dec 2019 16:39:32 +0530 Subject: [PATCH] avformat/mpegtsenc: warn users if codec

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: warn users if codec isn't supported

2019-12-23 Thread Limin Wang
On Fri, Dec 20, 2019 at 04:55:12PM +0530, Gyan wrote: > > Regards, > Gyan > From fbbd221b089f3b272cfd712c3d4824dd86b4eac0 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Fri, 20 Dec 2019 16:39:32 +0530 > Subject: [PATCH] avformat/mpegtsenc: warn users if codec isn't supported > > The MPEG-T

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: warn users if codec isn't supported

2019-12-22 Thread Gyan
On 20-12-2019 04:55 pm, Gyan wrote: Regards, Gyan Will push tonight. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpe

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: warn users if codec isn't supported

2019-12-20 Thread Gyan
Regards, Gyan From fbbd221b089f3b272cfd712c3d4824dd86b4eac0 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 20 Dec 2019 16:39:32 +0530 Subject: [PATCH] avformat/mpegtsenc: warn users if codec isn't supported The MPEG-TS muxer will mux streams with unsupported codec id as a private data str

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: do not write SDT for m2ts

2019-11-14 Thread Marton Balint
BDMV does not seem to use it. Signed-off-by: Marton Balint --- doc/muxers.texi | 3 ++- libavformat/mpegtsenc.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 4e76b40151..aa4bde518d 100644 --- a/doc/muxers.texi +++ b/doc/mu

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-06 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 6 de August de 2019 0:20, Marton Balint wrote: > On Mon, 5 Aug 2019, Andreas Håkon wrote: > > > Hi Marton, > > ‐‐‐ Original Message ‐‐‐ > > On Sunday, 4 de August de 2019 22:30, Marton Balint c...@passwd.hu wrote: > > > > > PCR gen

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-05 Thread Marton Balint
On Mon, 5 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:30, Marton Balint wrote: PCR generation was based on counting packets for both CBR and VBR streams. Couting packets might have worked for CBR streams (when muxrate was sp

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-05 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:30, Marton Balint wrote: > PCR generation was based on counting packets for both CBR and VBR streams. > Couting packets might have worked for CBR streams (when muxrate was specified) > but it only took into account th

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-04 Thread Marton Balint
PCR generation was based on counting packets for both CBR and VBR streams. Couting packets might have worked for CBR streams (when muxrate was specified) but it only took into account the packets of a service (or the packets of the PCR stream lately), so even that was problematic for multi program

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: added support for the write_data_type callback

2019-03-22 Thread Oliver Collyer via ffmpeg-devel
> > This patch makes it possible to do stuff like write a custom in-memory TS > segmenter, which was what I needed it for. > >> Hi >> >> I needed to be able to use the write_data_type callback when reading data >> from the mpegts muxer, to make my application aware of key frames in the >> dat

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: added support for the write_data_type callback

2019-03-15 Thread Oliver Collyer
> > This patch makes it possible to do stuff like write a custom in-memory TS > segmenter, which was what I needed it for. > >> Hi >> >> I needed to be able to use the write_data_type callback when reading data >> from the mpegts muxer, to make my application aware of key frames in the >> dat

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: added support for the write_data_type callback

2019-03-08 Thread Oliver Collyer
[Apols for sending this again, but I realised the subject didn't describe the change, which was unhelpful) This patch makes it possible to do stuff like write a custom in-memory TS segmenter, which was what I needed it for. > Hi > > I needed to be able to use the write_data_type callback when

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc:

2019-03-07 Thread Oliver Collyer
> Hi > > I needed to be able to use the write_data_type callback when reading data > from the mpegts muxer, to make my application aware of key frames in the data > so I added support. I used the matroska implementation as a reference. > > If this is accepted, I will format this as a proper pa

[FFmpeg-devel] [PATCH] avformat/mpegtsenc:

2019-03-06 Thread Oliver Collyer
Hi I needed to be able to use the write_data_type callback when reading data from the mpegts muxer, to make my application aware of key frames in the data so I added support. I used the matroska implementation as a reference. If this is accepted, I will format this as a proper patch after feedb

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Add option to mark stream begin as discontinuous

2016-11-02 Thread Michael Niedermayer
On Wed, Nov 02, 2016 at 10:31:38PM +0800, Steven Liu wrote: > 2016-11-02 7:51 GMT+08:00 Michael Niedermayer : > > > This avoids continuity check failures in concatenated streams > > > > TODO: docs > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mpegtsenc.c | 26 +++

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Add option to mark stream begin as discontinuous

2016-11-02 Thread Steven Liu
2016-11-02 7:51 GMT+08:00 Michael Niedermayer : > This avoids continuity check failures in concatenated streams > > TODO: docs > > Signed-off-by: Michael Niedermayer > --- > libavformat/mpegtsenc.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/libavformat/m

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Add option to mark stream begin as discontinuous

2016-11-01 Thread Michael Niedermayer
This avoids continuity check failures in concatenated streams TODO: docs Signed-off-by: Michael Niedermayer --- libavformat/mpegtsenc.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 3ad3de7..71a6642 100644

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-25 Thread Vittorio Gambaletta (VittGam)
Hi, On 25/01/2016 19:35:58 CET, Michael Niedermayer wrote: On Sun, Jan 24, 2016 at 03:54:34PM +0100, Vittorio Gambaletta (VittGam) wrote: Hi, On 24/01/2016 12:01:38 CET, Michael Niedermayer wrote: >On Sun, Jan 24, 2016 at 06:06:36AM +0100, Vittorio Gambaletta (VittGam) wrote: >>Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-25 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 03:54:34PM +0100, Vittorio Gambaletta (VittGam) wrote: > Hi, > > On 24/01/2016 12:01:38 CET, Michael Niedermayer wrote: > >On Sun, Jan 24, 2016 at 06:06:36AM +0100, Vittorio Gambaletta (VittGam) > >wrote: > >>Signed-off-by: Vittorio Gambaletta > >>--- > >> libavformat/mpe

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-24 Thread Vittorio Gambaletta (VittGam)
Hi, On 24/01/2016 12:01:38 CET, Michael Niedermayer wrote: On Sun, Jan 24, 2016 at 06:06:36AM +0100, Vittorio Gambaletta (VittGam) wrote: Signed-off-by: Vittorio Gambaletta --- libavformat/mpegtsenc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 06:06:36AM +0100, Vittorio Gambaletta (VittGam) wrote: > Signed-off-by: Vittorio Gambaletta > --- > libavformat/mpegtsenc.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c > inde

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-23 Thread Vittorio Gambaletta (VittGam)
Signed-off-by: Vittorio Gambaletta --- libavformat/mpegtsenc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 2c12043..a20e229 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -275

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-23 Thread Michael Niedermayer
On Sun, Dec 13, 2015 at 11:54:32AM +0100, Stefan Pöschel wrote: > So far an AC-3 elementary stream is refered to in the PMT according to > System A (ATSC). An E-AC-3 ES in contrast is embedded the System B (DVB) way. > To fix this inconsistency, this commit changes the default E-AC-3 behaviour to >

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-23 Thread Stefan Pöschel
Just wanted to ask if there is any further information needed regarding my patch. > Gesendet: Sonntag, 13. Dezember 2015 um 11:54 Uhr > Von: "Stefan Pöschel" > An: ffmpeg-devel@ffmpeg.org > Betreff: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an > A

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-17 Thread Stefan Pöschel
*bump* Am 13.12.2015 um 15:23 schrieb Stefan Pöschel: > Am 13.12.2015 um 14:18 schrieb Moritz Barsnick: >> On Sun, Dec 13, 2015 at 11:54:32 +0100, Stefan Pöschel wrote: >>> So far an AC-3 elementary stream is refered to in the PMT according to >>> System A (ATSC). An E-AC-3 ES in contrast is embed

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-13 Thread Stefan Pöschel
Am 13.12.2015 um 14:18 schrieb Moritz Barsnick: > On Sun, Dec 13, 2015 at 11:54:32 +0100, Stefan Pöschel wrote: >> So far an AC-3 elementary stream is refered to in the PMT according to >> System A (ATSC). An E-AC-3 ES in contrast is embedded the System B (DVB) way. > > Interesting, that's apparen

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-13 Thread Moritz Barsnick
On Sun, Dec 13, 2015 at 11:54:32 +0100, Stefan Pöschel wrote: > So far an AC-3 elementary stream is refered to in the PMT according to > System A (ATSC). An E-AC-3 ES in contrast is embedded the System B (DVB) way. Interesting, that's apparently the reason why my (DVB-)PVR didn't ever recognize AC

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: add flag to embed an AC-3/E-AC-3 ES the DVB way

2015-12-13 Thread Stefan Pöschel
So far an AC-3 elementary stream is refered to in the PMT according to System A (ATSC). An E-AC-3 ES in contrast is embedded the System B (DVB) way. To fix this inconsistency, this commit changes the default E-AC-3 behaviour to use the ATSC way, too. Furthermore a new flag is added to optionally se

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Support a user specified PAT/PMT period

2015-07-18 Thread Michael Niedermayer
On Thu, Jul 16, 2015 at 12:56:55PM +0200, Michael Niedermayer wrote: > From: Michael Niedermayer > > Can be used to fix Ticket3714 > > TODO, add docs added docs applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign e

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Support a user specified PAT/PMT period

2015-07-16 Thread Michael Niedermayer
From: Michael Niedermayer Can be used to fix Ticket3714 TODO, add docs Signed-off-by: Michael Niedermayer --- libavformat/mpegtsenc.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 7fc717c..

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix build with msvc

2015-02-03 Thread Michael Niedermayer
On Wed, Feb 04, 2015 at 12:49:39AM +1100, Matt Oliver wrote: > A recent commit has broken msvc compilation. > http://fate.ffmpeg.org/report.cgi?time=20150203090035&slot=x86_32-msvc12-windows-native > > Attached is the corresponding fix. > mpegtsenc.c | 20 ++-- > 1 file changed

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix build with msvc

2015-02-03 Thread Matt Oliver
A recent commit has broken msvc compilation. http://fate.ffmpeg.org/report.cgi?time=20150203090035&slot=x86_32-msvc12-windows-native Attached is the corresponding fix. avformat-mpegtsenc-Fix-build-with-msvc.patch Description: Binary data ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add an option to disable first PTS check.

2014-10-24 Thread Michael Niedermayer
On Fri, Oct 24, 2014 at 04:47:51PM +0200, Nicolas George wrote: > Le tridi 3 brumaire, an CCXXIII, Benoit Fouet a écrit : > > Fixes ticket #1598 > > --- > > libavformat/mpegtsenc.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > Are the produced files valid? If they are, why do

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add an option to disable first PTS check.

2014-10-24 Thread Benoit Fouet
Hi, Le 24/10/2014 16:47, Nicolas George a écrit : > Le tridi 3 brumaire, an CCXXIII, Benoit Fouet a écrit : >> Fixes ticket #1598 >> --- >> libavformat/mpegtsenc.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) > Are the produced files valid? If they are, why do the test at all? If

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: add an option to disable first PTS check.

2014-10-24 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIII, Benoit Fouet a écrit : > Fixes ticket #1598 > --- > libavformat/mpegtsenc.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Are the produced files valid? If they are, why do the test at all? If they are not, can this be considered actually a fix for t

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: add an option to disable first PTS check.

2014-10-24 Thread Benoit Fouet
Fixes ticket #1598 --- libavformat/mpegtsenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index d73b75f..74541d1 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -91,6 +91,7 @@ typedef struct MpegT