On Fri, Oct 24, 2014 at 04:47:51PM +0200, Nicolas George wrote:
> Le tridi 3 brumaire, an CCXXIII, Benoit Fouet a écrit :
> > Fixes ticket #1598
> > ---
> >  libavformat/mpegtsenc.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Are the produced files valid? If they are, why do the test at all? If they
> are not, can this be considered actually a fix for the issue?

its allowed to have some timestamps missing in TS under some
circumstances. so it might be possible to generate a valid file
with the first pts missing (i dont know for sure, id have to check the
spec) also iam not sure what our muxer makes out of that case.
Its certainly better to have valid timestamps on the muxer input
on all frames and let the muxer decide which to store in the file
and which to ommit
calculating valid timestamps for h264/hevc input that ommits some is
not entirely trivial though

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to