Hi, Le 24/10/2014 16:47, Nicolas George a écrit : > Le tridi 3 brumaire, an CCXXIII, Benoit Fouet a écrit : >> Fixes ticket #1598 >> --- >> libavformat/mpegtsenc.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) > Are the produced files valid? If they are, why do the test at all? If they > are not, can this be considered actually a fix for the issue?
This was just a shot in the dark from a real quick look at the issue. ffplay is able to play the file (with a warning on pts though), but I don't think the files are valid. I think I'll spend some more time on all this end of next week, specifically on the genpts thing, as this would seem a valid way to be able to remux the raw h264 files. > I believe the commit message should at least spare a few words to explain. I believe I could have refrained from sending this patch in the first place, as my gut feeling is that it does not fix anything in the first place. Thanks, -- Ben _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
