Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread James Almer
On 5/13/2024 7:49 PM, Michael Niedermayer wrote: On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote: On Mon, 13 May 2024, 02:32 Michael Niedermayer, wrote: On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: Fixes: CID1439574 Dereference after null check Sponsore

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread Michael Niedermayer
On Mon, May 13, 2024 at 06:15:16AM +0100, Kieran Kunhya wrote: > On Mon, 13 May 2024, 02:32 Michael Niedermayer, > wrote: > > > On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: > > > Fixes: CID1439574 Dereference after null check > > > > > > Sponsored-by: Sovereign Tech Fund >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-13 Thread Michael Niedermayer
On Mon, May 13, 2024 at 09:04:34AM +0300, Rémi Denis-Courmont wrote: > > > Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer > a écrit : > >Fixes: CID1439574 Dereference after null check > > If SPS is guaranteed to be non-NULL, there should probably be an assertion to > document it, and i

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-12 Thread Rémi Denis-Courmont
Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer a écrit : >Fixes: CID1439574 Dereference after null check If SPS is guaranteed to be non-NULL, there should probably be an assertion to document it, and it should be *before* that alleged dereference (which is not visible in the patch con

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-12 Thread Kieran Kunhya
On Mon, 13 May 2024, 02:32 Michael Niedermayer, wrote: > On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: > > Fixes: CID1439574 Dereference after null check > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/h264_slice.c |

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-12 Thread Michael Niedermayer
On Mon, May 06, 2024 at 03:23:07AM +0200, Michael Niedermayer wrote: > Fixes: CID1439574 Dereference after null check > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/h264_slice.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [.

[FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

2024-05-05 Thread Michael Niedermayer
Fixes: CID1439574 Dereference after null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/h264_slice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 90d37f60848..ce2c4caca1b 100