Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-21 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 11:26:13AM +0200, Deti Fliegl wrote: > On 30.08.14 01:22, Michael Niedermayer wrote: > >moving code from (like from decklink_enc.cpp to decklink_common.cpp) > >should be in a seperate patch > Done. Both patches are attached to this mail. > > >If you want to maintain this co

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-19 Thread Timothy Gu
On Fri, Sep 19, 2014 at 8:53 AM, Amnon Israely wrote: >> >> >> What do you think might be the problem here? >> >> > I changed streams order in deckling_dec.cpp > and Video now on 0:0 Video is not guaranteed to be always on 0:0, and therefore you are trying to fix a nonexistent problem here. [...

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-19 Thread Amnon Israely
> > > What do you think might be the problem here? > > I changed streams order in deckling_dec.cpp and Video now on 0:0 /* Setup streams. */ st = avformat_new_stream(avctx, NULL); if (!st) { av_log(avctx, AV_LOG_ERROR, "Cannot add stream\n"); goto error; } st

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-17 Thread Roger Pack
On Mon, Sep 15, 2014 at 11:19 AM, Amnon Israely wrote: > It's work already more than 24h > > Maybe it's not a big problem but in some scenario may do some problem > > Input #0, decklink, from 'DeckLink SDI (3)@3': > Duration: N/A, start: 0.00, bitrate: 172032 kb/s > Stream #0:0: Audio:

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-15 Thread Amnon Israely
It's work already more than 24h Maybe it's not a big problem but in some scenario may do some problem Input #0, decklink, from 'DeckLink SDI (3)@3': Duration: N/A, start: 0.00, bitrate: 172032 kb/s Stream #0:0: Audio: pcm_s16le, 48000 Hz, 8 channels, s16, 6144 kb/s Stream #0:1: Vide

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-14 Thread Amnon Israely
I can help with testing under Linux. We use many deckling devices in production. 2014-09-14 17:15 GMT+03:00 Dave Rice : > > On Sep 14, 2014, at 7:07 AM, Deti Fliegl wrote: > > > I really would like to bring things forward, but currently nobody wants > to review this patch. It's primarily somethi

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-14 Thread Dave Rice
On Sep 14, 2014, at 7:07 AM, Deti Fliegl wrote: > I really would like to bring things forward, but currently nobody wants to > review this patch. It's primarily something that is used under Linux and not > Windows. So please would anyone have a look at my patch. I have a few decklink devices

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-14 Thread Deti Fliegl
I really would like to bring things forward, but currently nobody wants to review this patch. It's primarily something that is used under Linux and not Windows. So please would anyone have a look at my patch. Deti On 30.08.14 01:22, Michael Niedermayer wrote: On Sat, Aug 23, 2014 at 10:50:37P

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-05 Thread Deti Fliegl
Using the native DeckLink api is more efficient and allows you to do more things. On top you get Linux and MacOS X support. Deti On 05.09.14 16:37, Roger Pack wrote: So you tested this in linux and windows? And it works? What is the advantage of this over dshow, does it work "better" somehow [

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-05 Thread Roger Pack
So you tested this in linux and windows? And it works? What is the advantage of this over dshow, does it work "better" somehow [I know dshow is deficient in multiple ways, FWIW]. Or was it just to add linux support? Cheers! -roger- On Mon, Aug 18, 2014 at 12:40 PM, Deti Fliegl wrote: > Rebased

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-05 Thread Deti Fliegl
On 04.09.14 16:44, Deron wrote: What I did to test capture capabilities was use two decklink devices and connect them together. To test output, I happen to have an HD-SDI capable monitor. Good luck, I've not had any luck with the "official" ffmpeg decklink driver. Could you please explain what yo

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-04 Thread Dave Rice
On Sep 4, 2014, at 10:44 AM, Deron wrote: > On 9/4/14 8:06 AM, Roger Pack wrote: >> Do you have some instructions on how to get the headers to make this >> download work? Any links to some device to exercise the code, like on >> amazon [cheaper better LOL]. >> > The DeckLink headers/sdk/librari

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-04 Thread Deron
On 9/4/14 8:06 AM, Roger Pack wrote: Do you have some instructions on how to get the headers to make this download work? Any links to some device to exercise the code, like on amazon [cheaper better LOL]. The DeckLink headers/sdk/libraries can be found at blackmagicdesign.com. The last copy I d

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-04 Thread Roger Pack
Do you have some instructions on how to get the headers to make this download work? Any links to some device to exercise the code, like on amazon [cheaper better LOL]. On Tue, Sep 2, 2014 at 3:26 AM, Deti Fliegl wrote: > On 30.08.14 01:22, Michael Niedermayer wrote: > >> moving code from (like

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-02 Thread Deti Fliegl
On 30.08.14 01:22, Michael Niedermayer wrote: moving code from (like from decklink_enc.cpp to decklink_common.cpp) should be in a seperate patch Done. Both patches are attached to this mail. If you want to maintain this code, please add yourself to the MAINTAINERs file Added. non static fun

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-29 Thread Michael Niedermayer
On Sat, Aug 23, 2014 at 10:50:37PM +0200, Deti Fliegl wrote: > On 19.08.14 15:43, Carl Eugen Hoyos wrote: > >Deti Fliegl fliegl.de> writes: > > > >>Minor update to propagate field dominance. > > > >At least a Changelog entry and a libavdevice version > >bump are still missing, but consider waiting

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-23 Thread Deti Fliegl
On 19.08.14 15:43, Carl Eugen Hoyos wrote: Deti Fliegl fliegl.de> writes: Minor update to propagate field dominance. At least a Changelog entry and a libavdevice version bump are still missing, but consider waiting for a real review. Well in the meantime I updated my patch once again to add

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-19 Thread Carl Eugen Hoyos
Deti Fliegl fliegl.de> writes: > Minor update to propagate field dominance. At least a Changelog entry and a libavdevice version bump are still missing, but consider waiting for a real review. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-19 Thread Deti Fliegl
Minor update to propagate field dominance. On 18.08.14 20:40, Deti Fliegl wrote: > Rebased commits to have all changes in one patch. Hopefully it's > complete now. > > Deti > > On 18.08.14 19:48, Deti Fliegl wrote: >> On 18.08.14 19:23, Carl Eugen Hoyos wrote: >>> Deti Fliegl fliegl.de> writes:

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Deti Fliegl
On 18.08.14 20:05, Carl Eugen Hoyos wrote: > Deti Fliegl fliegl.de> writes: > +av_log(NULL, AV_LOG_ERROR, >>> >>> Context should not be NULL. >> Can hardly be done in this file unless you supply avctx as >> argument in every function only for av_log purposes. > > Please do this

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Deti Fliegl
Rebased commits to have all changes in one patch. Hopefully it's complete now. Deti On 18.08.14 19:48, Deti Fliegl wrote: > On 18.08.14 19:23, Carl Eugen Hoyos wrote: >> Deti Fliegl fliegl.de> writes: >> >>> +/* free() is needed for a string returned by the DeckLink SDL. */ >>> +#undef free >> >

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Carl Eugen Hoyos
Deti Fliegl fliegl.de> writes: > >> +av_log(NULL, AV_LOG_ERROR, > > > > Context should not be NULL. > Can hardly be done in this file unless you supply avctx as > argument in every function only for av_log purposes. Please do this. The patch you sent in your second mail is complet

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Deti Fliegl
On 18.08.14 19:23, Carl Eugen Hoyos wrote: > Deti Fliegl fliegl.de> writes: > >> +/* free() is needed for a string returned by the DeckLink SDL. */ >> +#undef free > > I believe this is not needed anymore but ... removed it - but this has been part of the existing code which I simply moved to a

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Carl Eugen Hoyos
Deti Fliegl fliegl.de> writes: > +/* free() is needed for a string returned by the DeckLink SDL. */ > +#undef free I believe this is not needed anymore but ... > +free((void *) tmpDisplayName); ... please move the comment here. Is the cast necessary? > +av_log(NULL, AV_LOG_ERR

[FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Deti Fliegl
Signed-off-by: Deti fliegl --- libavdevice/decklink_common.cpp | 227 ++ libavdevice/decklink_common.h | 98 libavdevice/decklink_common_c.h | 32 +++ libavdevice/decklink_dec.cpp| 520 libavdevice/decklink_dec.h | 3