Deti Fliegl <deti <at> fliegl.de> writes: > +/* free() is needed for a string returned by the DeckLink SDL. */ > +#undef free
I believe this is not needed anymore but ... > + free((void *) tmpDisplayName); ... please move the comment here. Is the cast necessary? > + av_log(NULL, AV_LOG_ERROR, Context should not be NULL. > + av_log(NULL, AV_LOG_INFO, "Found Decklink mode %d x > %d with rate %.2f%s\n", bmd_width, bmd_height, > (float)bmd_tb_den/(float)bmd_tb_num, > (ctx->bmd_field_dominance==bmdLowerFieldFirst || > ctx->bmd_field_dominance==bmdUpperFieldFirst)?"(i)":""); Please split this line. Isn't your patch missing a configure check and a change to Makefile? (What is the license of the decklink libraries?) Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
