I really would like to bring things forward, but currently nobody wants to review this patch. It's primarily something that is used under Linux and not Windows. So please would anyone have a look at my patch.

Deti

On 30.08.14 01:22, Michael Niedermayer wrote:
On Sat, Aug 23, 2014 at 10:50:37PM +0200, Deti Fliegl wrote:
On 19.08.14 15:43, Carl Eugen Hoyos wrote:
Deti Fliegl <deti <at> fliegl.de> writes:

Minor update to propagate field dominance.

At least a Changelog entry and a libavdevice version
bump are still missing, but consider waiting for a
real review.
Well in the meantime I updated my patch once again to add proper
frame sizes and frame rates to the video codec. Maybe somebody wants
to review the patch.

Deti


  configure                       |    4
  doc/indevs.texi                 |   54 ++++
  libavdevice/Makefile            |    5
  libavdevice/alldevices.c        |    2
  libavdevice/decklink_common.cpp |  229 +++++++++++++++++
  libavdevice/decklink_common.h   |   98 +++++++
  libavdevice/decklink_common_c.h |   32 ++
  libavdevice/decklink_dec.cpp    |  531 
++++++++++++++++++++++++++++++++++++++++
  libavdevice/decklink_dec.h      |   32 ++
  libavdevice/decklink_dec_c.c    |   54 ++++
  libavdevice/decklink_enc.cpp    |  196 +-------------

moving code from (like from decklink_enc.cpp to decklink_common.cpp)
should be in a seperate patch


  libavdevice/decklink_enc.h      |   11
  libavdevice/decklink_enc_c.c    |    1
  13 files changed, 1055 insertions(+), 194 deletions(-)

If you want to maintain this code, please add yourself to the
MAINTAINERs file


[...]

+#ifdef _WIN32
+char *dup_wchar_to_utf8(wchar_t *w)

non static functions should have a ff_ prefix (or av if they are
public but that isnt)

also i dont really know windows & decklink stuff, so iam not the
ideal one to review ...

[...]



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to