Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-09-06 Thread Dale Curtis
Were there any more comments on this patch? Thanks! - dale On Mon, Aug 19, 2024 at 12:19 PM Dale Curtis wrote: > On Sat, Aug 17, 2024 at 12:25 PM James Almer wrote: > >> On 8/17/2024 3:04 PM, Michael Niedermayer wrote: >> > >> > >> 20978/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_f

Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-19 Thread Dale Curtis
On Sat, Aug 17, 2024 at 12:25 PM James Almer wrote: > On 8/17/2024 3:04 PM, Michael Niedermayer wrote: > > > > > 20978/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5746381832847360 > sent privately > Thanks for the sample Michael. I've confirmed it does not reproduce with my cha

Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-17 Thread James Almer
On 8/17/2024 3:04 PM, Michael Niedermayer wrote: On Wed, Aug 14, 2024 at 04:32:36PM -0700, Dale Curtis wrote: MAX_MBPAIR_SIZE was added in 23f5cff92cdcfa55a735c458fcb5f95c0e0f3b1f to prevent CABAC/CAVLC overread issues. It adds 256kb of padding to RBSP allocations. AFAICT it seems unnecessary wi

Re: [FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-17 Thread Michael Niedermayer
On Wed, Aug 14, 2024 at 04:32:36PM -0700, Dale Curtis wrote: > MAX_MBPAIR_SIZE was added in 23f5cff92cdcfa55a735c458fcb5f95c0e0f3b1f > to prevent CABAC/CAVLC overread issues. It adds 256kb of padding to > RBSP allocations. AFAICT it seems unnecessary with the checked > bitstream reader. Dropping th

[FFmpeg-devel] [PATCH] [h264] Use small padding with the checked bitstream reader.

2024-08-14 Thread Dale Curtis
MAX_MBPAIR_SIZE was added in 23f5cff92cdcfa55a735c458fcb5f95c0e0f3b1f to prevent CABAC/CAVLC overread issues. It adds 256kb of padding to RBSP allocations. AFAICT it seems unnecessary with the checked bitstream reader. Dropping this padding is a substantial memory improvement for constrained device