ff_vf_lensfun;
+extern const AVFilter ff_vf_libdewobble;
extern const AVFilter ff_vf_libvmaf;
extern const AVFilter ff_vf_limiter;
extern const AVFilter ff_vf_loop;
diff --git a/libavfilter/vf_libdewobble.c b/libavfilter/vf_libdewobble.c
new file mode 100644
index 00..45d17dd745
--- /dev
VFilter ff_vf_lenscorrection;
extern const AVFilter ff_vf_lensfun;
+extern const AVFilter ff_vf_libdewobble;
extern const AVFilter ff_vf_libvmaf;
extern const AVFilter ff_vf_limiter;
extern const AVFilter ff_vf_loop;
diff --git a/libavfilter/vf_libdewobble.c b/libavfilter/vf_libdewobble.c
new
On Tue, Aug 24, 2021 at 11:42 PM Mapul Bhola
wrote:
> I agree with Mahol here. It's good to make sure all the code in FFmpeg meets
> a certain quality.
> I thought there were OpenCV filters in ffmpeg already?
I'm more than happy to address any issues of code quality in this
filter to go into F
On Tue, Aug 24, 2021 at 3:09 AM Paul B Mahol wrote:
> library is named dewobble, thus filter should be libdewobble.
Lynne suggested "libdewobble_opencl". I can rename it to "libdewobble"
if you prefer, but will everyone be happy with that?
Perhaps it will be easier if you explain the convention
rom within FFmpeg.
Signed-off-by: Daniel Playfair Cal
---
Changelog v2:
- style improvements
- rename from "dewobble_opencl" to "libdewobble_opencl"
I'm still confused as to why this filter should be prefixed with lib but
not others that wrap external libraries like lensf
s until they do what you suggest.
> function arguments do not go on one line each
This one in particular is not clear to me. If not on one line each,
then where? They are not currently all on separate lines, but putting
them all on one line would result in some unreasonably long lines.
On Sun
On Sun, Aug 15, 2021 at 6:18 PM Paul B Mahol wrote:
> Non native filters can not be named like this.
OK, how would you suggest to name it - just "dewobble"?
My thinking was that since the user must ensure that the input/output
is OpenCL hardware frames (e.g. using hwupload/hwmap), the "_opencl"
rom within FFmpeg.
Signed-off-by: Daniel Playfair Cal
---
Changelog|1 +
LICENSE.md |2 +-
configure|4 +
doc/filters.texi | 149
libavfilter/Makefile |1 +
libavfilter/al
lat.
On Sun, Apr 11, 2021 at 6:23 PM Paul B Mahol wrote:
>
> Ok, dfov for width != height in (d)fisheye have been fixed.
>
> Dunno what to do with rest of patches.
>
> The aspect ratio one breaks handling in case input is in equirectangular
> format.
>
> On Sun, Apr 11
utput. If my image is not a
real equidistant fisheye projection, or if my FoV measurements are
wrong, then the chessboard won't have the right shape in the output.
This is not the problem I am trying to solve here.
On Sun, Apr 11, 2021 at 9:37 AM Paul B Mahol wrote:
>
>
>
> On Mon, Mar
B Mahol wrote:
>
>
> On Tue, Mar 23, 2021 at 5:00 AM Daniel Playfair Cal <
> daniel.playfair@gmail.com> wrote:
>
>> What exactly is your definition of fisheye?
>>
>
> Take look at source code. I do not see how your definition matches one in
> sour
areas
are marked as invisible? That causes your example filtergraph to work as
before.
On Tue, Mar 23, 2021 at 3:46 AM Paul B Mahol wrote:
>
>
> On Mon, Mar 22, 2021 at 1:35 PM Daniel Playfair Cal <
> daniel.playfair@gmail.com> wrote:
>
>> > I disagree, if I use 180 hf
tire input from a fisheye image.
On Mon, Mar 22, 2021 at 5:59 PM Paul B Mahol wrote:
>
>
> On Mon, Mar 22, 2021 at 5:09 AM Daniel Playfair Cal <
> daniel.playfair@gmail.com> wrote:
>
>> I've tried that filtergraph and a few other similar ones and I'm not sure
e two x or two y coordinates of the
>> outermost points above/below or left/right of the center, in the
>> flat/rectilinear projection.
>>
>> Signed-off-by: Daniel Playfair Cal
>> ---
>> libavfilter/vf_v360.c | 19 +--
>> 1 file change
instead each single one.
>
> On Fri, Mar 19, 2021 at 1:08 PM Daniel Playfair Cal <
> daniel.playfair@gmail.com> wrote:
>
>> This changes the iflat_range and flat_range values for the fisheye
>> projection so that they indicate the maximum angle between an observed
&
This resulted in the default aspect ratio being doubled relative to most
input formats like flat/rectilinear. After this patch the default aspect
ratio is the same as a rectilinear input.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 4 ++--
1 file changed, 2 insertions(+), 2
Previously the visibility test referred to a circle in the input. This
changes it so that it refers accurately to the entire area in the input.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_v360.c
.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c
index 68bb2f7b0f..3158451963 100644
--- a/libavfilter/vf_v360.c
+++ b/libavfilter/vf_v360.c
This was previously incorrect, so that passing only id_fov or d_fov
resulted in incorrect transformation.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c
index
This changes the iflat_range and flat_range values for the fisheye
projection so that they indicate the maximum angle between an observed
point and the center (direction the camera is facing). This matches the
meaning of those variables in the flat projection.
Signed-off-by: Daniel Playfair Cal
This changes the iflat_range and flat_range values for the fisheye
projection so that they indicate the maximum angle between an observed
point and the center (direction the camera is facing). This matches the
meaning of those variables in the flat projection.
Signed-off-by: Daniel Playfair Cal
Previously the visibility test referred to a circle in the input. This
changes it so that it refers accurately to the entire area in the input.
Signed-off-by: Daniel Playfair Cal
---
This version avoids using double literals
libavfilter/vf_v360.c | 2 +-
1 file changed, 1 insertion(+), 1
This was previously incorrect, so that passing only id_fov or d_fov
resulted in incorrect transformation.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c
index
This was previously incorrect, so that passing only id_fov or d_fov
resulted in incorrect transformation.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c
index
This changes the iflat_range and flat_range values for the fisheye
projection so that they indicate the maximum angle between an observed
point and the center (direction the camera is facing). This matches the
meaning of those variables in the flat projection.
Signed-off-by: Daniel Playfair Cal
This resulted in the default aspect ratio being doubled relative to most
input formats like flat/rectilinear. After this patch the default aspect
ratio is the same as a rectilinear input.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 4 ++--
1 file changed, 2 insertions(+), 2
Previously the visibility test referred to a circle in the input. This
changes it so that it refers accurately to the entire area in the input.
Signed-off-by: Daniel Playfair Cal
---
libavfilter/vf_v360.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_v360.c
This matches the inclusion of the other hwcontext_.h headers.
The skipping of the header depending on build flags is already present.
Signed-off-by: Daniel Playfair Cal:
---
libavutil/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavutil/Makefile b/libavutil/Makefile
index
Ah cool, thanks!
On Fri., 29 Mar. 2019, 10:06 am Paul B Mahol, wrote:
> On 3/28/19, Daniel Playfair Cal wrote:
> > Hi,
> >
> > Is anyone able to take a look at this?
> >
> > I'd appreciate it. It's my first time posting a patch to ffmpeg (or any
>
Hi,
Is anyone able to take a look at this?
I'd appreciate it. It's my first time posting a patch to ffmpeg (or any
mailing list) so please let me know if I've done anything wrong :)
Daniel
On Mon, Mar 25, 2019 at 1:07 PM wrote:
> From: Daniel Playfair Cal
>
> The
From: Daniel Playfair Cal
The lensfun filter wraps the lensfun library which performs
transformations on videos to correct for lens distortion. Often this
results in areas in the input being mapped to areas that fall outside
the boundaries of the output. The library has a parameter called scale
31 matches
Mail list logo
