[FFmpeg-devel] [PATCH v4] libpostproc: deprecate the AMD 3DNow! define

2025-04-15 Thread Sean McGovern
It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. --- doc/APIchanges | 3 +++ libpostproc/postprocess.h | 2 ++ libpostproc/version.h | 2 +- libpostproc/version_major.h | 2 ++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/

[FFmpeg-devel] [PATCH v3] libpostproc: deprecate the AMD 3DNow! define

2025-04-14 Thread Sean McGovern
It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. --- libpostproc/postprocess.h | 2 ++ libpostproc/version_major.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h index 5decb7e8a9..e210e93b11 100644 --- a/libpostpr

Re: [FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow! define

2025-04-13 Thread Sean McGovern
Hi, On Fri, Apr 11, 2025, 09:52 Sean McGovern wrote: > It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. > --- > libpostproc/postprocess.h | 2 ++ > libpostproc/version.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/libpos

[FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow! define

2025-04-11 Thread Sean McGovern
It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. --- libpostproc/postprocess.h | 2 ++ libpostproc/version.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h index 5decb7e8a9..7010c2b51b 100644 --- a/libpostproc/p

Re: [FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

2025-04-11 Thread Sean McGovern
On Fri, Apr 11, 2025 at 9:17 AM Andreas Rheinhardt wrote: > > Sean McGovern: > > It was removed / left unreferenced some time ago. > > --- > > libpostproc/postprocess.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libpostproc/postproce

[FFmpeg-devel] [PATCH] libpostproc: remove AMD 3DNow! define

2025-04-11 Thread Sean McGovern
It was removed / left unreferenced some time ago. --- libpostproc/postprocess.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h index 5decb7e8a9..cc48c552cc 100644 --- a/libpostproc/postprocess.h +++ b/libpostproc/postprocess.h @@ -87,7 +87,

Re: [FFmpeg-devel] [PATCH] libpostproc: remove big-endian AltiVec acceleration

2025-04-10 Thread Sean McGovern
Hi Andreas, On Thu, Apr 10, 2025, 03:37 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Sean McGovern: > > Hi, > > > > On Wed, Apr 9, 2025 at 2:55 PM Michael Niedermayer > > wrote: > >> > >> Hi Sean > >> > &

Re: [FFmpeg-devel] [PATCH] libpostproc: remove big-endian AltiVec acceleration

2025-04-09 Thread Sean McGovern
Hi, On Wed, Apr 9, 2025 at 2:55 PM Michael Niedermayer wrote: > > Hi Sean > > On Sun, Apr 06, 2025 at 12:42:30PM -0400, Sean McGovern wrote: > > While POWER & PowerPC systems have technically > > supported little-endian from inception, > > it did no

Re: [FFmpeg-devel] [PATCH] libpostproc: remove big-endian AltiVec acceleration

2025-04-09 Thread Sean McGovern
On Sun, Apr 6, 2025, 12:42 Sean McGovern wrote: > While POWER & PowerPC systems have technically > supported little-endian from inception, > it did not come into proper usage until the > introducion of the POWER8 in 2013. > > The AltiVec acceleration present here has not &

[FFmpeg-devel] [PATCH] libpostproc: remove big-endian AltiVec acceleration

2025-04-06 Thread Sean McGovern
While POWER & PowerPC systems have technically supported little-endian from inception, it did not come into proper usage until the introducion of the POWER8 in 2013. The AltiVec acceleration present here has not had meaningful change since before then. refs: Trac/11120 --- libpostproc/postproces

Re: [FFmpeg-devel] [PATCH] tests: Fix enhanced-flv-hevc-hdr10 on big endian systems

2025-04-04 Thread Sean McGovern
gt; 2.46.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscrib

Re: [FFmpeg-devel] [PATCH] tests: Fix enhanced-flv-hevc-hdr10 on big endian systems

2025-03-29 Thread Sean McGovern
pace > and side data information. How to use sed together with stream_remux? > >> > >>> > >>> ___ > >>> ffmpeg-devel mailing list > >>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>

Re: [FFmpeg-devel] [PATCH 00/31] Major library soname bump

2025-03-26 Thread Sean McGovern
gt; ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > There wasn't a lot of mailing list noise around this patch set which kind of

Re: [FFmpeg-devel] [PATCH v2 1/6] tests: Add enhanced-flv-hevc-hdr10 for demux and mux HDR color info

2025-03-19 Thread Sean McGovern
de 100644 tests/ref/fate/enhanced-flv-hevc-hdr10 Sorry for not addressing this earlier -- this fails on big-endian PowerPC (both 32- and 64-bit). Please have a look at FATE. The test should probably explicitly request that the sample is little-endian. Thanks, Sean McGovern __

Re: [FFmpeg-devel] hevc: disable Unknown profile warning for small build

2025-03-11 Thread Sean McGovern
devel-requ...@ffmpeg.org with subject "unsubscribe". > I'm not doubting your assertion that it is "annoying", but really this could be a bit more descriptive. -- Sean McGovern > ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH FFmpeg 1/15] libavutil: add detectionbbox util functions

2025-03-08 Thread Sean McGovern
label to assign (will be copied internally) > + * @param index The index at which to store the label and probability > + * @param probability The confidence score/probability for this label > + * @return 0 on success > + */ > +int av_detection_bbox_set_content(AVDetectionBBox *bbox,

[FFmpeg-devel] FATE vc1-* failures on PowerPC64 with GCC Address Sanitizer

2025-01-30 Thread Sean McGovern
sing the scalar version of the DSP code if it does not align? Comments/suggestions are appreciated, Sean McGovern [1] https://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/ppc/vc1dsp_altivec.c;h=bbadb2aaeef098449e48d8f6f47c2fc2d9809b8d;hb=HEAD#l252 [2] https://git.videolan.org/?p=ffmp

Re: [FFmpeg-devel] GSoC 2025

2025-01-30 Thread Sean McGovern
lso yes please -- I'm not particularly attached to GitLab specifically even though I have my own instance of it running locally. Any CI/CD tool would be better than this. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-22 Thread Sean McGovern
Hi, On Thu, Jan 16, 2025 at 8:17 PM Michael Niedermayer wrote: > > Hi > > On Thu, Jan 16, 2025 at 04:57:13PM -0500, Sean McGovern wrote: > > On Thu, Jan 16, 2025 at 4:30 PM Sean McGovern wrote: > > > > > > This was disabled in da60b99a8857d5ca236f32c1799a066e

Re: [FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-16 Thread Sean McGovern
On Thu, Jan 16, 2025 at 4:30 PM Sean McGovern wrote: > > This was disabled in da60b99a8857d5ca236f32c1799a066e0135a866 and then > accidentally re-enabled in 172b0e2e88832822632841e8e0d3794f974cbc93. > > The code in question was never properly adapted for litte-endian mode. Woops!

Re: [FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Sean McGovern
On Thu, Jan 16, 2025 at 4:04 PM Martin Storsjö wrote: > > On Thu, 16 Jan 2025, Sean McGovern wrote: > > >> This feels like less of an issue with strncmp, and more of an issue with > >> the spec for main() and argc/argv; how do you do to end up with a NULL > >>

[FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-16 Thread Sean McGovern
This was disabled in da60b99a8857d5ca236f32c1799a066e0135a866 and then accidentally re-enabled in 172b0e2e88832822632841e8e0d3794f974cbc93. The code in question was never properly adapted for litte-endian mode. refs: trac/10955 --- libavcodec/ppc/svq1enc_altivec.c | 8 1 file changed, 4

Re: [FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Sean McGovern
Hi Martin, On Thu, Jan 16, 2025 at 3:44 PM Martin Storsjö wrote: > > On Thu, 16 Jan 2025, Sean McGovern wrote: > > > The POSIX specification for strncmp()[1] leaves this behaviour as > > undefined if either pointer argument is NULL. > > > > Prevent a segmentati

[FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Sean McGovern
The POSIX specification for strncmp()[1] leaves this behaviour as undefined if either pointer argument is NULL. Prevent a segmentation fault by ensuring 'arg' is non-NULL. [1] https://pubs.opengroup.org/onlinepubs/9799919799/functions/strncmp.html --- tests/checkasm/checkasm.c | 2 +- 1 file cha

Re: [FFmpeg-devel] CC candidates

2024-12-13 Thread Sean McGovern
__ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > --

[FFmpeg-devel] [PATCH, v3] swscale/ppc: disable YUV2RGB AltiVec acceleration

2024-11-28 Thread Sean McGovern
The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform, in both little- and big-endian configurations with AltiVec enabled. Disable it for the time being. --- libswscale/ppc/yuv2rgb_altivec.c | 8 1 file changed, 8 insertions(+) diff --git a/libswscale/ppc/yuv2rgb_altivec.

Re: [FFmpeg-devel] [PATCH v2] swscale/ppc: disable YUV2RGB AltiVec acceleration

2024-11-25 Thread Sean McGovern
Hi Rémi, On Mon, Nov 25, 2024, 13:02 Rémi Denis-Courmont wrote: > Le sunnuntaina 24. marraskuuta 2024, 21.01.48 EET Sean McGovern a écrit : > > The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform, > > in both little- and big-endian configurations. >

[FFmpeg-devel] [PATCH v2] swscale/ppc: disable YUV2RGB AltiVec acceleration

2024-11-24 Thread Sean McGovern
The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform, in both little- and big-endian configurations. Disable it by default. Add '-DSWS_USE_ALTIVEC_YUV2RGB' to CPPFLAGS to re-enable it. --- v2: rebased over top of the recent swscale changes from Nik Haas --- libswscale/ppc/yuv2rgb

Re: [FFmpeg-devel] [PATCH] swscale/ppc: disable YUV2RGB AltiVec acceleration

2024-11-22 Thread Sean McGovern
Hi, On Tue, Nov 19, 2024, 00:06 Sean McGovern wrote: > The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform, > in both little- and big-endian configurations. > > Disable it by default. > Add '-DSWS_USE_ALTIVEC_YUV2RGB' to CPPFLAGS to re

[FFmpeg-devel] [PATCH] swscale/ppc: disable YUV2RGB AltiVec acceleration

2024-11-18 Thread Sean McGovern
The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform, in both little- and big-endian configurations. Disable it by default. Add '-DSWS_USE_ALTIVEC_YUV2RGB' to CPPFLAGS to re-enable it. --- libswscale/ppc/yuv2rgb_altivec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libsw

Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove AltiVec acceleration for YUV->RGB conversions

2024-11-18 Thread Sean McGovern
Hi Andreas, On Fri, Nov 15, 2024, 14:34 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Sean McGovern: > > Even on a reasonably modern POWER9 (ppc64le), it does not function > correctly. > > IMO the commit message should contain a bit more information about

Re: [FFmpeg-devel] [PATCH] swscale/ppc: remove AltiVec acceleration for YUV->RGB conversions

2024-11-18 Thread Sean McGovern
Hi Andrew, On Fri, Nov 15, 2024, 13:44 Andrew Randrianasulu wrote: > чт, 14 нояб. 2024 г., 23:38 Sean McGovern : > > > Even on a reasonably modern POWER9 (ppc64le), it does not function > > correctly. > > > > > I was under impression it was mostly developed and

[FFmpeg-devel] [PATCH] swscale/ppc: remove AltiVec acceleration for YUV->RGB conversions

2024-11-14 Thread Sean McGovern
Even on a reasonably modern POWER9 (ppc64le), it does not function correctly. --- libswscale/ppc/Makefile | 1 - libswscale/ppc/swscale_altivec.c | 25 - libswscale/ppc/swscale_vsx.c | 1 - libswscale/ppc/yuv2rgb_altivec.c | 866 --- libswscale/ppc/yuv

Re: [FFmpeg-devel] patchwork.ffmpeg.org is down

2024-11-13 Thread Sean McGovern
peg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > -- Sean McGovern > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

[FFmpeg-devel] [PATCH] libavutil/ppc: defines involving bit shifts should be unsigned

2024-11-01 Thread Sean McGovern
Otherwise, these can overflow at the boundaries of the integer type. --- libavutil/ppc/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c index 62d495ec1d..9f9c073434 100644 --- a/libavutil/ppc/cpu.c +++ b/libavutil/ppc/cpu.c @

Re: [FFmpeg-devel] [PATCH] libavutil/ppc: Include the hardware feature flags like the other archs

2024-11-01 Thread Sean McGovern
mething needs to be 'unsigned'. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-22 Thread Sean McGovern
Hi, On Sun, Oct 6, 2024, 15:48 Martin Storsjö wrote: > On Sat, 5 Oct 2024, Sean McGovern wrote: > > > Hi > > > > On Sat, Oct 5, 2024, 19:15 Lynne via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> > > wrote: > > > >> On 05/10/2024 20

Re: [FFmpeg-devel] [PATCH 3/3] fate/vcodec: add a test for v410 pixel format raw video

2024-10-17 Thread Sean McGovern
el > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". These tests now fail on ppc64, even with the recent addition of the missing reference files. Please have a look at this FATE instance: http://fate.ffmpeg.org/report.cgi?slot=p

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-15 Thread Sean McGovern
To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > We should strive to make it easy and desirable to merge filters in to FFmpeg proper. -- Sean McGovern > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

2024-10-07 Thread Sean McGovern
Hi, On Mon, Oct 7, 2024 at 8:22 PM Niklas Haas wrote: > > On Mon, 07 Oct 2024 16:53:41 -0400 Sean McGovern wrote: > > Hi, > > > > On Sun, Oct 6, 2024 at 6:31 PM Michael Niedermayer > > wrote: > > > > > > On Sat, Oct 05, 2024 at 09:24:00PM +02

Re: [FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

2024-10-07 Thread Sean McGovern
Hi, On Sun, Oct 6, 2024 at 6:31 PM Michael Niedermayer wrote: > > On Sat, Oct 05, 2024 at 09:24:00PM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > I want to move away from having random leaf processing functions mutate > > plane pointers, and while we're at it, we might as well make th

Re: [FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-05 Thread Sean McGovern
Hi On Sat, Oct 5, 2024, 19:15 Lynne via ffmpeg-devel wrote: > On 05/10/2024 20:58, Sean McGovern wrote: > > --- > > libavcodec/aacenc_pred.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/aacenc_pred.c b/l

[FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-05 Thread Sean McGovern
--- libavcodec/aacenc_pred.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index a486c44d42..a6dfaa25fb 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c @@ -153,9 +153,7 @@ void ff_aac_adjust_common

Re: [FFmpeg-devel] [PATCH] ppc: Recognize the PPC VSX and Power8 CPU flags

2024-09-28 Thread Sean McGovern
> > { AV_CPU_FLAG_MMI, "mmi" }, > > { AV_CPU_FLAG_MSA, "msa"}, > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel &

Re: [FFmpeg-devel] [PATCH 2/7] avformat/dvdvideodec: Implement seeking

2024-07-28 Thread Sean McGovern
gle number", >OFFSET(opt_angle), AV_OPT_TYPE_INT,{ .i64=1 }, 1, > 9, AV_OPT_FLAG_DECODING_PARAM }, > @@ -1718,11 +1788,12 @@ const FFInputFormat ff_dvdvideo_demuxer = { > .p.name = "dvdvideo",

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Sean McGovern
if (colorspace) { > CVBufferSetAttachment(pixbuf, kCVImageBufferCGColorSpaceKey, > > base-commit: 9fb8d13d56f20728141fd7070d8a325720727d57 > -- > 2.39.3 (Apple Git-146) > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg

[FFmpeg-devel] [PATCH] configure: remove TILE-Gx and TILE-Pro due to lack of compiler support

2024-07-15 Thread Sean McGovern
GCC removed support for them in versions >= 13.0, and there was never any acceleration or compat code generated for these targets. --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index f84fefeaab..6777fc038f 100755 --- a/configure +++ b/configure @@ -214

Re: [FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-12 Thread Sean McGovern
Hi, On Wed, Jul 3, 2024, 21:24 Sean McGovern wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index b28221f258..bbda7a02cb 100755 > --- a/configure > +++ b/configure > @@ -5493,7 +5493,

[FFmpeg-devel] [PATCHv4] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-09 Thread Sean McGovern
For even small values of 'asrc[x]', shifting them by 24 bits or more will cause arithmetic overflow and be caught by GCC's undefined behaviour sanitizer. Ensure the values do not overflow by up-casting the bracketed expressions involving 'asrc' to uint32_t. --- libswscale/yuv2rgb.c | 4 ++-- 1 fi

Re: [FFmpeg-devel] Reset password on Patchwork

2024-07-09 Thread Sean McGovern
Hi Andriy, Any luck with this? I'm still locked out. On Wed, Jun 12, 2024 at 6:59 PM Michael Niedermayer wrote: > > Hi > > adding Andriy to CC, to make sure its not missed > > On Tue, Jun 11, 2024 at 07:45:21PM -0400, Sean McGovern wrote: > > Hi, > > > >

[FFmpeg-devel] [PATCHv3] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-09 Thread Sean McGovern
For even small values of 'asrc', shifting them by 24 bits or more will cause arithmetic overflow and be caught by GCC's undefined behaviour sanitizer. Ensure the values do not overflow by up-casting the bracketed expressions involving 'asrc' to int32_t. --- libswscale/yuv2rgb.c | 4 ++-- 1 file c

[FFmpeg-devel] [PATCHv2] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-07 Thread Sean McGovern
--- libswscale/yuv2rgb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 977eb3a7dd..ac0b811f61 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -100,9 +100,9 @@ const int *sws_getCoefficients(int colorspace)

[FFmpeg-devel] [PATCH] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-07 Thread Sean McGovern
@@ +/* + * Copyright (c) 2024 Sean McGovern + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-07 Thread Sean McGovern
Hi, On Sat, Jul 6, 2024, 16:18 Rémi Denis-Courmont wrote: > Le lauantaina 6. heinäkuuta 2024, 23.00.47 EEST Sean McGovern a écrit : > > Does wasted32 (and I guess wasted33 by proxy) not have to worry about > loops > > tails? I noticed the other vectorized versions don't d

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-06 Thread Sean McGovern
Hi, On Thu, Jul 4, 2024, 13:54 Rémi Denis-Courmont wrote: > Le torstaina 4. heinäkuuta 2024, 19.26.19 EEST Sean McGovern a écrit : > > Is that correlated with the comment above re: len? Or is it more general > > that I should unroll until I've exhausted the available vecto

Re: [FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-06 Thread Sean McGovern
Hi, On Wed, Jul 3, 2024, 21:24 Sean McGovern wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index b28221f258..bbda7a02cb 100755 > --- a/configure > +++ b/configure > @@ -5493,7 +5493,

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-04 Thread Sean McGovern
Hi Rémi, First of all, thanks for the review. On Thu, Jul 4, 2024, 07:15 Rémi Denis-Courmont wrote: > > > Le 4 juillet 2024 04:23:30 GMT+03:00, Sean McGovern > a écrit : > >RaptorCS POWER9 (8c4t) @ 2.2GHz: > >flac_wasted_32_c: 50.1 > >flac_wasted_32_vsx: 17.3 &

[FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-03 Thread Sean McGovern
@@ +/* + * Copyright (c) 2024 Sean McGovern + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the

[FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-03 Thread Sean McGovern
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b28221f258..bbda7a02cb 100755 --- a/configure +++ b/configure @@ -5493,7 +5493,7 @@ elif enabled ppc; then cpuflags="-mcpu=$cpu" disable vsx ;; -

Re: [FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Sean McGovern
Hi Rémi, On Wed, Jul 3, 2024 at 4:34 PM Rémi Denis-Courmont wrote: > > Le keskiviikkona 3. heinäkuuta 2024, 22.07.42 EEST Sean McGovern a écrit : > > Hi, > > > > Attached is an RFC patch to address the undefined behaviour from the > > new `fate-checkasm-sw_yuv2rgb`

[FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Sean McGovern
Hi, Attached is an RFC patch to address the undefined behaviour from the new `fate-checkasm-sw_yuv2rgb` test seen on both the x86 and ppc UBSan FATE nodes. -- Sean McGovern From 7b7c5fe69443085250ce8fc35110cfa2d756 Mon Sep 17 00:00:00 2001 From: Sean McGovern Date: Tue, 2 Jul 2024 23:07:54

Re: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: Add missing include

2024-07-02 Thread Sean McGovern
> > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > I did not test but visually this looks OK. As an aside, I wonder if the check headers config should be one of the runs on Patchwork. -- Sean McGovern > ___

Re: [FFmpeg-devel] [PATCH v12 15/15] avcodec/hw_base_encode: add avctx pointer for FFHWBaseEncodeContext

2024-07-02 Thread Sean McGovern
int > >>> vaapi_encode_create_recon_frames(AVCodecContext *avctx) > >>>>} > >>>>hwconfig->config_id = ctx->va_config; > >>>> > >>>> -err = ff_hw_base_get_recon_format(avctx, (const void*)hwconfig

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix mDCv typo

2024-07-02 Thread Sean McGovern
Hi Andreas, On Tue, Jul 2, 2024, 11:48 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Sean McGovern: > > Hi Leo, > > > > > > On Tue, Jul 2, 2024, 09:44 Leo Izen wrote: > > > >> When mDCv support was added, there was a typo in bo

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix mDCv typo

2024-07-02 Thread Sean McGovern
x27;, 'C', 'v'), > s->buf, 24); > } > } > > -- > 2.45.2 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubs

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-29 Thread Sean McGovern
gt; > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > It looks like this exposed an issue in the AltiVec acceleration in libswscale. libswscale/ppc/yuv2rgb.c looks a bit too complex for

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-26 Thread Sean McGovern
Hi, On Thu, Jun 6, 2024, 12:51 Sean McGovern wrote: > > > On Thu, Jun 6, 2024, 05:53 Rémi Denis-Courmont wrote: > >> >> >> Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a >> écrit : >> >Hi, >> > >> >Attached inline is a _non

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/j2kenc: Merge dwt_norm into lambda

2024-06-23 Thread Sean McGovern
cblk->layers[0].cum_passes = cblk->ninclpasses; > > cblk->layers[0].npasses = cblk->ninclpasses; > > Does this also fix the UB in the vsynth*-jpeg2000-yuva444p16 tests? > > - Andreas > >

Re: [FFmpeg-devel] [PATCH 2/2] sh4: remove architecture

2024-06-13 Thread Sean McGovern
On Fri, Jun 7, 2024, 17:18 Sean McGovern wrote: > On Fri, Jun 7, 2024 at 2:20 PM Rémi Denis-Courmont > wrote: > > > > Support for SuperH was dropped over a decade ago. There no longer is any > > architecture-specific code to be found, so just remove the corresponding >

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-13 Thread Sean McGovern
1 juin 2024 12:59:23 GMT+03:00, Michael Niedermayer < > > mich...@niedermayer.cc> a écrit : > > > >On Mon, Jun 10, 2024 at 08:52:08PM -0400, Sean McGovern wrote: > > > >[...] > > > >> Are there any real concerns about the Alpha removal itself? > &g

[FFmpeg-devel] Reset password on Patchwork

2024-06-11 Thread Sean McGovern
Hi, Can someone help me reset my password on Patchwork? I've used the 'Forgot password ' link several times and never received an email. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH] configure: detect 64-bit generic platforms

2024-06-11 Thread Sean McGovern
___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > +1 for this. L

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Sean McGovern
Hi, On Mon, Jun 10, 2024 at 8:17 PM Michael Niedermayer wrote: > > On Mon, Jun 10, 2024 at 02:42:16PM +0200, Vittorio Giovara wrote: > > On Mon, Jun 10, 2024 at 2:29 PM Michael Niedermayer > > wrote: > > > > > On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGov

[FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-09 Thread Sean McGovern
Hi, Attached is a patch to do proper removal of support for the DEC Alpha. I hope it is not mangled. Side note: it seems GMail now prevents sending patches directly with git send-email -- I really wish we could move to a CI platform like GitLab or Gitea. -- Sean McGovern From

Re: [FFmpeg-devel] [PATCH 2/2] sh4: remove architecture

2024-06-07 Thread Sean McGovern
On Fri, Jun 7, 2024 at 2:20 PM Rémi Denis-Courmont wrote: > > Support for SuperH was dropped over a decade ago. There no longer is any > architecture-specific code to be found, so just remove the corresponding > test. Technically it is still possible to compile FFmpeg as the > "generic" (pure C) a

Re: [FFmpeg-devel] [PATCH 1/2] lavu/bswap: remove some inline assembler

2024-06-07 Thread Sean McGovern
On Fri, Jun 7, 2024 at 2:20 PM Rémi Denis-Courmont wrote: > > C code or compiler built-ins are preferable over inline assembler for > byte-swaps as it allows for better optimisations (e.g. instruction > scheduling) which would otherwise be impossible. > > As with f64c2e710fa1a7b59753224e717f57c484

Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff

2024-06-07 Thread Sean McGovern
On Fri, Jun 7, 2024 at 12:49 PM Rémi Denis-Courmont wrote: > > Since the C11 support is required, those GCC versions can no longer be > supported anyhow. > --- > libavutil/arm/bswap.h| 20 > libavutil/arm/intreadwrite.h | 91 > libavutil/intre

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Sean McGovern
On Thu, Jun 6, 2024, 05:53 Rémi Denis-Courmont wrote: > > > Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a > écrit : > >Hi, > > > >Attached inline is a _non-working_ implementation of flac_wasted32 for > >VSX developed on a POWER9 in little-endian mo

[FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Sean McGovern
egister vec_s32 shifted; for (int i = 0; i < len; i += VSX_STRIDE) { vec1 = vec_vsx_ld(i, decoded); shifted = vec_sl(vec1, vec2); vec_vsx_st(shifted, i, decoded); } } Anyone with experience with AltiVec or VSX see something obvious I am missing? -- Sean M

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread Sean McGovern
On Mon, Jun 3, 2024, 17:32 Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > > On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > > > On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > > > > On Sat, Mar 2, 2

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: various: remove empty directories originally for legacy DSP code

2024-06-01 Thread Sean McGovern
On Thu, May 30, 2024 at 5:21 PM Sean McGovern wrote: > > --- > libavcodec/bfin/README | 6 -- > libavcodec/sh4/README | 6 -- > libavcodec/sparc/README | 6 -- > 3 files changed, 18 deletions(-) > delete mode 100644 libavcodec/bfin/README > delete mo

[FFmpeg-devel] [PATCH] [RFC] libavutil: remove AVR32 assembly

2024-05-30 Thread Sean McGovern
--- libavutil/avr32/bswap.h| 44 libavutil/avr32/intreadwrite.h | 182 - 2 files changed, 226 deletions(-) delete mode 100644 libavutil/avr32/bswap.h delete mode 100644 libavutil/avr32/intreadwrite.h diff --git a/libavutil/avr32/bswap.h b/libavu

Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)

2024-05-30 Thread Sean McGovern
On Thu, May 30, 2024 at 5:20 PM Ramiro Polla wrote: > > --- > libavcodec/libxvid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c > index b9ac39429d..a490f16b3f 100644 > --- a/libavcodec/libxvid.c > +++ b/libavcodec/libxvid

[FFmpeg-devel] [PATCH 2/2] [RFC] libavcodec: remove DSP acceleration code for DEC Alpha

2024-05-30 Thread Sean McGovern
--- Changelog| 1 + libavcodec/alpha/Makefile| 10 - libavcodec/alpha/asm.h | 153 -- libavcodec/alpha/blockdsp_alpha.c| 49 - libavcodec/alpha/hpeldsp_alpha.c | 213 --- libavcodec/alpha/hpeldsp_alph

[FFmpeg-devel] [PATCH 1/2] libavcodec: various: remove empty directories originally for legacy DSP code

2024-05-30 Thread Sean McGovern
--- libavcodec/bfin/README | 6 -- libavcodec/sh4/README | 6 -- libavcodec/sparc/README | 6 -- 3 files changed, 18 deletions(-) delete mode 100644 libavcodec/bfin/README delete mode 100644 libavcodec/sh4/README delete mode 100644 libavcodec/sparc/README diff --git a/libavcodec

[FFmpeg-devel] Empty arch/ directories

2024-05-29 Thread Sean McGovern
Hi, It is not likely we will get anyone to step up to do DSP work for arguably dead architectures like SPARC, Blackfin, etc. Maybe is it time to remove those directories that just contain a README now? Sean McGovern ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract the init and close function to base layer

2024-05-25 Thread Sean McGovern
kes FFHWBaseEncodeContext as an > argument, rather than AVCodecContext (apart from where the function > absolutely must read some data from it)? > Might this suggestion involve having to do some ugly down-casting? -- Sean McGovern > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

2024-05-06 Thread Sean McGovern
= {CTL_MACHDEP, CPU_ALTIVEC}; > #else > int sels[2] = {CTL_HW, HW_VECTORUNIT}; > -- > 2.44.0 > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe,

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

2024-04-29 Thread Sean McGovern
them. > > > > 95 GBP: Eurostar to Bruxelle-Midi > > 95 GBP: Eurostar from Bruxelle-Midi > > Total: 190 GBP > > LGTM > > PS: maybe we should make a page on trac that links to all talks from all > FFmpeg developers > Is there video/audio from this talk? I

Re: [FFmpeg-devel] [PATCH v2] configure: support msvc build inside WSL

2024-04-27 Thread Sean McGovern
> (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > +fi > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs' > _cflags_speed="-O2" > _cflags_size="-O1" > -- > 2.43.2 >

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-11 Thread Sean McGovern
exhausted all other alternatives. > -- Abba Eban > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmp

Re: [FFmpeg-devel] [PATCH] avcodec/libsvt1: check return value of sned/receive functions

2024-04-09 Thread Sean McGovern
.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe&qu

Re: [FFmpeg-devel] 7.0 Name

2024-04-01 Thread Sean McGovern
gt; ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Not sure if I am allowed to pick, my choice is D

Re: [FFmpeg-devel] [PATCH 6/6] fate/image: Fix EXR tests on big endian

2024-03-30 Thread Sean McGovern
-large: CMD = framecrc -i > $(TARGET_SAMPLES)/exr/rgb_tile_half_piz_dw_large.exr -vf scale -pix_fmt > gbrpf32le > > FATE_EXR += fate-exr-rgb-tile-uint32-piz-dw-large > -fate-exr-rgb-tile-uint32-piz-dw-large: CMD = framecrc -i > $(TARGET_SAMPLES)/exr/rgb_tile_uint32_piz_dw_large.

Re: [FFmpeg-devel] [PATCH 07/18] swscale/swscale_internal: Only include altivec header iff HAVE_ALTIVEC

2024-03-29 Thread Sean McGovern
t > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". This also looks good to me. -- Sean McGovern

Re: [FFmpeg-devel] [PATCH 06/18] postproc/postprocess: Don't generally include arch-specific headers

2024-03-29 Thread Sean McGovern
uint8_t src[], int stride, PPContext *c) > { > -#if HAVE_7REGS && TEMPLATE_PP_MMXEXT > +#if TEMPLATE_PP_MMXEXT && HAVE_7REGS > DECLARE_ALIGNED(8, uint64_t, tmp)[3]; > __asm__ volatile( > "pxor %%mm6, %%mm6 \n\t" > -- &g

Re: [FFmpeg-devel] [PATCH 2/5] fate/ffmpeg: Explicitly set pix fmt for sub2video tests

2024-03-29 Thread Sean McGovern
__ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > I already submitted this change a f

Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets

2024-03-25 Thread Sean McGovern
Hi, On Fri, Mar 8, 2024, 10:11 Sean McGovern wrote: > On Wed, Mar 6, 2024, 18:48 Sean McGovern wrote: > >> The reference file uses BGRA pixel format, so request it here. >> --- >> tests/fate/ffmpeg.mak | 2 ++ >> 1 file changed, 2 insertions(+) >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/tests/snowenc: Fix mixed declaration and code

2024-03-15 Thread Sean McGovern
> ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > OK, looks good to me. Thanks, Sean

Re: [FFmpeg-devel] [PATCH] avcodec/ppc/vp8dsp_altivec: Fix out-of-bounds access

2024-03-14 Thread Sean McGovern
__ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Confirming this patch fixes

  1   2   >