[FFmpeg-devel] [PATCH] avcodec/pngenc: include EXIF buffer in max_packet_size (PR #20539)

2025-09-17 Thread Leo Izen via ffmpeg-devel
PR #20539 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20539 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20539.patch When calculating the max size of an output PNG packet, we should include the size of a possible eXIf chunk that we may write. Signed

[FFmpeg-devel] [PATCH] avcodec/decode: treat orientation 1 as valid displaymatrix (PR #20447)

2025-09-05 Thread Leo Izen via ffmpeg-devel
PR #20447 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20447 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20447.patch Since 9dc79241d9680fc050376bb0cc37875a41d00cc9 we now always pop the orientation off of the IFD and use a display matrix instead

[FFmpeg-devel] [PATCH] .forge/CODEOWNERS: add myself to EXIF code (PR #20369)

2025-08-29 Thread Leo Izen via ffmpeg-devel
PR #20369 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20369 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20369.patch Now that the major EXIF overhaul has been merged, I should be suggested to review patches that modify it. Signed-off-by: Leo Izen

[FFmpeg-devel] [PATCH] avcodec/libjxldec: consume input on error (PR #20355)

2025-08-27 Thread Leo Izen via ffmpeg-devel
PR #20355 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20355 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20355.patch libjxl consumes no input if it returns an error, so this loops over and over while it spits out the same error many times. If we got

[FFmpeg-devel] [PATCH] libjxldec/libjxlenc: fix leaks (PR #20352)

2025-08-27 Thread Leo Izen via ffmpeg-devel
PR #20352 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20352 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20352.patch Fix leaks. We forgot to free these. >From a8d6b87a4442c690587db6f44cc7ed72a2de81fc Mon Sep 17 00:00:00 2001 From: Leo Izen D

[FFmpeg-devel] [PATCH] avcodec/libjxldec: submit frame after file is complete (PR #20337)

2025-08-25 Thread Leo Izen via ffmpeg-devel
PR #20337 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20337 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20337.patch This commit causes the libjxl decoder wrapper to hold onto the decoded frame until the trailing metadata after the frame is possibly

[FFmpeg-devel] [PATCH] Two exif Fixes (PR #20326)

2025-08-24 Thread Leo Izen via ffmpeg-devel
PR #20326 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20326 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20326.patch Fixes for two EXIF bugs, notably #20305 and #20291. >From c9e86ffd2ae9b3f296b761f3d7c2f10d69a46840 Mon Sep 17 00:00:00 2001 F

[FFmpeg-devel] [PATCH] avcodec/exif: fix some coverity errors (PR #20296)

2025-08-20 Thread Leo Izen via ffmpeg-devel
PR #20296 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20296 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20296.patch This commit fixes some memory and security issues due to improper sanitizing and checks. Fixes: - CID 1665100..1665107 Signed-off

[FFmpeg-devel] [PATCH] .forgejo/CODEOWNERS: add myself to JPEG XL and PNG (PR #20238)

2025-08-13 Thread Leo Izen
PR #20238 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20238 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20238.patch Add myself to JPEG XL and PNG decoders/encoders/parsers/etc. as a suggested reviewer. I'm the maintainer of the JXL files and I

[FFmpeg-devel] [PATCH] RELEASE: update to 8.0 (PR #20228)

2025-08-12 Thread Leo Izen
PR #20228 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20228 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20228.patch >From 53dd4c0e7be5e710b73042e5c1d8f52688f5f76d Mon Sep 17 00:00:00 2001 From: Leo Izen Date: Tue, 12 Aug 2025 18:17:36 -0

[FFmpeg-devel] [PATCH] avcodec/vp9: fix leaked cbs fragment AVBufferRef (PR #20205)

2025-08-09 Thread Leo Izen
PR #20205 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20205 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20205.patch When this function returns, the fragment is never reset, so current_frag->data_ref is never unref-ed, which ends up leaking it.

[FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: add include for boolean literals (PR #20155)

2025-08-07 Thread Leo Izen
PR #20155 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20155 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20155.patch One call of av_assert2(false && foo) is in this file, which causes it to fail to compile on certain platforms with --assert

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-22 Thread Leo Izen
file. May be wise to do that in a separate patch, don't know. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH] forgejo/workflows: add initial rudimentary CI

2025-07-21 Thread Leo Izen
On 7/21/25 12:37, Timo Rothenpieler wrote: It runs basic fate with no special dependencies enabled on x86_64 and aarch64. --- .forgejo/workflows/test.yml | 39 + .gitignore | 1 + 2 files changed, 40 insertions(+) create mode 100644 .for

[FFmpeg-devel] [PATCH v2] avcodec/jpegxl_parser: add sanity check for frame size

2025-07-21 Thread Leo Izen
If a frame size is absolutely massive, this can spin the parser as it attempts to decode a permuted TOC. We add a sanity check here for eight times the size of the image for an internal frame to prevent malicious bitstreams from slowing the parser down to a crawl. Signed-off-by: Leo Izen

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: add sanity check for frame size

2025-07-16 Thread Leo Izen
On 7/16/25 06:34, Kacper Michajlow wrote: On Tue, 15 Jul 2025 at 20:02, Leo Izen wrote: If a frame size is absolutely massive, this can spin the parser as it attempts to decode a permuted TOC. We add a sanity check here for eight times the size of the image for an internal frame to prevent

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: add sanity check for frame size

2025-07-15 Thread Leo Izen
If a frame size is absolutely massive, this can spin the parser as it attempts to decode a permuted TOC. We add a sanity check here for eight times the size of the image for an internal frame to prevent malicious bitstreams from slowing the parser down to a crawl. Signed-off-by: Leo Izen

Re: [FFmpeg-devel] [POLL] [VOTE] code.ffmpeg.org

2025-07-15 Thread Leo Izen
eolan, freedesktop) has been incredibly slow, and I have not had experiences like such with forgejo. - Leo Izen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [RFC] Introducing policies regarding "AI" contributions

2025-07-03 Thread Leo Izen
because of the legal implications of including LLM-generated code in our codebase. I am not a lawyer, so I cannot say for certain how the legality plays out, and it may be safer to just not permit it than try to hire a laywer to figure out how to permit it, if it's even possible. - Leo

[FFmpeg-devel] [PATCH] configure: rename POSIX ioctl check

2025-06-06 Thread Leo Izen
0. Since this is only used for avdevice/v4l2, we rename this to something else, namely ioctl_posix, simply to prevent the name conflict with the file /usr/include/libv4l2.h at least until they can upstream a fix on their end. Signed-off-by: Leo Izen --- configure | 4 ++-- libavdevice

Re: [FFmpeg-devel] The "bad" Patch

2025-05-31 Thread Leo Izen
e review or the discussion thereof, this is kind of email complaining about specific people is basically spam. If you have issues with specific members please report them to the CC. A callout post on the public mailing list is not doing anybody any favors, including for yourself. - Leo I

[FFmpeg-devel] Funding Proposals

2025-05-22 Thread Leo Izen
ocess, in a nutshell, along with reasonable numbers for requests? - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

Re: [FFmpeg-devel] [PATCH] avformat/apvdec: remove unused variable

2025-05-09 Thread Leo Izen
, good thing I checked the ML. LGTM, will apply. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.or

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-19 Thread Leo Izen
"=" 2,2 ]=] 2,2 �=� 2,2 y=y 2,2 *=* 2,2 5=5 2,2 ~=~ 2,2 �=� 2,2 �=� 2,2 �=� 2,2 �=� 2,2 )=) 2,2 �=� 2,2 e=e 2,2 �=� 2,2 A=A 2,2 B=B 2,2 �=� 2,2 �=� 2,2 �=� 2,2 J=J 2,2 �=� 2,2 �=� 2,2 �=� 2,2 �=� 2,2 �=� 2,2 �=� 2,2 �=� 2,2 �=� 2,2

Re: [FFmpeg-devel] [PATCH v3] libavutil: Add AVMap

2025-04-18 Thread Leo Izen
efore comparison rather than just pass the pointers as-is. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/libjxlenc: prevent color encoding from being set twice

2025-04-15 Thread Leo Izen
On 4/13/25 06:12, Leo Izen wrote: We currently populate the color encoding bundle and then check to see if there's an ICC profile to attach, and set the color encoding bundle in either case. The ICC profile overrides the color encoding bundle, so we should not calculate enum-based color enc

[FFmpeg-devel] [PATCH] avcodec/libjxlenc: prevent color encoding from being set twice

2025-04-13 Thread Leo Izen
esent. Fixes several unnecessary warnings from being emitted. Signed-off-by: Leo Izen --- libavcodec/libjxlenc.c | 115 + 1 file changed, 59 insertions(+), 56 deletions(-) diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c index 81d466e6cc..54ba7

Re: [FFmpeg-devel] [RFC] AVDictionary2

2025-04-08 Thread Leo Izen
ue to support. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 0/4] avformat/hls: Some extension fixes that need testing

2025-04-06 Thread Leo Izen
nsion we didn't think about" patch over and over again when we could have just solved the original problem. This feels like an XY problem, we really want to accomplish X but we're solving Y because we believe it will fix X. Rather than just fixi

Re: [FFmpeg-devel] [RFC] FFV1 float support

2025-03-06 Thread Leo Izen
more popular May also be worth considering the JPEG XL way, where each entropy-coded symbol is a "hybrid integer" of a token read from the entropy stream (ANS) followed by zero or more "raw bits" that are spliced in. - Leo Izen (Traneptora) __

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Leo Izen
On 2/13/25 4:27 AM, Tanay Manerikar wrote: On Thu, Feb 13, 2025 at 2:20 PM Leo Izen wrote: On 2/12/25 5:05 PM, Timo Rothenpieler wrote: My understanding as a Github and Gitlab user is the usual way to make a PR is to first fork the repository, then commit changes to a branch on your fork

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Leo Izen
option to send a PR. Under the hood this is just the process I described. Also I don't believe Forgejo has a web UI editor (and if it did I wouldn't want to send PRs with it, I'd rather use my own code editing workflow). - Leo I

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Leo Izen
sitory, I'm not sure how you would do a PR. It sounds like you're saying there's another way to do it, but I'm not familiar with it and I expect many other people are not either. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: avoid hard failure on illegal sBIT chunks

2025-02-08 Thread Leo Izen
On 2/3/25 10:22 PM, Leo Izen wrote: If a malformed chunk like sBIT appears but otherwise the stream is still parseable, we should print a warning and skip it rather than failing with an error. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 18 ++ 1 file changed, 10

Re: [FFmpeg-devel] [PATCH] avfilter/scale*: add option reset_sar

2025-02-07 Thread Leo Izen
c b/libavfilter/vf_scale_vulkan.c index 6f99769d81..1d6492e213 100644 --- a/libavfilter/vf_scale_vulkan.c +++ b/libavfilter/vf_scale_vulkan.c @@ -336,7 +336,7 @@ static int scale_vulkan_config_output(AVFilterLink *outlink) if (err < 0) return err; -ff_scale_adjust_dim

Re: [FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true

2025-02-05 Thread Leo Izen
nges on my end, preserving authorship before I do, if that is okay with you. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2025-02-05 Thread Leo Izen
foo.mkv exists without asking on stdin (as you'd expect it to not, cause it's reading from stdin) - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-05 Thread Leo Izen
decklink code in FFmpeg was authored last april (not counting minor one-line bugfixes and the like) and as far as I am aware nobody is currently working on that so you wouldn't be redoing someone else's work. - Leo Izen (Traneptora) ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-02-04 Thread Leo Izen
y don't we just separate this into two different demuxers/protocols? - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

[FFmpeg-devel] [PATCH] avcodec/pngdec: avoid hard failure on illegal sBIT chunks

2025-02-03 Thread Leo Izen
If a malformed chunk like sBIT appears but otherwise the stream is still parseable, we should print a warning and skip it rather than failing with an error. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-01 Thread Leo Izen
people who used to be active and then stopped and then started up again. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-29 Thread Leo Izen
in handing over reigns to anybody. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parse{, r}: fix integer overflow for some malformed files

2025-01-29 Thread Leo Izen
igned int. Several other members are also changed to int64_t to avoid this problem in other possible scenarios. Signed-off-by: Leo Izen Reported-by: Kacper Michajlow Fixes: clusterfuzz-testcase-minimized-fuzzer_loadfile-6085331937460224 --- libavcodec/jpegxl_parse.c | 5 +++-- libavc

Re: [FFmpeg-devel] [PATCH] avutil/frame: check return value for cropping offsets

2025-01-28 Thread Leo Izen
On 1/21/25 7:34 AM, Leo Izen wrote: This function can return AVERROR_BUG in theory if something went wrong, but so can the caller, so we should propagate that error message upward in that case. Signed-off-by: Leo Izen --- libavutil/frame.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[FFmpeg-devel] [PATCH] avutil/frame: check return value for cropping offsets

2025-01-21 Thread Leo Izen
This function can return AVERROR_BUG in theory if something went wrong, but so can the caller, so we should propagate that error message upward in that case. Signed-off-by: Leo Izen --- libavutil/frame.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavutil

Re: [FFmpeg-devel] Regarding Git Tooling

2025-01-20 Thread Leo Izen
rofit enterprise controversy that surrounded Gitea. I can't vouch for it (or against it, for that matter) but I can say that some prominent projects (e.g. Fedora) have chosen it. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/flvdec: implement support for parsing ModEx data

2025-01-16 Thread Leo Izen
On 1/16/25 6:32 PM, Timo Rothenpieler wrote: On 17.01.2025 00:16, Leo Izen wrote: On 1/15/25 5:41 PM, Timo Rothenpieler wrote: ---   libavformat/flv.h    |  5   libavformat/flvdec.c | 68   2 files changed, 73 insertions(+) diff --git a

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/flvdec: implement support for parsing ModEx data

2025-01-16 Thread Leo Izen
On 1/15/25 5:41 PM, Timo Rothenpieler wrote: --- libavformat/flv.h| 5 libavformat/flvdec.c | 68 2 files changed, 73 insertions(+) diff --git a/libavformat/flv.h b/libavformat/flv.h index 74d3b8de8b..d8f7980f2e 100644 --- a/libavformat/

Re: [FFmpeg-devel] [PATCH] avcodec/leaddec: support format 0x1006

2025-01-14 Thread Leo Izen
On 1/15/25 2:10 AM, Peter Ross wrote: Fixes ticket #10658. --- libavcodec/leaddec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index 88387902ca..12e27061e9 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leadde

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvdec: implement support for parsing ModEx data

2025-01-14 Thread Leo Izen
On 1/14/25 7:36 PM, Timo Rothenpieler wrote: --- libavformat/flv.h| 5 libavformat/flvdec.c | 63 2 files changed, 68 insertions(+) diff --git a/libavformat/flv.h b/libavformat/flv.h index 74d3b8de8b..d8f7980f2e 100644 --- a/libavformat/

[FFmpeg-devel] [PATCH v2] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-10 Thread Leo Izen
It should be more clear what this flag is indicating with a more verbose comment documenting it. Signed-off-by: Leo Izen Reviewed-by: Marton Balint Reviewed-by: Alexander Strasser Reviewed-by: Marth64 --- libavutil/frame.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-07 Thread Leo Izen
It should be more clear what this flag is indicating with a more verbose comment documenting it. Signed-off-by: Leo Izen --- libavutil/frame.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 993fa6b65a..e3657f193f 100644

Re: [FFmpeg-devel] [PATCH] avformat/ipfsgateway: fix capitalizaton mistake

2025-01-07 Thread Leo Izen
On 1/7/25 4:54 PM, Alexander Strasser via ffmpeg-devel wrote: On 2025-01-07 14:18 -0500, Leo Izen wrote: Fix the incorrect capitalization of the project name in a comment. The project is named FFmpeg, not FFMpeg. Signed-off-by: Leo Izen Reported-by: NyanMaths --- libavformat/ipfsgateway.c

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2025-01-07 Thread Leo Izen
this second complaint made in a public environment? If not, carry on as before. If so, I don't see the complaint on the ML - do you have a link to the conversation? Asking as a GA member who votes. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avformat/ipfsgateway: fix capitalizaton mistake

2025-01-07 Thread Leo Izen
Fix the incorrect capitalization of the project name in a comment. The project is named FFmpeg, not FFMpeg. Signed-off-by: Leo Izen Reported-by: NyanMaths --- libavformat/ipfsgateway.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ipfsgateway.c b/libavformat

Re: [FFmpeg-devel] [PATCH v4 0/2] Animated JPEG XL encoding (via libjxl)

2025-01-03 Thread Leo Izen
On 12/30/24 11:34 AM, Leo Izen wrote: On 12/24/24 2:51 AM, Leo Izen wrote: Changes since v3: - Added APIChanges and Changelog entry - bumped minor version (new codec id) - Changed commit message to libjxl: - Added Reviewed-by to commits Changes since v2: - Replaced "goto end;" with &

Re: [FFmpeg-devel] [PATCH v4 0/2] Animated JPEG XL encoding (via libjxl)

2024-12-30 Thread Leo Izen
On 12/24/24 2:51 AM, Leo Izen wrote: Changes since v3: - Added APIChanges and Changelog entry - bumped minor version (new codec id) - Changed commit message to libjxl: - Added Reviewed-by to commits Changes since v2: - Replaced "goto end;" with "return ret;" when unneces

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-30 Thread Leo Izen
CC or the previous CC? I just want to confirm the current CC situation. Carbon-copying James to double check. [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-December/337990.html - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: check NULL pointer of av_strtok

2024-12-27 Thread Leo Izen
On 12/27/24 9:15 AM, Steven Liu wrote: Leo Izen 于2024年12月27日周五 21:29写道: Hi Leo, On 12/26/24 6:37 PM, Steven Liu wrote: fix CID: 1637073 there maybe have NULL pointer return by av_strtok, and should be checked before strtoll it. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: check NULL pointer of av_strtok

2024-12-27 Thread Leo Izen
integer, do we want to return that integer? What about returning an empty segment struct (as though the range == NULL)? It looks fine for preventing a NULL dereference, I just want to check to make sure this behavior is desired if the "-" token is no

Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2024-12-27 Thread Leo Izen
nding the variable, but if I had to guess, it may be a bug in its path-mangling (i.e. converting /foo/bar to C:\foo\bar) where it's interpreting "=" as a filename. I could not say for certain if this is the case. In either case, I don't

Re: [FFmpeg-devel] Worsening messages

2024-12-25 Thread Leo Izen
iled. Mails for FOSS projects like this one with public mailing lists get immortalized fairly quickly, even if you remove them from the server. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] matroskadec: support S_TEXT/WEBVTT

2024-12-25 Thread Leo Izen
end of a block where cleanup happens. - Leo Izen (Traneptora) From 5bd4a6f56231c3160be6c2d322f5d1081d7b3622 Mon Sep 17 00:00:00 2001 From: wang-bin Date: Tue, 17 Dec 2024 23:21:57 +0800 Subject: [PATCH] matroskadec: support S_TEXT/WEBVTT fix ticket #5641 --- libavformat/matroska.c|

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxl: add animated JPEG XL encoder

2024-12-24 Thread Leo Izen
version bump. I'm not so sure about the assert. See: c3083b3266cf01fdc43e5d03e27bea35d7c1faae which is the most recent codec added, and it didn't change the assert. Although that may have been a mistake as well. - Leo Izen (Traneptora) _

[FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxl: add animated JPEG XL encoder

2024-12-23 Thread Leo Izen
: Marth64 Co-authored-by: Zsolt Vadász Signed-off-by: Leo Izen --- Changelog | 1 + configure | 2 + doc/APIchanges | 3 + libavcodec/allcodecs.c | 2 + libavcodec/codec_desc.c| 8 + libavcodec/codec_id.h | 1 + libavcodec

[FFmpeg-devel] [PATCH v4 2/2] avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID

2024-12-23 Thread Leo Izen
A new codec ID has been added to avcodec for animated JPEG XL, so we should use that in the animated JPEG XL demuxer. Reviewed-by: Marth64 Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c| 2 +- tests/ref/fate/jxl-anim-demux-icos4d | 2 +- tests/ref/fate/jxl-anim-demux-newton

[FFmpeg-devel] [PATCH v4 0/2] Animated JPEG XL encoding (via libjxl)

2024-12-23 Thread Leo Izen
t and added it as an argument to libjxl_preprocess_frame as that's the only place it was used - Added some comments Changes since v1: - Fixed FATE failures Leo Izen (2): avcodec/libjxl: add animated JPEG XL encoder avformat/jpegxl_anim_dec: use new animated JPE

Re: [FFmpeg-devel] [PATCH v3 0/2] Animated JPEG XL (via libjxl)

2024-12-23 Thread Leo Izen
On 12/15/24 12:04 PM, Leo Izen wrote: Changes since v2: - Replaced "goto end;" with "return ret;" when unnecessary - removed *data from JXLEncodeContext and added it as an argument to libjxl_preprocess_frame as that's the only place it was used - Added some comments

Re: [FFmpeg-devel] matroskadec: support S_TEXT/WEBVTT

2024-12-23 Thread Leo Izen
g.org with subject "unsubscribe". This patch has a big web of gotos. This can get very confusing. Is there any way to change it so there's if blocks or other static functions to call? Gotos should be used very sparingly and mostly to goto the end of a block where cleanup h

Re: [FFmpeg-devel] [PATCH] avformat/iff: remove surplus if statement

2024-12-22 Thread Leo Izen
iff_read_packet(AVFormatContext *s, av_assert0(0); } -if (ret < 0) -return ret; return ret; } Seems fine to me. Will apply. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH] swscale: use 16-bit intermediate precision for RGB/XYZ conversion

2024-12-22 Thread Leo Izen
insignificant amount? What if we lazily allocate them only if CONFIG_SMALL? Considering we have NULL_IF_CONFIG_SMALL() on several-byte text strings I can see us caring in that scenario. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 04/17] swscale/utils: read HDR mastering metadata from AVFrame

2024-12-19 Thread Leo Izen
On 12/16/24 6:17 AM, Niklas Haas wrote: From: Niklas Haas --- libswscale/utils.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libswscale/utils.c b/libswscale/utils.c index 2d8fc10beb..3d3fcadacc 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -46

Re: [FFmpeg-devel] [PATCH] configure: add option to statically link to libvulkan

2024-12-18 Thread Leo Izen
n, can you give an example of a weird setup where this would solve a problem? - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Leo Izen
it works for all cases, my point is, that it is a valid solution It really isn't, because it doesn't work in all cases. It works for a specific list of known cases. This is not the same thing. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Leo Izen
some sort of tool that decodes relevant zlib chunks and then run a checksum on its output However, (b) is much more complicated and probably not worth the effort. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

[FFmpeg-devel] [PATCH v3 2/2] avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID

2024-12-15 Thread Leo Izen
A new codec ID has been added to avcodec for animated JPEG XL, so we should use that in the animated JPEG XL demuxer. Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c| 2 +- tests/ref/fate/jxl-anim-demux-icos4d | 2 +- tests/ref/fate/jxl-anim-demux-newton | 2 +- 3 files

[FFmpeg-devel] [PATCH v3 1/2] avcodec/libjxlenc: add animated JPEG XL encoder

2024-12-15 Thread Leo Izen
: Zsolt Vadász Signed-off-by: Leo Izen --- configure | 2 + libavcodec/allcodecs.c | 2 + libavcodec/codec_desc.c| 8 + libavcodec/codec_id.h | 1 + libavcodec/jpegxl_parser.c | 2 +- libavcodec/libjxldec.c | 16 ++ libavcodec/libjxlenc.c | 392

[FFmpeg-devel] [PATCH v3 0/2] Animated JPEG XL (via libjxl)

2024-12-15 Thread Leo Izen
Changes since v2: - Replaced "goto end;" with "return ret;" when unnecessary - removed *data from JXLEncodeContext and added it as an argument to libjxl_preprocess_frame as that's the only place it was used - Added some comments Changes since v1: - Fixed FATE failures

Re: [FFmpeg-devel] [PATCH 0/2] Animated JPEG XL Encoder

2024-12-14 Thread Leo Izen
spot? They could be. There use to be a free statement there that was moved, and I didn't update the gotos. Good catch! - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 0/2] Animated JPEG XL Encoder

2024-12-11 Thread Leo Izen
On 12/4/24 9:59 AM, Leo Izen wrote: > Changes since v1: > - modified fate tests to use jpegxl_anim codec ID, so > the fate tests don't fail after applying patch 2/2 > > Leo Izen (2): >avcodec/libjxlenc: add animated JPEG XL encoder >avformat/jpegxl_anim_dec: use

Re: [FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-09 Thread Leo Izen
On 12/8/24 2:23 PM, Jan Ekström wrote: On Sun, Dec 1, 2024 at 4:21 PM Leo Izen wrote: The PNGv3 Specification Draft [1] has changed the capitalization of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates FFmpeg to work with the new chunk names while retaining decode-side

Re: [FFmpeg-devel] [PATCH v2] avfilter/af_ashowinfo: fix scaling factor of replaygain peak values

2024-12-07 Thread Leo Izen
LOG_INFO, "%f", peak / 10.0f); av_log(ctx, AV_LOG_INFO, ", "); } LGTM, will apply. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubs

Re: [FFmpeg-devel] Decoding performance -f rawvideo pipe:1 vs BMP images output

2024-12-07 Thread Leo Izen
mailing list, rather than ffmpeg-devel. However, you did bring up an issue with the codebase after further investigation. What happens if you use -thread_queue_size 0 before the output? - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-07 Thread Leo Izen
On 12/1/24 9:20 AM, Leo Izen wrote: The PNGv3 Specification Draft [1] has changed the capitalization of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates FFmpeg to work with the new chunk names while retaining decode-side compatibility with files created using the old names. [1

Re: [FFmpeg-devel] [PATCH v2 10/16] avfilter/vf_scale: strip metadata when changing colorspace

2024-12-06 Thread Leo Izen
ut not primaries (e.g. after linearization), since it only references the gamut of the mastering display. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH v2 11/16] swscale/csputils: add internal colorspace math helpers

2024-12-06 Thread Leo Izen
t pq_eotf(float x) +{ +float idxf = av_clipf(x, 0.0f, 1.0f) * (PQ_LUT_SIZE - 1); +int ipart = floorf(idxf); +float fpart = idxf - ipart; + return fmixf(pq_eotf_lut[ipart], pq_eotf_lut[ipart + 1], fpart); +} + +static inline float pq_oetf(float x) +{ +x = powf(fmaxf(x * 1e-4f, 0.0f)

Re: [FFmpeg-devel] [PATCH] avfilter/af_ashowinfo: fix scaling factor of replaygain peak values

2024-12-04 Thread Leo Izen
it be possible to post a sentence or two in the commit message body explaining at first glance? e.g. something like "Commit changed replaygain values to use 100k instead of UINT32_MAX as peak, with possibility of overflow. af_ashowinfo was never updated to reflect this, so we update it now

Re: [FFmpeg-devel] [PATCH 0/2] Animated JPEG XL Encoder

2024-12-04 Thread Leo Izen
On 12/4/24 9:59 AM, Leo Izen wrote: Changes since v1: - modified fate tests to use jpegxl_anim codec ID, so the fate tests don't fail after applying patch 2/2 Leo Izen (2): avcodec/libjxlenc: add animated JPEG XL encoder avformat/jpegxl_anim_dec: use new animated JPEG XL cod

[FFmpeg-devel] [PATCH 2/2] avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID

2024-12-04 Thread Leo Izen
A new codec ID has been added to avcodec for animated JPEG XL, so we should use that in the animated JPEG XL demuxer. Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c| 2 +- tests/ref/fate/jxl-anim-demux-icos4d | 2 +- tests/ref/fate/jxl-anim-demux-newton | 2 +- 3 files

[FFmpeg-devel] [PATCH 1/2] avcodec/libjxlenc: add animated JPEG XL encoder

2024-12-04 Thread Leo Izen
: Zsolt Vadász Signed-off-by: Leo Izen --- configure | 2 + libavcodec/allcodecs.c | 2 + libavcodec/codec_desc.c| 8 + libavcodec/codec_id.h | 1 + libavcodec/jpegxl_parser.c | 2 +- libavcodec/libjxldec.c | 16 ++ libavcodec/libjxlenc.c | 365

[FFmpeg-devel] [PATCH 0/2] Animated JPEG XL Encoder

2024-12-04 Thread Leo Izen
Changes since v1: - modified fate tests to use jpegxl_anim codec ID, so the fate tests don't fail after applying patch 2/2 Leo Izen (2): avcodec/libjxlenc: add animated JPEG XL encoder avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID configure

[FFmpeg-devel] [PATCH 2/2] avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID

2024-12-03 Thread Leo Izen
A new codec ID has been added to avcodec for animated JPEG XL, so we should use that in the animated JPEG XL demuxer. Signed-off-by: Leo Izen --- libavformat/jpegxl_anim_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat

[FFmpeg-devel] [PATCH 1/2] avcodec/libjxlenc: add animated JPEG XL encoder

2024-12-03 Thread Leo Izen
: Zsolt Vadász Signed-off-by: Leo Izen --- configure | 2 + libavcodec/allcodecs.c | 2 + libavcodec/codec_desc.c| 8 + libavcodec/codec_id.h | 1 + libavcodec/jpegxl_parser.c | 2 +- libavcodec/libjxldec.c | 16 ++ libavcodec/libjxlenc.c | 365

Re: [FFmpeg-devel] [RFC] infrastructure documentation

2024-12-02 Thread Leo Izen
so I shouldn't have access, so that's a good thing. - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

Re: [FFmpeg-devel] [PATCH v2 2/6] avutil/csp: eliminate redundant branch

2024-12-01 Thread Leo Izen
urn NULL; -return func; +return trc_funcs[trc]; } This is future-proof in case there's gaps in H.273, which there are in some cases. Also it prevents a segfault crash if someone passes an enum that hasn't been added to FFmpeg yet, but has been added to H.273.

[FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-01 Thread Leo Izen
-off-by: Leo Izen --- libavcodec/pngdec.c | 12 +++- libavcodec/pngenc.c | 4 ++-- tests/ref/fate/png-mdcv | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index c5b32c166d..f8cb61775e 100644 --- a/libavcodec/pngdec.c

[FFmpeg-devel] [PATCH] MAINTAINERS: list csp.c and csp.h maintainers

2024-11-22 Thread Leo Izen
Ronald S. Bultje wrote most of the code before there was a refactor and condense (which I mostly wrote). As such, listing both him and myself as maintainers of csp.h and csp.h, which previously had no maintainer listed at all (after conferring on IRC). Signed-off-by: Leo Izen --- MAINTAINERS

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-13 Thread Leo Izen
ounts that have made no commits in a decade, and I don't believe anyone has objected to that either. (As you mentioned, if they become active we can re-add them.) - Leo Izen (Traneptora) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-13 Thread Leo Izen
le. I'd even say that we may go as far and remove *every* key that is unlabeled unless we can clearly establish who it belongs to and label it as such. We need to know who these keys belong to so we can contact those people if necessary or know

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix reading lz77-pair as initial entropy symbol

2024-11-07 Thread Leo Izen
window). Reported-by: Kacper Michajłow Found-by: ossfuzz Fixes: 368725676/clusterfuzz-testcase-minimized-fuzzer_protocol_file-6022251122589696-cut Fixes: 42537758/clusterfuzz-testcase-minimized-fuzzer_protocol_file-5818969469026304-cut Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c

  1   2   3   4   5   6   7   >