in handing over reigns to anybody.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
igned int.
Several other members are also changed to int64_t to avoid this problem
in other possible scenarios.
Signed-off-by: Leo Izen
Reported-by: Kacper Michajlow
Fixes: clusterfuzz-testcase-minimized-fuzzer_loadfile-6085331937460224
---
libavcodec/jpegxl_parse.c | 5 +++--
libavc
On 1/21/25 7:34 AM, Leo Izen wrote:
This function can return AVERROR_BUG in theory if something
went wrong, but so can the caller, so we should propagate that
error message upward in that case.
Signed-off-by: Leo Izen
---
libavutil/frame.c | 9 +++--
1 file changed, 7 insertions(+), 2
This function can return AVERROR_BUG in theory if something
went wrong, but so can the caller, so we should propagate that
error message upward in that case.
Signed-off-by: Leo Izen
---
libavutil/frame.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavutil
rofit enterprise
controversy that surrounded Gitea.
I can't vouch for it (or against it, for that matter) but I can say that
some prominent projects (e.g. Fedora) have chosen it.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@
On 1/16/25 6:32 PM, Timo Rothenpieler wrote:
On 17.01.2025 00:16, Leo Izen wrote:
On 1/15/25 5:41 PM, Timo Rothenpieler wrote:
---
libavformat/flv.h | 5
libavformat/flvdec.c | 68
2 files changed, 73 insertions(+)
diff --git a
On 1/15/25 5:41 PM, Timo Rothenpieler wrote:
---
libavformat/flv.h| 5
libavformat/flvdec.c | 68
2 files changed, 73 insertions(+)
diff --git a/libavformat/flv.h b/libavformat/flv.h
index 74d3b8de8b..d8f7980f2e 100644
--- a/libavformat/
On 1/15/25 2:10 AM, Peter Ross wrote:
Fixes ticket #10658.
---
libavcodec/leaddec.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c
index 88387902ca..12e27061e9 100644
--- a/libavcodec/leaddec.c
+++ b/libavcodec/leadde
On 1/14/25 7:36 PM, Timo Rothenpieler wrote:
---
libavformat/flv.h| 5
libavformat/flvdec.c | 63
2 files changed, 68 insertions(+)
diff --git a/libavformat/flv.h b/libavformat/flv.h
index 74d3b8de8b..d8f7980f2e 100644
--- a/libavformat/
It should be more clear what this flag is indicating with a more
verbose comment documenting it.
Signed-off-by: Leo Izen
Reviewed-by: Marton Balint
Reviewed-by: Alexander Strasser
Reviewed-by: Marth64
---
libavutil/frame.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
It should be more clear what this flag is indicating with a more
verbose comment documenting it.
Signed-off-by: Leo Izen
---
libavutil/frame.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavutil/frame.h b/libavutil/frame.h
index 993fa6b65a..e3657f193f 100644
On 1/7/25 4:54 PM, Alexander Strasser via ffmpeg-devel wrote:
On 2025-01-07 14:18 -0500, Leo Izen wrote:
Fix the incorrect capitalization of the project name in a comment.
The project is named FFmpeg, not FFMpeg.
Signed-off-by: Leo Izen
Reported-by: NyanMaths
---
libavformat/ipfsgateway.c
this second complaint made in a public environment? If not, carry on
as before. If so, I don't see the complaint on the ML - do you have a
link to the conversation? Asking as a GA member who votes.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing
Fix the incorrect capitalization of the project name in a comment.
The project is named FFmpeg, not FFMpeg.
Signed-off-by: Leo Izen
Reported-by: NyanMaths
---
libavformat/ipfsgateway.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/ipfsgateway.c b/libavformat
On 12/30/24 11:34 AM, Leo Izen wrote:
On 12/24/24 2:51 AM, Leo Izen wrote:
Changes since v3:
- Added APIChanges and Changelog entry
- bumped minor version (new codec id)
- Changed commit message to libjxl:
- Added Reviewed-by to commits
Changes since v2:
- Replaced "goto end;" with &
On 12/24/24 2:51 AM, Leo Izen wrote:
Changes since v3:
- Added APIChanges and Changelog entry
- bumped minor version (new codec id)
- Changed commit message to libjxl:
- Added Reviewed-by to commits
Changes since v2:
- Replaced "goto end;" with "return ret;" when unneces
CC or the previous CC? I just want to
confirm the current CC situation. Carbon-copying James to double check.
[1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-December/337990.html
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg
On 12/27/24 9:15 AM, Steven Liu wrote:
Leo Izen 于2024年12月27日周五 21:29写道：
Hi Leo,
On 12/26/24 6:37 PM, Steven Liu wrote:
fix CID: 1637073
there maybe have NULL pointer return by av_strtok, and should be checked before
strtoll it.
Signed-off-by: Steven Liu
---
libavformat/dashdec.c | 2
integer, do we want to return that integer? What about
returning an empty segment struct (as though the range == NULL)? It
looks fine for preventing a NULL dereference, I just want to check to
make sure this behavior is desired if the "-" token is no
nding the variable, but if I had to guess, it may
be a bug in its path-mangling (i.e. converting /foo/bar to C:\foo\bar)
where it's interpreting "=" as a filename. I could not say for certain
if this is the case.
In either case, I don't
iled. Mails for FOSS
projects like this one with public mailing lists get immortalized fairly
quickly, even if you remove them from the server.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listin
end of
a block where cleanup happens.
- Leo Izen (Traneptora)
From 5bd4a6f56231c3160be6c2d322f5d1081d7b3622 Mon Sep 17 00:00:00 2001
From: wang-bin
Date: Tue, 17 Dec 2024 23:21:57 +0800
Subject: [PATCH] matroskadec: support S_TEXT/WEBVTT
fix ticket #5641
---
libavformat/matroska.c|
version
bump. I'm not so sure about the assert. See:
c3083b3266cf01fdc43e5d03e27bea35d7c1faae which is the most recent codec
added, and it didn't change the assert. Although that may have been a
mistake as well.
- Leo Izen (Traneptora)
_
: Marth64
Co-authored-by: Zsolt Vadász
Signed-off-by: Leo Izen
---
Changelog | 1 +
configure | 2 +
doc/APIchanges | 3 +
libavcodec/allcodecs.c | 2 +
libavcodec/codec_desc.c| 8 +
libavcodec/codec_id.h | 1 +
libavcodec
A new codec ID has been added to avcodec for animated JPEG XL, so
we should use that in the animated JPEG XL demuxer.
Reviewed-by: Marth64
Signed-off-by: Leo Izen
---
libavformat/jpegxl_anim_dec.c| 2 +-
tests/ref/fate/jxl-anim-demux-icos4d | 2 +-
tests/ref/fate/jxl-anim-demux-newton
t and added it as an argument
to libjxl_preprocess_frame as that's the only place it was used
- Added some comments
Changes since v1:
- Fixed FATE failures
Leo Izen (2):
avcodec/libjxl: add animated JPEG XL encoder
avformat/jpegxl_anim_dec: use new animated JPE
On 12/15/24 12:04 PM, Leo Izen wrote:
Changes since v2:
- Replaced "goto end;" with "return ret;" when unnecessary
- removed *data from JXLEncodeContext and added it as an argument
to libjxl_preprocess_frame as that's the only place it was used
- Added some comments
g.org with subject "unsubscribe".
This patch has a big web of gotos. This can get very confusing. Is there
any way to change it so there's if blocks or other static functions to
call? Gotos should be used very sparingly and mostly to goto the end of
a block where cleanup h
iff_read_packet(AVFormatContext *s,
av_assert0(0);
}
-if (ret < 0)
-return ret;
return ret;
}
Seems fine to me. Will apply.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
insignificant amount?
What if we lazily allocate them only if CONFIG_SMALL? Considering we
have NULL_IF_CONFIG_SMALL() on several-byte text strings I can see us
caring in that scenario.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel
On 12/16/24 6:17 AM, Niklas Haas wrote:
From: Niklas Haas
---
libswscale/utils.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/libswscale/utils.c b/libswscale/utils.c
index 2d8fc10beb..3d3fcadacc 100644
--- a/libswscale/utils.c
+++ b/libswscale/utils.c
@@ -46
n, can you give an example of a weird setup
where this would solve a problem?
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ff
it works for all cases,
my point is, that it is a valid solution
It really isn't, because it doesn't work in all cases. It works for a
specific list of known cases. This is not the same thing.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing li
some sort of tool that decodes relevant zlib chunks and then
run a checksum on its output
However, (b) is much more complicated and probably not worth the effort.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffm
A new codec ID has been added to avcodec for animated JPEG XL, so
we should use that in the animated JPEG XL demuxer.
Signed-off-by: Leo Izen
---
libavformat/jpegxl_anim_dec.c| 2 +-
tests/ref/fate/jxl-anim-demux-icos4d | 2 +-
tests/ref/fate/jxl-anim-demux-newton | 2 +-
3 files
: Zsolt Vadász
Signed-off-by: Leo Izen
---
configure | 2 +
libavcodec/allcodecs.c | 2 +
libavcodec/codec_desc.c| 8 +
libavcodec/codec_id.h | 1 +
libavcodec/jpegxl_parser.c | 2 +-
libavcodec/libjxldec.c | 16 ++
libavcodec/libjxlenc.c | 392
Changes since v2:
- Replaced "goto end;" with "return ret;" when unnecessary
- removed *data from JXLEncodeContext and added it as an argument
to libjxl_preprocess_frame as that's the only place it was used
- Added some comments
Changes since v1:
- Fixed FATE failures
spot?
They could be. There use to be a free statement there that was moved,
and I didn't update the gotos. Good catch!
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-deve
On 12/4/24 9:59 AM, Leo Izen wrote:
> Changes since v1:
> - modified fate tests to use jpegxl_anim codec ID, so
> the fate tests don't fail after applying patch 2/2
>
> Leo Izen (2):
>avcodec/libjxlenc: add animated JPEG XL encoder
>avformat/jpegxl_anim_dec: use
On 12/8/24 2:23 PM, Jan Ekström wrote:
On Sun, Dec 1, 2024 at 4:21 PM Leo Izen wrote:
The PNGv3 Specification Draft [1] has changed the capitalization
of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates
FFmpeg to work with the new chunk names while retaining decode-side
LOG_INFO, "%f", peak / 10.0f);
av_log(ctx, AV_LOG_INFO, ", ");
}
LGTM, will apply.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubs
mailing list, rather
than ffmpeg-devel. However, you did bring up an issue with the codebase
after further investigation.
What happens if you use -thread_queue_size 0 before the output?
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel
On 12/1/24 9:20 AM, Leo Izen wrote:
The PNGv3 Specification Draft [1] has changed the capitalization
of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates
FFmpeg to work with the new chunk names while retaining decode-side
compatibility with files created using the old names.
[1
ut not primaries (e.g. after linearization), since it only
references the gamut of the mastering display.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit
t pq_eotf(float x)
+{
+float idxf = av_clipf(x, 0.0f, 1.0f) * (PQ_LUT_SIZE - 1);
+int ipart = floorf(idxf);
+float fpart = idxf - ipart;
+ return fmixf(pq_eotf_lut[ipart], pq_eotf_lut[ipart + 1], fpart);
+}
+
+static inline float pq_oetf(float x)
+{
+x = powf(fmaxf(x * 1e-4f, 0.0f)
it be possible to post a sentence or two in the commit message
body explaining at first glance?
e.g. something like "Commit changed replaygain values
to use 100k instead of UINT32_MAX as peak, with possibility of overflow.
af_ashowinfo was never updated to reflect this, so we update it now
On 12/4/24 9:59 AM, Leo Izen wrote:
Changes since v1:
- modified fate tests to use jpegxl_anim codec ID, so
the fate tests don't fail after applying patch 2/2
Leo Izen (2):
avcodec/libjxlenc: add animated JPEG XL encoder
avformat/jpegxl_anim_dec: use new animated JPEG XL cod
A new codec ID has been added to avcodec for animated JPEG XL, so
we should use that in the animated JPEG XL demuxer.
Signed-off-by: Leo Izen
---
libavformat/jpegxl_anim_dec.c| 2 +-
tests/ref/fate/jxl-anim-demux-icos4d | 2 +-
tests/ref/fate/jxl-anim-demux-newton | 2 +-
3 files
: Zsolt Vadász
Signed-off-by: Leo Izen
---
configure | 2 +
libavcodec/allcodecs.c | 2 +
libavcodec/codec_desc.c| 8 +
libavcodec/codec_id.h | 1 +
libavcodec/jpegxl_parser.c | 2 +-
libavcodec/libjxldec.c | 16 ++
libavcodec/libjxlenc.c | 365
Changes since v1:
- modified fate tests to use jpegxl_anim codec ID, so
the fate tests don't fail after applying patch 2/2
Leo Izen (2):
avcodec/libjxlenc: add animated JPEG XL encoder
avformat/jpegxl_anim_dec: use new animated JPEG XL codec ID
configure
A new codec ID has been added to avcodec for animated JPEG XL, so
we should use that in the animated JPEG XL demuxer.
Signed-off-by: Leo Izen
---
libavformat/jpegxl_anim_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat
: Zsolt Vadász
Signed-off-by: Leo Izen
---
configure | 2 +
libavcodec/allcodecs.c | 2 +
libavcodec/codec_desc.c| 8 +
libavcodec/codec_id.h | 1 +
libavcodec/jpegxl_parser.c | 2 +-
libavcodec/libjxldec.c | 16 ++
libavcodec/libjxlenc.c | 365
so I shouldn't
have access, so that's a good thing.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-req
urn NULL;
-return func;
+return trc_funcs[trc];
}
This is future-proof in case there's gaps in H.273, which there are in
some cases.
Also it prevents a segfault crash if someone passes an enum that hasn't
been added to FFmpeg yet, but has been added to H.273.
-off-by: Leo Izen
---
libavcodec/pngdec.c | 12 +++-
libavcodec/pngenc.c | 4 ++--
tests/ref/fate/png-mdcv | 2 +-
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index c5b32c166d..f8cb61775e 100644
--- a/libavcodec/pngdec.c
Ronald S. Bultje wrote most of the code before there was a refactor
and condense (which I mostly wrote). As such, listing both him and myself
as maintainers of csp.h and csp.h, which previously had no maintainer
listed at all (after conferring on IRC).
Signed-off-by: Leo Izen
---
MAINTAINERS
ounts that have made no commits in a
decade, and I don't believe anyone has objected to that either. (As you
mentioned, if they become active we can re-add them.)
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://
le.
I'd even say that we may go as far and remove *every* key that is
unlabeled unless we can clearly establish who it belongs to and label it
as such. We need to know who these keys belong to so we can contact
those people if necessary or know
window).
Reported-by: Kacper Michajłow
Found-by: ossfuzz
Fixes:
368725676/clusterfuzz-testcase-minimized-fuzzer_protocol_file-6022251122589696-cut
Fixes:
42537758/clusterfuzz-testcase-minimized-fuzzer_protocol_file-5818969469026304-cut
Signed-off-by: Leo Izen
---
libavcodec/jpegxl_parser.c
ng on fate-pixfmt-yuv444p12-yuv444p,
but i can't reproduce it.
This may be a silly question, but does CPUFLAGS set -march=foo? What
happens with --extra-cflags=-march=x86_64?
- Leo Izen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
htt
On 11/7/24 12:28 AM, Kacper Michajlow wrote:
On Tue, 5 Nov 2024 at 11:05, Leo Izen wrote:
This says reported by kacper, could you send me the fuzz testcase?
I've sent you testcases privately.
- Kacper
Thanks, I received them. I'll take a look today.
FFER_TOO_SMALL;
}
LTGM, Will apply.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
cted to
be previously set.
It would be, as this is just a sliding LZ77 window. Reading
uninitialized bytes that weren't written is a bug. I'd be curious to see
the fuzz case so I could run it through valgrind and figure out why
that's happening.
This says reported by k
On 10/1/24 7:36 AM, Anton Khirnov wrote:
Quoting James Almer (2024-09-30 01:01:39)
On 9/16/2024 11:43 AM, Leo Izen wrote:
I've made some changes to the last EXIF overhaul patch I sent,
notably I fixed up some bugs and added MakerNote parsing, so it
should not corrupt MakerNotes that are i
+v = av_crc(av_crc_get_table(AV_CRC_32_IEEE), f->crcref, buf_p, bytes) ^
(f->crcref&0x4964AF46);
Nitpick: should probably be (f->crcref & 0x4964af46), the space makes it
a bit more readable.
AV_WL32(buf_p + bytes, v);
bytes += 4;
breaking change, because you're changing the function
signature (including the size of arguments) for a function exposed as
a public API. You'll need to figure out a solution that doesn't break
public interfaces.
- Leo Izen (Traneptora)
___
Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk
to PNG files, if present.
Signed-off-by: Leo Izen
---
libavcodec/pngenc.c | 4
tests/ref/fate/cover-art-mp3-id3v2-remux | 6 +++---
tests/ref/fate/mov-cover-image | 6 +++---
3 files changed, 10
Add support to parse eXIf chunks using the new EXIF framework.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index c5b32c166d..efd173e154 100644
--- a/libavcodec
tests to read the keys from the side data instead of
from the main frame metadata.
This commit also deprecates an avpriv_ function in exif.h, exposing the
parsing functionality as a public API in the exported libavcodec/exif.h
header file.
Signed-off-by: Leo Izen
---
fftools/ffprobe.c
yMatrix is not in the
dihedral group D4.
Currently there's no code that takes an AVDictionary and writes it back into
EXIF as these are not compatible structures. EXIF includes integers of varying
lengths, while AVDictionary contains strings only.
Leo Izen (3):
various: change EXIF metadata
eo coding", offsetof(AACEncContext,
options.mid_side), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, AACENC_FLAGS},
{"aac_is", "Intensity stereo coding", offsetof(AACEncContext,
options.intensity_stereo), AV_OPT_TYPE_BOOL, {.i64 = 1}, -1, 1, AACENC_FLAGS},
On 7/19/24 12:04 PM, Leo Izen wrote:
The PNG specification[1] says that sBIT entries must be at most the bit
depth specified in IHDR, unless the PNG is indexed-color, in which case
sBIT must be between 1 and 8. We should not reject valid sBITs on PNGs
with indexed color.
[1]: https://www.w3.org
://www.w3.org/TR/png-3/#11sBIT
Regression since: c125860892e931d9b10f88ace73c91484815c3a8.
Signed-off-by: Leo Izen
Reported-by: Ramiro Polla:
---
libavcodec/pngenc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 7ae16fa2c5
84b454935fae2633a8a5dd075e22393f3e8f932f.
Signed-off-by: Leo Izen
Reported-by: Ramiro Polla
---
libavcodec/pngdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index cb861e5f60..c5b32c166d 100644
--- a/libavcodec/pngdec.c
+++ b
On 7/18/24 4:47 AM, Marton Balint wrote:
On Fri, 12 Jul 2024, Leo Izen wrote:
Indexed color images use three colors for sBIT, but the function
ff_png_get_nb_channels returns 1 in this case. We should avoid erroring
out on valid files in this scenario.
Please mention that this is a
On 7/12/24 3:03 PM, Leo Izen wrote:
If the sBIT chunk size is invalid, we should print a more informative
error message rather than return an error and print nothing.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Will merge soon
This test confirms that we can write mDCv and cLLi chunks and read them
back via the png decoder. It uses an HEVC conformance sample with this
metadata as the base source for the side data in the frames.
Signed-off-by: Leo Izen
Reported-by: Jan Ekström
Reviewed-by: Jan Ekström
Reviewed-by
av_frame_clone(buf);
if (!buf_out)
return AVERROR(ENOMEM);
This LGTM, I submitted a similar patch.
- Leo Izen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, v
Declare AVFrame *buf_out with the rest of the declarations to fix a
compiler warning about Declarations after Statements in ISO C90.
Signed-off-by: Leo Izen
---
libavfilter/af_channelsplit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavfilter/af_channelsplit.c b
On 7/9/24 12:45 PM, Leo Izen wrote:
This test confirms that we can write mDCv chunks and read them back via
the png decoder. It uses an HEVC conformance sample with this metadata
as the base source for the side data in the frames.
Signed-off-by: Leo Izen
Reported-by: Jan Ekström
Reviewed-by
If the sBIT chunk size is invalid, we should print a more informative
error message rather than return an error and print nothing.
Signed-off-by: Leo Izen
---
libavcodec/pngdec.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
Indexed color images use three colors for sBIT, but the function
ff_png_get_nb_channels returns 1 in this case. We should avoid erroring
out on valid files in this scenario.
Signed-off-by: Leo Izen
Reported-by: Ramiro Polla
---
libavcodec/pngdec.c | 2 +-
1 file changed, 1 insertion(+), 1
sc->h_spacing = num;
+sc->v_spacing = den;
}
If den == 0, nothing is assigned at all, but if den != 0 and if num ==
0, we assign 0 to h_spacing, which will end up doing nothing because we
check h_spacing && v_spacing later on in the other
);
#define PUTRGB48(dst, src, asrc, i, abase) \
Y= src[ 2 * i]; \
Are these able to be negative? If not, it may be wise to cast to
uint32_t instead as left shifting a negative integer is UB.
- Leo Izen (Traneptora)
___
This test confirms that we can write mDCv chunks and read them back via
the png decoder. It uses an HEVC conformance sample with this metadata
as the base source for the side data in the frames.
Signed-off-by: Leo Izen
Reported-by: Jan Ekström
Reviewed-by: Andreas Rheinhardt
---
tests/fate
Changes since v1:
- changed transcode command
Leo Izen (1):
fate/png: add mDCv read and write test
tests/fate/image.mak| 6 ++
tests/ref/fate/png-mdcv | 22 ++
2 files changed, 28 insertions(+)
create mode 100644 tests/ref/fate/png-mdcv
--
2.45.2
This test confirms that we can write mDCv chunks and read them back via
the png decoder. It uses an HEVC conformance sample with this metadata
as the base source for the side data in the frames.
Signed-off-by: Leo Izen
Reported-by: Jan Ekström
---
tests/fate/image.mak| 5 +
tests/ref
On 7/2/24 9:44 AM, Leo Izen wrote:
When mDCv support was added, there was a typo in both variable names
and also the MKTAG itself, incorrectly listing it as mDVc. The tag name
stands for Mastering Display Color Volume so mDCv is correct.
Typo originally introduced in
When mDCv support was added, there was a typo in both variable names
and also the MKTAG itself, incorrectly listing it as mDVc. The tag name
stands for Mastering Display Color Volume so mDCv is correct.
Typo originally introduced in 78949041417caaef0c82b2b23d7defdd88aa2378.
Signed-off-by: Leo
c7a57b0f70f8d1574aa0f0dbe98db85d8ac91c76.
Signed-off-by: Leo Izen
Reported-by: Ramiro Polla
---
libavcodec/pngdec.c | 53 +++--
1 file changed, 27 insertions(+), 26 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 1c910e6a5b..180806e5e1 100644
On 6/27/24 1:27 PM, Lynne via ffmpeg-devel wrote:
On 21/06/2024 23:20, Leo Izen wrote:
int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.
Sorry, missed this patch, LGTM.
Applied as 539d2e989d7ce3556a549d59ee9c5125ae7d7b6b
- Leo
On 6/21/24 5:20 PM, Leo Izen wrote:
int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.
---
libavcodec/aac/aacdec_lpd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/libavcodec/aac/aacdec_lpd.c b
that one is unnecessary, but this one is fine.
I have no comment on the generic patches.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.
---
libavcodec/aac/aacdec_lpd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
index 796edd2ab5..91
int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.
Signed-off-by: Leo Izen
---
libavcodec/aac/aacdec_lpd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac
Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat,
and add a stub ffjni.c to libavformat, which allows the symbols to be
duplicated for shared builds but not static builds.
Signed-off-by: Leo Izen
---
libavcodec/Makefile | 1 +
libavformat/Makefile | 1 +
libavformat
Changes since v1:
- Rebased onto master
I was unable to credit the original reporter with a Reported-by because
the name used Chinese characters (and it translated to 'admin').
Leo Izen (1):
avcodec,avformat/ffjni: fix duplicate JNI symbols
libavcodec/Makefile | 1 +
libavforma
commit message, you want libtorch, not libtoch.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
ard in order to
alphabetize it.
- Leo Izen (Traneptora)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
The continue statement will break out of the do/while loop, not the
outer loop as intended. This is one (compound) statement anyway, so we
can remove the do/while entirely.
Signed-off-by: Leo Izen
---
libavutil/film_grain_params.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
1 - 100 of 624 matches
Mail list logo
