On 12/4/24 3:26 PM, Kacper Michajłow wrote:
Fixes: 8542f9c4f17125d483c40c0c5723842f1c982f81
Signed-off-by: Kacper Michajłow <kaspe...@gmail.com>
---
libavfilter/af_ashowinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/af_ashowinfo.c b/libavfilter/af_ashowinfo.c
index b83847b866..de94d4c7c2 100644
--- a/libavfilter/af_ashowinfo.c
+++ b/libavfilter/af_ashowinfo.c
@@ -120,7 +120,7 @@ static void print_peak(AVFilterContext *ctx, const char
*str, uint32_t peak)
if (!peak)
av_log(ctx, AV_LOG_INFO, "unknown");
else
- av_log(ctx, AV_LOG_INFO, "%f", (float)peak / UINT32_MAX);
+ av_log(ctx, AV_LOG_INFO, "%f", peak / 100000.0f);
av_log(ctx, AV_LOG_INFO, ", ");
}
It's not clear what "fixes: commit hash" means. I had to open up the
commit to see what it meant.
Would it be possible to post a sentence or two in the commit message
body explaining at first glance?
e.g. something like "Commit <hash> changed replaygain values
to use 100k instead of UINT32_MAX as peak, with possibility of overflow.
af_ashowinfo was never updated to reflect this, so we update it now."
As for the commit itself, LGTM.
- Leo Izen (Traneptora)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
