Re: [FFmpeg-devel] [PATCH v4 7/7] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-26 Thread Josh de Kock
On 26/06/2020 15:03, lance.lmw...@gmail.com wrote: On Wed, Jun 24, 2020 at 09:43:20PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Timo Rothenpieler Signed-off-by: Limin Wang --- libavcodec/nvenc.c | 17 + libavcodec/nvenc.h | 1 + libavco

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/hevcdec: create AVFrame side data from HEVC timecodes like H.264

2020-06-23 Thread Josh de Kock
On 17/06/2020 17:07, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevcdec.c | 44 1 file changed, 44 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index c9e28f5..39abbb9 100644

Re: [FFmpeg-devel] [PATCH] mailmap: add entry for myself

2020-06-17 Thread Josh de Kock
On 17/06/2020 18:16, Josh de Kock wrote: On 17/06/2020 15:16, Zhong Li wrote: Signed-off-by: Zhong Li ---   .mailmap | 3 ++-   1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index d1925bfab0..f14770d800 100644 --- a/.mailmap +++ b/.mailmap @@ -15,7 +15,8

Re: [FFmpeg-devel] [PATCH] mailmap: add entry for myself

2020-06-17 Thread Josh de Kock
On 17/06/2020 15:16, Zhong Li wrote: Signed-off-by: Zhong Li --- .mailmap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index d1925bfab0..f14770d800 100644 --- a/.mailmap +++ b/.mailmap @@ -15,7 +15,8 @@ - + + Is better if you wo

Re: [FFmpeg-devel] [PATCH v3 0/3] swscale: add AVX2 version of yuv2nv12cX

2020-06-14 Thread Josh de Kock
Hi, On 03/06/2020 08:02, Nelson Gomez wrote: Bumping this patchset (and apologies if Outlook mangles the threading) [...] Nelson Gomez (3): swscale: make yuv2interleavedX more asm-friendly swscale/x86/output: add AVX2 version of yuv2nv12cX swscale: cosmetic fixes libswscale/output.

Re: [FFmpeg-devel] [PATCH 02/17] avdevice: deprecate av_*_device_next()

2020-05-28 Thread Josh de Kock
On 28/05/2020 21:15, Anton Khirnov wrote: These functions rely on deprecated libavformat APIs and apparently have zero users outside of cmdutils. Since the functionality they provide is apparently not useful to anyone, deprecate them without replacement. --- doc/APIchanges | 4 ff

[FFmpeg-devel] [PATCH] lavc/h264_cavlc: use inline function get_bits API

2020-05-26 Thread Josh de Kock
To prepare for using the cached bitstream reader, which only defines the inline functions rather than the macros, with CAVLC decoding. Signed-off-by: Josh de Kock --- libavcodec/h264_cavlc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix NEON hscale init

2020-05-16 Thread Josh de Kock
On 16/05/2020 11:50, Carl Eugen Hoyos wrote: Am Fr., 15. Mai 2020 um 12:27 Uhr schrieb Josh de Kock : On 08/05/2020 12:25, Michael Niedermayer wrote: On Thu, May 07, 2020 at 12:25:34PM +0100, Josh de Kock wrote: The NEON hscale function only supports X8 filter sizes and should only be

Re: [FFmpeg-devel] [PATCH v2 2/2] swscale: aarch64: Add a NEON implementation of interleaveBytes

2020-05-15 Thread Josh de Kock
On 15/05/2020 19:11, Martin Storsjö wrote: This allows speeding up format conversions from yuv420 to nv12. Cortex A53 A72 A73 interleave_bytes_c: 86077.5 51433.0 66972.0 interleave_bytes_neon: 19701.7 23019.2 15859.2 interleave_byt

Re: [FFmpeg-devel] [PATCH] swscale: fix arm NEON hscale init

2020-05-15 Thread Josh de Kock
On 15/05/2020 19:35, Martin Storsjö wrote: From: Josh de Kock The NEON hscale function only supports X8 filter sizes and should only be selected when these are being used. At the moment filterAlign is set to 8 but in the future when extra NEON assembly for specific sizes is added they will

Re: [FFmpeg-devel] [PATCH] checkasm: Add functions for printing pixel buffers

2020-05-15 Thread Josh de Kock
On 14/05/2020 22:28, Martin Storsjö wrote: On Thu, 14 May 2020, Josh de Kock wrote: From: Martin Storsjö This was ported from dav1d (c950e7101bdf5f7117bfca816984a21e550509f0). Signed-off-by: Josh de Kock --- tests/checkasm/checkasm.c | 42 +++ tests

Re: [FFmpeg-devel] [PATCH v3] checkasm: add hscale test

2020-05-15 Thread Josh de Kock
On 15/05/2020 09:41, Martin Storsjö wrote: On Thu, 14 May 2020, Josh de Kock wrote: This tests the hscale 8bpp to 14bpp functions with different filter sizes. Signed-off-by: Josh de Kock --- Adds support for checking corner cases for signed and large coefficients. Also makes the padded

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix NEON hscale init

2020-05-15 Thread Josh de Kock
On 08/05/2020 12:25, Michael Niedermayer wrote: On Thu, May 07, 2020 at 12:25:34PM +0100, Josh de Kock wrote: The NEON hscale function only supports X8 filter sizes and should only be selected when these are being used. Signed-off-by: Josh de Kock --- libswscale/aarch64/swscale.c | 5

[FFmpeg-devel] [PATCH v3] checkasm: add hscale test

2020-05-14 Thread Josh de Kock
This tests the hscale 8bpp to 14bpp functions with different filter sizes. Signed-off-by: Josh de Kock --- Adds support for checking corner cases for signed and large coefficients. Also makes the padded coefficients random data. Tested on x86_64 and aarch64. tests/checkasm/Makefile

[FFmpeg-devel] [PATCH] checkasm: Add functions for printing pixel buffers

2020-05-14 Thread Josh de Kock
From: Martin Storsjö This was ported from dav1d (c950e7101bdf5f7117bfca816984a21e550509f0). Signed-off-by: Josh de Kock --- tests/checkasm/checkasm.c | 42 +++ tests/checkasm/checkasm.h | 16 +++ 2 files changed, 58 insertions(+) diff --git a

[FFmpeg-devel] [PATCH v2] checkasm: add hscale test

2020-05-13 Thread Josh de Kock
This tests the hscale 8bpp to 14bpp functions with different filter sizes. Signed-off-by: Josh de Kock --- Should address all previous comments. tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/sw_scale.c | 114

Re: [FFmpeg-devel] [PATCH v3] libavcodec/libx264: fix reference frame computation based on level

2020-05-07 Thread Josh de Kock
ffmpeg-devel-boun...@ffmpeg.org On Behalf Of Josh de Kock Sent: Tuesday, April 28, 2020 23:47 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/libx264: fix reference frame computation based on level On 26/04/2020 12:46, Josh Brewster wrote: Hi, is there anything else I

[FFmpeg-devel] [WIP PATCH 2/2] checkasm: add hscale test

2020-05-07 Thread Josh de Kock
This tests the hscale 8bpp to 14bpp functions with different filter sizes. Signed-off-by: Josh de Kock --- Not quite ready to be committed but I wanted to submit it anyway so I could get some comments. I still need to do the rest of the scale sizes (such as 8bpp to 19bpp) and make the

[FFmpeg-devel] [PATCH 1/2] swscale: fix NEON hscale init

2020-05-07 Thread Josh de Kock
The NEON hscale function only supports X8 filter sizes and should only be selected when these are being used. Signed-off-by: Josh de Kock --- libswscale/aarch64/swscale.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libswscale/aarch64/swscale.c b/libswscale/aarch64

Re: [FFmpeg-devel] [PATCH] tools: fix const specifier for AVInputFormat

2020-04-30 Thread Josh de Kock
On 29/04/2020 20:58, Michael Niedermayer wrote: On Wed, Apr 29, 2020 at 12:00:23PM +0100, Josh de Kock wrote: Signed-off-by: Josh de Kock --- tools/probetest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Small fix for compiler warning caused by my earlier change. LGTM

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Josh de Kock
On 29/04/2020 14:00, Nicolas George wrote: Anton Khirnov (12020-04-29): Better late than never, this patch will continue to put in place the voting systems for FFmpeg discussed at VDD 2019 and FOSDEM 2020. There is probably a better way to do this, but the aim is just to 'bootstrap' and

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_v360: adjustment out_pad and in_pad maximum value to 1/10

2020-04-29 Thread Josh de Kock
On 26/04/2020 15:43, Steven Liu wrote: 2020年4月21日 下午10:54,Steven Liu 写道: Because not every user know about in_pad and out_pad reasonable value range so maybe try to set 1.0, but setting 1.0 is so hugh to get an fatal error. Suggested-by: Paul B Mahol Signed-off-by: Steven Liu --- doc/filt

Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-slice-test: remove unused bool header

2020-04-29 Thread Josh de Kock
On 29/04/2020 13:11, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Carl Eugen Hoyos Sent: Thursday, April 2, 2020 03:23 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-slice-test: remove unused bool header Am Mi., 1. Apr. 2020 um 06:58

Re: [FFmpeg-devel] [PATCH 0/2] fix for seeking in HLS with TS/FMP4 media

2020-04-29 Thread Josh de Kock
On 25/04/2020 22:42, Carl Eugen Hoyos wrote: Am Fr., 24. Apr. 2020 um 17:21 Uhr schrieb vectronic : I am resubmitting a patch which fixes the following two tickets: Do you not want to commit with your name rather than a handle here? https://trac.ffmpeg.org/ticket/7359 https://trac.ffmpeg.o

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Josh de Kock
On 24/04/2020 11:44, Josh de Kock wrote: On 24/04/2020 11:29, Nicolas George wrote: Josh de Kock (12020-04-24): This script aims to extract contributors who are eligible for the general assembly. Signed-off-by: Josh de Kock ---   Better late than never, this patch will continue to put in

Re: [FFmpeg-devel] [PATCH] fate: Skip the dnxhd-uhd-hr-sq tests of large tests are disabled

2020-04-29 Thread Josh de Kock
On 23/04/2020 08:14, Martin Storsjö wrote: These tests are also in the same size range as the previously skipped 2k and 4k tests. --- tests/fate/vcodec.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak index fc27da5456..e

Re: [FFmpeg-devel] [PATCH] avformat/hls: disable persistent HTTP connections by default w/ schannel

2020-04-29 Thread Josh de Kock
On 26/04/2020 20:43, Jan Ekström wrote: This TLS implementation has always had issues with the way that libavformat implemented persistency, yet nobody seemed to be able to figure out why. It currently can lead to completely stuck playback, so disable it by default. Additionally, update the docu

[FFmpeg-devel] [PATCH] tools: fix const specifier for AVInputFormat

2020-04-29 Thread Josh de Kock
Signed-off-by: Josh de Kock --- tools/probetest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Small fix for compiler warning caused by my earlier change. diff --git a/tools/probetest.c b/tools/probetest.c index cfa309cabd..6f0e002b74 100644 --- a/tools/probetest.c +++ b/tools

Re: [FFmpeg-devel] [PATCH v3] libavcodec/libx264: fix reference frame computation based on level

2020-04-28 Thread Josh de Kock
On 26/04/2020 12:46, Josh Brewster wrote: I only made sure that the level was positive because its initial value was -1. else if (x4->params.i_level_idc >= 0) { Let me know if I need to reject 0 too. It seemed like premature optimization as the level simply wouldn't be present in x264_levels.

Re: [FFmpeg-devel] [PATCH] Complete rewrite of the "fps" video filter section. More accurate.

2020-04-28 Thread Josh de Kock
On 27/04/2020 07:17, list+ffmpeg-...@jdlh.com wrote: From: Jim DeLaHunt This is a complete rewrite of the documentation for the "fps" video filter. It describes the filter's behaviour more clearly and accurately. I based the rewrite on reading the source code in vf_fps.c closely. No code, or o

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-24 Thread Josh de Kock
On 24/04/2020 11:29, Nicolas George wrote: Josh de Kock (12020-04-24): This script aims to extract contributors who are eligible for the general assembly. Signed-off-by: Josh de Kock --- Better late than never, this patch will continue to put in place the voting systems for FFmpeg

[FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-24 Thread Josh de Kock
This script aims to extract contributors who are eligible for the general assembly. Signed-off-by: Josh de Kock --- Better late than never, this patch will continue to put in place the voting systems for FFmpeg discussed at VDD 2019 and FOSDEM 2020. There is probably a better way to do this

Re: [FFmpeg-devel] [PATCH] cmdutils: stop using deprecated av_codec_next()

2020-04-20 Thread Josh de Kock
On 14/04/2020 13:37, Josh de Kock wrote: On Tue, Apr 14, 2020, at 9:09 AM, Anton Khirnov wrote: --- fftools/cmdutils.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) [...] LGTM, thanks. I will apply this a bit later after my set (or you can if

Re: [FFmpeg-devel] [PATCH 3/3] tools: stop using deprecated av_codec_next()

2020-04-20 Thread Josh de Kock
On 14/04/2020 13:38, Josh de Kock wrote: Signed-off-by: Josh de Kock --- tools/enum_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/enum_options.c b/tools/enum_options.c index 28631d1a6b..548e427b7a 100644 --- a/tools/enum_options.c +++ b/tools

Re: [FFmpeg-devel] [PATCH v2] configure: fix clang on macOS 10.15

2020-04-15 Thread Josh de Kock
On Wed, Apr 15, 2020, at 3:54 PM, Jan Ekström wrote: > [...] > > Thank you, LGTM from me. > > Jan Pushed. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above

[FFmpeg-devel] [PATCH v2] configure: fix clang on macOS 10.15

2020-04-15 Thread Josh de Kock
Works around a bug in the newer Xcode 11's clang with -fstack-check emitting bad code with misaligned call instructions. This fixes Trac #8073 --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 4d4c429be9..2ede4e7163 100755 --- a/configure +++ b/con

[FFmpeg-devel] [PATCH] configure: fix clang on macOS 10.15

2020-04-14 Thread Josh de Kock
Works around a bug in the newer Xcode 11's clang with -fstack-check emitting bad code with misaligned call instructions. --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 4d4c429be9..c872a2932d 100755 --- a/configure +++ b/configure @@ -5358,6 +5358

[FFmpeg-devel] [PATCH 2/3] lavf/utils: stop using deprecated av_codec_next()

2020-04-14 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index a58e47fabc..4f777ba849 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -222,7 +222,8 @@ static const AVCodec

[FFmpeg-devel] [PATCH 3/3] tools: stop using deprecated av_codec_next()

2020-04-14 Thread Josh de Kock
Signed-off-by: Josh de Kock --- tools/enum_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/enum_options.c b/tools/enum_options.c index 28631d1a6b..548e427b7a 100644 --- a/tools/enum_options.c +++ b/tools/enum_options.c @@ -113,13 +113,14 @@ static void

[FFmpeg-devel] [PATCH 1/3] lavc: stop using deprecated av_codec_next()

2020-04-14 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavcodec/options.c | 5 +++-- libavcodec/tests/utils.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 35e8ac9313..babab599fc 100644 --- a/libavcodec/options.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] cmdutils: stop using deprecated av_codec_next()

2020-04-14 Thread Josh de Kock
On Tue, Apr 14, 2020, at 9:09 AM, Anton Khirnov wrote: > --- > fftools/cmdutils.c | 33 +++-- > 1 file changed, 19 insertions(+), 14 deletions(-) > > [...] LGTM, thanks. I will apply this a bit later after my set (or you can if you want it sooner). -- Josh

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-14 Thread Josh de Kock
Hi, On Mon, Apr 13, 2020, at 10:32 PM, Josh Allmann wrote: > Hi, > > On Sat, 24 Mar 2018 at 14:40, Josh de Kock wrote: > > > > Signed-off-by: Josh de Kock > > --- > > configure| 29 +- > > doc/APIchanges |

Re: [FFmpeg-devel] REMOTE JOB POST: FFMPEG EXPERT

2020-03-04 Thread Josh de Kock
On Tue, Mar 3, 2020, at 12:55 PM, sumaklos rembert wrote: > We are hiring a remote FFMPEG engineer > > [...] You already posted this a week ago, there is no need to spam the list with the same job multiple times. -- Josh ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-26 Thread Josh de Kock
On Mon, Feb 24, 2020, at 11:19 AM, Thilo Borgmann wrote: > Am 23.02.20 um 21:40 schrieb Josh de Kock: > > On Sun, Feb 23, 2020, at 4:07 PM, Thilo Borgmann wrote: > >> [...] > >> > >> How is it automatically generated? > > > > I wrote a sma

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-26 Thread Josh de Kock
Hi Steven, On Mon, Feb 24, 2020, at 2:03 AM, Steven Liu wrote: > [...] > How can I get the script :D > > Thanks > > Steven I won't be looking to upstream this script (the other one yes), but I will share it here for you. You'll have to excuse my poor scripting :) -- Josh #!/usr/bin/env perl

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Josh de Kock
On Sun, Feb 23, 2020, at 4:07 PM, Thilo Borgmann wrote: > [...] > > How is it automatically generated? I wrote a small script to parse author names/emails and group emails together based on names. In the future, additions should be added manually. -- Josh ___

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Josh de Kock
On Sun, Feb 23, 2020, at 2:36 PM, James Darnley wrote: > [...] > > What is "preferred email" when you have 2 roles? My commits on the job > get obe.tv (or are supposed to) and ones made in my own time get > gmail.com (or are supposed to). > > Is it: when you screw up what email should you be sho

Re: [FFmpeg-devel] [PATCH] Add .mailmap

2020-02-23 Thread Josh de Kock
On Sun, Feb 23, 2020, at 2:12 PM, Jean-Baptiste Kempf wrote: > [...] > > I think this is a good idea. > But are you sure all of those are in the right order? (aka preferred > email is shown) It looks mostly right to me, of course individuals will need to manually verify it for themselves (but it

[FFmpeg-devel] [PATCH] Add .mailmap

2020-02-22 Thread Josh de Kock
This allows for easy shortlog/log parsing, useful in determining eligible members of the general assembly for the new FFmpeg voting system. Signed-off-by: Josh de Kock --- This list was automatically generated based off of commits from people with the same names. If you want this adjusted/your

[FFmpeg-devel] Followup: FOSDEM meeting

2020-02-21 Thread Josh de Kock
Hi all, Firstly, I want to thank j-b for his organisation of the meeting at FOSDEM, I think the meeting itself was productive and the outcome was good. Unfortunately, there is one issue: So far no one has shared a copy of the notes or a picture of the blackboard after the meeting. I was silly to

Re: [FFmpeg-devel] AVWriter API

2020-01-12 Thread Josh de Kock
Hi, I have very little time to work on FFmpeg lately but this thread caught my interest. Nicolas George writes: > Anton Khirnov (12020-01-07): >> And most importantly - strings are simple. Every C programmer (worth the >> name) understands strings. But now you'd be forcing every API user to >> u

Re: [FFmpeg-devel] [PATCH vFINAL] fate: add api-h264-slice test

2018-10-26 Thread Josh de Kock
On 24/10/2018 19:02, jos...@ob-encoder.com wrote: From: Josh de Kock This test ensures that you are able to send N number of slice NALUs in slice threaded mode to be decoded simultaneously --- tests/api/Makefile | 1 + tests/api/api-h264-slice-test.c | 221

Re: [FFmpeg-devel] [PATCH v4] fate: add api-h264-slice test

2018-10-22 Thread Josh de Kock
On 16/10/2018 12:33, Michael Niedermayer wrote: On Mon, Oct 15, 2018 at 01:32:03PM +0100, jos...@ob-encoder.com wrote: From: Josh de Kock This test ensures that you are able to send N number of slice NALUs in slice threaded mode to be decoded simultaneously --- Tested on Linux 32/64, MinGW

[FFmpeg-devel] [RFC] New build system

2018-06-14 Thread Josh de Kock
Hi, The current build system is a rather large, and complex monolithic build system. The configure script takes a sizeable amount of time to execute, making improving, and modifying it a pain. It is completely written custom from scratch, while this may not sound terrible it definitely makes

Re: [FFmpeg-devel] [RFC][PATCH][Type 2] Revert "doc/developer.texi: Add a code of conduct"

2018-06-10 Thread Josh de Kock
On 2018/05/14 17:50, Derek Buitenhuis wrote: It was never enforced, and there is no documented way to enforce it, rendering it useless. [...] I think this is the best thing to do first. We could always re-add a more 'proper' CoC later, but for now there's no point creating more confusion. I

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-04 Thread Josh de Kock
> On 4 May 2018, at 12:26, Michael Niedermayer wrote: > >> On Fri, May 04, 2018 at 11:03:20AM +0800, Steven Liu wrote: >> >> >>> On 4 May 2018, at 02:00, Jan Ekström wrote: >>> >>> On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: On Thu, May 3, 2018 at 7:50 PM, Alex Converse w

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
On 2018/04/27 0:38, Carl Eugen Hoyos wrote: 2018-04-27 1:28 GMT+02:00, Josh de Kock : On 2018/04/27 0:19, Carl Eugen Hoyos wrote: 2018-04-27 1:08 GMT+02:00, Josh de Kock : The postproc library is only used in a single filter Is libswscale used in more filters? Are you planning to deprecate

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
On 2018/04/27 0:15, James Almer wrote: On 4/26/2018 8:08 PM, Josh de Kock wrote: The postproc library is only used in a single filter, so should be moved into the filter itself if the filter was to stay, but the filter has all of its internal filters now in lavfi itself. (Also it's

Re: [FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
On 2018/04/27 0:19, Carl Eugen Hoyos wrote: 2018-04-27 1:08 GMT+02:00, Josh de Kock : The postproc library is only used in a single filter Is libswscale used in more filters? Are you planning to deprecate it? No, libswscale does not suffer from the same issue of being a secondary filter

[FFmpeg-devel] [PATCH] configure: deprecate libpostproc and pp filter

2018-04-26 Thread Josh de Kock
The postproc library is only used in a single filter, so should be moved into the filter itself if the filter was to stay, but the filter has all of its internal filters now in lavfi itself. (Also it's a bit weird to have a separate library of filters which is used in a filter in the filter libr

Re: [FFmpeg-devel] [PATCH] avcodec: remove duplicate prores decoder

2018-04-26 Thread Josh de Kock
On 2018/04/26 14:14, Paul B Mahol wrote: Removed slower one, couldn't figure out why it is slower. Signed-off-by: Paul B Mahol --- [...] I agree with this patch in principle (no need to have two decoders which do the same thing), though it might be nice to show some numbers in the commit me

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder

2018-04-26 Thread Josh de Kock
On 2018/04/26 12:26, Carl Eugen Hoyos wrote: 2018-04-26 13:17 GMT+02:00, Josh de Kock : On 2017/06/26 15:09, Paul B Mahol wrote: Rationale: - Slower then other encoder - Less configurable - Does not support alpha profile - Does not set interlaced flag - Worse output quality - No need for 2

Re: [FFmpeg-devel] github

2018-04-26 Thread Josh de Kock
> On 26 Apr 2018, at 12:15, Daniel Oberhoff > wrote: > > Hello, > > I was wondering if there is any chance to move development to github? I.e. > not just mirror, but as primary development repo, with issues and pull > requests? Would make collaboration a *lot* easier (think of submitting a p

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder

2018-04-26 Thread Josh de Kock
On 2017/06/26 15:09, Paul B Mahol wrote: Rationale: - Slower then other encoder - Less configurable - Does not support alpha profile - Does not set interlaced flag - Worse output quality - No need for 2 encoders Signed-off-by: Paul B Mahol Is there any reason this was not pushed? I can't seem

Re: [FFmpeg-devel] [GSoC] FFserver further development direction

2018-04-26 Thread Josh de Kock
On 2018/04/26 11:56, Nicolas George wrote: Josh de Kock (2018-04-26): Generally, adding more things to public API is a bad move I do not accept this statement as is. Please justify it. What I mean by this is making private fields public is generally a bad move. They were initially made

Re: [FFmpeg-devel] [GSoC] FFserver further development direction

2018-04-26 Thread Josh de Kock
On 2018/04/24 22:33, Stephan Holljes wrote: Hi all, I've discussed this on IRC a bit, but I don't want to exclude those views that are not present there. The consensus seems to be that there are more disadvantages in using the http server of libavformat than there are advantages. I honestly t

Re: [FFmpeg-devel] [GSoC] FFserver further development direction

2018-04-26 Thread Josh de Kock
On 2018/04/25 23:18, Nicolas George wrote: Josh de Kock (2018-04-25): If anything, this should have never been added and a suitable external library should have been picked. This opinion should have been expressed three years ago. It was decided then that lavf deserved a HTTP

Re: [FFmpeg-devel] [GSoC] FFserver further development direction

2018-04-25 Thread Josh de Kock
On 2018/04/24 22:46, Nicolas George wrote: Stephan Holljes (2018-04-24): The consensus seems to be that there are more disadvantages in using the http server of libavformat than there are advantages. I completely disagree. There is no point in having the HTTP server in libavformat if it cannot

Re: [FFmpeg-devel] Add IRC nicknames to MAINTAINERS?

2018-04-25 Thread Josh de Kock
On 2018/04/25 9:35, Paul B Mahol wrote: On 4/25/18, Tomas Haerdin wrote: [...] I'll push this this some time later this week if I don't hear any objections What is point of it if there is only one nickname? There are two nicknames. -- Josh ___

Re: [FFmpeg-devel] [PATCH] doc/developer: remove merge request method of contributing

2018-04-06 Thread Josh de Kock
On 2018/04/05 19:17, Lou Logan wrote: This seems to confuse Github users into thinking that we may accept pull requests. We do not accept pull requests. Sending patches to the ffmpeg-devel mailing list is our preferred method for users to contribute code. Signed-off-by: Lou Logan --- doc/dev

Re: [FFmpeg-devel] [PATCH] lavfi, lavd: add gitignore for generated static component lists

2018-04-05 Thread Josh de Kock
On 2018/04/05 22:34, Hendrik Leppkes wrote: On Thu, Apr 5, 2018 at 11:09 PM, Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavdevice/.gitignore | 2 ++ libavfilter/.gitignore | 1 + 2 files changed, 3 insertions(+) create mode 100644 libavdevice/.gitignore create mode 100644

[FFmpeg-devel] [PATCH] lavfi, lavd: add gitignore for generated static component lists

2018-04-05 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavdevice/.gitignore | 2 ++ libavfilter/.gitignore | 1 + 2 files changed, 3 insertions(+) create mode 100644 libavdevice/.gitignore create mode 100644 libavfilter/.gitignore diff --git a/libavdevice/.gitignore b/libavdevice/.gitignore new file mode 100644

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-05 Thread Josh de Kock
On 2018/04/02 18:53, mi...@brew.sh wrote: segafilm muxer Thanks, pushed. I also clarified with wm4 on IRC that while he was against it he wasn't blocking the muxer if someone else pushes it. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread Josh de Kock
> On 2 Apr 2018, at 14:16, James Almer wrote: > >> On 4/2/2018 10:13 AM, Josh de Kock wrote: >> --- >> Changelog | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Changelog b/Changelog >> index 200866d873..f0b51ad1ee 100644 >>

[FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread Josh de Kock
--- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 200866d873..f0b51ad1ee 100644 --- a/Changelog +++ b/Changelog @@ -52,6 +52,8 @@ version : - E-AC-3 dependent frames support - bitstream filter for extracting E-AC-3 core - Haivision SRT protocol via

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-02 Thread Josh de Kock
On 2018/04/02 3:56, mi...@brew.sh wrote: From: Misty De Meo [...] --- /dev/null +++ b/libavformat/segafilmenc.c @@ -0,0 +1,397 @@ +/* + * Sega FILM Format (CPK) Muxer + * Copyright (C) 2003 The FFmpeg project I assume you copied the demuxer but shouldn't you be here as well? + * + * This fil

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread Josh de Kock
On 2018/04/02 2:40, wm4 wrote: On Sun, 1 Apr 2018 03:39:40 +0100 Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95

Re: [FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-04-01 Thread Josh de Kock
On 2018/04/01 3:39, Josh de Kock wrote: Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95..cf430a9680 100644 --- a/libavformat/allformats.c +++ b

Re: [FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

2018-04-01 Thread Josh de Kock
On 2018/04/01 16:14, James Almer wrote: [...] > LGTM. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] cmdutils: fix new API break the "ffmpeg -muxers/demuxers"

2018-04-01 Thread Josh de Kock
On 2018/04/02 0:07, Jun Zhao wrote: [...] Thanks, pushed. I thought I had checked this, obviously not. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavdevice/alldevices.c | 1 + libavformat/allformats.c | 1 + libavformat/avformat.h | 2 -- libavformat/internal.h | 1 + 4 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index ebf95f8a81

[FFmpeg-devel] [PATCH 5/6] Revert "avformat/format: temporarily use old next api"

2018-03-31 Thread Josh de Kock
This reverts commit 909e00ae816df9b6a05b1c4d0cafb794d4d0ca28. There is no need to use the old API anymore as the new API now behaves in the same way (treating devices as formats when loaded). Signed-off-by: Josh de Kock --- libavformat/format.c | 19 --- 1 file changed, 4

[FFmpeg-devel] [PATCH 4/6] lav*, tests: remove several register_all calls

2018-03-31 Thread Josh de Kock
avdevice_register_all() is still required to register devices into lavf (this is required due to lavd being somewhat of a hack). Signed-off-by: Josh de Kock --- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc

[FFmpeg-devel] [PATCH 6/6] lavf/format: use const AVInputFormat for iteration

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/format.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/format.c b/libavformat/format.c index 1b2ce22e25..1c66afb7e6 100644 --- a/libavformat/format.c +++ b/libavformat/format.c @@ -117,11 +117,11 @@ enum

[FFmpeg-devel] [PATCH 2/6] lavf/img2dec: use new iteration API

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/img2dec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..5fda850e7d 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -323,7 +323,8 @@ int

[FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95..cf430a9680 100644 --- a/libavformat/allformats.c +++ b/libavformat/allformats.c @@ -493,7 +493,7

[FFmpeg-devel] [PATCH 3/4] lavf: move avpriv function definition to internal.h

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/avformat.h | 2 -- libavformat/internal.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index ec4e5f45f5..a2fe7c6bb2 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h

[FFmpeg-devel] [PATCH 4/4] lav*, tests: remove several register_all calls

2018-03-31 Thread Josh de Kock
avdevice_register_all() is still required to register devices into lavf (this is required due to lavd being somewhat of a hack). Signed-off-by: Josh de Kock --- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc

[FFmpeg-devel] [PATCH 1/4] lavf/img2dec: use new iteration API

2018-03-31 Thread Josh de Kock
Signed-off-by: Josh de Kock --- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int

[FFmpeg-devel] [PATCH 2/4] Revert "avformat/format: temporarily use old next api"

2018-03-31 Thread Josh de Kock
This reverts commit 909e00ae816df9b6a05b1c4d0cafb794d4d0ca28. There is no need to use the old API anymore as the new API now behaves in the same way (treating devices as formats when loaded). Signed-off-by: Josh de Kock --- libavformat/format.c | 13 + 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-31 Thread Josh de Kock
On 2018/03/25 13:53, Josh de Kock wrote: On 2018/03/23 20:48, Josh de Kock wrote: This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Josh de Kock
On 2018/03/25 16:21, Michael Niedermayer wrote: On Fri, Mar 23, 2018 at 11:05:22AM +0100, Nicolas George wrote: Josh de Kock (2018-03-22): move lavd avinputformats and avoutputformats into lavf delete lavd Possibly ok in principle for me, but see below. write new lavd aimed at actual

Re: [FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-25 Thread Josh de Kock
On 2018/03/23 20:48, Josh de Kock wrote: This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise between what Nicolas George suggested and a

[FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2018-03-24 Thread Josh de Kock
Signed-off-by: Josh de Kock --- configure| 29 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 823 +-- libavfilter/avfilter.c | 50 +-- libavfilter/avfilter.h | 29

Re: [FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.2: add name

2018-03-23 Thread Josh de Kock
On 2018/03/23 13:22, Danil Iashchenko wrote: Thanks, fixed! --- libavfilter/opencl/convolution.cl | 2 ++ libavfilter/vf_convolution_opencl.c | 2 ++ 2 files changed, 4 insertions(+) When you update patches you should send the same patch again (yes the whole patch) with the required cha

[FFmpeg-devel] [PATCH v2 2/5] lavfi: add new iteration API

2018-03-23 Thread Josh de Kock
Signed-off-by: Josh de Kock --- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 820 +-- libavfilter/avfilter.c | 50 +-- libavfilter/avfilter.h | 29

[FFmpeg-devel] [PATCH 4/5] lavd: remove linked lists

2018-03-23 Thread Josh de Kock
--- configure| 23 +++-- libavdevice/alldevices.c | 87 ++-- libavformat/allformats.c | 78 +-- libavformat/avformat.h | 2 ++ 4 files changed, 120 insertions(+), 70 deletions(-) diff --

[FFmpeg-devel] [PATCH 3/5] Revert "lavd: add new API for iterating input and output devices"

2018-03-23 Thread Josh de Kock
This reverts commit 0fd475704e871ef3a535947596a012894bae3cbd. Revert "lavd: fix iterating of input and output devices" This reverts commit ce1d77a5e7cebce11074bf6f9e38ad6da37338ff. --- Makefile | 3 +- configure| 23 +++--- doc/APIchanges | 5 -- li

[FFmpeg-devel] [PATCH 5/5] cmdutils: use new APIs

2018-03-23 Thread Josh de Kock
--- fftools/cmdutils.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index c0ddf0b287..a6cf002fd0 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1259,8 +1259,10 @@ static int is_device(const AVClass *avcla

[FFmpeg-devel] [PATCH 1/5] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-23 Thread Josh de Kock
--- tests/checkasm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 0520e264e2..ae7e810d25 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -61,7 +61,7 @@ tests/checkasm/checkasm.o: CFLAGS += -

  1   2   3   4   >