Re: [FFmpeg-devel] [PATCH] avformat/vqf: fix memory leak in add_metadata()

2025-01-29 Thread Jan Ekström
On Wed, Jan 29, 2025 at 10:21 PM Jan Ekström wrote: > > On Sun, Jan 26, 2025 at 9:41 PM Kacper Michajłow wrote: > > > > Signed-off-by: Kacper Michajłow > > --- > > libavformat/vqf.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avformat/vqf: fix memory leak in add_metadata()

2025-01-29 Thread Jan Ekström
On Sun, Jan 26, 2025 at 9:41 PM Kacper Michajłow wrote: > > Signed-off-by: Kacper Michajłow > --- > libavformat/vqf.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/vqf.c b/libavformat/vqf.c > index 58b1546f53..fbe54739cd 100644 > --- a/libavformat/v

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

2025-01-28 Thread Jan Ekström
On Mon, Jan 27, 2025 at 9:56 PM Jan Ekström wrote: > > On Sat, Jan 25, 2025 at 9:38 PM Jan Ekström wrote: > > > > Found out to have been utilized via a user reporting an attached > > image not being available in a player utilizing avformat's demuxing > > capabi

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-01-28 Thread Jan Ekström
On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer wrote: > > Maybe fixes: 11435 > Do I understand correctly that the root issue that's being attempted to be fixed by the initial patch set is that unusual demuxers were possible to have been probed and opened through the HLS meta demuxer? In that

Re: [FFmpeg-devel] Regarding Git Tooling

2025-01-27 Thread Jan Ekström
On Wed, Jan 22, 2025 at 2:39 PM Nicolas George wrote: > > Marth64 (12025-01-20): > > This is fine and your preferences are understandable. Everyone has > > their tools of choice. > > > > That said, I did try Forgejo on a local instance today without > > JavaScript and it was not a usable experienc

Re: [FFmpeg-devel] [PATCH] avfilter/xpsnr: avoid division by zero

2025-01-27 Thread Jan Ekström
On Mon, Jan 27, 2025 at 9:23 PM Marton Balint wrote: > > > > On Mon, 27 Jan 2025, Gyan Doshi wrote: > > > The ref input may have its frame rate unset, which would then lead to > > SIGFPE. > > > > Related to #11428 > > --- > > libavfilter/vf_xpsnr.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 de

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

2025-01-27 Thread Jan Ekström
On Sat, Jan 25, 2025 at 9:38 PM Jan Ekström wrote: > > Found out to have been utilized via a user reporting an attached > image not being available in a player utilizing avformat's demuxing > capabilities. > --- Asked around in the audio player circles of foobar2000, and thes

[FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

2025-01-25 Thread Jan Ekström
Found out to have been utilized via a user reporting an attached image not being available in a player utilizing avformat's demuxing capabilities. --- libavformat/id3v2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index 3507885706..29ee59e1f4 1006

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-20 Thread Jan Ekström
On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > ff_aom_uninit_film_grain_params() Set LGTM. Thanks for testing/noticing this stuff. I just happened to get an issue reported when someone disabled the HEVC decoder,

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Add option to correct subtitles duration in webvtt subtitles

2024-12-09 Thread Jan Ekström
On Mon, Dec 9, 2024 at 1:24 PM Vladimir Kharchevin wrote: > > When importing text subtitles from libzvbi_teletext stream the duration of > subtitle > frames is -1 by default or fixed value per codec setting. > For hls webvtt stream it makes disappear time always 1193:02:47.295 for every > subtit

Re: [FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-08 Thread Jan Ekström
On Sun, Dec 8, 2024 at 9:23 PM Jan Ekström wrote: > > On Sun, Dec 1, 2024 at 4:21 PM Leo Izen wrote: > > > > The PNGv3 Specification Draft [1] has changed the capitalization > > of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates > > FFmpeg to work

Re: [FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-08 Thread Jan Ekström
On Sun, Dec 1, 2024 at 4:21 PM Leo Izen wrote: > > The PNGv3 Specification Draft [1] has changed the capitalization > of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates > FFmpeg to work with the new chunk names while retaining decode-side > compatibility with files created using

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

2024-12-05 Thread Jan Ekström
On Thu, Nov 28, 2024 at 4:30 PM Anton Khirnov wrote: > > Hi all, > the current Technical Committee (TC) was elected on 2023-12-05 and its > mandate lasts for one year, so we should hold a new election soon. If > there are no unforeseen circumstances, I would like to start the vote on > Monday 2024

[FFmpeg-devel] [PATCH v4 0/3] Initial support for fragmented TTML muxing

2024-10-25 Thread Jan Ekström
improve things are welcome. Jan Jan Ekström (3): tests/fate-run: add support for specifying the final encode muxer in `transcode` avcodec/avpacket: add functionality to prepend to AVPacketLists avformat/movenc: add support for fragmented TTML muxing libavcodec/packet.c

[FFmpeg-devel] [PATCH v4 1/3] tests/fate-run: add support for specifying the final encode muxer in `transcode`

2024-10-24 Thread Jan Ekström
From: Jan Ekström This allows for direct dumping of the packets' contents (useful for text based formats), while getting the timestamps/sizes etc from ffprobe. If used via TRANSCODE, the actually utilized muxer should be added within the last argument as an additional dependency, as that i

[FFmpeg-devel] [PATCH v4 3/3] avformat/movenc: add support for fragmented TTML muxing

2024-10-24 Thread Jan Ekström
From: Jan Ekström Attempts to base the fragmentation timing on other streams as most receivers expect media fragments to be more or less aligned. Currently does not support fragmentation on subtitle track only, as the subtitle packet queue timings would have to be checked in addition to the

[FFmpeg-devel] [PATCH v4 2/3] avcodec/avpacket: add functionality to prepend to AVPacketLists

2024-10-24 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/packet.c | 20 +++- libavcodec/packet_internal.h | 2 ++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/libavcodec/packet.c b/libavcodec/packet.c index 381001fd65..a6302340bb 100644 --- a

Re: [FFmpeg-devel] [PATCH] fate/ffmpeg: add samples requirement to fate-ffmpeg-spec-disposition

2024-10-21 Thread Jan Ekström
On Sun, Oct 20, 2024 at 11:33 PM Jan Ekström wrote: > > This tests utilizes an MPEG-TS sample from FATE suite, yet is > marked as not requiring samples. > > This fixes running `make fate` without SAMPLES being set. > > Reported-by: Sebastian Ramacher > --- Superceded b

Re: [FFmpeg-devel] [PATCH] fate/ffmpeg: add samples dependency to fate-ffmpeg-spec-disposition

2024-10-21 Thread Jan Ekström
On Mon, Oct 21, 2024 at 9:05 PM Jan Ekström wrote: > > On Mon, Oct 7, 2024 at 2:05 AM Emily via ffmpeg-devel > wrote: > > > > From: Emily > > > > --- > > In the NixOS FFmpeg package, we run `make check` without downloading > > the entire FATE suite

Re: [FFmpeg-devel] [PATCH] fate/ffmpeg: add samples dependency to fate-ffmpeg-spec-disposition

2024-10-21 Thread Jan Ekström
On Mon, Oct 7, 2024 at 2:05 AM Emily via ffmpeg-devel wrote: > > From: Emily > > --- > In the NixOS FFmpeg package, we run `make check` without downloading > the entire FATE suite. The FFmpeg 7.1 update broke this, seemingly > because of an undeclared FATE sample dependency. > > This package is m

[FFmpeg-devel] [PATCH] fate/ffmpeg: add samples requirement to fate-ffmpeg-spec-disposition

2024-10-20 Thread Jan Ekström
This tests utilizes an MPEG-TS sample from FATE suite, yet is marked as not requiring samples. This fixes running `make fate` without SAMPLES being set. Reported-by: Sebastian Ramacher --- tests/fate/ffmpeg.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/ffmpe

Re: [FFmpeg-devel] [PATCH] hevc/sei: return INVALIDDATA when a referenced SPS is not available

2024-08-30 Thread Jan Ekström
On Fri, Aug 30, 2024 at 8:40 PM Hendrik Leppkes wrote: > > The code previously returned ENOMEM, despite this not being an > allocation problem, but rather a bitstream problem referring to data not > currently available. > > Fixes playback of such streams, as it allows further processing of NAL > u

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header

2024-08-08 Thread Jan Ekström
On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow wrote: > > Fixes remaining \r\n is ASS header after 57c545090d. > > Signed-off-by: Kacper Michajłow > --- With an initial look this set looks good. If I understand correctly, the generic ASS encoder moved to outputting LF only in 7bf1b9b35769b376

Re: [FFmpeg-devel] [PATCH v2 1/1] fate/png: add mDCv read and write test

2024-07-14 Thread Jan Ekström
h the slight adjustments (image2->image2pipe and updated commit message), the patch can be applied. Jan On Tue, Jul 9, 2024 at 7:45 PM Leo Izen wrote: > > This test confirms that we can write mDCv chunks and read them back via > the png decoder. It uses an HEVC conformance sam

Re: [FFmpeg-devel] [PATCH 1/3] avutil/ambient_viewing_environment: set a sane default value for AVRational fields

2024-06-21 Thread Jan Ekström
On Thu, Jun 20, 2024 at 6:54 PM James Almer wrote: > > On 6/18/2024 4:20 PM, James Almer wrote: > > Prevent potential divisions by 0 when using them immediately after > > allocation. > > > > Signed-off-by: James Almer > > --- > > libavutil/ambient_viewing_environment.c | 10 ++ > > 1

Re: [FFmpeg-devel] [PATCH v2 1/6] lavf/tls_mbedtls: handle more error codes for

2024-06-03 Thread Jan Ekström
On Wed, May 29, 2024 at 2:05 PM sfan5 wrote: > Did an initial tired look at the set, and in general it looks alright and the wrapper still builds with Fedora's mbedtls 2.28.8. (Of course then it fails to link due to unchecked usage of `mbedtls_x509_crt_{init,free,parse_file}` in tls_mbedtls, as

Re: [FFmpeg-devel] [PATCH v5 01/10] channel_layout: add new channel positions supported by xHE-AAC

2024-05-31 Thread Jan Ekström
On Thu, May 30, 2024 at 5:39 AM Lynne via ffmpeg-devel wrote: > > apichanges will be updated upon merging, as well as a version bump. > --- > libavutil/channel_layout.c | 4 > libavutil/channel_layout.h | 8 > 2 files changed, 12 insertions(+) > > diff --git a/libavutil/channel_layo

[FFmpeg-devel] FFmpeg, zlib based modules' FATE tests expecting bit-exact and Fedora switching to zlib-ng

2024-05-10 Thread Jan Ekström
Hi, As of Fedora 40, the zlib provider has been switched to zlib-ng (https://fedoraproject.org/wiki/Changes/ZlibNGTransition). This has reared the ugly fact that we expect that the usage of zlib APIs is bit-exact. Some of these tests such as copy-apng that only do remux can be moved from transcod

Re: [FFmpeg-devel] [PATCH] avcodec/riscv/vp9dsp: Fix inclusion guard

2024-04-29 Thread Jan Ekström
On Mon, Apr 29, 2024 at 9:33 PM Andreas Rheinhardt wrote: > > Fixes fate-source. > > Signed-off-by: Andreas Rheinhardt > --- > I intend to apply this soon. Verified that this fixes fate-source, LGTM. Thanks for noticing this. Jan ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] configure: Fix typo

2024-04-22 Thread Jan Ekström
On Mon, Apr 22, 2024 at 3:34 PM Xiang, Haihao wrote: > > From: Haihao Xiang > > Otherwise there are link errors: > LD ffprobe_g > /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to > `ff_dovi_rpu_generate' > /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to > `ff_dovi_

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-03 Thread Jan Ekström
On Tue, Apr 2, 2024 at 8:58 PM Jan Ekström wrote: > > On Mon, Apr 1, 2024 at 2:34 PM Jan Ekström wrote: > > > > On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > > > > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > > &g

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-02 Thread Jan Ekström
On Mon, Apr 1, 2024 at 2:34 PM Jan Ekström wrote: > > On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi > >

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-04-01 Thread Jan Ekström
On Fri, Mar 29, 2024 at 8:32 PM Jan Ekström wrote: > > On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi > > Profile 5. Profile 5 can thus now be represented in VUI as > > {AVCO

Re: [FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-03-29 Thread Jan Ekström
On Fri, Mar 29, 2024 at 2:33 AM Jan Ekström wrote: > > * SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi > Profile 5. Profile 5 can thus now be represented in VUI as > {AVCOL_RANGE_JPEG, AVCOL_PRI_BT2020, AVCOL_TRC_SMPTE2084, >AVCOL_SPC_IPT_C2, AVCHROMA_LOC_

[FFmpeg-devel] [PATCH 4/4] avcodec/libx265: do not arbitrarily limit color values

2024-03-28 Thread Jan Ekström
Newer specifications such as H.273 have, and probably will further in the future add new values to these, so - instead of trying to update these limits - we should simply check if the values are not set to the value of "unspecified". This should allow newer avutil values such as IPT-C2 or YCgCo-R

[FFmpeg-devel] [PATCH 3/4] avfilter/{buffersrc, vf_setparams}: map IPT-C2, YCgCo-R variants

2024-03-28 Thread Jan Ekström
--- libavfilter/buffersrc.c| 3 +++ libavfilter/vf_setparams.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index ddcd403785..680eedf25b 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -337,12 +337,15 @@ static

[FFmpeg-devel] [PATCH 1/4] avutil/pix{desc, fmt}: add new matrix coefficients from H.273 v3

2024-03-28 Thread Jan Ekström
* SMPTE ST 2128 IPT-C2 defines the coefficients utilized in DoVi Profile 5. Profile 5 can thus now be represented in VUI as {AVCOL_RANGE_JPEG, AVCOL_PRI_BT2020, AVCOL_TRC_SMPTE2084, AVCOL_SPC_IPT_C2, AVCHROMA_LOC_LEFT} (although other chroma sample locations are allowed). AVCOL_TRC_SMPTE20

[FFmpeg-devel] [PATCH 2/4] avcodec/options_table: map IPT-C2, YCgCo-R variants in colorspace

2024-03-28 Thread Jan Ekström
--- libavcodec/options_table.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 7a2ef3474e..7a70fa7b6c 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -331,8 +331,11 @@ static const AVOption avcodec_opt

Re: [FFmpeg-devel] [PATCH] tests: Remove fate-libx265-hdr10

2024-03-22 Thread Jan Ekström
On Fri, Mar 22, 2024 at 10:18 PM Anton Khirnov wrote: > > Quoting Zhao Zhili (2024-03-22 13:43:43) > > From: Zhao Zhili > > > > The test depends on the compile option of x265. It failed when > > HIGH_BIT_DEPTH isn't enabled. It also failed when asan is enabled > > because of memory issue inside o

Re: [FFmpeg-devel] [PATCH 5/5] avutil/frame: Use av_realloc_array(), improve overflow check

2024-03-22 Thread Jan Ekström
On Fri, Mar 22, 2024 at 4:41 PM Andreas Rheinhardt wrote: > > Also use sizeof of the proper type, namely sizeof(**sd) > and not sizeof(*sd). > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/frame.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavutil/fra

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Don't call frame_data twice

2024-03-22 Thread Jan Ekström
On Fri, Mar 22, 2024 at 6:07 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_enc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c > index f01be1c22f..5f7fcf8a5f 100644 > --- a/fftools/ffmpeg_enc.c > ++

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/libx265: encode dovi RPUs

2024-03-20 Thread Jan Ekström
On Wed, Mar 20, 2024 at 9:30 PM Michael Niedermayer wrote: > > On Tue, Mar 19, 2024 at 08:16:42PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > libx265 supports these natively, we just need to forward them to the > > x265picture. > > --- > > libavcodec/libx265.c | 11 +++ > > 1

Re: [FFmpeg-devel] [PATCH v10 00/14] encoder AVCodecContext configuration side data

2024-03-20 Thread Jan Ekström
On Wed, Mar 20, 2024 at 7:00 PM James Almer wrote: > > On 3/18/2024 6:31 PM, Jan Ekström wrote: > > Differences to v9: > > 1. rebased on top of current master > > 2. renamed the avctx AVFrameSideData array according to Anton's naming > > sense, > > as

[FFmpeg-devel] [PATCH v10 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89

[FFmpeg-devel] [PATCH v10 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a F

[FFmpeg-devel] [PATCH v10 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE test

[FFmpeg-devel] [PATCH v10 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-18 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index c9a12af139

[FFmpeg-devel] [PATCH v10 10/14] avcodec: add frame side data array to AVCodecContext

2024-03-18 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 13 + libavcodec/options.c | 2 ++ libavcodec/version.h | 4 ++-- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges ind

[FFmpeg-devel] [PATCH v10 09/14] {avutil/version, APIchanges}: bump, document new AVFrameSideData functions

2024-03-18 Thread Jan Ekström
--- doc/APIchanges | 5 + libavutil/version.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index a44c8e4f10..4f906432d5 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,11 @@ The last version increases of all libraries we

[FFmpeg-devel] [PATCH v10 08/14] avutil/frame: add helper for getting side data from array

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 922185b823..e8dfd4d926 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@ in

[FFmpeg-devel] [PATCH v10 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-18 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9d3eae4bae..922185b823 100644

[FFmpeg-devel] [PATCH v10 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index e4c2fa4f6a..9d3eae4bae 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -98,6

[FFmpeg-devel] [PATCH v10 05/14] avutil/frame: add helper for adding side data to array

2024-03-18 Thread Jan Ekström
ibavutil/tests/side_data_array.c new file mode 100644 index 00..793a62c009 --- /dev/null +++ b/libavutil/tests/side_data_array.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it unde

[FFmpeg-devel] [PATCH v10 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-18 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 382e1f6d58..2a319adb86 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.

[FFmpeg-devel] [PATCH v10 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..382e1f6d58 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef *av_frame_get_plane_buffe

[FFmpeg-devel] [PATCH v10 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void frame_side_data_wipe(AVFram

[FFmpeg-devel] [PATCH v10 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-18 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++ b/libavutil/fram

[FFmpeg-devel] [PATCH v10 00/14] encoder AVCodecContext configuration side data

2024-03-18 Thread Jan Ekström
so be utilized to list handled side data from f.ex. `ffmpeg -h encoder=libsvtav1`. Jan Jan Ekström (14): avutil/frame: split side data list wiping out to non-AVFrame function avutil/frame: add helper for freeing arrays of side data avutil/frame: split side_data_from_buf to base and AVFr

[FFmpeg-devel] [PATCH v9 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-17 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89

[FFmpeg-devel] [PATCH v9 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-17 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a F

[FFmpeg-devel] [PATCH v9 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-17 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE test

[FFmpeg-devel] [PATCH v9 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-17 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index c9a12af139..c8d

[FFmpeg-devel] [PATCH v9 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-03-17 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 31 +++ libavcodec/avcodec.h | 21 + 2 files changed, 52 insertions(+) diff --git a/libavcodec

[FFmpeg-devel] [PATCH v9 09/14] avcodec: add frame side data array to AVCodecContext

2024-03-17 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 12 libavcodec/options.c | 2 ++ 2 files changed, 14 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 554501aa44..550df0e589 100644 --- a/libavcodec/avcodec.h +++ b/li

[FFmpeg-devel] [PATCH v9 08/14] avutil/frame: add helper for getting side data from array

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 30db83a5e5..47ecd964b8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@ in

[FFmpeg-devel] [PATCH v9 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-17 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 46f976a3ed..30db83a5e5 100644

[FFmpeg-devel] [PATCH v9 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4074391a92..46f976a3ed 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -98,6

[FFmpeg-devel] [PATCH v9 05/14] avutil/frame: add helper for adding side data to array

2024-03-17 Thread Jan Ekström
data_set.c new file mode 100644 index 00..793a62c009 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the te

[FFmpeg-devel] [PATCH v9 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-17 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9ebe830c5c..dd27456031 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.

[FFmpeg-devel] [PATCH v9 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..9ebe830c5c 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef *av_frame_get_plane_buffe

[FFmpeg-devel] [PATCH v9 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-17 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void frame_side_data_wipe(AVFram

[FFmpeg-devel] [PATCH v9 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-17 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++ b/libavutil/fram

[FFmpeg-devel] [PATCH v9 00/14] encoder AVCodecContext configuration side data

2024-03-17 Thread Jan Ekström
hould have handled_side_data list, so that if format specific generic logic is added, it could be checked whether the codec itself handles this side data? This could also be utilized to list handled side data from f.ex. `ffmpeg -h encoder=libsvtav1`. Jan Jan Ekström (14): avutil/frame:

[FFmpeg-devel] [PATCH v8 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-11 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 88

[FFmpeg-devel] [PATCH v8 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-11 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a F

[FFmpeg-devel] [PATCH v8 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-11 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE test

[FFmpeg-devel] [PATCH v8 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-11 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index bdba50df03..5ec

[FFmpeg-devel] [PATCH v8 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-03-11 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 30 ++ libavcodec/avcodec.h | 21 + 2 files changed, 51 insertions(+) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH v8 09/14] avcodec: add frame side data array to AVCodecContext

2024-03-11 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 21fc74707f..432a3fd153 100644 --- a/libavcodec/avcodec.h +++ b/libavcod

[FFmpeg-devel] [PATCH v8 08/14] avutil/frame: add helper for getting side data from array

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 30db83a5e5..47ecd964b8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@ in

[FFmpeg-devel] [PATCH v8 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-11 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 46f976a3ed..30db83a5e5 100644

[FFmpeg-devel] [PATCH v8 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4074391a92..46f976a3ed 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -98,6

[FFmpeg-devel] [PATCH v8 05/14] avutil/frame: add helper for adding side data to array

2024-03-11 Thread Jan Ekström
data_set.c new file mode 100644 index 00..793a62c009 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the te

[FFmpeg-devel] [PATCH v8 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-11 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9ebe830c5c..dd27456031 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.

[FFmpeg-devel] [PATCH v8 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..9ebe830c5c 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef *av_frame_get_plane_buffe

[FFmpeg-devel] [PATCH v8 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-11 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void frame_side_data_wipe(AVFram

[FFmpeg-devel] [PATCH v8 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-11 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++ b/libavutil/fram

[FFmpeg-devel] [PATCH v8 00/14] encoder AVCodecContext configuration side data

2024-03-11 Thread Jan Ekström
-h encoder=libsvtav1`. Jan Jan Ekström (14): avutil/frame: split side data list wiping out to non-AVFrame function avutil/frame: add helper for freeing arrays of side data avutil/frame: split side_data_from_buf to base and AVFrame func avutil/frame: split side data removal out to non-AVFram

[FFmpeg-devel] [PATCH v7 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 88

[FFmpeg-devel] [PATCH v7 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a F

[FFmpeg-devel] [PATCH v7 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-02-29 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE test

[FFmpeg-devel] [PATCH v7 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-02-29 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index bdba50df03..e39

[FFmpeg-devel] [PATCH v7 10/14] avcodec: add helper for configuring AVCodecContext's frame side data

2024-02-29 Thread Jan Ekström
This allows API clients that wish to configure multiple entries at a time to do so without writing the looping code themselves. --- libavcodec/avcodec.c | 30 ++ libavcodec/avcodec.h | 20 2 files changed, 50 insertions(+) diff --git a/libavcodec/a

[FFmpeg-devel] [PATCH v7 09/14] avcodec: add frame side data array to AVCodecContext

2024-02-29 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- libavcodec/avcodec.h | 8 libavcodec/options.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 43859251cc..411f4caad3 100644 --- a/libavcodec/avcodec.h +++ b/libavcod

[FFmpeg-devel] [PATCH v7 08/14] avutil/frame: add helper for getting side data from array

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 3a2084d1ca..fd4b53f9ff 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -940,16 +940,26 @@ in

[FFmpeg-devel] [PATCH v7 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-02-29 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 57 +++ libavutil/frame.h | 20 + 2 files changed, 58 insertions(+), 19 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 99c9ce4119..3a2084d1ca 100644

[FFmpeg-devel] [PATCH v7 06/14] avutil/frame: add helper for adding existing side data to array

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 19 ++ 2 files changed, 68 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index d9741240e7..99c9ce4119 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -110,6

[FFmpeg-devel] [PATCH v7 05/14] avutil/frame: add helper for adding side data to array

2024-02-29 Thread Jan Ekström
e 100644 index 00..7ef99db3d2 --- /dev/null +++ b/libavutil/tests/side_data_set.c @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2023 Jan Ekström + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser

[FFmpeg-devel] [PATCH v7 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-02-29 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 5d30887ec9..788999bdeb 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.

[FFmpeg-devel] [PATCH v7 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-02-29 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 615dcb1b83..5d30887ec9 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -787,23 +787,23 @@ FF_ENABLE_DEPRECATION_WARNINGS r

  1   2   3   4   5   6   7   8   9   10   >