On Fri, Mar 22, 2024 at 10:18 PM Anton Khirnov <an...@khirnov.net> wrote: > > Quoting Zhao Zhili (2024-03-22 13:43:43) > > From: Zhao Zhili <zhiliz...@tencent.com> > > > > The test depends on the compile option of x265. It failed when > > HIGH_BIT_DEPTH isn't enabled. It also failed when asan is enabled > > because of memory issue inside of x265, which I don't think can > > be fixed within FFmpeg. > > I suggested some time ago we should mark x265 as experimental. It didn't > receive much enthusiasm, and some probably considered it a joke, but I > was mostly serious. It has major memory safety issues that have been > ignored for years. >
Yea, I recall when I was testing my patch set with valgrind about half a year ago, some of the memory issues showed up there as well. The problem being that most users are happily oblivious to these issues as long as the piece of software "seems to work". Which is a line that x265 does cross. Thus at least on my side the reason for not much enthusiasm for marking it experimental at this point came from it being on the output side (and thus not handling random input/being a parser) as well as it most likely receiving much less understanding from users than just complaints about command lines which had worked for ages suddenly breaking. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
