On 6/3/20 4:19 PM, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes:
> 22692/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5678686190960640
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by:
On 5/2/20 2:08 PM, Michael Niedermayer wrote:
> Fixes: shift exponent 32 is too large for 32-bit type 'int'
> Fixes:
> 21647/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5686168323883008
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/
On 4/18/20 10:32 AM, Carl Eugen Hoyos wrote:
> Am Sa., 18. Apr. 2020 um 19:31 Uhr schrieb David Bryant :
>> On 4/18/20 9:49 AM, Carl Eugen Hoyos wrote:
>>> Am Sa., 18. Apr. 2020 um 17:36 Uhr schrieb David Bryant :
>>>> As suggested in another thread, I have c
On 4/18/20 9:49 AM, Carl Eugen Hoyos wrote:
> Am Sa., 18. Apr. 2020 um 17:36 Uhr schrieb David Bryant :
>> As suggested in another thread, I have created a WavPack DSD test file that
>> exercises all three of the DSD modes (fast, high, and copy).
>>
>> If someone would
: 74b2181f3e9829d9a5b98edd037984ac)
decoded MD5 (f32le): a3a88bba95f809025dce01ecb9064091
Thanks!
-David Bryant
From 8e11e2068f1e763c46903d52da6489cb360b8f8e Mon Sep 17 00:00:00 2001
From: David Bryant
Date: Fri, 17 Apr 2020 15:48:05 -0700
Subject: [PATCH] tests/fate/wavpack: add a lossless DSD file
On 4/5/20 1:32 PM, Anton Khirnov wrote:
> They are not forbidden by the specification.
> ---
> libavformat/wvdec.c | 18 --
> 1 file changed, 18 deletions(-)
>
> diff --git a/libavformat/wvdec.c b/libavformat/wvdec.c
> index b9fc6a59f9..4159bf1253 100644
> --- a/libavformat/wvdec.c
On 4/2/20 11:32 PM, Anton Khirnov wrote:
> Quoting David Bryant (2020-04-03 07:14:21)
>> On 4/2/20 2:13 AM, Anton Khirnov wrote:
>>> Quoting David Bryant (2020-04-01 23:35:13)
>>>> On 3/31/20 2:47 AM, Anton Khirnov wrote:
>>>>>>> Looking at wav
On 4/5/20 1:32 PM, Anton Khirnov wrote:
> Fix invalid memory access on DSD streams with changing channel count.
> ---
> libavcodec/wavpack.c | 122 +++
> 1 file changed, 90 insertions(+), 32 deletions(-)
>
> diff --git a/libavcodec/wavpack.c b/libavcodec/wav
On 4/2/20 2:13 AM, Anton Khirnov wrote:
> Quoting David Bryant (2020-04-01 23:35:13)
>> On 3/31/20 2:47 AM, Anton Khirnov wrote:
>>>>> Looking at wavpack, the code looks suspicious to me. You allocate one
>>>>> dsdctx per channel at init, but AFAIU the numb
On 3/31/20 2:47 AM, Anton Khirnov wrote:
> Quoting David Bryant (2020-03-28 21:22:40)
>> On 3/28/20 6:23 AM, Anton Khirnov wrote:
>>> Quoting David Bryant (2020-03-27 23:51:19)
>>>> On 3/27/20 5:57 AM, Anton Khirnov wrote:
>>>>> The current design, wher
t every WavPack block
>> encountered as invalid data (unless the WavPack stream is to be
>> discarded (i.e. the streams discard is >= AVDISCARD_ALL)) and try to
>> resync to the next level 1 element.
>>
>> Luckily, the WavPack version is currently not really important;
On 3/28/20 6:23 AM, Anton Khirnov wrote:
> Quoting David Bryant (2020-03-27 23:51:19)
>> On 3/27/20 5:57 AM, Anton Khirnov wrote:
>>> The current design, where
>>> - proper init is called for the first per-thread context
>>> - first thread's private dat
On 3/27/20 5:57 AM, Anton Khirnov wrote:
> The current design, where
> - proper init is called for the first per-thread context
> - first thread's private data is copied into private data for all the
> other threads
> - a "fixup" function is called for all the other threads to e.g.
> allocate d
On 3/23/20 9:49 AM, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-03-20 21:50:18)
>> On Fri, Mar 20, 2020 at 10:18:49AM +0100, Anton Khirnov wrote:
>>> Quoting Michael Niedermayer (2020-03-20 01:03:36)
Fixes: out of array access
Fixes:
21193/clusterfuzz-testcase-minimized
On 3/20/20 1:54 AM, Paul B Mahol wrote:
> lgtm
Looks good to me too, sorry about that!
>
> On 3/20/20, Michael Niedermayer wrote:
>> Fixes: out of array access
>> Fixes:
>> 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720
>>
>> Found-by: continuous fuzzing
valgrind. Also, essentially the same DSD decoder has been extensively fuzzed on
OSS-Fuzz because WavPack is also part of that
project now.
Kind regards,
David
From 5d033a4628bdaa13694c5df88b185e7b099bfea5 Mon Sep 17 00:00:00 2001
From: David Bryant
Date: Mon, 9 Mar 2020 15:23:53 -0700
Subject
On 7/31/19 11:49 PM, Paul B Mahol wrote:
> Hi,
>
> patches attached.
>
> This time DSD decoding is approx %50 faster on old Celeron N3050 CPUs and 2
> threads.
I see about 42% speedup on Core Duo E8400 (36x to 52x) for a 5-channel file.
On the same file encoded in DST, the improvement almost disa
On 7/30/19 1:43 AM, Carl Eugen Hoyos wrote:
> Am So., 28. Juli 2019 um 23:35 Uhr schrieb Paul B Mahol :
>> Hi,
>>
>> patch attached.
> As just posted on irc:
> On an 8-core Intel cpu, this makes decoding slower by a factor two,
> heating the cpu
> ten times as much, on a multi-core powerpc, decodi
On 7/28/19 10:27 AM, Paul B Mahol wrote:
> On Sun, Jul 28, 2019 at 6:02 AM David Bryant wrote:
>
>> On 7/24/19 12:26 AM, Paul B Mahol wrote:
>>> On 7/23/19, David Bryant wrote:
>>>> On 7/23/19 12:47 AM, Paul B Mahol wrote:
>>>>> On 7/23/19, David B
On 7/24/19 12:26 AM, Paul B Mahol wrote:
> On 7/23/19, David Bryant wrote:
>> On 7/23/19 12:47 AM, Paul B Mahol wrote:
>>> On 7/23/19, David Bryant wrote:
>>>> On 7/21/19 11:23 PM, Paul B Mahol wrote:
>>>>> On 7/22/19, David Bryant wrote:
>>
ropriately, but I wanted to leave it
in a working state in case someone wanted to test
it or use it as is in the interim. It has been exhaustively tested and I
believe that it is complete and safe.
Kind regards,
David
> ___
> ffmpeg-devel mailing li
On 7/21/19 5:57 PM, Lynne wrote:
> Jul 22, 2019, 12:03 AM by da...@wavpack.com:
>
>> Hi,
>>
>> As I promised late last year, here is a patch to add a WavPack DSD decoder.
>>
>> Thanks!
>>
>> -David Bryant
>>
>> + unsigned char p
On 7/23/19 12:47 AM, Paul B Mahol wrote:
> On 7/23/19, David Bryant wrote:
>> On 7/21/19 11:23 PM, Paul B Mahol wrote:
>>> On 7/22/19, David Bryant wrote:
>>>> Hi,
>>>>
>>>> As I promised late last year, here is a patch to add a WavPack DSD
&
On 7/21/19 11:23 PM, Paul B Mahol wrote:
> On 7/22/19, David Bryant wrote:
>> Hi,
>>
>> As I promised late last year, here is a patch to add a WavPack DSD decoder.
>>
>> Thanks!
>>
>> -David Bryant
>>
>>
> Please correct me if I'm w
Hi,
As I promised late last year, here is a patch to add a WavPack DSD decoder.
Thanks!
-David Bryant
From d80f4fb59e4afec1e2c539391a7b4484f5ae8436 Mon Sep 17 00:00:00 2001
From: David Bryant
Date: Sun, 21 Jul 2019 15:43:25 -0700
Subject: [PATCH] avcodec: add a WavPack DSD decoder
Signed-off
On 1/6/19 4:43 AM, Carl Eugen Hoyos wrote:
> 2019-01-03 6:19 GMT+01:00, David Bryant :
>> On 12/28/18 3:56 AM, Paul B Mahol wrote:
>>> On 12/24/18, Derek Buitenhuis wrote:
>>>> On 24/12/2018 17:47, David Bryant wrote:
>>>>> I want to do that, but am s
On 12/28/18 3:56 AM, Paul B Mahol wrote:
> On 12/24/18, Derek Buitenhuis wrote:
>> On 24/12/2018 17:47, David Bryant wrote:
>>> I want to do that, but am swamped at work right now, so it will probably
>>> be a few months before I can get to that.
>>>
>>&
On 12/24/18 12:21 AM, Paul B Mahol wrote:
> On 12/24/18, David Bryant wrote:
>> On 11/21/18 9:50 PM, David Bryant wrote:
>>> On 11/20/18 10:58 PM, Peter Ross wrote:
>>>> On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote:
>>>>> Hi,
>&
On 11/21/18 9:50 PM, David Bryant wrote:
> On 11/20/18 10:58 PM, Peter Ross wrote:
>> On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote:
>>> Hi,
>>>
>>> Was made aware of this problem on Kodi:
>>>
>>> https://github.com/xbmc/xbmc/iss
On 11/20/18 10:58 PM, Peter Ross wrote:
> On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote:
>> Hi,
>>
>> Was made aware of this problem on Kodi:
>>
>> https://github.com/xbmc/xbmc/issues/14771
>>
>> I'm going to try to add full WavPa
n Sep 17 00:00:00 2001
From: David Bryant
Date: Tue, 20 Nov 2018 21:00:47 -0800
Subject: [PATCH] detect and error out on WavPack DSD files (which are not
currently supported)
---
libavformat/wvdec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/wvdec.c b/libavformat/wvdec
31 matches
Mail list logo
