Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-13 Thread Carotti, Elias via ffmpeg-devel
On Fri, 2023-10-13 at 16:16 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias via ffmpeg-de

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-11 Thread Carotti, Elias via ffmpeg-devel
Hi Anton, On Tue, 2023-10-10 at 12:54 +0200, Anton Khirnov wrote: > > Quoting Carotti, Elias via ffmpeg-devel (2023-10-02 19:35:09) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > > index 77a9f173b4..4c643c9066 100644 > > --- a/libavcodec/libx264.c > &

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-02 Thread Carotti, Elias via ffmpeg-devel
> Hi, > please find attached a patch to propagate the SSE for a frame into > the > encoder stats. > Since libx264 already provides PSNR values, this is done by basically > inverting the formula to recover the SSE values. > > Would it be possible to also append other values to the errors > vector?

[FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-09-23 Thread Carotti, Elias via ffmpeg-devel
Hi, please find attached a patch to propagate the SSE for a frame into the encoder stats. Since libx264 already provides PSNR values, this is done by basically inverting the formula to recover the SSE values. Would it be possible to also append other values to the errors vector? E.g., libx264 also

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-05 Thread Carotti, Elias via ffmpeg-devel
-Original Message- From: ffmpeg-devel On Behalf Of Stefano Sabatini Sent: Saturday, September 2, 2023 5:45 PM To: ffmpeg-devel@ffmpeg.org Cc: kier...@obe.tv; Carotti, Elias Subject: RE: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_i

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Carotti, Elias via ffmpeg-devel
On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > In particular why are you turning on fast_pskip silently based on a > > completely different setting? > > The patch is fixing the regression introduced by the unconditional > setting of b_fast_pskip. > > Now the question is if

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Carotti, Elias via ffmpeg-devel
Hi -Original Message- From: ffmpeg-devel On Behalf Of Stefano Sabatini Sent: Friday, August 25, 2023 12:01 PM To: FFmpeg development discussions and patches Cc: Stefano Sabatini Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-26 Thread Carotti, Elias
On Mon, 2023-07-24 at 01:27 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > > > sorry to nitpick, but if we have this information

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option

2023-07-11 Thread Carotti, Elias
> +2023-06-21 - xx - lavc 60.23.100 - libx264.c > + Add mb_info option. > Do we actually need the option? If the encoder's caller bothered with adding > the side data, then I'd think it should always be used, otherwise why is it > even there? >I agree, I just thought I had to update t

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option

2023-07-11 Thread Carotti, Elias
> From 5bdb624d8dbcff96493a63f02f68a3961cf72723 Mon Sep 17 00:00:00 2001 > From: Elias Carotti > Date: Tue, 20 Jun 2023 19:29:08 +0200 > Subject: [PATCH 2/2] lavc/libx264: add mb_info option > > Pass the information about unchanged parts of the frame by means of > the AVVideoHint side data. > ---

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-10 Thread Carotti, Elias
On Mon, 2023-07-10 at 08:13 +, Carotti, Elias wrote: > > AVVideoHint is a bad name for something like this. > Could you borrow some wording from graphics and call it > AVVideoDamagedHint or maybe AVVideoChangedAreaHint or a combination > of both? > I'd prefer the for

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-10 Thread Carotti, Elias
-Original Message- From: ffmpeg-devel On Behalf Of Lynne Sent: Sunday, July 9, 2023 3:11 PM To: FFmpeg development discussions and patches Subject: RE: [EXTERNAL][FFmpeg-devel] [PATCH] lavu: add AVVideoHint API CAUTION: This email originated from outside of the organization. Do not cl

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-07-10 Thread Carotti, Elias
-Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Sunday, July 9, 2023 1:05 PM To: ffmpeg-devel@ffmpeg.org Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API CAUTION: This email originated from outside of the organization. Do not click links or o

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-07 Thread Carotti, Elias
On Mon, 2023-07-03 at 15:51 +, Carotti, Elias wrote: > On Sat, 2023-07-01 at 10:33 +0200, Anton Khirnov wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the > > sender > > a

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option

2023-07-03 Thread Carotti, Elias
On Wed, 2023-06-21 at 15:57 +, Carotti, Elias wrote: > Hi all, > please find the second part of the patch set. > Best, > Elias Hi all, please find the second part of the patch, updating libavcodec/libx264.c to use the AVVideoHint side data. This should use the block_size field

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-03 Thread Carotti, Elias
On Sat, 2023-07-01 at 10:33 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Sorry to still nag you, but I just noticed that unlike > v

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-30 Thread Carotti, Elias
On Wed, 2023-06-28 at 14:55 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-26

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-26 Thread Carotti, Elias
On Sat, 2023-06-24 at 13:01 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-22

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-22 Thread Carotti, Elias
On Thu, 2023-06-22 at 10:44 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias

[FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option

2023-06-21 Thread Carotti, Elias
Hi all, please find the second part of the patch set. Best, Elias NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico From 2a

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-21 Thread Carotti, Elias
On Sun, 2023-06-18 at 12:18 +0200, Stefano Sabatini wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On date Monday 2023-06-12 17

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-12 Thread Carotti, Elias
On Mon, 2023-06-12 at 18:23 +1000, Kieran Kunhya wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > > > > Looks good to me otherwise, maybe Michael/Anton or

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-12 Thread Carotti, Elias
the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On date Monday 2023-06-05 15:32:35 +, Carotti, Elias wrote: > > Hi, > > please find attached the patch which I updated according

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-05 Thread Carotti, Elias
sender > and know the content is safe. > > > > On date Monday 2023-05-29 17:56:55 +, Carotti, Elias wrote: > [...] > > From 7cb97ee977197e310a932b2d7a53bf5c6e0e Mon Sep 17 00:00:00 > > 2001 > > From: Elias Carotti > > Date: Wed, 19 Apr 2023 11:

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-29 Thread Carotti, Elias
Hi Stefano, hi all, please find the updated patch according to the suggestions. Now it is possible to specify whether the rectangles refer to the part we want to hint as P_SKIP or to the rest portion of the frame. Best, Elias On Mon, 2023-05-22 at 09:19 +, Carotti, Elias wrote: >

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-22 Thread Carotti, Elias
rm the sender > and know the content is safe. > > > > On date Friday 2023-05-19 10:19:03 +, Carotti, Elias wrote: > > > > Hi again, > > I am sending this patch again (I had missed a check for NULL), > > could > > somebody please have a look at

[FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-05-19 Thread Carotti, Elias
Hi again, I am sending this patch again (I had missed a check for NULL), could somebody please have a look at it?  It is mainly an optimization when the encoder knows in advance that only portions of the whole frame changed and which areas actually did. The patch allows a user to pass down infor

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2023-05-05 Thread Carotti, Elias
Hi all, any chance someone could possibly have a look at this patch, please? Thanks in advance Elias On Wed, 2023-05-03 at 12:27 +, Carotti, Elias wrote: > Sorry to revive an old thread, but I updated the patch for ffmpeg 6 > and > this new patch should address the comments. > S

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2023-05-03 Thread Carotti, Elias
Rothenpieler wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On 17.06.2022 12:59, Carotti, Elias wrote: > > > > > > Yes