On Mon, 2023-07-03 at 15:51 +0000, Carotti, Elias wrote: > On Sat, 2023-07-01 at 10:33 +0200, Anton Khirnov wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the > > sender > > and know the content is safe. > > > > > > > > Sorry to still nag you, but I just noticed that unlike > > video_enc_params, > > you do not store AVVideoRect size in AVVideoHint. This means that > > no new fields can be added to AVVideoRect without an ABI break. > > This > > seems suboptimal, since I do see potential use for per-block > > information. > > > > Hi Anton, > I do agree with you. > Please find the updated (and rebased) patch attached to this email. > > Best, > Elias > > P.S. By the way, I would be tempted (I didn't do that here) to > declare > the block_size field as > > const size_t block_size; > > and then when setting it into av_video_hint_alloc(...) cast away the > const (it has to be assigned only once, upon allocation of the > struct), > just to enforce compiler checking against accidental assignments and > for better clarity that this is a read-only field, in the general > case. > > P.P.S.: I'm sending the second part of the patch for libavcodec as a > separate email.
Hi Anton, Hi Stefano, do you think this solves the issue? Best Elias NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
