Re: [FFmpeg-devel] [PATCH]Two patches from github

2017-05-16 Thread Benoit Fouet
Hi, On 15/05/2017 12:40, Carl Eugen Hoyos wrote: > > 0002-avutil-Use-_SC_NPROCESSORS_CONF.patch > > > From 42766f345dbf398716c6fd9072f072f5fa91c940 Mon Sep 17 00:00:00 2001 > From: Steve Kondik > Date: Tue, 16 Dec 2014 01:37:57 -0800 > Subject: [PATCH 2/2] avutil: Use _SC_NPROCESSORS_CONF > > *

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/simple_idct: separate macro arguments with commas

2017-05-02 Thread Benoit Fouet
Hi, On 28/04/2017 21:58, Matthieu Bouron wrote: > Untested: fixes ticket #6324. > --- > libavcodec/aarch64/simple_idct_neon.S | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/aarch64/simple_idct_neon.S > b/libavcodec/aarch64/simple_idct_neon.S > i

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-21 Thread Benoit Fouet
Hi, On 20/04/2017 18:18, Amine kabab wrote: > From 5079f9b7114589626a4c9fff0fbb8f6e0d2f4fd9 Mon Sep 17 00:00:00 2001 > From: amine kabab > Date: Thu, 20 Apr 2017 15:59:42 + > Subject: [PATCH] HLS skip down streams > > --- > libavformat/hls.c | 14 +- > 1 file changed, 13 inserti

Re: [FFmpeg-devel] [PATCH 1/3] avutil/spherical: add av_spherical_projection_name()

2017-03-30 Thread Benoit Fouet
Hi, On 29/03/2017 04:55, James Almer wrote: > Signed-off-by: James Almer > --- > doc/APIchanges| 3 +++ > libavutil/spherical.c | 15 +++ > libavutil/spherical.h | 9 + > 3 files changed, 27 insertions(+) > [...] > diff --git a/libavutil/spherical.c b/libavutil/s

Re: [FFmpeg-devel] [PATCH 2/2] avformat/apng: set max_fps to no limit by default

2017-03-22 Thread Benoit Fouet
Hi, On 21/03/2017 14:03, James Almer wrote: > On 3/21/2017 9:52 AM, Michael Niedermayer wrote: >> On Mon, Mar 20, 2017 at 11:03:23PM -0300, James Almer wrote: >>> Should fix ticket #6252 >>> >>> Signed-off-by: James Almer >>> --- >>> libavformat/apngdec.c | 2 +- >>> 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCHv3] mov: Evaluate the movie display matrix

2016-10-18 Thread Benoit Fouet
Hi, On 14/10/2016 00:50, Vittorio Giovara wrote: > diff --git a/libavformat/mov.c b/libavformat/mov.c > index a15c8d1..e8da77f 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c [...] > @@ -3798,16 +3804,33 @@ static int mov_read_meta(MOVContext *c, AVIOContext > *pb, MOVAtom atom) >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-17 Thread Benoit Fouet
Hi, On 17/10/2016 02:34, James Almer wrote: > Fixes valgrind warning about "Conditional jump or move depends on > uninitialised value(s)" > > Signed-off-by: James Almer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavf

Re: [FFmpeg-devel] [PATCH] matroskadec: fix NULL pointer dereference

2016-10-17 Thread Benoit Fouet
Hi, On 17/10/2016 06:49, James Almer wrote: On 10/16/2016 9:30 PM, James Almer wrote: On 10/16/2016 5:11 PM, Andreas Cadhalpun wrote: The problem was introduced in commit 1273bc6. Signed-off-by: Andreas Cadhalpun --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

2016-09-23 Thread Benoit Fouet
Hi, On 22/09/2016 23:03, Sophia Wang wrote: Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..936690d 100644 --- a/libavformat/matros

Re: [FFmpeg-devel] [PATCH] avfilter: add nlmeans filter

2016-09-21 Thread Benoit Fouet
Hi, On 20/09/2016 21:52, Clément Bœsch wrote: Fixes Ticket #4910 --- I actually tried to implement the better defaults suggestion from ipol (see @todo) but it wasn't convincing; probably because of different scales, so I need to investigate. Also, integral is still inplace in the filter for no

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Use ptrdiff_t for (bi)width functions

2016-09-21 Thread Benoit Fouet
Hi, On 21/09/2016 03:34, Michael Niedermayer wrote: Might fix some mysterious asm related issues like Ticket5579 Signed-off-by: Michael Niedermayer --- libavcodec/h264dsp.h | 5 +++-- libavcodec/h264dsp_template.c | 4 ++-- libavcodec/mips/h264dsp_mips.h | 26 +---

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec_h264: fix SODB escaping

2016-09-07 Thread Benoit Fouet
Hi, On 06/09/2016 16:53, Matthieu Bouron wrote: From: Matthieu Bouron Fixes escaping of consecutive 0x00, 0x00, 0x0{0-3} sequences. --- libavcodec/mediacodecdec_h264.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mediacodecdec_h264.c b/libavcodec/med

Re: [FFmpeg-devel] [PATCH] lavc/ffjni: replace ff_jni_{attach, detach} with ff_jni_get_env

2016-07-25 Thread Benoit Fouet
Hi, On 24/07/2016 23:05, Matthieu Bouron wrote: From: Matthieu Bouron If a JNI environment is not already attached to the thread where the MediaCodec calls are made the current implementation will attach / detach an environment for each MediaCodec call wasting some CPU time. ff_jni_get_env rep

Re: [FFmpeg-devel] [PATCH] lavc/mediacodec: add hwaccel support

2016-07-08 Thread Benoit Fouet
On 08/07/2016 15:40, Matthieu Bouron wrote: On Fri, Jul 08, 2016 at 01:21:48PM +0200, Benoit Fouet wrote: Hi, On 07/07/2016 17:43, Matthieu Bouron wrote: [...] 0001-lavc-add-mediacodec-hwaccel-support.patch From 9bb86990f0f7a26d25878a771f5977ae83d14769 Mon Sep 17 00:00:00 2001 From

Re: [FFmpeg-devel] [PATCH] lavc/mediacodec: add hwaccel support

2016-07-08 Thread Benoit Fouet
Hi, On 07/07/2016 17:43, Matthieu Bouron wrote: [...] 0001-lavc-add-mediacodec-hwaccel-support.patch From 9bb86990f0f7a26d25878a771f5977ae83d14769 Mon Sep 17 00:00:00 2001 From: Matthieu Bouron Date: Fri, 11 Mar 2016 17:21:04 +0100 Subject: [PATCH] lavc: add mediacodec hwaccel support ---

Re: [FFmpeg-devel] [PATCH] mediacodecdec_h264: properly convert extradata to annex-b

2016-07-05 Thread Benoit Fouet
Hi, On 04/07/2016 10:12, Matthieu Bouron wrote: From: Matthieu Bouron H264ParamSets has its SPS/PPS stored raw (SODB) and needs to be converted to NAL units before sending them to MediaCodec. This patch adds the missing convertion of the SPS/PPS from SOBP to RBSP which makes the resulting NAL

Re: [FFmpeg-devel] [PATCH] H264ParamSets: make sps const

2016-06-30 Thread Benoit Fouet
Hi, On 27/06/2016 14:37, Benoit Fouet wrote: Hi, First patch change decode_scaling_matrices function, so that it does not affect the SPS structure it gets, and marks SPS and PPS const in its arguments. Second patch straightens the check for macroblock sizes in

Re: [FFmpeg-devel] [PATCH] git: ignore test binaries

2016-06-29 Thread Benoit Fouet
Hi, On 29/06/2016 17:57, Clément Bœsch wrote: On Wed, Jun 29, 2016 at 05:54:37PM +0200, Benoit Fouet wrote: From e514644033781cb431641ae088482f5a8aa2de42 Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Wed, 29 Jun 2016 17:53:50 +0200 Subject: [PATCH] git: ignore test binaries

[FFmpeg-devel] [PATCH] git: ignore test binaries

2016-06-29 Thread Benoit Fouet
From e514644033781cb431641ae088482f5a8aa2de42 Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Wed, 29 Jun 2016 17:53:50 +0200 Subject: [PATCH] git: ignore test binaries --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 524fb73..670d1d2 100644

Re: [FFmpeg-devel] [PATCH] H264ParamSets: make sps const

2016-06-28 Thread Benoit Fouet
Hi, On 27/06/2016 14:37, Benoit Fouet wrote: Hi, First patch change decode_scaling_matrices function, so that it does not affect the SPS structure it gets, and marks SPS and PPS const in its arguments. Second patch straightens the check for macroblock sizes in

Re: [FFmpeg-devel] [PATCH 1/3] h264_ps: change decode_scaling_matrices so that it takes

2016-06-28 Thread Benoit Fouet
Hi, On 27/06/2016 18:31, Michael Niedermayer wrote: On Mon, Jun 27, 2016 at 02:38:50PM +0200, Benoit Fouet wrote: h264_ps.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) ea8cc471972e1dbaa4f4f03cd7a5fe92a3b848e9 0001-h264_ps-change-decode_scaling_matrices-so-that-it

[FFmpeg-devel] [PATCH 3/3] h264: make H264ParamSets sps const

2016-06-27 Thread Benoit Fouet
From 735362df589eb5f8b05063c56862ff18589475ad Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Tue, 21 Jun 2016 14:17:13 +0200 Subject: [PATCH 3/3] h264: make H264ParamSets sps const --- libavcodec/h264.h| 3 +-- libavcodec/h264_parser.c | 2 +- libavcodec/h264_ps.c | 4

[FFmpeg-devel] [PATCH 2/3] h264: straighten dimensions check

2016-06-27 Thread Benoit Fouet
From 91b000bf2e0b01695803c5ef98cfb06590f5f409 Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Mon, 27 Jun 2016 13:31:21 +0200 Subject: [PATCH 2/3] h264: straighten dimensions check ff_h264_decode_seq_parameter_set The MBS only flag was not taken into account when checking macroblock

[FFmpeg-devel] [PATCH 1/3] h264_ps: change decode_scaling_matrices so that it takes

2016-06-27 Thread Benoit Fouet
From c2606da98ecd04762305734f4f45ca8eaf266459 Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Mon, 27 Jun 2016 12:00:39 +0200 Subject: [PATCH 1/3] h264_ps: change decode_scaling_matrices so that it takes const {s,p}ps In order to be able to make SPS const in H264ParamSets, modify

[FFmpeg-devel] [PATCH] H264ParamSets: make sps const

2016-06-27 Thread Benoit Fouet
Hi, First patch change decode_scaling_matrices function, so that it does not affect the SPS structure it gets, and marks SPS and PPS const in its arguments. Second patch straightens the check for macroblock sizes in ff_h264_decode_seq_parameter_set and removes the unneeded check in H.264 sl

Re: [FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

2016-06-27 Thread Benoit Fouet
Hi, On 25/06/2016 14:15, Clément Bœsch wrote: On Fri, Jun 24, 2016 at 09:20:35AM +0200, Benoit Fouet wrote: [...] Any objection to this patch now? iam ok with the patch, maybe give others a bit of time to reply before applying though Yeah, I'm in no hurry, I just saw this FIXME i

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: drop people who do not appear in git history > 2013

2016-06-24 Thread Benoit Fouet
thieu Bouron + aiffdec.c Matthieu Bouron + aiffenc.c Matthieu Bouron apngdec.c Benoit Fouet - ass* Aurelien Jacobs astdec.c Paul B

Re: [FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

2016-06-24 Thread Benoit Fouet
Hi, On 23/06/2016 22:37, Michael Niedermayer wrote: On Thu, Jun 23, 2016 at 03:28:10PM +0200, Benoit Fouet wrote: Hi, On 21/06/2016 16:42, Benoit Fouet wrote: Hi, On 21/06/2016 16:29, Hendrik Leppkes wrote: On Tue, Jun 21, 2016 at 4:20 PM, Benoit Fouet wrote: Hi, On 21/06/2016 14:52

Re: [FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

2016-06-23 Thread Benoit Fouet
Hi, On 21/06/2016 16:42, Benoit Fouet wrote: Hi, On 21/06/2016 16:29, Hendrik Leppkes wrote: On Tue, Jun 21, 2016 at 4:20 PM, Benoit Fouet wrote: Hi, On 21/06/2016 14:52, Hendrik Leppkes wrote: On Tue, Jun 21, 2016 at 2:40 PM, Clément Bœsch wrote: On Tue, Jun 21, 2016 at 02:34:33PM

Re: [FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

2016-06-21 Thread Benoit Fouet
Hi, On 21/06/2016 16:29, Hendrik Leppkes wrote: On Tue, Jun 21, 2016 at 4:20 PM, Benoit Fouet wrote: Hi, On 21/06/2016 14:52, Hendrik Leppkes wrote: On Tue, Jun 21, 2016 at 2:40 PM, Clément Bœsch wrote: On Tue, Jun 21, 2016 at 02:34:33PM +0200, Benoit Fouet wrote: Hi, Unless I totally

Re: [FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

2016-06-21 Thread Benoit Fouet
Hi, On 21/06/2016 14:52, Hendrik Leppkes wrote: On Tue, Jun 21, 2016 at 2:40 PM, Clément Bœsch wrote: On Tue, Jun 21, 2016 at 02:34:33PM +0200, Benoit Fouet wrote: Hi, Unless I totally missed something, the FIXME in H264ParamSets structure should be fixed by attached patch. -- Ben From

[FFmpeg-devel] [PATCH] h264: make H264ParamSets sps const

2016-06-21 Thread Benoit Fouet
Hi, Unless I totally missed something, the FIXME in H264ParamSets structure should be fixed by attached patch. -- Ben From 28ae10498f81070539bdb8f40236326743350101 Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Tue, 21 Jun 2016 14:17:13 +0200 Subject: [PATCH] h264: make H264ParamSets sps

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: allow devices not implementing VIDIOC_G_PARM

2016-06-16 Thread Benoit Fouet
Hi, On 15/06/2016 17:21, Niklas Söderlund wrote: Not all v4l2 devices implement the VIDIOC_G_PARM ioctl. This patch allow ffmpeg to open such device and treat it the same as devices that do implement the ioctl but returns that it do not implement the V4L2_CAP_TIMEPERFRAME capability. Signed-of

Re: [FFmpeg-devel] [PATCH] hls muxer doc: clarify segment splitting option

2016-06-13 Thread Benoit Fouet
Hi, Le 08/06/2016 11:46, Benoit Fouet a écrit : Hi, find attached a patch to $subj This would have been useful at least to me :-) Anyone against this patch? If not, can someone please apply it? Thanks, -- Ben ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/os_support.h: Fix for unicode filenames on windows.

2016-06-13 Thread Benoit Fouet
Hi, On 13/06/2016 10:21, Clément Bœsch wrote: On Mon, Jun 13, 2016 at 05:50:18AM +0200, Matt Oliver wrote: ffmpeg | branch: master | Matt Oliver | Mon Jun 6 17:04:39 2016 +1000| [37787f261639c53998487400e874741c17e85fc6] | committer: Matt Oliver lavf/os_support.h: Fix for unicode filename

Re: [FFmpeg-devel] [VOTE] Ban Carl Eugen Hoyos

2016-06-13 Thread Benoit Fouet
Hi, On 12/06/2016 22:58, Paul B Mahol wrote: Hi, As requested in the IRC meeting I hereby request for the voting committee to begin voting on whatever to ban Carl Eugen Hoyos from mailing list, trac and IRC for 4 months, starting after the voting has finished. Voting will last 7 days from now

[FFmpeg-devel] [PATCH] hls muxer doc: clarify segment splitting option

2016-06-08 Thread Benoit Fouet
Hi, find attached a patch to $subj This would have been useful at least to me :-) -- Ben From aac7f87102337b7b1a59f88fc69766a20dfa0790 Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Wed, 8 Jun 2016 11:42:51 +0200 Subject: [PATCH] hls muxer doc: clarify segment splitting option --- doc

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: move putstr8 definition up

2016-05-21 Thread Benoit Fouet
Hi, Le 19/05/2016 18:45, Stefano Sabatini a écrit : This allows to use the function in a future commit. --- libavformat/mpegtsenc.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index

Re: [FFmpeg-devel] [PATCH] doc/developer.texi: Add a code of conduct

2016-05-19 Thread Benoit Fouet
Hi, Le 18 mai 2016 20:40:08 GMT+02:00, Michael Niedermayer a écrit : >Signed-off-by: Michael Niedermayer >--- > doc/developer.texi | 29 + > 1 file changed, 29 insertions(+) > >diff --git a/doc/developer.texi b/doc/developer.texi >index 6db93ce..4d3a7ae 100644 >---

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-12 Thread Benoit Fouet
Hi, On 12/05/2016 15:22, Matthieu Bouron wrote: On Thu, May 12, 2016 at 10:01 AM, Benoit Fouet wrote: Hi, I mostly have nits remarks. On 11/05/2016 18:39, Matthieu Bouron wrote: From: Matthieu Bouron [...] diff --git a/libswresample/arm/resample.S b/libswresample/arm/resample.S new

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-12 Thread Benoit Fouet
Hi, I mostly have nits remarks. On 11/05/2016 18:39, Matthieu Bouron wrote: From: Matthieu Bouron [...] diff --git a/libswresample/arm/resample.S b/libswresample/arm/resample.S new file mode 100644 index 000..13462e3 --- /dev/null +++ b/libswresample/arm/resample.S @@ -0,0 +1,77 @@ [

Re: [FFmpeg-devel] [PATCH] swscale/arm: add yuv2planeX_8_neon

2016-04-11 Thread Benoit Fouet
Hi, (again, thanks to both of you for documenting all this assembly /NEON code) On 09/04/2016 10:22, Matthieu Bouron wrote: From: Matthieu Bouron --- Hello, The following patch add yuv2planeX_8_neon function for the arm platform. It is currently restricted to 8-bit per component sources un

Re: [FFmpeg-devel] [PATCH v2 6/9] swscale/arm/yuv2rgb: macro-ify

2016-03-31 Thread Benoit Fouet
On 28/03/2016 21:19, Matthieu Bouron wrote: --- libswscale/arm/yuv2rgb_neon.S | 137 ++ 1 file changed, 60 insertions(+), 77 deletions(-) diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2rgb_neon.S index ef7b0a6..e1b68c1 100644 --- a/li

Re: [FFmpeg-devel] [PATCH v2 8/9] swscale/arm/yuv2rgb: save a few instructions by processing the luma line interleaved

2016-03-31 Thread Benoit Fouet
Hi, On 28/03/2016 21:19, Matthieu Bouron wrote: --- libswscale/arm/yuv2rgb_neon.S | 88 +-- 1 file changed, 34 insertions(+), 54 deletions(-) diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2rgb_neon.S index 124d7d3..6b911c8 100644 --- a

Re: [FFmpeg-devel] [PATCH v2 6/9] swscale/arm/yuv2rgb: macro-ify

2016-03-31 Thread Benoit Fouet
Hi, (sorry for the first mail, fuzzy fingers...) On 28/03/2016 21:19, Matthieu Bouron wrote: --- libswscale/arm/yuv2rgb_neon.S | 137 ++ 1 file changed, 60 insertions(+), 77 deletions(-) diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2

Re: [FFmpeg-devel] [PATCH v2 6/9] swscale/arm/yuv2rgb: macro-ify

2016-03-31 Thread Benoit Fouet
On 28/03/2016 21:19, Matthieu Bouron wrote: --- libswscale/arm/yuv2rgb_neon.S | 137 ++ 1 file changed, 60 insertions(+), 77 deletions(-) diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2rgb_neon.S index ef7b0a6..e1b68c1 100644 --- a/li

Re: [FFmpeg-devel] [PATCH 06/10] swscale/arm/yuv2rgb: only process one line at a time for the yuv420p and nv{12, 21} formats

2016-03-30 Thread Benoit Fouet
Hi, Le 26/03/2016 13:05, Matthieu Bouron a écrit : On Sat, Mar 26, 2016 at 2:09 AM, Michael Niedermayer >wrote: >On Fri, Mar 25, 2016 at 11:46:01PM +0100, Matthieu Bouron wrote: > >From: Matthieu Bouron > > > >--- > > libswscale/arm/yuv2rgb_neon.S | 89 >--

Re: [FFmpeg-devel] [PATCH 02/10] swscale/arm/yuv2rgb: fix comments and factorize lsl in load_args_yuv422p

2016-03-30 Thread Benoit Fouet
Hi, Le 25/03/2016 23:45, Matthieu Bouron a écrit : From: Matthieu Bouron --- libswscale/arm/yuv2rgb_neon.S | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2rgb_neon.S index f40327b..aac0773 100644 --- a/libswscale

Re: [FFmpeg-devel] [PATCH] lavc/psymodel: check for av_malloc failure

2016-03-10 Thread Benoit Fouet
Hi, Le 04/03/2016 04:06, Ganesh Ajjanagadde a écrit : No idea why in commit 01ecb7172b684f1c4b3e748f95c5a9a494ca36ec the checks were removed; this can lead to NULL pointer dereferences. This effectively reverts that portion of the commit. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/psym

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-22 Thread Benoit Fouet
Hi, Le 21/01/2015 23:10, Andreas Cadhalpun a écrit : Hi, Debian tries to make binary packages build reproducible [1]. FFmpeg embeds date and time in the program and documentation, which makes it hard to have binary reproducible packages. The attached patch allows to specify the build date a

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_cropdetect: Factorize duplicated code using a macro

2014-12-27 Thread Benoit Fouet
Hi, Le 27/12/2014 04:35, Michael Niedermayer a écrit : This simplifies subsequent changes Signed-off-by: Michael Niedermayer --- libavfilter/vf_cropdetect.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_cropdetect.c

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: remove buffer_mutex

2014-12-22 Thread Benoit Fouet
Hi, On December 23, 2014 1:44:03 AM GMT+01:00, Michael Niedermayer wrote: >It was used for protecting calls to get/release_buffer() >there are no such calls anymore > >Signed-off-by: Michael Niedermayer >--- > libavcodec/frame_thread_encoder.c |7 --- > 1 file changed, 7 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Benoit Fouet
Hi, Le 17/12/2014 22:15, Reimar Döffinger a écrit : On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote: On 12/16/2014 08:36 AM, Reimar Döffinger wrote: On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote: codec->sample_rate = avio_rl32(pb); codec->bit_ra

[FFmpeg-devel] [PATCH] avcodec/pngdec: check av_image_get_linesize return value

2014-12-07 Thread Benoit Fouet
>From 13e02ad678cc8d9ab678f73b82fa59a66681e05e Mon Sep 17 00:00:00 2001 From: Benoit Fouet Date: Mon, 8 Dec 2014 03:16:46 +0100 Subject: [PATCH] avcodec/pngdec: check av_image_get_linesize return value Fixes CID 1257012 --- libavcodec/pngdec.c | 3 +++ 1 file changed, 3 insertions(+) d

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: use memcpy instead of byte loops for P frames.

2014-12-04 Thread Benoit Fouet
Hi, Le 03/12/2014 14:31, Benoit Fouet a écrit : Rely on the way memcpy is optimized for one's system instead of looping on a byte buffer for buffer copies to handle P frames. --- libavcodec/pngdec.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: use memcpy instead of byte loops for P frames.

2014-12-03 Thread Benoit Fouet
Hi, On December 3, 2014 6:39:12 PM GMT+01:00, Christophe Gisquet wrote: >Hi, > >2014-12-03 18:32 GMT+01:00 Benoit Fouet : >> When the overhead here is high, then it means that we are going to >perform a >> lot on the frame itself, looping using byte buffers. >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: use memcpy instead of byte loops for P frames.

2014-12-03 Thread Benoit Fouet
Hi, Le 03/12/2014 14:51, Christophe Gisquet a écrit : Hi, 2014-12-03 14:16 GMT+01:00 Benoit Fouet : Rely on the way memcpy is optimized for one's system instead of looping on a byte buffer for buffer copies to handle P frames. Are there many compilers left that actually perform a call

[FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: use memcpy instead of byte loops for P frames.

2014-12-03 Thread Benoit Fouet
Rely on the way memcpy is optimized for one's system instead of looping on a byte buffer for buffer copies to handle P frames. --- libavcodec/pngdec.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 7e7

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: use memcpy instead of byte loops for P frames.

2014-12-03 Thread Benoit Fouet
Hi, - Mail original - > Rely on the way memcpy is optimized for one's system instead of > looping > on a byte buffer for buffer copies to handle P frames. > --- > libavcodec/pngdec.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a

[FFmpeg-devel] [PATCH 3/4] avcodec/pngdec: fix indentation in handle_row()

2014-12-03 Thread Benoit Fouet
--- libavcodec/pngdec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 3905e0f..7e7b285 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -307,13 +307,13 @@ static void png_handle_row(PNGDecContext *s)

[FFmpeg-devel] [PATCH 4/4] avcodec/pngdec: use memcpy instead of byte loops for P frames.

2014-12-03 Thread Benoit Fouet
Rely on the way memcpy is optimized for one's system instead of looping on a byte buffer for buffer copies to handle P frames. --- libavcodec/pngdec.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c inde

[FFmpeg-devel] [PATCH 1/4] libavcodec/pngdec: support 'previous' dispose operation for APNG.

2014-12-03 Thread Benoit Fouet
--- libavcodec/pngdec.c | 72 + 1 file changed, 50 insertions(+), 22 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 229a6d6..b1e77e5 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -38,6 +38,7 @@ typedef

[FFmpeg-devel] [PATCH 2/4] avcodec/pngdec: fix mem leak in init()

2014-12-03 Thread Benoit Fouet
--- libavcodec/pngdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index b1e77e5..3905e0f 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1237,8 +1237,12 @@ static av_cold int png_dec_init(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-03 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > 2014-12-02 14:31 GMT+01:00 Benoit Fouet : > > Fixes ticket #4148 > > Please try that one instead. > Works fine, thanks. Please fix commit message: s/onlu/only > As all your changes have been reverted, I've put myself

Re: [FFmpeg-devel] [PATCH] libavcodec/pngdec: support 'previous' dispose operation for APNG.

2014-12-02 Thread Benoit Fouet
Le 02/12/2014 15:21, Michael Niedermayer a écrit : On Tue, Dec 02, 2014 at 08:44:02AM +0100, Benoit Fouet wrote: Hi, On December 1, 2014 11:34:44 PM GMT+01:00, Michael Niedermayer wrote: On Mon, Dec 01, 2014 at 11:41:41AM +0100, Benoit Fouet wrote: --- Tested against all the materials I

[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Fixes ticket #4148 Signed-off-by: Christophe Gisquet Signed-off-by: Benoit Fouet --- Add TODO Update function prototype documentation Mention ticket 4148 --- libavcodec/pngdsp.h | 2 ++ libavcodec/x86/pngdsp.asm | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a

Re: [FFmpeg-devel] [PATCH 1/2] configure: add optional pkg-config helper and use it.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > The require variant dies if the package is not present. > The check variant does not import the flags to the used list. > The new variant imports the flags if the package is present > but does not die if it is not. > The new call graph is: require -> use -> check. >

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > Benoit Fouet free.fr> writes: > > [...] > > Please mention ticket #4148 (if it is related). > It is, just forgot about it. Also, I should be changing the libavcodec/pngdsp.h to no more mention the alignment constraints (or at least d

Re: [FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > 2014-12-02 13:51 GMT+01:00 Benoit Fouet : > > Signed-off-by: Christophe Gisquet > > Signed-off-by: Benoit Fouet > > While I suggested that the change be written like this, I didn't > think > long about that spec

[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

2014-12-02 Thread Benoit Fouet
Signed-off-by: Christophe Gisquet Signed-off-by: Benoit Fouet --- libavcodec/x86/pngdsp.asm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/pngdsp.asm b/libavcodec/x86/pngdsp.asm index 8e23ccf..76b93a9 100644 --- a/libavcodec/x86/pngdsp.asm +++ b

[FFmpeg-devel] [PATCH] avformat/apngdec: exit probing when skipping is not possible.

2014-12-02 Thread Benoit Fouet
--- Found an infinite loop on probing while zzuf'ing. --- libavformat/apngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index 189480e..d97b015 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec.c @@ -87,7 +87,7 @@

[FFmpeg-devel] [PATCH] apng: move shared header from avformat to avcodec.

2014-12-02 Thread Benoit Fouet
--- {libavformat => libavcodec}/apng.h | 6 +++--- libavcodec/pngdec.c| 2 +- libavformat/apngdec.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) rename {libavformat => libavcodec}/apng.h (93%) diff --git a/libavformat/apng.h b/libavcodec/apng.h similarity

Re: [FFmpeg-devel] [PATCH] libavcodec/pngdec: support 'previous' dispose operation for APNG.

2014-12-01 Thread Benoit Fouet
Hi, On December 1, 2014 11:34:44 PM GMT+01:00, Michael Niedermayer wrote: >On Mon, Dec 01, 2014 at 11:41:41AM +0100, Benoit Fouet wrote: >> --- >> Tested against all the materials I have at hand. >> There is an artifact showing for >https://raw.githubusercontent.com/max

[FFmpeg-devel] [PATCH] libavcodec/pngdec: support 'previous' dispose operation for APNG.

2014-12-01 Thread Benoit Fouet
--- Tested against all the materials I have at hand. There is an artifact showing for https://raw.githubusercontent.com/maxcom/lorsource/master/src/test/resources/images/i_want_to_be_a_hero__apng_animated__by_tamalesyatole-d5ht8eu.png which I don't really understand, as it seems the individual fra

Re: [FFmpeg-devel] [PATCH] avcodec/pcm: Increase a/mu-law encoding table sizes

2014-11-30 Thread Benoit Fouet
Hi, Le 30/11/2014 13:11, Christophe Gisquet a écrit : 2014-11-30 13:03 GMT+01:00 Michael Niedermayer : not really, no, that was also why i posted a patch for this, i wasnt sure this is worth the extra table size No strong opinion here, I don't think the increased memory/potential speed impact

Re: [FFmpeg-devel] [PATCH v2] avcodec/pngdec: apng: fix output buffer filling when no blending is needed.

2014-11-28 Thread Benoit Fouet
Hi, Le 28/11/2014 18:33, Michael Niedermayer a écrit : On Fri, Nov 28, 2014 at 04:54:09PM +0100, Benoit Fouet wrote: --- libavcodec/pngdec.c | 10 ++ 1 file changed, 10 insertions(+) applied maybe some of this can be factorized with the code above the else, though iam not sure it

[FFmpeg-devel] [PATCH v2] avcodec/pngdec: apng: fix output buffer filling when no blending is needed.

2014-11-28 Thread Benoit Fouet
--- libavcodec/pngdec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index a330d36..9e52d0b 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -927,7 +927,17 @@ static int handle_p_frame_apng(AVCodecContext *avctx, PNGDecCont

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: apng: fix buffer index when no blending is needed.

2014-11-28 Thread Benoit Fouet
Please discard, this is wrong... - Mail original - > --- > libavcodec/pngdec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index a96667f..0ba2749 100644 > --- a/libavcodec/pngdec.c > +++ b/libavcodec/pngdec.c > @@ -933,7 +933,1

[FFmpeg-devel] [PATCH] avcodec/pngdec: apng: fix buffer index when no blending is needed.

2014-11-28 Thread Benoit Fouet
--- libavcodec/pngdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index a96667f..0ba2749 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -933,7 +933,11 @@ static int handle_p_frame_apng(AVCodecContext *avctx, PNGDecContext *s,

[FFmpeg-devel] [PATCH] avcodec/pngdec: allow for some code path optimizations.

2014-11-28 Thread Benoit Fouet
Use 'if (CONFIG_APNG_DECODER)' where needed, so that the compiler can optimize out some portion of code. --- libavcodec/pngdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index da852c4..a330d36 100644 --- a/libavcodec/pngd

[FFmpeg-devel] [PATCH] avcodec/pngdec: do not blend on transparent black

2014-11-28 Thread Benoit Fouet
There is no need to memset the zlib output buffer, as there is no blending happening there. Instead, do not blend when the dispose operation is set to 'background' (tranparent black). --- libavcodec/pngdec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/pngdec

[FFmpeg-devel] [PATCH 2/2] avcodec/pngdec: add support for 'over' blend operation for 'none' dispose operation.

2014-11-27 Thread Benoit Fouet
--- libavcodec/pngdec.c | 160 +++- 1 file changed, 133 insertions(+), 27 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 8529956..4c9d321 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -29,6 +29,7 @@ #inclu

[FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: split P frames handling to a separate function.

2014-11-27 Thread Benoit Fouet
--- libavcodec/pngdec.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 35dcd76..8529956 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -825,6 +825,22 @@ static int decode_fctl_chunk(

[FFmpeg-devel] [PATCH] avformat/apngdec: use packet pts and duration instead of altering stream framerate.

2014-11-26 Thread Benoit Fouet
--- libavformat/apngdec.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index 1b59b82..276d765 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec.c @@ -44,6 +44,9 @@ typedef struct APNGDemuxContext {

Re: [FFmpeg-devel] [PATCH] lavf/apngdec: use AVStream.time_base instead of r_frame_rate

2014-11-26 Thread Benoit Fouet
Hi, - Mail original - > On 25/11/14 6:53 PM, Benoit Fouet wrote: > >> i suggest to use set_pts_info to set a reasonable precisse > >> timebase something like one millionth or billionth or similar in > >> base 2. and then set pts based on these delays a

[FFmpeg-devel] [PATCH v2] avformat/apngdec: validate frame dimensions.

2014-11-26 Thread Benoit Fouet
--- libavformat/apngdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index dac71f1..1b59b82 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec.c @@ -295,7 +295,11 @@ static int decode_fctl_chunk(AVFormatContext *

Re: [FFmpeg-devel] [PATCH] lavf/apngdec: use AVStream.time_base instead of r_frame_rate

2014-11-25 Thread Benoit Fouet
Hi, On November 25, 2014 10:15:31 PM GMT+01:00, Michael Niedermayer wrote: >On Tue, Nov 25, 2014 at 02:56:07PM -0300, James Almer wrote: >> Should fix framedrops on some apng files >> >> Signed-off-by: James Almer >> --- >> This is still not optimal because the value of time_base will be >upda

[FFmpeg-devel] [PATCH 2/2] avformat/apngdec: validate frame dimensions.

2014-11-25 Thread Benoit Fouet
--- libavformat/apngdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index dac71f1..e9c87a1 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec.c @@ -295,7 +295,9 @@ static int decode_fctl_chunk(AVFormatContext *s,

[FFmpeg-devel] [PATCH 1/2] avformat/apngdec: account for blend and dispose operations.

2014-11-25 Thread Benoit Fouet
changed, 46 insertions(+), 1 deletion(-) create mode 100644 libavformat/apng.h diff --git a/libavformat/apng.h b/libavformat/apng.h new file mode 100644 index 000..2abf011 --- /dev/null +++ b/libavformat/apng.h @@ -0,0 +1,41 @@ +/* + * APNG common header + * Copyright (c) 2014 Benoit Fouet

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-25 Thread Benoit Fouet
Hi, - Mail original - > On 24/11/14 12:12 PM, Benoit Fouet wrote: > > In order to support multiple IDAT of fdAT chunks following an fcTL > > one, > > transmit all the chunks between two fcTL ones (or between fcTL and > > IEND > > one). > >

[FFmpeg-devel] [PATCH] doc: add entry for APNG demuxer where needed.

2014-11-25 Thread Benoit Fouet
+386,7 @@ Muxers/Demuxers: aiffdec.c Baptiste Coudurier, Matthieu Bouron aiffenc.c Baptiste Coudurier, Matthieu Bouron ape.c Kostya Shishkov + apngdec.c Benoit Fouet ass

Re: [FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Benoit Fouet
Hi, Le 24/11/2014 17:54, James Almer a écrit : On 24/11/14 12:12 PM, Benoit Fouet wrote: In order to support multiple IDAT of fdAT chunks following an fcTL one, transmit all the chunks between two fcTL ones (or between fcTL and IEND one). Using one of the samples from https

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: add APNG support.

2014-11-24 Thread Benoit Fouet
Hi, - Mail original - > On Fri, Nov 21, 2014 at 08:09:50AM -0500, compn wrote: > > On Fri, 21 Nov 2014 12:05:47 +0100 > > Benoit Fouet wrote: > > > > > configure | 1 + > > > libavcodec/Makefile | 1 + > > > l

[FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Benoit Fouet
In order to support multiple IDAT of fdAT chunks following an fcTL one, transmit all the chunks between two fcTL ones (or between fcTL and IEND one). --- libavformat/apngdec.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/libavformat/apngd

[FFmpeg-devel] [PATCH] avformat/apngdec: transmit all the chunks between consecutive fcTL ones.

2014-11-24 Thread Benoit Fouet
In order to support multiple IDAT of fdAT chunks following an fcTL one, transmit all the chunks between two fcTL ones (or between fcTL and IEND one). --- libavformat/apngdec.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/libavformat/apngdec.c

Re: [FFmpeg-devel] [PATCH] lavf/apngdec: print currently unsupported in-stream tags in a more readable form

2014-11-23 Thread Benoit Fouet
Hi, On November 22, 2014 5:45:17 PM GMT+01:00, James Almer wrote: >Also use length and not stream position > >Signed-off-by: James Almer >--- > libavformat/apngdec.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c >index

Re: [FFmpeg-devel] [PATCH 2/2] lavf/apngdec: print currently unsupported in-stream tags in a readable form

2014-11-21 Thread Benoit Fouet
Hi, On November 21, 2014 11:09:34 PM GMT+01:00, James Almer wrote: >Also use length and not stream position > >Signed-off-by: James Almer >--- > libavformat/apngdec.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c >inde

Re: [FFmpeg-devel] [PATCH 1/2] lavf/apngdec: properly skip currently unsupported in-stream tags

2014-11-21 Thread Benoit Fouet
Hi, On November 21, 2014 11:09:33 PM GMT+01:00, James Almer wrote: >Signed-off-by: James Almer >--- > libavformat/apngdec.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c >index 54fbd29..2af87ad 100644 >--- a/libavformat/apngdec.c >+++ b/lib

[FFmpeg-devel] [PATCH] avcodec/pngdec: add APNG support.

2014-11-21 Thread Benoit Fouet
--- Changes: - do not reset decode_next_dat when decoding IDAT of fdAT - add configure part --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 8 +++ libavcodec/pngdec.c | 139 +++

Re: [FFmpeg-devel] [PATCH 3/6] Add AV_PIX_FMT_NV12T.

2014-11-21 Thread Benoit Fouet
Hi, - Mail original - [...] > I think it's safe to assume that if you have a SOC with a HW dec that > outputs only this insane and uncommon format, the SOC also has a HW > filter that can convert it. This is a good argument IMHO. On a side note, I don't think it would be that complicate

  1   2   3   >