On 12/30/2017 8:44 AM, wm4 wrote:
There is no POSIX error code for EOF - recv() signals EOF by simply
returning 0. But libavformat recently changed its conventionts and
"conventionts" -> "conventions"
requires an explicit AVERROR_EOF, or it might get into an endless retry
loop, consuming 100%
e need for using goto and the done
label: store the return value of ScheduleAudioSamples() in a local
variable. Then, free outbuf if appropriate. Then handle the
ScheduleAudioSamples() failure case. Eliminating the goto will also
make the code easier to understand, and it will result
FSET(enable_scte_104),
AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, DEC, "enable_scte_104"},
{ NULL },
};
diff --git a/libavdevice/version.h b/libavdevice/version.h
index 364404d65e..0d4477f82e 100644
--- a/libavdevice/version.h
+++ b/libavdevice/version.h
@@ -29,7 +29,7
ERROR().
+goto error;
+} else {
+ctx->vanc_ctx->verbose = 0;
+ctx->vanc_ctx->callbacks = &callbacks;
+}
+#endif
+
if (ctx->dli->StartStreams() != S_OK) {
av_log(avctx, AV_LOG_ERROR, "Cannot start input stream\n");
ret = AVERROR(EIO);
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
c 8.2.5) */
+sei_data[7] = 0x41;
+sei_data[8] = 0xf0 | side_data->data[0];
+
+return 0;
+}
+
int64_t ff_guess_coded_bitrate(AVCodecContext *avctx)
{
AVRational framerate = avctx->framerate;
I don't know enough about this to review the technical aspects of this
co
io_mode"},
+{ "discrete", NULL, 0,
AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_DISCRETE}, 0, 0,DEC, "audio_mode"},
+{ "pairs",NULL, 0,
AV_OPT_TYPE_CONST, { .i64 = AUDIO_MODE_PAIRS}, 0, 0,DEC, "audio_mode"},
{ "duplex_mode", "duplex mode", OFFSET(duplex_mode),
AV_OPT_TYPE_INT, { .i64 = 0}, 0, 2,DEC, "duplex_mode"},
{ "unset", NULL, 0,
AV_OPT_TYPE_CONST, { .i64 = 0}, 0, 0,DEC, "duplex_mode"},
{ "half", NULL, 0,
AV_OPT_TYPE_CONST, { .i64 = 1}, 0, 0,DEC, "duplex_mode"},
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 12/29/2017 10:12 AM, Devin Heitmueller wrote:
Hook in libklvanc and use it for output of EIA-708 captions over
SDI. The bulk of this patch is just general support for ancillary
data for the Decklink SDI module - the real work for construction
of the EIA-708 CDP and VANC line construction is d
deo modes, then there
probably ought to be checks to make sure the code changes are only
exercised for those video modes.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
formance perspective. According to
the blog post, it builds at least twice as fast under WSL than it does
with msys2.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 12/9/2017 11:25 PM, Rostislav Pehlivanov wrote:
On 10 December 2017 at 02:41, Aaron Levinson
wrote:
On 12/9/2017 6:24 PM, Aaron Levinson wrote:
On 12/9/2017 6:15 PM, Aaron Levinson wrote:
On 12/9/2017 1:18 AM, Hendrik Leppkes wrote:
On Fri, Dec 8, 2017 at 8:49 AM, Mateusz
wrote:
W
x object, perhaps one stored in avctx->internal.
This approach would also eliminate the codec_mutex memory leak.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 12/9/2017 6:24 PM, Aaron Levinson wrote:
On 12/9/2017 6:15 PM, Aaron Levinson wrote:
On 12/9/2017 1:18 AM, Hendrik Leppkes wrote:
On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote:
W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze:
Am 07.12.2017 20:40 schrieb "Mateusz" :
W dniu 07
On 12/9/2017 6:15 PM, Aaron Levinson wrote:
On 12/9/2017 1:18 AM, Hendrik Leppkes wrote:
On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote:
W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze:
Am 07.12.2017 20:40 schrieb "Mateusz" :
W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze:
On
On 12/9/2017 1:18 AM, Hendrik Leppkes wrote:
On Fri, Dec 8, 2017 at 8:49 AM, Mateusz wrote:
W dniu 07.12.2017 o 22:58, Hendrik Leppkes pisze:
Am 07.12.2017 20:40 schrieb "Mateusz" :
W dniu 07.12.2017 o 10:42, Hendrik Leppkes pisze:
On Thu, Dec 7, 2017 at 2:02 AM, Mateusz wrote:
After commi
Ping
On 10/31/2017 11:05 AM, Aaron Levinson wrote:
When ffmpeg is built using MSVC, symbols are stored separately from
executables and libraries in .pdb files. However, unlike with
gcc-based builds, when make install is invoked, symbols, in the form
of .pdb files, which are important for
On 11/8/2017 7:20 PM, James Almer wrote:
Should fix ticket #6822
Signed-off-by: James Almer
---
libavdevice/decklink_dec.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index 191547ff10..e90b42811a 10
ource base, and this issue exists there as well.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
See comments below.
Aaron Levinson
On 11/5/2017 4:49 PM, Marton Balint wrote:
On Fri, 27 Oct 2017, Jeyapal, Karthick wrote:
Please find the patch attached.
Thanks, below some comments:
From b18679b91a79f5e23a5ad23ae70f3862a34ddfb8 Mon Sep 17 00:00:00 2001
From: Karthick J
Date: Fri
On 10/31/2017 11:44 AM, Hendrik Leppkes wrote:
On Tue, Oct 31, 2017 at 6:50 PM, Aaron Levinson
wrote:
Signed-off-by: Aaron Levinson
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index ea22d692b9..572299c9d3 100755
--- a
.
Signed-off-by: Aaron Levinson
---
configure| 4 +++-
fftools/Makefile | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 2ac6fed98a..feb86b2069 100755
--- a/configure
+++ b/configure
@@ -5101,9 +5101,10 @@ case $target_os in
Signed-off-by: Aaron Levinson
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 572299c9d3..2ac6fed98a 100755
--- a/configure
+++ b/configure
@@ -5994,7 +5994,7 @@ enabled libkvazaar&& require_pkg_config
libkvazaar
Signed-off-by: Aaron Levinson
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index ea22d692b9..572299c9d3 100755
--- a/configure
+++ b/configure
@@ -3327,7 +3327,7 @@ avformat_deps="avcodec avutil"
avformat_suggest="li
On 7/3/2017 1:06 PM, Marton Balint wrote:
On Mon, 3 Jul 2017, Aaron Levinson wrote:
+22, and lines 318 to 335. Line 6 is the LSB in the mask. Selected lines
which
+do not contain teletext information will be ignored. You can use the
special
+@option{all} constant to select all possible
av_log(avctx, AV_LOG_ERROR, "Libzvbi support is needed for capturing
teletext, please recompile FFmpeg.\n");
-return AVERROR(ENOSYS);
-}
-#endif
-
/* Check audio channel option for valid values: 2, 8 or 16 */
switch (cctx->audio_channel
if (i == 22)
+i = 317;
}
- if (i == 22)
-i = 317;
}
vanc->Release();
if (txt_buf - txt_buf0 > 1) {
Overall, looks good. I'll review the second patch in a bit.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
patch isn't sufficient. Plus, there
is no reason to #define LOAD_LIBRARY_SEARCH_SYSTEM32 if the code won't
be built anyway.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 5/18/2017 9:21 AM, Hendrik Leppkes wrote:
On Thu, May 18, 2017 at 3:18 PM, Michael Niedermayer
wrote:
On Tue, May 16, 2017 at 03:38:32PM -0700, Aaron Levinson wrote:
Signed-off-by: Aaron Levinson
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
On 5/16/2017 4:23 PM, Steven Liu wrote:
2017-05-17 6:38 GMT+08:00 Aaron Levinson :
Signed-off-by: Aaron Levinson
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 7980d92..49f91ac 100755
--- a/configure
+++ b/configure
Signed-off-by: Aaron Levinson
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 7980d92..49f91ac 100755
--- a/configure
+++ b/configure
@@ -6013,10 +6013,10 @@ check_header sys/videoio.h
check_code cc sys/videoio.h "s
ws, it likely
results in memory corruption, since av_free() is being called on
memory that was allocated using
IDirectXVideoAccelerationService::CreateSurface().
Signed-off-by: Aaron Levinson
---
libavutil/hwcontext_dxva2.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --gi
Please disregard--I will submit a new patch with a better commit message.
Aaron
On 5/16/2017 4:09 AM, Aaron Levinson wrote:
Purpose: No longer improperly freeing IDirect3DSurface9 objects in
hwcontext_dxva2.c. Added dxva2_pool_release_dummy() and using it in
call to av_buffer_create() in
7;t appear
to result in a crash when the release version of the C-runtime is used
on Windows, it likely results in memory corruption, since av_free() is
being called on memory that was allocated using
IDirectXVideoAccelerationService::CreateSurface().
Signed-off-by: Aaron Levinson
-
t the source code that was used to build
the FFmpeg binaries that were shipped with the app.
Aaron Levinson
On Mon, May 15, 2017 at 1:38 PM, Kieran Kunhya wrote:
Hi,
Out of interest, how did you automate this process? Is it as simple as
looking for the FFmpeg configure string?
Regards,
K
On 5/12/2017 5:51 PM, Michael Niedermayer wrote:
On Fri, May 12, 2017 at 01:19:43PM -0700, Aaron Levinson wrote:
On 5/9/2017 11:56 AM, Michael Niedermayer wrote:
On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote:
I've provided a new version of the patch. When I create
tion to the output stream's
codecpar (mux_par->field_order in do_video_out()). However,
check_init_output_file() calls avformat_write_header() prior to the
initial call to do_video_out(), so field_order is populated too late,
and the header is written with the default field_order value,
Purpose: Separated the call to check_init_output_file() from
init_output_stream(), and now check_init_output_file() is called by
the parent after calling init_output_stream(). Additionally, moved
some static function declarations to the beginning of the file.
Signed-off-by: Aaron Levinson
Please disregard--I messed up the subject. I'll send a new one.
Aaron Levinson
On 5/12/2017 1:22 PM, Aaron Levinson wrote:
Purpose: Separated the call to check_init_output_file() from
init_output_stream(), and now check_init_output_file() is called by
the parent after ca
Purpose: Separated the call to check_init_output_file() from
init_output_stream(), and now check_init_output_file() is called by
the parent after calling init_output_stream(). Additionally, moved
some static function declarations to the beginning of the file.
Signed-off-by: Aaron Levinson
On 5/9/2017 11:56 AM, Michael Niedermayer wrote:
On Thu, May 04, 2017 at 11:46:30PM -0700, Aaron Levinson wrote:
I've provided a new version of the patch. When I created the first version of the patch on March
26th, this was the first patch that I submitted to ffmpeg, and some aspects
&& { check_header ladspa.h || die "ERROR: ladspa.h header
not found"; }
enabled libiec61883 && require libiec61883 libiec61883/iec61883.h
iec61883_cmp_connect -lraw1394 -lavc1394 -lrom1394 -liec61883
enabled libass&& require_pkg_config libass ass/ass
On 5/10/2017 3:33 AM, Steven Liu wrote:
Suggested-by: Aaron Levinson
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 221089c..7ed121a 100644
--- a/libavformat
ls to av_free(old_filename).
}
ret = ff_write_chained(oc, stream_index, pkt, s, 0);
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
handle .m3u8 files that use '\' for multi-line TAG spans, and in
addition, there is no mention of '\' anywhere in the actual grammar
documented in the specification. So, it seems that that this patch
isn't needed.
Aaron Levinson
On 5/9/2017 1:01 PM, Aaron Levi
ts
#EXTINF:8.64,
out1.ts
#EXTINF:9.16,
out2.ts
Reported-by: Aaron Levinson
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 21 +++--
1 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 221089c..c1
Are you also planning to change ffmpeg_videotoolbox.c? See below for
more comments.
Aaron Levinson
On 5/2/2017 8:26 PM, wm4 wrote:
This adds tons of code for no other benefit than making VideoToolbox
support conform with the new hwaccel API (using hw_device_ctx and
hw_frames_ctx).
Since
From 30eb78bac7bd92b0c085ba6873341e8319072acc Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 5 May 2017 21:31:30 -0700
Subject: [PATCH 2/2] qsvenc: Make sure the interlaced encoding works
Purpose: qsvenc: make sure that interlaced encoding works. Also,
reduce the vertical alignment
From 2882d77d76805e74fe139f6763f91c39746bebaf Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 5 May 2017 18:49:57 -0700
Subject: [PATCH 1/2] qsvenc: Use MFXVideoENCODE_Query() to update the
parameters
Purpose: Fill out the default/unset parameters with ones actually in use.
Note
Please disregard this patch--I'm submitting two new patches that have
already been reviewed and applied to libav.
Aaron Levinson
On 4/13/2017 11:36 PM, Aaron Levinson wrote:
From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 13 Apr 20
for the decoder). The third component always starts at
100 to distinguish FFmpeg from Libav." Note that my review only covers
the content of the patch, and I don't know whether or not it makes sense
to discontinue this practice.
Aaron Levinson
__
On 5/5/2017 2:26 AM, wm4 wrote:
On Fri, 5 May 2017 01:11:17 -0700
Aaron Levinson wrote:
As I said on IRC, I'm skeptic against this, but I'm also not sure
whether I understand the situation.
First, your change seems a bit fragile, and almost relies on
coincidences. This could easil
On 5/5/2017 4:50 AM, Michael Niedermayer wrote:
> On Fri, May 05, 2017 at 11:36:05AM +0200, Hendrik Leppkes wrote:
>> On Fri, May 5, 2017 at 9:57 AM, Clément Bœsch wrote:
>>> On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote:
>>> [...]
>>>>>
On 5/5/2017 4:57 PM, Marton Balint wrote:
>
>
> On Fri, 5 May 2017, Aaron Levinson wrote:
>
>> On 4/16/2017 4:11 PM, Aaron Levinson wrote:
>>> On 4/15/2017 6:13 AM, Aaron Levinson wrote:
>>>> On 4/15/2017 4:19 AM, Marton Balint wrote:
>>>&g
The entire patch set LGTM.
Aaron Levinson
On 5/3/2017 6:41 PM, James Almer wrote:
On 5/3/2017 9:39 PM, Aaron Levinson wrote:
James,
Can you document which patches depend on other patches in this patch set
to make it easier to review this patch set in chunks?
Patch 2 depends on 1. Patches 3
On 5/5/2017 12:57 AM, Clément Bœsch wrote:
On Fri, May 05, 2017 at 12:54:12AM -0700, Aaron Levinson wrote:
[...]
Back to your issue: you should fix the .pc in the upstream project, this
is the correct fix.
The "upstream project" in this case is the Intel Media SDK. This is not an
o
On 5/5/2017 12:55 AM, wm4 wrote:
On Thu, 4 May 2017 23:46:30 -0700
Aaron Levinson wrote:
On 4/12/2017 6:08 PM, Aaron Levinson wrote:
On 3/26/2017 10:34 AM, Aaron Levinson wrote:
On 3/26/2017 4:41 AM, Matthias Hunstock wrote:
Am 26.03.2017 um 11:50 schrieb Aaron Levinson
On 5/5/2017 12:44 AM, Carl Eugen Hoyos wrote:
2017-05-05 9:42 GMT+02:00 Aaron Levinson :
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote:
2017-05-05 3:29 GMT+02:00 Aaron Levinson :
On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote:
Hi!
Attached patch is one possibility to fix the following
On 5/5/2017 12:42 AM, Clément Bœsch wrote:
On Fri, May 05, 2017 at 12:11:27AM -0700, Aaron Levinson wrote:
On 4/19/2017 10:43 AM, Aaron Levinson wrote:
On 4/14/2017 6:51 PM, Aaron Levinson wrote:
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date
On 5/5/2017 12:20 AM, Carl Eugen Hoyos wrote:
2017-05-05 3:29 GMT+02:00 Aaron Levinson :
On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote:
Hi!
Attached patch is one possibility to fix the following warning with gcc 7:
libavutil/timecode.c: In function ‘av_timecode_make_string’:
libavutil
On 4/16/2017 4:11 PM, Aaron Levinson wrote:
> On 4/15/2017 6:13 AM, Aaron Levinson wrote:
>> On 4/15/2017 4:19 AM, Marton Balint wrote:
>>>
>>> On Thu, 13 Apr 2017, Aaron Levinson wrote:
>>>
>>>> On 4/13/2017 1:23 PM, Hendrik Leppkes wrote:
>&
On 4/19/2017 10:43 AM, Aaron Levinson wrote:
> On 4/14/2017 6:51 PM, Aaron Levinson wrote:
>> From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
>> From: Aaron Levinson
>> Date: Fri, 14 Apr 2017 18:38:37 -0700
>> Subject: [PATCH] Added require fall
On 4/14/2017 6:27 PM, Aaron Levinson wrote:
From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 14 Apr 2017 18:14:21 -0700
Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to
bindir for MSVC builds for make install
Purpose
On 4/12/2017 6:08 PM, Aaron Levinson wrote:
> On 3/26/2017 10:34 AM, Aaron Levinson wrote:
>> On 3/26/2017 4:41 AM, Matthias Hunstock wrote:
>>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson:
>>>> When using the following command to play back either file:
>>
On 5/2/2017 2:29 PM, wm4 wrote:
On Tue, 2 May 2017 14:17:33 -0700
Aaron Levinson wrote:
On 5/1/2017 11:06 PM, MFojtak wrote:
Currently this muxer does not work at all. I don't know if 000Z would make
it compatible with more player as I don't know any. However, adding Z makes
it
On 5/4/2017 9:15 PM, Steven Liu wrote:
2017-05-03 9:49 GMT+08:00 Aaron Levinson :
On 4/27/2017 7:21 PM, Steven Liu wrote:
2017-04-26 7:30 GMT+08:00 Steven Liu :
fix ticket id: #6353
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 24
1 file changed, 24
never use 32 characters, its not a big deal to
have a little waste here. The buffer size should match the format
specification. An alternative would be to use "%02hd" or "%02hhd", but
doing so would require casts or using different types for hh, mm, etc.
Aaron Levins
NAN);
In order to preserve the original logic, why not do the following:
+num = den ? num * intnum / den : (((num * intnum) != 0) ? INFINITY :
NAN);
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
James,
Can you document which patches depend on other patches in this patch set
to make it easier to review this patch set in chunks?
Thanks,
Aaron Levinson
On 5/2/2017 2:55 PM, James Almer wrote:
Some changes and fixes suggested on IRC. Some patches are v3 as they have
been sent before
On 4/21/2017 2:03 PM, James Almer wrote:
On 4/21/2017 12:09 PM, Michael Niedermayer wrote:
On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote:
From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 20 Apr 2017 23:20:20 -0700
Subject
From 345a98d31c6c758f0f82edab1b502cd8aeb3354b Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Wed, 3 May 2017 12:38:39 -0700
Subject: [PATCH] doc: Enhanced fate.texi to reference Windows line endings
section from git-howto.texi
Purpose: Enhanced fate.texi to indicate that FATE will fail if
On 4/22/2017 12:22 PM, Aaron Levinson wrote:
On 4/22/2017 12:09 PM, Hendrik Leppkes wrote:
On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson
wrote:
On 4/22/2017 2:16 AM, Clément Bœsch wrote:
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
[...]
This is documented in doc
I don't seem to have the original e-mail in my inbox anymore, so I'll
respond to wm4's response. Overall, the new code is a lot cleaner and
easier to understand than the existing code.
See below for more.
Aaron Levinson
On 5/2/2017 5:04 PM, wm4 wrote:
On Fri, 28 Apr 2017
f(hls->key_uri)).
In addition, based on the EXT-X-KEY example at
https://developer.apple.com/library/content/technotes/tn2288/_index.html
, it would appear that an EXT-X-KEY declaration may span multiple lines.
Your solution will not work properly in this case.
Aaron Levinson
+
currently taken in configure
doesn't distinguish between encoding and decoding, but the patch as
originally proposed just trades decoding API requirements for encoding
API requirements.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
mmit your patch, but hopefully someone
else will do so.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 5/1/2017 1:51 AM, Carl Eugen Hoyos wrote:
Hi!
Even without the casts, the patch reduces the number of warnings shown when
compiling compat/strtod from seven to three.
Please comment, Carl Eugen
LGTM
Aaron Levinson
___
ffmpeg-devel mailing list
to populate
milliseconds anyway as follows:
if (!strftime(buf, size, "%Y-%m-%dT%H:%M:%S.000Z", ptm))
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 4/26/2017 12:47 PM, James Almer wrote:
On 4/26/2017 2:46 AM, Aaron Levinson wrote:
On 4/24/2017 3:47 PM, James Almer wrote:
Free coded_frame, coded_side_data and unref hw_device_ctx to prevent
potential leaks.
Signed-off-by: James Almer
---
libavcodec/options.c | 15 +++
1
ame based on the way it is
formed, this in theory could be a problem, although it is unlikely in
practice since LINE_BUFFER_SIZE is 1024. While ideally there would be a
sanity check somewhere in the code to make sure those URLs aren't too
long, an alternative is to copy up to max LINE
define alloc_and_copy_or_fail(obj, size, pad) \
if (src->obj && size > 0) { \
I'm not sure if this patch is intended to be a replacement for your last
"2/2" patch, but this version is missing the the coded_side_data
population code that was in the first version
resolution and move forward. Its one thing to fire off
an e-mail--its another to say things to someone's "face", so to speak.
I'd also suggest, when passions are up, to step aside and then maybe
come back to it later.
Aaron Levinson
fmpeg was to contribute it to libav first. But, if this patch has to
pass yet another round of code reviews, code reviews that weren't
forthcoming in the first place on ffmpeg-devel when I originally
submitted the patch, then that could be problematic.
Aaro
lements in dest, even though they are owned by src. After doing the
memcpy() call, I think you can fix this by setting dest->coded_side_data
to NULL and dest->nb_coded_side_data to 0.
Everything else looks good.
Aaron Levinson
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
t with the values in src, and besides the copies made of
dest->codec and dest->priv_data earlier in the function, anything else
that is overwritten could in theory leak. But, I guess that would have
been a preexisting issue with this function and not really relevant for
this patch. And th
On 4/22/2017 12:09 PM, Hendrik Leppkes wrote:
On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote:
On 4/22/2017 2:16 AM, Clément Bœsch wrote:
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
[...]
diff --git a/doc/fate.texi b/doc/fate.texi
index 7a96c25..f3b8c0c8 100644
On 4/22/2017 2:16 AM, Clément Bœsch wrote:
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
[...]
diff --git a/doc/fate.texi b/doc/fate.texi
index 7a96c25..f3b8c0c8 100644
--- a/doc/fate.texi
+++ b/doc/fate.texi
@@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate
@float NOTE
ssors at all if the fields are public? As far as
I can tell, the benefit to using these accessors is that, if certain
properties become internal in the future, or variable names change, or
the structures become opaque, etc, the code will continue to work.
Aaron Lev
Note that in case it wasn't clear, I confirmed that this patch works by
running make on Linux and examining both the generated text file and the
generated HTML file in a Web browser.
Aaron
On 4/21/2017 4:48 PM, Aaron Levinson wrote:
On 4/21/2017 4:17 PM, Lou Logan wrote:
On Fri, 21 Apr
On 4/21/2017 4:17 PM, Lou Logan wrote:
> On Fri, 21 Apr 2017 16:05:16 -0700
> Aaron Levinson wrote:
>
>> From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001
>> From: Aaron Levinson
>> Date: Fri, 21 Apr 2017 15:55:11 -0700
>> Subject: [PATCH] A
From 7ea6455cd52ffe561f94bf03f48c4c2cf61b33c5 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 21 Apr 2017 15:55:11 -0700
Subject: [PATCH] Added additional note to fate.texi to describe the importance
of not checking out files from git with core.autocrlf set to true
Purpose: Added
On 4/19/2017 2:27 PM, Marton Balint wrote:
On Mon, 17 Apr 2017, James Almer wrote:
On 4/17/2017 5:39 AM, Clément Bœsch wrote:
On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote:
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date
From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Thu, 20 Apr 2017 23:20:20 -0700
Subject: [PATCH] Fixed memory leaks associated with AVStream objects if
FF_API_LAVF_AVCTX is defined
Purpose: Fixed memory leaks associated with AVStream objects if
On 4/14/2017 6:51 PM, Aaron Levinson wrote:
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Fri, 14 Apr 2017 18:38:37 -0700
Subject: [PATCH] Added require fallback for libmfx in the case that
pkg-config cannot find libmfx
Purpose: Added
On 4/17/2017 8:28 AM, wm4 wrote:
On Mon, 17 Apr 2017 12:06:59 -0300
James Almer wrote:
On 4/17/2017 5:39 AM, Clément Bœsch wrote:
On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote:
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Sun, 16 Apr 2017 17:13:31 -0700
Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when
ASSERT_LEVEL is greater than 1
Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL
I'll try that again with [PATCH] in the subject line.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
From 9e6a9e2b8d58f17c661a3f455e03c95587ec7b18 Mon Sep 17 00:00:00 2001
From: Aaron Levinson
Date: Sun, 16 Apr 2017 17:13:31 -0700
Subject: [PATCH] libavutil/thread.h: Fixed g++ build error when
ASSERT_LEVEL is greater than 1
Purpose: libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL
On 4/16/2017 4:25 PM, Aaron Levinson wrote:
On 4/16/2017 3:31 PM, Hendrik Leppkes wrote:
On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson
wrote:
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
Thanks, applied.
Regards,
Marton
This seems to have broken the coverity builds:
https://travis
On 4/16/2017 3:31 PM, Hendrik Leppkes wrote:
On Mon, Apr 17, 2017 at 12:26 AM, Aaron Levinson wrote:
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
Thanks, applied.
Regards,
Marton
This seems to have broken the coverity builds:
https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds
On 4/15/2017 6:13 AM, Aaron Levinson wrote:
> On 4/15/2017 4:19 AM, Marton Balint wrote:
>>
>> On Thu, 13 Apr 2017, Aaron Levinson wrote:
>>
>>> On 4/13/2017
On 4/16/2017 1:33 PM, Timo Rothenpieler wrote:
Thanks, applied.
Regards,
Marton
This seems to have broken the coverity builds:
https://travis-ci.org/FFmpeg/FFmpeg-Coverity/builds/222597943#L1103
It was suggested on IRC by James Almer that "it seems to complain about
ubitux's 'strict' pthrea
1 - 100 of 133 matches
Mail list logo
