Re: [FFmpeg-devel] [PATCH 1/2] lavc/vp9dsp: R-V V mc tap h v

ping flow gg 于2024年8月28日周三 14:43写道： > It seems that the previous patch have partially lacked if RVB, but now it > has if (flags & AV_CPU_FLAG_RVB). > > Rémi Denis-Courmont 于2024年8月28日周三 03:00写道： > >> Le sunnuntaina 25. elokuuta 2024, 14.41.22 EEST flow gg a écrit : >> > > Does not assemble with

[FFmpeg-devel] [PATCH v3 4/8] lavc/cbs_h266: Add NumSlicesInTile to H266RawPPS

From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/cbs_h266.h | 1 + libavcodec/cbs_h266_syntax_template.c | 16 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 7f0e537b31..67a3ff6151 100644

[FFmpeg-devel] [PATCH v3 8/8] lavc/vaapi_dec: Add VVC decoder

From: Fei Wang Signed-off-by: Fei Wang --- Changelog | 2 + configure | 3 + libavcodec/Makefile | 1 + libavcodec/hwaccels.h | 1 + libavcodec/vaapi_decode.c | 4 + libavcodec/vaapi_vvc.c| 657 ++ libav

[FFmpeg-devel] [PATCH v3 5/8] lavc/vvc_refs: Define VVC_FRAME_FLAG* to h header

From: Fei Wang So that hardware decoder can use the flags too. Signed-off-by: Fei Wang --- libavcodec/vvc/refs.c | 4 libavcodec/vvc/refs.h | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c index 133ff9eaba..3ed9d6768d

[FFmpeg-devel] [PATCH v3 6/8] lavc/vvc_ps: Add alf raw syntax into VVCALF

From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vvc/ps.c | 10 +- libavcodec/vvc/ps.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c index ff9a6c7a15..f32f1cc5a1 100644 --- a/libavcodec/vvc/ps.c +++ b/libavcodec/vvc

[FFmpeg-devel] [PATCH v3 7/8] lavc/vvc_dec: Add hardware decode API

From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vvc/dec.c | 90 --- libavcodec/vvc/dec.h | 4 ++ libavcodec/vvc/refs.c | 6 +++ 3 files changed, 87 insertions(+), 13 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index ed

[FFmpeg-devel] [PATCH v3 3/8] lavc/cbs_h266: Add SliceTopLeftTileIdx to H266RawPPS

From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/cbs_h266.h | 1 + libavcodec/cbs_h266_syntax_template.c | 4 2 files changed, 5 insertions(+) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index d24a8e9313..7f0e537b31 100644 --- a/libavcodec/cbs_h266.h ++

[FFmpeg-devel] [PATCH v3 1/8] lavc/vaapi_dec: Create VA parameters dynamically

From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_decode.c | 34 +- libavcodec/vaapi_decode.h | 7 ++- 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index a59194340f..709699dc

[FFmpeg-devel] [PATCH v3 2/8] lavc/vaapi_decode: Use a more meaningful variable name

From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_decode.c | 20 ++-- libavcodec/vaapi_decode.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 709699dcaf..7753f72106 100644 --- a/lib

Re: [FFmpeg-devel] Uncompressed MP4

On 25.09.24 01:34, Devon Sookhoo wrote: Historically, whenever an application required the use of uncompressed data, it was a "wild west" of file formats, with no shortage of proprietary options which has lead to interoperability issues across communities. Sure, a few simple old fashioned s

[FFmpeg-devel] [PATCH v4] avcodec/riscv: add h264 qpel

From: Niklas Haas Benched on K230 for VLEN 128, SpaceMIT for VLEN 256. Variants for 4 width have no speedup for VLEN 256 vs VLEN 128 on available hardware, so were disabled. C RVV128 C RVV256 avg_h264_qpel_4_mc00_8 33.9 33.6 (1.01x) avg_h264_qpel_4_

Re: [FFmpeg-devel] [RFC] 7.1 Release

On 25.09.2024 02:23, Dennis Mungai wrote: On Wed, 25 Sept 2024, 2:39 am Steven Liu, > wrote: > On Sep 25, 2024, at 05:38, Dennis Mungai mailto:dmng...@gmail.com>> wrote: > > On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, mailto:i...@datarhei.com>> wro

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Wed, 25 Sept 2024, 2:39 am Steven Liu, wrote: > > > > On Sep 25, 2024, at 05:38, Dennis Mungai wrote: > > > > On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, wrote: > > > >> "Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) > >> > >>> On 24 Sep 2024, at 17:47, Michael Niedermayer

[FFmpeg-devel] [PATCH] avformat/mov: get heif image rotation from irot box

Based on a patch by Hacene Bouaroua. Co-authored-by: Hacene Bouaroua Signed-off-by: James Almer --- libavformat/avformat.h | 6 + libavformat/isom.h | 1 + libavformat/mov.c | 54 ++ 3 files changed, 57 insertions(+), 4 deletions(-) diff -

Re: [FFmpeg-devel] Uncompressed MP4

Hello Martin, I work with various scientific communities that have adopted the ISO BMFF architecture, which includes the MP4 and HEIF file formats. Historically, whenever an application required the use of uncompressed data, it was a "wild west" of file formats, with no shortage of proprietary opt

Re: [FFmpeg-devel] [RFC] 7.1 Release

> On Sep 25, 2024, at 05:38, Dennis Mungai wrote: > > On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, wrote: > >> "Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) >> >>> On 24 Sep 2024, at 17:47, Michael Niedermayer >> wrote: >>> >>> On Wed, Aug 14, 2024 at 02:41:55PM +0200, Mi

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

On Tue, Sep 24, 2024 at 7:16 AM Martin Storsjö wrote: > > On Mon, 23 Sep 2024, Cameron Gutman wrote: > > > On Mon, Sep 23, 2024 at 12:43 PM Zhao Zhili wrote: > >> > >> > >> > >> > On Sep 24, 2024, at 01:24, Cameron Gutman wrote: > >> > > >> > On Mon, Sep 23, 2024 at 6:07 AM Zhao Zhili > >> > w

Re: [FFmpeg-devel] Uncompressed MP4

On 23.09.24 16:36, Devon Sookhoo wrote: I'm interested in implementing uncompressed MP4 parsing according to the newly released ISO/IEC 23001-17:2024. Would anyone be interested in further discussing this with me? As you have most likely already seen I've worked on a rather similar project

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Wed, Sep 25, 2024 at 12:38:29AM +0300, Dennis Mungai wrote: > On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, wrote: > > > "Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) > > > > > On 24 Sep 2024, at 17:47, Michael Niedermayer > > wrote: > > > > > > On Wed, Aug 14, 2024 at 02:41:

[FFmpeg-devel] [PATCH 4/4] tests/fate/vcodec: Add 10bit 2pass FFv1 test

(this covers ticket5405) Signed-off-by: Michael Niedermayer --- tests/fate/vcodec.mak | 5 - tests/ref/vsynth/vsynth1-ffv1-2pass10 | 4 tests/ref/vsynth/vsynth2-ffv1-2pass10 | 4 tests/ref/vsynth/vsynth3-ffv1-2pass10 | 4 tests/ref/vsynth/vsynth

[FFmpeg-devel] [PATCH 3/4] avcodec/ffv1enc: Fix >8bit context size

Fixes: Ticket5405 Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 1c37f61adaf..a6f405289eb 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1

[FFmpeg-devel] [PATCH 2/4] avformat/movenc: Fix ffv1 support

Fixes: Ticket9975 Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d20e45cf810..c88461ab8a0 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -8582,6 +8582,7 @@ static c

[FFmpeg-devel] [PATCH 1/4] avcodec/ffv1dec: Blow up if user asks for explosion

Fixes: Ticket8403 Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 415c66be636..0afdeabd915 100644 --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -354,6 +354,9 @@ static

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, wrote: > "Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) > > > On 24 Sep 2024, at 17:47, Michael Niedermayer > wrote: > > > > On Wed, Aug 14, 2024 at 02:41:55PM +0200, Michael Niedermayer wrote: > >> Hi all > >> > >> Are there any upco

[FFmpeg-devel] [Uncompressed MP4] Write uncC Tag

>From 5767e173414432d6079b1b581121622e874a26cd Mon Sep 17 00:00:00 2001 From: dukesook Date: Tue, 24 Sep 2024 12:27:31 -0600 Subject: [PATCH] mov_write_uncC_tag() Initial function for writing the uncC, or uncopmressed codec box --- libavformat/movenc.c | 52 ++

Re: [FFmpeg-devel] [RFC] 7.1 Release

On 2024-09-25 12:39 am, martin schitter wrote: On 24.09.24 20:45, martin schitter wrote: "Meitner" (https://en.wikipedia.org/wiki/Lise_Meitner) because of: https://en.wikipedia.org/wiki/Lise_Meitner#/media/ File:Bohr_Heisenberg_Pauli_Meitner_u.a._1937_(cropped).jpg sorry -- I had the im

Re: [FFmpeg-devel] [RFC] 7.1 Release

+1 for Rózsa Péter Best regards, Reto > On 24 Sep 2024, at 21:09, martin schitter wrote: > > sorry -- I had the impression, that physics count, but in the field of > mathematics and computer sciences I would definitely vote for: > > "peters" (https://en.wikipedia.org/wiki/R%C3%B3zsa_P%C3%A9te

Re: [FFmpeg-devel] [RFC] 7.1 Release

"Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) > On 24 Sep 2024, at 17:47, Michael Niedermayer wrote: > > On Wed, Aug 14, 2024 at 02:41:55PM +0200, Michael Niedermayer wrote: >> Hi all >> >> Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? >> If so p

Re: [FFmpeg-devel] [RFC] 7.1 Release

On 24.09.24 20:45, martin schitter wrote: "Meitner" (https://en.wikipedia.org/wiki/Lise_Meitner) because of: https://en.wikipedia.org/wiki/Lise_Meitner#/media/ File:Bohr_Heisenberg_Pauli_Meitner_u.a._1937_(cropped).jpg sorry -- I had the impression, that physics count, but in the field of

Re: [FFmpeg-devel] [RFC] 7.1 Release

On 24.09.24 18:08, Marcus B Spencer wrote: anyone has a suggestion/preferrance for a name ? I have a preference for the name "Huffman". "Meitner" (https://en.wikipedia.org/wiki/Lise_Meitner) because of: https://en.wikipedia.org/wiki/Lise_Meitner#/media/File:Bohr_Heisenberg_Pauli_Meitner_u.

Re: [FFmpeg-devel] [PATCH] doc: Add email URLs for Fate samples-request

On 24.09.24 01:48, martin schitter wrote: they should be T: feel free to send a patch fixing that, or ill fix it later Although you fixed one occurrence of this issue by f2aba7 it's still present on the next line. My patch would have fixed both of them. ;) Martin ___

Re: [FFmpeg-devel] [PATCH 22/23] tests/fate/hevc: add a test for switching between single and multi-view

Should be fixed with 9dc0edd4546bebfa451233b12548a8caa4a399ab -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg

[FFmpeg-devel] [PATCH] avformat/oma: Demux oma-encapsulated AAC audio

Empty MessageFrom 35d8ce6136fa4cf128395aeed56ea57c0496ef3a Mon Sep 17 00:00:00 2001 From: asivery Date: Tue, 24 Sep 2024 18:58:37 +0200 Subject: [PATCH] avformat/oma: Demux oma-encapsulated AAC audio Signed-off-by: asivery --- libavformat/oma.c| 1 + libavformat/oma.h| 1 + libavformat/

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/internal: Add ff_get_frame_filename

On Mon, 23 Sept 2024 at 16:14, Zhao Zhili wrote: > From: Zhao Zhili > > It's similar to av_get_frame_filename2 but with int64_t number > support. Make av_get_frame_filename* a wrapper over > ff_get_frame_filename. > > Co-authored-by: Filip Mašić > --- > libavformat/internal.h | 16

Re: [FFmpeg-devel] [PATCH 2/7] avformat/mxfdec: Check avio_read() success in mxf_decrypt_triplet()

mån 2024-09-23 klockan 23:32 +0200 skrev Michael Niedermayer: > Fixes: Use of uninitialized memory > Fixes: 71444/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > 5448597561212928 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sig

Re: [FFmpeg-devel] [PATCH v3] avcodec/riscv: add h264 qpel

Le tiistaina 24. syyskuuta 2024, 16.59.19 EEST J. Dekker a écrit : > From: Niklas Haas > > Benched on K230 for VLEN 128, SpaceMIT for VLEN 256. > > C RVV128 C RVV256 > avg_h264_qpel_4_mc00_8 33.9 33.6 (1.01x) 40.1 29.6 (1.35x) > avg_h264_qpel_

Re: [FFmpeg-devel] [PATCH] tests/fate/hevc: use bitexact scaling flags for fate-hevc-mv-switch

On Tue, 24 Sep 2024, Anton Khirnov wrote: Makes the results consistent across platforms. --- tests/fate/hevc.mak | 2 +- tests/ref/fate/hevc-mv-switch | 296 +- 2 files changed, 149 insertions(+), 149 deletions(-) diff --git a/tests/fate/hevc.mak b/test

Re: [FFmpeg-devel] [PATCH 11/14] swscale/x86/range_convert: update sse2 and avx2 range_convert functions to new API

Le maanantaina 23. syyskuuta 2024, 15.40.14 EEST Ramiro Polla a écrit : > chrRangeFromJpeg8_1920_c: 3874.8 ( 1.00x) > chrRangeFromJpeg8_1920_sse2: 1493.8 ( 2.59x) > chrRangeFromJpeg8_1920_avx2: 741.8 ( 5.22x) > chrRangeT

[FFmpeg-devel] [PATCH] tests/fate/hevc: use bitexact scaling flags for fate-hevc-mv-switch

Makes the results consistent across platforms. --- tests/fate/hevc.mak | 2 +- tests/ref/fate/hevc-mv-switch | 296 +- 2 files changed, 149 insertions(+), 149 deletions(-) diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 6d8865ea66..7f7ec439

Re: [FFmpeg-devel] Uncompressed MP4

Derek, Thanks again for responding. I was able to access Libera using the web IRC client. I will continue to seek additional guidance there. Thanks for the feedback, I'm aware the code is odd. I had no idea what I was doing when I wrote it. I created a new branch here

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Wed, Aug 14, 2024 at 02:41:55PM +0200, Michael Niedermayer wrote: > Hi all > > Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? > If so please reply here and list the date before which we would have to > finish the 7.1 release so it can be included with no problems >

Re: [FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

Quoting Nuo Mi (2024-09-24 16:56:46) > On Tue, Sep 24, 2024 at 10:43 PM Nuo Mi wrote: > > Currently, the pure decode speed for 8K is around 27–30 fps. > To achieve stable 8K@30 playback, we may need to go through several rounds > of refactoring and optimization for both the decoder and executor,

Re: [FFmpeg-devel] Uncompressed MP4

Hi, On 9/24/2024 3:22 PM, Devon Sookhoo wrote: > Thanks for responding, I have been struggling to get any responses. I have > tried to use the IRC on Libera, however the server seems to be down. I suspect not too many people resonded on this list since it is more for code review than anything. W

Re: [FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

On Tue, Sep 24, 2024 at 10:43 PM Nuo Mi wrote: > > > On Tue, Sep 24, 2024 at 10:24 PM Zhao Zhili > wrote: > >> >> >> > On Sep 24, 2024, at 22:16, Nuo Mi wrote: >> > >> > Due to the nature of multithreading, using a "ready check" mechanism >> may introduce a deadlock. For example: >> > >> > Supp

Re: [FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

On Tue, Sep 24, 2024 at 10:24 PM Zhao Zhili wrote: > > > > On Sep 24, 2024, at 22:16, Nuo Mi wrote: > > > > Due to the nature of multithreading, using a "ready check" mechanism may > introduce a deadlock. For example: > > > > Suppose all tasks have been submitted to the executor, and the last >

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_demux: merge streams in a LCEVC stream group

Add the LCEVC data stream payloads as packet side data to the main video stream, ensuring the former is always output by the demuxer even if not used by the process. Signed-off-by: James Almer --- configure | 2 +- fftools/ffmpeg.h | 6 + fftools/ffmpeg_demux.c | 296 +

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_demux: factorize the bitstream filtering loop

Will be needed by the following patch. Signed-off-by: James Almer --- fftools/ffmpeg_demux.c | 74 -- 1 file changed, 43 insertions(+), 31 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 13aef15eab..108a4a94bf 100644 --- a/

[FFmpeg-devel] [PATCH 1/3] avcodec: add an LCEVC merger bsf

Signed-off-by: James Almer --- libavcodec/bitstream_filters.c | 1 + libavcodec/bsf/Makefile | 1 + libavcodec/bsf/lcevc_merge_bsf.c | 273 +++ 3 files changed, 275 insertions(+) create mode 100644 libavcodec/bsf/lcevc_merge_bsf.c diff --git a/libavcod

Re: [FFmpeg-devel] [PATCH 2/4] aarch64/vvc: Add apply_bdof

On Sun, Sep 22, 2024 at 1:42 AM Zhao Zhili wrote: > From: Zhao Zhili > > apply_bdof_8_8x16_c:18.7 ( 1.00x) > apply_bdof_8_8x16_neon: 9.7 ( 1.93x) > apply_bdof_8_16x8_c:20.0 ( 1.00x) > apply_b

Re: [FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

> On Sep 24, 2024, at 22:16, Nuo Mi wrote: > > Due to the nature of multithreading, using a "ready check" mechanism may > introduce a deadlock. For example: > > Suppose all tasks have been submitted to the executor, and the last thread > checks the entire list and finds > no ready tasks. It

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

On 15/09/2024 14:41, Anton Khirnov wrote: Quoting Antoni Bizoń (2024-09-13 15:20:16) Hello, I recently upgraded FFmpeg to version 6.1 in my web application and encountered a change while running my app's tests. After the upgrade, ffprobe reported an r_frame_rate of 60/1 instead of the expected

[FFmpeg-devel] [PATCH 2/2] avcodec/vvc: simplify priority logical to improve performance for 4K/8K

For 4K/8K video processing, it's possible to have over 1,000 tasks pending on the executor. In such cases, O(n) and O(log(n)) insertion times are too costly. Reducing this to O(1) will significantly decrease the time spent in critical sections clip

[FFmpeg-devel] [PATCH 1/2] avutils/executor: remove unused ready callback

Due to the nature of multithreading, using a "ready check" mechanism may introduce a deadlock. For example: Suppose all tasks have been submitted to the executor, and the last thread checks the entire list and finds no ready tasks. It then goes to sleep, waiting for a new task. However, for som

[FFmpeg-devel] [PATCH v3] avcodec/riscv: add h264 qpel

From: Niklas Haas Benched on K230 for VLEN 128, SpaceMIT for VLEN 256. C RVV128 C RVV256 avg_h264_qpel_4_mc00_8 33.9 33.6 (1.01x) 40.1 29.6 (1.35x) avg_h264_qpel_4_mc01_8 218.8 89.1 (2.46x) 227.6 92.3 (2.47x) avg_h264_qpel_4_mc02_8 21

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/xan: Add basic input size check

On Sun, Sep 22, 2024 at 11:56:45PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71739/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_WC3_fuzzer-6170301405134848 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe > Sign

Re: [FFmpeg-devel] [PATCH 09/10] avcodec/vble: Allocate buffer later

On Sun, Sep 22, 2024 at 11:56:44PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71727/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VBLE_fuzzer-6126342574243840 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 08/10] swscale/swscale_unscaled: Fix odd height with nv24_to_yuv420p_chroma()

On Mon, Sep 23, 2024 at 12:42:22AM +0200, Ramiro Polla wrote: > Hi, > > On Mon, Sep 23, 2024 at 12:04 AM Michael Niedermayer > wrote: > > > > Fixes: out of array read > > Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer-5876893532880896 > > > > Found-by: continuous fuzzing process > > https:/

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/sgirl edec: Check input length

On Sun, Sep 22, 2024 at 11:56:42PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71712/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGIRLE_fuzzer-5763700835811328 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/imm4: Check input size

On Sun, Sep 22, 2024 at 11:56:41PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71324/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IMM4_fuzzer-5388489435185152 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 04/10] avcodec/svq3: Check for minimum size input

On Sun, Sep 22, 2024 at 11:56:39PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-441125111808 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 03/10] tools/target_swr_fuzzer: Limit the number of samples

On Sun, Sep 22, 2024 at 11:56:38PM +0200, Michael Niedermayer wrote: > Fixes: OOM and Timeout > Fixes: 71254/clusterfuzz-testcase-minimized-ffmpeg_SWR_fuzzer-5941896977907712 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 01/10] tools/target_dec_fuzzer: Add threshold for SRGC

On Sun, Sep 22, 2024 at 11:56:36PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71234/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SRGC_fuzzer-5098445864501248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/osq: Treat sum = 0 as k = 0

On Fri, Sep 20, 2024 at 12:56:31AM +0200, Michael Niedermayer wrote: > We have no valid sample that triggers this so we do not know if this would > decode > correctly, but -inf is not the correct k value > > Fixes: Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:423 > Fixes: -inf is outsi

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

On Fri, Sep 20, 2024 at 06:05:46PM +0100, Frank Plowman wrote: > On 20/09/2024 01:54, James Almer wrote: > > On 9/19/2024 9:34 PM, Michael Niedermayer wrote: > >> On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: > >>> On 9/19/2024 7:56 PM, Michael Niedermayer wrote: > Fixes: shift

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

On 9/23/2024 4:34 PM, Vittorio Giovara wrote: > Should we schedule deprecation for one of the two fields? I agree it's > confusing for end users to check in two fields. Warning: Hot take. IMO r_frame_rate does more harm than good and should be nuked. Possibly avg_frame_rate should also be nuked,

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

On 9/24/2024 12:27 AM, Michael Niedermayer wrote: > An "average" is precissely one number (once the type of average is defined) > Maybe you are thinkin of "approximate" instead of "average" Which doesn't actually represent how it is set usually. Take one grep around libavformat/*.c and you'll see

Re: [FFmpeg-devel] Uncompressed MP4

On 9/23/2024 3:36 PM, Devon Sookhoo wrote: > I'm interested in implementing uncompressed MP4 parsing according to the > newly released ISO/IEC 23001-17:2024. Would anyone be interested in further > discussing this with me? Since, as far as I am aware, there are no official (or unofficial) test vec

Re: [FFmpeg-devel] [PATCH 10/14] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

On 9/23/2024 1:40 PM, Ramiro Polla wrote: > { > +#if 0 > int cpu_flags = av_get_cpu_flags(); Are these '#if 0' throughout this patch intended? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 10/14] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

On Mon, Sep 23, 2024 at 02:40:13PM +0200, Ramiro Polla wrote: > There is an issue with the constants used in YUV to YUV range conversion, > where the upper bound is not respected when converting to mpeg range. > > With this commit, the constants are calculated at runtime, depending on > the bit de

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

On Mon, 23 Sep 2024, Cameron Gutman wrote: On Mon, Sep 23, 2024 at 12:43 PM Zhao Zhili wrote: > On Sep 24, 2024, at 01:24, Cameron Gutman wrote: > > On Mon, Sep 23, 2024 at 6:07 AM Zhao Zhili wrote: >> >> >> >>> On Sep 21, 2024, at 05:39, Martin Storsjö wrote: >>> >>> From: Jan Ekström

Re: [FFmpeg-devel] [PATCH v2] swscale/aarch64: Fix rgb24toyv12 only works with aligned width

On Tue, Sep 24, 2024 at 5:44 AM Zhao Zhili wrote: > > On Sep 18, 2024, at 21:11, Zhao Zhili wrote: > > From: Zhao Zhili > > > > Since c0666d8b, rgb24toyv12 is broken for width non-aligned to 16. > > Add a simple wrapper to handle the non-aligned part. > > > > Signed-off-by: Zhao Zhili > > Co-au

Re: [FFmpeg-devel] [PATCH v2] compat: Fix the fallback definition of stdc_trailing_zeros

Quoting Martin Storsjö (2024-09-24 12:13:37) > While shifting "value" to left, we would iterate through all bits > of an unsigned long long, while we only expect to count through > "size * CHAR_BIT" bits; instead shift bits to the right and just > count the trailing zeros. > > This fixes fate with

[FFmpeg-devel] [PATCH v2] compat: Fix the fallback definition of stdc_trailing_zeros

While shifting "value" to left, we would iterate through all bits of an unsigned long long, while we only expect to count through "size * CHAR_BIT" bits; instead shift bits to the right and just count the trailing zeros. This fixes fate with MSVC. --- Fixed the UB by shifting to the right instead

Re: [FFmpeg-devel] mediacodec and qsv not really hwaccels ?

To elaborate on this, there are two distinct types of hardware decoding support in libavcodec - hwaccels and hardware decoders. Hwaccels are integrated into the corresponding native libavcodec decoder; the decoder does all the high-level header parsing and then hands off parsed headers and remaini

Re: [FFmpeg-devel] [PATCH] compat: Fix the fallback definition of stdc_trailing_zeros

Quoting Martin Storsjö (2024-09-24 10:53:38) > While shifting "value" to left, we would iterate through all bits > of an unsigned long long, while we only expect to count through > "size * CHAR_BIT" bits. > > This fixes fate with MSVC. > --- > compat/stdbit/stdbit.h | 3 ++- > 1 file changed, 2 i

[FFmpeg-devel] [PATCH] compat: Fix the fallback definition of stdc_trailing_zeros

While shifting "value" to left, we would iterate through all bits of an unsigned long long, while we only expect to count through "size * CHAR_BIT" bits. This fixes fate with MSVC. --- compat/stdbit/stdbit.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/compat/stdbit/stdbi

[FFmpeg-devel] [PATCH 03/13] fftools/ffmpeg_enc: stop using OutputStream in hw_device_setup_for_encode()

The only variable accessed from it is AVCodecContext, which we can pass directly. Also, this function currently logs into the AVCodecContext, which is wrong. Log to Encoder instead. --- fftools/ffmpeg_enc.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) dif

[FFmpeg-devel] [PATCH 10/13] fftools/ffmpeg_filter: drop a redundant check

OutputFilterOptions.frame_rates are always NULL if the conditional is true. --- fftools/ffmpeg_filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 4196fd865d..7a37cb1d2d 100644 --- a/fftools/ffmpeg_filter.c +++ b/ff

[FFmpeg-devel] [PATCH 11/13] fftools/ffmpeg_filter: stop accessing OutputStream.[max_]frame_rate

Pass them to ofilter_bind_ost() via OutputFilterOptions, as is done for most other data it needs. OutputStream.[max_]frame_rate/force_fps are no longer used outside of ffmpeg_mux*, and so can be made private. This is a step toward decoupling encoders from muxers. --- fftools/ffmpeg.h |

[FFmpeg-devel] [PATCH 12/13] fftools/ffmpeg_filter: drop the OutputStream parameter to ofilter_bind_ost()

It is no longer used for anything besides a sanity-checking assert. Rename the function to ofilter_bind_enc(), as it no longer has any assumptions about the target being an output stream. --- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_filter.c | 8 fftools/ffmpeg_mux_init.c | 2 +-

[FFmpeg-devel] [PATCH 09/13] fftools/ffmpeg_filter: clarify error message

--- fftools/ffmpeg_filter.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 7ec328e04e..4196fd865d 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1351,8 +1351,10 @@ static int fg_complex_bind_

[FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_enc: do not set output stream codec parameters directly

Have the muxer code read them out of the encoder context in of_stream_init() instead. OutputStream.par_in no longer needs to be public, so can be moved to MuxStream. This is a step towards decoupling encoders from muxers. --- fftools/ffmpeg.h | 6 -- fftools/ffmpeg_enc.c | 7

[FFmpeg-devel] [PATCH 04/13] fftools/ffmpeg_enc: do not set AVStream timebase directly

Instead, pass the encoder context to of_stream_init() and have the muxer take the timebase from there. Note that the muxer can currently access the codec context directly, but that will change in future commits. This is a step towards decoupling encoders from muxers. --- fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg_filter: remove remaining OutputStream usage in init_simple_filtergraph()

With this, nothing in ffmpeg_filter acesses OutputStream anymore, thus there are no more direct ties between filtering and muxing. Rename init_simple_filtergraph() to fg_create_simple() for consistency. --- fftools/ffmpeg.h | 9 + fftools/ffmpeg_filter.c | 22 +++--

[FFmpeg-devel] [PATCH 07/13] fftools/ffmpeg_enc: move set_encoder_id() to ffmpeg_mux_init

This code uses no encoder properties or state besides its name, and is mostly muxer logic, and thus belongs more properly into the muxer. The results of several test change due to different metadata tag order (the "encoder" tag is now set first). --- fftools/ffmpeg_enc.c

[FFmpeg-devel] [PATCH 08/13] fftools/ffmpeg_enc: don't write frame rate/SAR to AVStream directly

Have the muxer code read them out of the encoder context in of_stream_init() instead. This is a step towards decoupling encoders from muxers. --- fftools/ffmpeg_enc.c | 3 +-- fftools/ffmpeg_mux.c | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftoo

[FFmpeg-devel] [PATCH 01/13] doc/ffmpeg; improve wording in the description section

--- doc/ffmpeg.texi | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 34007f7ea2..d43782e2a4 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -21,22 +21,24 @@ ffmpeg [@var{global_options}] @{[@var{input_

[FFmpeg-devel] [PATCH 06/13] fftools/ffmpeg_enc: remove unnecessary pointer references from enc_open()

--- fftools/ffmpeg_enc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 796849fdb9..499d6ea1f3 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -343,7 +343,7 @@ int enc_open(void *opaque, const AVFrame

[FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_enc: add an AVClass to Encoder

Log decoder messages to the encoder rather than OutputStream. This is a step towards decoupling encoders from muxers, similarly to what was previously done to decoders and demuxers. --- fftools/ffmpeg.h | 2 +- fftools/ffmpeg_enc.c | 62 +++ ffto