On Mon, Sep 23, 2024 at 12:42:22AM +0200, Ramiro Polla wrote: > Hi, > > On Mon, Sep 23, 2024 at 12:04 AM Michael Niedermayer > <mich...@niedermayer.cc> wrote: > > > > Fixes: out of array read > > Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer-5876893532880896 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > > --- > > libswscale/swscale_unscaled.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c > > index dc1d5f35932..d403c953cc7 100644 > > --- a/libswscale/swscale_unscaled.c > > +++ b/libswscale/swscale_unscaled.c > > @@ -230,6 +230,8 @@ static void nv24_to_yuv420p_chroma(uint8_t *dst1, int > > dstStride1, > > const uint8_t *src2 = src + srcStride; > > // average 4 pixels into 1 (interleaved U and V) > > for (int y = 0; y < h; y += 2) { > > + if (y + 1 == h) > > + src2 = src1; > > for (int x = 0; x < w; x++) { > > dst1[x] = (src1[4 * x + 0] + src1[4 * x + 2] + > > src2[4 * x + 0] + src2[4 * x + 2]) >> 2; > > I would prefer to keep nv24_to_yuv420p_chroma() expecting height to be > a multiple of 2. We could add && !(c->srcH & 1) before selecting > nv24ToYuv420Wrapper.
what advantage does this have ? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
