Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Paul B Mahol
On Tue, Jun 4, 2024 at 8:53 AM Vittorio Giovara wrote: > On Tue, Jun 4, 2024 at 3:01 AM Cosmin Stejerean via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > > Reposting my question/comment here since Thilo hasn't had a chance to > > > respond, but shouldn't these kinds of requests go throu

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 3:01 AM Cosmin Stejerean via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > > Reposting my question/comment here since Thilo hasn't had a chance to > > respond, but shouldn't these kinds of requests go through the GA? If > > anybody can do whatever they want with the ffmpe

Re: [FFmpeg-devel] [PATCH] x86/aacencdsp: add SSE2 and AVX versions of quantize_bands

2024-06-03 Thread Rémi Denis-Courmont
Le 4 juin 2024 04:23:43 GMT+03:00, James Almer a écrit : >quant_bands_signed_sse2: 417.0 >quant_bands_signed_avx: 202.0 What about unsigned? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To uns

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread Rémi Denis-Courmont
Le 4 juin 2024 00:41:03 GMT+03:00, James Almer a écrit : >Well, no. Breakages are expected when you remove API. The real question is why >so many projects wait until the old API is gone to migrate. What we removed in >7.0 has had its replacement in place for a couple years, since 5.1. Because

Re: [FFmpeg-devel] [PATCH] avcodec: add farbfeld encoder

2024-06-03 Thread Rémi Denis-Courmont
Le 4 juin 2024 00:56:21 GMT+03:00, Andreas Rheinhardt a écrit : >Rémi Denis-Courmont: >> Le maanantaina 3. kesäkuuta 2024, 22.29.13 EEST marcus a écrit : Bogus cast / aliasing violation. >>> >>> I thought qualifiers don't affect aliasing rules in C. Am I wrong? >> >> If they didn't, the c

[FFmpeg-devel] [PATCH v6 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

2024-06-03 Thread Connor Worley
Offers a modest performance gain due to the switch from naive linear probling to robin hood. Signed-off-by: Connor Worley --- libavcodec/dxvenc.c | 119 1 file changed, 32 insertions(+), 87 deletions(-) diff --git a/libavcodec/dxvenc.c b/libavcodec/d

[FFmpeg-devel] [PATCH v6 1/2] lavu/hashtable: create generic robin hood hash table

2024-06-03 Thread Connor Worley
Signed-off-by: Connor Worley --- libavutil/Makefile | 2 + libavutil/hashtable.c | 192 libavutil/hashtable.h | 91 + libavutil/tests/hashtable.c | 110 + 4 files changed, 395 insertions(+) create mo

Re: [FFmpeg-devel] [PATCH] x86/aacencdsp: add SSE2 and AVX versions of quantize_bands

2024-06-03 Thread James Almer
On 6/3/2024 10:42 PM, Andreas Rheinhardt wrote: James Almer: quant_bands_signed_sse2: 417.0 quant_bands_signed_avx: 202.0 Missing benchmark numbers for the C code About 1670. And it doesn't matter as I'm only adding the AVX version (The subject is wrong, copy-paste fail), so i mentioned the

Re: [FFmpeg-devel] [PATCH] x86/aacencdsp: add SSE2 and AVX versions of quantize_bands

2024-06-03 Thread Andreas Rheinhardt
James Almer: > quant_bands_signed_sse2: 417.0 > quant_bands_signed_avx: 202.0 Missing benchmark numbers for the C code > > Signed-off-by: James Almer > --- > libavcodec/aacenc.h | 2 +- > libavcodec/x86/aacencdsp.asm| 27 --- > libavcodec/x86/aacencdsp_

[FFmpeg-devel] [PATCH] x86/aacencdsp: add SSE2 and AVX versions of quantize_bands

2024-06-03 Thread James Almer
quant_bands_signed_sse2: 417.0 quant_bands_signed_avx: 202.0 Signed-off-by: James Almer --- libavcodec/aacenc.h | 2 +- libavcodec/x86/aacencdsp.asm| 27 --- libavcodec/x86/aacencdsp_init.c | 6 ++ tests/checkasm/aacencdsp.c | 4 ++-- 4 files c

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread Michael Niedermayer
On Mon, Jun 03, 2024 at 06:41:03PM -0300, James Almer wrote: > On 6/3/2024 6:32 PM, Michael Niedermayer wrote: > > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > > > On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > > > > On 2024-03-02 20:39:08 -0500, Sean McGovern wr

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Cosmin Stejerean via ffmpeg-devel
> On Jun 3, 2024, at 3:58 PM, Vittorio Giovara > wrote: > > On Mon, Jun 3, 2024 at 10:57 PM Cosmin Stejerean via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > >> >> >>> On Jun 3, 2024, at 12:26 PM, Rémi Denis-Courmont >> wrote: >>> >>> Le maanantaina 3. kesäkuuta 2024, 21.58.48 EEST

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vvcdec: support mv wraparound

2024-06-03 Thread Michael Niedermayer
On Mon, Jun 03, 2024 at 08:51:16PM +0800, Nuo Mi wrote: > A 360 video specific tool > see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 > > passed files: > DMVR_A_Huawei_3.bit > WRAP_D_InterDigital_4.bit > WRAP_A_InterDigital_4.bit > WRAP_B_InterDigital_4.bit > W

Re: [FFmpeg-devel] [PATCH] codec_desc: drop INTRA_ONLY flag for AAC

2024-06-03 Thread Michael Niedermayer
On Sun, Jun 02, 2024 at 07:15:54PM +0200, Lynne via ffmpeg-devel wrote: > Not valid anymore with xHE-AAC. > --- > libavcodec/codec_desc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) breaks fate --- ./tests/ref/fate/mkv2024-06-03 22:55:42.149081056 +0200 +++ tests/data/fat

Re: [FFmpeg-devel] [PATCH] avformat/demux: fix pcm read too much when call find_stream_info

2024-06-03 Thread Michael Niedermayer
On Mon, Jun 03, 2024 at 06:25:34PM +0800, Shiqi Zhu wrote: > Signed-off-by: Shiqi Zhu > --- > libavformat/demux.c| 2 ++ > tests/ref/seek/lavf-al | 4 ++-- > tests/ref/seek/lavf-ul | 4 ++-- > 3 files changed, 6 insertions(+), 4 deletions(-) breaks fate --- ./tests/ref/fate/gapless-mp3

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Vittorio Giovara
On Mon, Jun 3, 2024 at 10:57 PM Cosmin Stejerean via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > > > > On Jun 3, 2024, at 12:26 PM, Rémi Denis-Courmont > wrote: > > > > Le maanantaina 3. kesäkuuta 2024, 21.58.48 EEST Cosmin Stejerean via > ffmpeg- > > devel a écrit : > >> Not sure why you ke

Re: [FFmpeg-devel] [PATCH] area changed: scdet filter

2024-06-03 Thread Michael Niedermayer
On Sun, Jun 02, 2024 at 11:17:29PM +0300, radu.taraib...@gmail.com wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: vineri, 31 mai 2024 00:32 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC.

2024-06-03 Thread Andreas Rheinhardt
Billy O'Neal (VC AIR) via ffmpeg-devel: > Assigning the non-const version to the const version is valid (at least, > builds on other platforms succeeded). > It is not valid: "If a converted pointer is used to call a function whose type is not compatible with the referenced type, the behavior is

Re: [FFmpeg-devel] [PATCH] avcodec: add farbfeld encoder

2024-06-03 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le maanantaina 3. kesäkuuta 2024, 22.29.13 EEST marcus a écrit : >>> Bogus cast / aliasing violation. >> >> I thought qualifiers don't affect aliasing rules in C. Am I wrong? > > If they didn't, the compiler wouldn't warn about incompatible pointer type > conversions in the

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: gracefully ignore mismatching channel layouts for -channel_layout option

2024-06-03 Thread Marton Balint
The very old behaviour of -channel_layout was to simply warn the user about channel layouts which does not have a matching channel count, and ignore them, instead of reporting an error. The recent fix re-added support for overriding -channel_layout, but it rejected mismatching layouts. There is no

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread James Almer
On 6/3/2024 6:32 PM, Michael Niedermayer wrote: On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: On Sat, Mar 2, 2024, 18:19 Michael Niedermayer wrote: On Sun, Mar 03

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread Sean McGovern
On Mon, Jun 3, 2024, 17:32 Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > > On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > > > On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > > > > On Sat, Mar 2, 2024, 18:19 Michael Niedermayer <

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread Michael Niedermayer
On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > > On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > > > On Sat, Mar 2, 2024, 18:19 Michael Niedermayer > > > wrote: > > > > > > > On Sun, Mar 03, 2024 at 12:06:14AM +

[FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: use the newly added channel ids for more exact mapping

2024-06-03 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e65cec74c2..78a3ec6b06 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1668,8 +1668,8 @@ static cons

[FFmpeg-devel] [PATCH 2/3] avformat/mov_chan: make iso_channel_position table more compact

2024-06-03 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mov_chan.c | 164 +++-- 1 file changed, 45 insertions(+), 119 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 53805c6a35..cc5b333129 100644 --- a/libavformat/mov_chan.c +++ b/libavfor

[FFmpeg-devel] [PATCH 1/3] avformat/mov_chan: use the newly added channel ids for more exact mapping

2024-06-03 Thread Marton Balint
Also make the iso_channel_position table consistent with what the AAC decoder uses in avcodec/aac/aacdec_usac.c. Fate changes are caused by the change of how 7.1 layout is mapped, previously it included Side Surround channels, now it includes the Surround channels. Signed-off-by: Marton Balint -

Re: [FFmpeg-devel] [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c()

2024-06-03 Thread Michael Niedermayer
On Mon, Jun 03, 2024 at 10:32:17AM +0300, Rémi Denis-Courmont wrote: > > > Le 31 mai 2024 04:03:24 GMT+03:00, Michael Niedermayer > a écrit : > >> Are you imitating Thilo and grand-standing by putting words in my mouth? > > > >That seems unneccesarily insulting towards Thilo > > This is not an

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Cosmin Stejerean via ffmpeg-devel
> On Jun 3, 2024, at 12:26 PM, Rémi Denis-Courmont wrote: > > Le maanantaina 3. kesäkuuta 2024, 21.58.48 EEST Cosmin Stejerean via ffmpeg- > devel a écrit : >> Not sure why you keep beating this dead horse. > > Err, I think that it is obvious why: > > 1) The questions were not answered back t

[FFmpeg-devel] [PATCH] avformat/tls_schannel: forward AVIO_FLAG_NONBLOCK to tcp stream

2024-06-03 Thread Timo Rothenpieler
From: BtbN Fixes for example rtmps streaming over schannel. --- libavformat/tls_schannel.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index 214a47a218..7265a9794d 100644 --- a/libavformat/tls_schanne

Re: [FFmpeg-devel] [PATCH v2 1/6] lavf/tls_mbedtls: handle more error codes for

2024-06-03 Thread Jan Ekström
On Wed, May 29, 2024 at 2:05 PM sfan5 wrote: > Did an initial tired look at the set, and in general it looks alright and the wrapper still builds with Fedora's mbedtls 2.28.8. (Of course then it fails to link due to unchecked usage of `mbedtls_x509_crt_{init,free,parse_file}` in tls_mbedtls, as

[FFmpeg-devel] [PATCH] avfilter/vf_rotate: Check ff_draw_init2() return value

2024-06-03 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 3_343 Found-by: De3mond Signed-off-by: Michael Niedermayer --- libavfilter/vf_rotate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_rotate.c b/libavfilter/vf_rotate.c index 3adde22c093..3e65f265527 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH] avcodec: add farbfeld encoder

2024-06-03 Thread Rémi Denis-Courmont
Le maanantaina 3. kesäkuuta 2024, 22.29.13 EEST marcus a écrit : > > Bogus cast / aliasing violation. > > I thought qualifiers don't affect aliasing rules in C. Am I wrong? If they didn't, the compiler wouldn't warn about incompatible pointer type conversions in the absence of the explict cast.

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Rémi Denis-Courmont
Le maanantaina 3. kesäkuuta 2024, 21.58.48 EEST Cosmin Stejerean via ffmpeg- devel a écrit : > Not sure why you keep beating this dead horse. Err, I think that it is obvious why: 1) The questions were not answered back then. Calling the people asking questions troll is not answering, it's insult

[FFmpeg-devel] [PATCH 2/2] lavc/vc1dsp: R-V V vc1_inv_trans_8x4

2024-06-03 Thread Rémi Denis-Courmont
T-Head C908: vc1dsp.vc1_inv_trans_8x4_c: 10.5 vc1dsp.vc1_inv_trans_8x4_rvv_i32: 3.5 --- libavcodec/riscv/vc1dsp_init.c | 2 + libavcodec/riscv/vc1dsp_rvv.S | 74 ++ 2 files changed, 76 insertions(+) diff --git a/libavcodec/riscv/vc1dsp_init.c b/libavcodec/ri

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Cosmin Stejerean via ffmpeg-devel
> On Jun 3, 2024, at 11:18 AM, Rémi Denis-Courmont wrote: > > Le maanantaina 3. kesäkuuta 2024, 20.48.08 EEST Cosmin Stejerean via ffmpeg- > devel a écrit : What was cost-problematic about NAB? As far as I know it cost ffmpeg $0. It would be hard for IBC to be less cost-problematic th

Re: [FFmpeg-devel] [WIP PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv

2024-06-03 Thread James Almer
On 6/3/2024 10:02 AM, Zhao Zhili wrote: From: Zhao Zhili --- The test still failed on x86, but success on arm64 and longarch. I have tried to call rgb24ToY_c and ff_rgb24ToY_avx directly and compare the results, they don't match. You're using an incomplete table. See below. https://github

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Rémi Denis-Courmont
Le maanantaina 3. kesäkuuta 2024, 20.48.08 EEST Cosmin Stejerean via ffmpeg- devel a écrit : > >> What was cost-problematic about NAB? As far as I know it cost ffmpeg $0. > >> It would be hard for IBC to be less cost-problematic than that. > > > > > > Booth setup is notoriously expensive due to l

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Cosmin Stejerean via ffmpeg-devel
> On Jun 3, 2024, at 10:36 AM, Rémi Denis-Courmont wrote: > > Le 3 juin 2024 19:43:52 GMT+03:00, Cosmin Stejerean via ffmpeg-devel > a écrit : >> >> >>> On Jun 3, 2024, at 12:55 AM, Rémi Denis-Courmont wrote: >>> >>> IBC is probably not as (cost-)problematic as NAB, w.r.t. setting up the

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Rémi Denis-Courmont
Le 3 juin 2024 19:43:52 GMT+03:00, Cosmin Stejerean via ffmpeg-devel a écrit : > > >> On Jun 3, 2024, at 12:55 AM, Rémi Denis-Courmont wrote: >> >> IBC is probably not as (cost-)problematic as NAB, w.r.t. setting up the >> booth or transportation > >What was cost-problematic about NAB? As fa

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Ronald S. Bultje
Hi, On Mon, Jun 3, 2024 at 12:14 PM Zhao Zhili wrote: > > > > On Jun 3, 2024, at 22:17, Rémi Denis-Courmont wrote: > > > > Le maanantaina 3. kesäkuuta 2024, 16.11.15 EEST Zhao Zhili a écrit : > >>> See https://github.com/mstorsjo/FFmpeg/actions/runs/9346228714 for one > >>> example run of these

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Cosmin Stejerean via ffmpeg-devel
> On Jun 3, 2024, at 12:55 AM, Rémi Denis-Courmont wrote: > > IBC is probably not as (cost-)problematic as NAB, w.r.t. setting up the booth > or transportation What was cost-problematic about NAB? As far as I know it cost ffmpeg $0. It would be hard for IBC to be less cost-problematic than t

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Zhao Zhili
> On Jun 3, 2024, at 22:17, Rémi Denis-Courmont wrote: > > Le maanantaina 3. kesäkuuta 2024, 16.11.15 EEST Zhao Zhili a écrit : >>> See https://github.com/mstorsjo/FFmpeg/actions/runs/9346228714 for one >>> example run of these actions with your patches. >> Wow, it’s very helpful. This is the a

Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC.

2024-06-03 Thread Billy O'Neal (VC AIR) via ffmpeg-devel
Assigning the non-const version to the const version is valid (at least, builds on other platforms succeeded). Would you still like Apple guards? (I'm hesitating only because most upstreams ask for minimal preprocessor use) Thanks for the consideration! Get Outlook for Android

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Tomas Härdin
mån 2024-06-03 klockan 08:50 +0200 skrev Thilo Borgmann via ffmpeg- devel: > Am 02.06.24 um 22:14 schrieb Tomas Härdin: > > sön 2024-06-02 klockan 20:01 +0200 skrev Michael Niedermayer: > > > Hi > > > > > > > > > On Sat, Jun 01, 2024 at 05:19:26PM +0200, Tomas Härdin wrote: > > > > > > [...] > >

[FFmpeg-devel] [PATCH] lavc/vc1dsp: R-V V vc1_inv_trans_8x8

2024-06-03 Thread Rémi Denis-Courmont
T-Head C908: vc1dsp.vc1_inv_trans_8x8_c: 14.7 vc1dsp.vc1_inv_trans_8x8_rvv_i32: 4.7 --- libavcodec/riscv/vc1dsp_init.c | 2 + libavcodec/riscv/vc1dsp_rvv.S | 112 + 2 files changed, 114 insertions(+) diff --git a/libavcodec/riscv/vc1dsp_init.c b/libavcodec/

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Vittorio Giovara
On Mon, Jun 3, 2024 at 8:50 AM Thilo Borgmann via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Am 02.06.24 um 22:14 schrieb Tomas Härdin: > > sön 2024-06-02 klockan 20:01 +0200 skrev Michael Niedermayer: > >> Hi > >> > >> > >> On Sat, Jun 01, 2024 at 05:19:26PM +0200, Tomas Härdin wrote: > >>

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Suppress unused variable warnings

2024-06-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/tiff.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > index 846d817cdc..fd4116aec4 100644 > --- a/libavcodec/tiff.c > +++ b/libavcodec/tiff.c > @@ -422

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Rémi Denis-Courmont
Le maanantaina 3. kesäkuuta 2024, 16.11.15 EEST Zhao Zhili a écrit : > > See https://github.com/mstorsjo/FFmpeg/actions/runs/9346228714 for one > > example run of these actions with your patches. > Wow, it’s very helpful. This is the action result of the updated patch: > > https://github.com/quink

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC

2024-06-03 Thread Andreas Rheinhardt
Christian Bartnik: > From: Thomas Siedel > > Add external encoder VVenC for H266/VVC encoding. > Register new encoder libvvenc. > Add libvvenc to wrap the vvenc interface. > libvvenc implements encoder option: preset,qp,qpa,period, > passlogfile,stats,vvenc-params,level,tier. > Enable encoder by

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC

2024-06-03 Thread Nuo Mi
Hi all, Tested with ./ffmpeg -f lavfi -i testsrc=duration=10:size=1280x720:rate=30 -c:v libvvenc test.mp4 && ./ffplay -strict -2 -i test.mp4 I will merge in 3 days if there are no objections. thank you On Wed, May 29, 2024 at 12:27 AM Christian Bartnik wrote: > From: Thomas Siedel > > Add ext

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Zhao Zhili
> On Jun 3, 2024, at 16:07, Martin Storsjö wrote: > > On Mon, 3 Jun 2024, Zhao Zhili wrote: > >> diff --git a/libswscale/aarch64/input.S b/libswscale/aarch64/input.S >> new file mode 100644 >> index 00..0a46475723 >> --- /dev/null >> +++ b/libswscale/aarch64/input.S >> @@ -0,0 +1,229 @

[FFmpeg-devel] [PATCH 2/5] avcodec/vvcdec: misc, move src offset inside emulated_edge

2024-06-03 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 0843c99eb6..07b55c4bac 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -57,6 +57,8 @@ static void emulated_edge

[FFmpeg-devel] [PATCH 1/5] avcodec/vvcdec: refact, remove emulated_edge_dmvr and emulated_edge_bilinear to simplify code

2024-06-03 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 146 + 1 file changed, 46 insertions(+), 100 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index e1011b4fa1..0843c99eb6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -44,112 +44,

[FFmpeg-devel] [PATCH] lavc/vvc: Reallocate pixel buffers if pixel shift changes

2024-06-03 Thread Frank Plowman
Allocations in the following lines depend on the pixel shift, and so these buffers must be reallocated if the pixel shift changes. Patch fixes segmentation faults in fuzzed bitstreams. Signed-off-by: Frank Plowman --- libavcodec/vvc/dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[FFmpeg-devel] [WIP PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Zhao Zhili
From: Zhao Zhili Test on Apple M1: rgb24_to_uv_1080_c: 7.0 rgb24_to_uv_1080_neon: 5.5 rgb24_to_uv_1280_c: 8.2 rgb24_to_uv_1280_neon: 6.0 rgb24_to_uv_4096_c: 26.2 rgb24_to_uv_4096_neon: 20.7 rgb24_to_uv_half_540_c: 6.5 rgb24_to_uv_half_540_neon: 3.0 rgb24_to_uv_half_640_c: 8.0 rgb24_to_uv_half_6

[FFmpeg-devel] [WIP PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv

2024-06-03 Thread Zhao Zhili
From: Zhao Zhili --- The test still failed on x86, but success on arm64 and longarch. I have tried to call rgb24ToY_c and ff_rgb24ToY_avx directly and compare the results, they don't match. https://github.com/quink-black/FFmpeg/actions/runs/9347753270 https://patchwork.ffmpeg.org/project/ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] lavc/speedhqdec: Add AV_CODEC_CAP_SLICE_THREADS

2024-06-03 Thread Tomas Härdin
tor 2024-05-30 klockan 16:23 +0200 skrev Tomas Härdin: > Ping > > Will push in a couple of days Passes FATE -> pushed /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit l

Re: [FFmpeg-devel] [PATCH] lavc/speedhqenc: Require width to be a multiple of 16

2024-06-03 Thread Tomas Härdin
tor 2024-05-30 klockan 16:23 +0200 skrev Tomas Härdin: > Ping > > This stops us from producing broken output Pushed /Tomass ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit l

[FFmpeg-devel] [PATCH 5/5] avcodec/vvcdec: support mv wraparound

2024-06-03 Thread Nuo Mi
A 360 video specific tool see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 passed files: DMVR_A_Huawei_3.bit WRAP_D_InterDigital_4.bit WRAP_A_InterDigital_4.bit WRAP_B_InterDigital_4.bit WRAP_C_InterDigital_4.bit ERP_A_MediaTek_3.bit --- libavcodec/vvc/inte

[FFmpeg-devel] [PATCH 4/5] avcodec/vvcdec: misc, reindent inter.c

2024-06-03 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 278 - 1 file changed, 139 insertions(+), 139 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index aacd5d8da0..09575eb2b4 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -127,14 +12

[FFmpeg-devel] [PATCH 3/5] avcodec/vvcdec: refact out emulated_edge_no_wrap

2024-06-03 Thread Nuo Mi
prepare for refrence wraparound --- libavcodec/vvc/inter.c | 91 -- 1 file changed, 61 insertions(+), 30 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 07b55c4bac..aacd5d8da0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavco

Re: [FFmpeg-devel] [PATCH v2] avcodec: add farbfeld encoder

2024-06-03 Thread Tomas Härdin
> Check the return value of av_image_get_buffer_size() before adding > HEADER_SIZE to it. There will be a signed overflow (UB) for images of > size 16385x16385 (and many others). Sorry, I missed the multiplication by h+128 in av_image_check_size2(). So this isn't a problem in this specific case.

Re: [FFmpeg-devel] [PATCH v2] avcodec: add farbfeld encoder

2024-06-03 Thread Tomas Härdin
This format seems to reproduce some of the same issues as QOI: > The RGB-data should be sRGB for best interoperability and not alpha- > premultiplied. This seems to imply it could be something other than sRGB since it says SHOULD rather than MUST. This probably isn't a huge issue, but it should

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Rémi Denis-Courmont
Le 3 juin 2024 10:55:45 GMT+03:00, "Rémi Denis-Courmont" a écrit : >Hi, > >IBC is probably not as (cost-)problematic as NAB, w.r.t. setting up the booth >or transportation, assuming people come from Europe, and the booth itself is >paid for. > >Indeed, it was not appropriate for GPAC to use

Re: [FFmpeg-devel] [PATCH v2 3/3] tests/checkasm/vvc_alf: change alf step size to 8

2024-06-03 Thread Bross, Benjamin
> From Benjamin Bross: >> for ALF where functions are in increments of 4 while 8 should be sufficient >> according to the spec. Actually, it is not only the increment but the size has to be a multiple of 8, hence in addition loops should start at 8 instead of at 4. ALF filter and classification

[FFmpeg-devel] [PATCH] avformat/demux: fix pcm read too much when call find_stream_info

2024-06-03 Thread Shiqi Zhu
Signed-off-by: Shiqi Zhu --- libavformat/demux.c| 2 ++ tests/ref/seek/lavf-al | 4 ++-- tests/ref/seek/lavf-ul | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index dc65f9ad91..c878839175 100644 --- a/libavformat/demux.c +++

[FFmpeg-devel] [PATCH] avformat/demux: fix pcm read too much when call find_stream_info

2024-06-03 Thread Shiqi Zhu
Signed-off-by: Shiqi Zhu --- libavformat/demux.c| 4 tests/ref/seek/lavf-al | 4 ++-- tests/ref/seek/lavf-ul | 4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index dc65f9ad91..64b6a1757c 100644 --- a/libavformat/demux.c ++

Re: [FFmpeg-devel] [PATCH 0/1] avfilter/framesync: fix forward EOF pts

2024-06-03 Thread Nicolas Gaullier
>Envoyé : mardi 28 mai 2024 11:11 > >This a new ping but I post the patch again to get fate cleanly completed on >patchwork. >BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc, so >one can say that time has past... > >Thank you in advance for the review. >Nicolas Another

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-03 Thread Stefano Sabatini
On date Tuesday 2024-05-28 18:58:28 +0200, Stefano Sabatini wrote: > On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote: > > Hi, > > > > still missing documentation and might be optimized (and maybe extended > > to support gray16 - this should be simple), comments are welcome. > > U

Re: [FFmpeg-devel] [PATCH] movenc: Add an option for hiding fragments at the end

2024-06-03 Thread Dennis Sädtler via ffmpeg-devel
On 2024-06-03 09:51, Martin Storsjö wrote: Finally, I've also had a somewhat cursed thought about having a second always-hidden ftyp before the initial moov, which would then allow you to use the same file for progressive download and DASH/HLS streaming by using range-requests (e.g. via BYTERAN

Re: [FFmpeg-devel] [PATCH v12 15/15] avcodec/hw_base_encode: add avctx pointer for FFHWBaseEncodeContext

2024-06-03 Thread Wu, Tong1
>From: Lynne >Sent: Wednesday, May 29, 2024 8:02 AM >To: Wu, Tong1 ; FFmpeg development discussions and >patches >Subject: Re: [FFmpeg-devel] [PATCH v12 15/15] avcodec/hw_base_encode: add >avctx pointer for FFHWBaseEncodeContext > >On 29/05/2024 00:53, Wu, Tong1 wrote: >>> From: ffmpeg-devel On

[FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu This patch is to make FFHWBaseEncodeContext a standalone component and avoid getting FFHWBaseEncodeContext from avctx->priv_data. This patch also removes some unnecessary AVCodecContext arguments. For receive_packet call, a small wrapper is introduced. Signed-off-by: Tong Wu ---

[FFmpeg-devel] [PATCH v13 14/15] Changelog: add D3D12VA HEVC encoder changelog

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 03d6b29ad8..ff1efcfea6 100644 --- a/Changelog +++ b/Changelog @@ -12,7 +12,7 @@ version : - qsv_params option added for QSV encoders - VVC decoder

[FFmpeg-devel] [PATCH v13 13/15] avcodec: add D3D12VA hardware HEVC encoder

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu This implementation is based on D3D12 Video Encoding Spec: https://microsoft.github.io/DirectX-Specs/d3d/D3D12VideoEncoding.html Sample command line for transcoding: ffmpeg.exe -hwaccel d3d12va -hwaccel_output_format d3d12 -i input.mp4 -c:v hevc_d3d12va output.mp4 Signed-off-by: T

[FFmpeg-devel] [PATCH v13 12/15] avutil/hwcontext_d3d12va: add Flags for resource creation

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Flags field is added to support diffferent resource creation. Signed-off-by: Tong Wu --- doc/APIchanges| 3 +++ libavutil/hwcontext_d3d12va.c | 2 +- libavutil/hwcontext_d3d12va.h | 8 libavutil/version.h | 2 +- 4 files changed, 13 insertions(+

[FFmpeg-devel] [PATCH v13 08/15] avcodec/vaapi_encode: extract gop configuration and two options to base layer

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu idr_interval and desired_b_depth are moved to HW_BASE_ENCODE_COMMON_OPTIONS. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 54 + libavcodec/hw_base_encode.h | 19 + libavcodec/vaapi_encode.c | 52 +++

[FFmpeg-devel] [PATCH v13 11/15] avcodec/vaapi_encode: extract a free funtion to base layer

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 11 +++ libavcodec/hw_base_encode.h | 2 ++ libavcodec/vaapi_encode.c | 6 +- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index 31

[FFmpeg-devel] [PATCH v13 10/15] avcodec/vaapi_encode: extract a get_recon_format function to base layer

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Surface size and block size parameters are also moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 58 +++ libavcodec/hw_base_encode.h | 12 + libavcodec/vaapi_encode.c | 81 - libavc

[FFmpeg-devel] [PATCH v13 07/15] avcodec/vaapi_encode: extract the init and close function to base layer

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Related parameters such as device context, frame context are also moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 49 ++ libavcodec/hw_base_encode.h | 17 +++ libavcodec/vaapi_encode.c | 90 +++---

[FFmpeg-devel] [PATCH v13 09/15] avcodec/vaapi_encode: extract set_output_property to base layer

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 40 + libavcodec/hw_base_encode.h | 3 +++ libavcodec/vaapi_encode.c | 44 ++--- 3 files changed, 45 insertions(+), 42 deletions(-) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Move receive_packet function to base. This requires adding *alloc, *issue, *output, *free as hardware callbacks. HWBaseEncodePicture is introduced as the base layer structure. The related parameters in VAAPIEncodeContext are also extracted to HWBaseEncodeContext. Then DPB management

[FFmpeg-devel] [PATCH v13 05/15] avcodec/vaapi_encode: move pic->input_surface initialization to encode_alloc

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu When allocating the VAAPIEncodePicture, pic->input_surface can be initialized right in the place. This movement simplifies the send_frame logic and is the preparation for moving vaapi_encode_send_frame to the base layer. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode.c | 8 +

[FFmpeg-devel] [PATCH v13 04/15] avcodec/vaapi_encode: add picture type name to base

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 6 ++ libavcodec/vaapi_encode.c | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_encode.h index c14c174102..858450afa8 100644 --- a/libavcodec/hw

[FFmpeg-devel] [PATCH v13 03/15] avcodec/vaapi_encode: add async_depth to common options

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 10 +- libavcodec/vaapi_encode.c | 13 - libavcodec/vaapi_encode.h | 7 --- libavcodec/vaapi_encode_av1.c | 1 + libavcodec/vaapi_encode_h264.c | 1 + libavcodec/vaapi_encode_h26

[FFmpeg-devel] [PATCH v13 02/15] avcodec/hw_base_encode: add FF_HW_ prefix for two enums

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu PICTURE_TYPE_* and FLAG_* are added FF_HW_ prefix after being moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 20 ++--- libavcodec/vaapi_encode.c | 50 - libavcodec/vaapi_encode_av1.c | 12

[FFmpeg-devel] [PATCH v13 01/15] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-06-03 Thread tong1 . wu-at-intel . com
From: Tong Wu Since VAAPI and future D3D12VA implementation may share some common parameters, a base layer encode context is introduced as vaapi context's base. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 56 + libavcodec/vaapi_encode.h | 39 +

Re: [FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Martin Storsjö
On Mon, 3 Jun 2024, Zhao Zhili wrote: diff --git a/libswscale/aarch64/input.S b/libswscale/aarch64/input.S new file mode 100644 index 00..0a46475723 --- /dev/null +++ b/libswscale/aarch64/input.S @@ -0,0 +1,229 @@ +/* + * Copyright (c) 2024 Zhao Zhili + * + * This file is part of FFmpeg

Re: [FFmpeg-devel] [DON'T MERGE PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv

2024-06-03 Thread Martin Storsjö
On Mon, 3 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili --- I need help on the test. It succeed with the following patch on ARM64, but failed with x86. I'm not sure whether the issue is in the test, or hidden in x86 asm, and I don't know x86 asm. Note that by default, the output of swscale ca

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-03 Thread Rémi Denis-Courmont
Hi, Le 3 juin 2024 09:50:15 GMT+03:00, Thilo Borgmann via ffmpeg-devel a écrit : >We have a booth on IBC this year which again gets sponsored so no costs for >FFmpeg. >Some details are still unclear which is why it's not yet announced. For the sake of clarity, on what basis are, or were, you n

Re: [FFmpeg-devel] [PATCH] movenc: Add an option for hiding fragments at the end

2024-06-03 Thread Martin Storsjö
On Sun, 2 Jun 2024, Dennis Sädtler wrote: On 2024-06-02 21:36, Martin Storsjö wrote: On Sat, 1 Jun 2024, Dennis Sädtler via ffmpeg-devel wrote: Should the ftyp atom also be updated to remove brands no longer required for non-fragmented files? I'm not sure how important that is in real-world s

Re: [FFmpeg-devel] [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c()

2024-06-03 Thread Rémi Denis-Courmont
Le 31 mai 2024 04:03:24 GMT+03:00, Michael Niedermayer a écrit : >> Are you imitating Thilo and grand-standing by putting words in my mouth? > >That seems unneccesarily insulting towards Thilo This is not an insult in the first place, and besides Thilo did put words in mouth to discredit me a

[FFmpeg-devel] [PATCH 2/2] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-03 Thread Zhao Zhili
From: Zhao Zhili Test on Apple M1: rgb24_to_uv_1080_c: 7.0 rgb24_to_uv_1080_neon: 5.5 rgb24_to_uv_1280_c: 8.2 rgb24_to_uv_1280_neon: 6.0 rgb24_to_uv_4096_c: 26.2 rgb24_to_uv_4096_neon: 20.7 rgb24_to_uv_half_540_c: 6.5 rgb24_to_uv_half_540_neon: 3.0 rgb24_to_uv_half_640_c: 8.0 rgb24_to_uv_half_6

[FFmpeg-devel] [DON'T MERGE PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv

2024-06-03 Thread Zhao Zhili
From: Zhao Zhili --- I need help on the test. It succeed with the following patch on ARM64, but failed with x86. I'm not sure whether the issue is in the test, or hidden in x86 asm, and I don't know x86 asm. tests/checkasm/sw_rgb.c | 126 1 file changed,