Re: [FFmpeg-devel] [PATCH 1/2] doc/plans: add a file to list approved projects

2022-08-17 Thread Anton Khirnov
I am very strongly against this. You keep trying to preemptively shield your code from criticism that you're unable to deal with, rather than actually build consensus. Stop that, it will lead to nothing good for you or the project. You also keep insinuating that I'm "blocking" your precious avwri

Re: [FFmpeg-devel] [PATCH 2/2] doc/plans: add AVWriter

2022-08-17 Thread Paul B Mahol
Why reinventing yet another ad-hoc thing. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1 1/3] lavc/decode: Add get_hw_config function

2022-08-17 Thread Wang, Fei W
On Tue, 2022-08-16 at 13:22 +0200, Anton Khirnov wrote: > The commit message is misleading - you are not adding code, you are > moving code. > > Quoting Fei Wang (2022-08-12 14:55:43) > > From: Linjie Fu > > > > Wrap the procedure of getting the hardware config from a pixel > > format > > into a

[FFmpeg-devel] [PATCH v2 3/3] lavc/vaapi_vp9: add surface internal re-allocation capability

2022-08-17 Thread Fei Wang
From: Linjie Fu Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/vaapi_vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_vp9.c b/libavcodec/vaapi_vp9.c index 776382f683..fc6ff0a0f2 100644 --- a/libavcodec/vaapi_vp9.c +++ b/libavcodec/vaap

[FFmpeg-devel] [PATCH v2 2/3] lavc/decode: Add internal surface re-allocate method for hwaccel

2022-08-17 Thread Fei Wang
From: Linjie Fu Add HWACCEL_CAP_INTERNAL_ALLOC flag to indicate hwaccels are able to re-allocate surface internally through ff_decode_get_hw_frames_ctx. So that hwaccels don't need to reinitialize all hw configs when decode parameters change. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --

[FFmpeg-devel] [PATCH v2 1/3] lavc/decode: Warp get_hw_config function

2022-08-17 Thread Fei Wang
From: Linjie Fu Wrap the procedure of getting the hardware config from a pixel format into a function. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/decode.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/libavcodec/deco

[FFmpeg-devel] [PATCH] avformat/avidec: Prevent entity expansion attacks

2022-08-17 Thread Michael Niedermayer
Fixes: Timeout Fixes no testcase, this is the same idea as similar attacks against XML parsers Signed-off-by: Michael Niedermayer --- libavformat/avidec.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 937d9e6ffb

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr

2022-08-17 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Aug 15, 2022 at 01:49:24PM +0200, Andreas Rheinhardt wrote: >> It is done later in ff_mpv_frame_start() (and nobody uses >> current_picture_ptr between setting it in ff_mpv_frame_start()). >> >> (The reason the vsynth*-h263-obmc code changes is because >> the call to

[FFmpeg-devel] [PATCH 2/2] doc/plans: add AVWriter

2022-08-17 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/plans.md | 38 ++ 1 file changed, 38 insertions(+) diff --git a/doc/plans.md b/doc/plans.md index 0d7336e8b4..d96328aabc 100644 --- a/doc/plans.md +++ b/doc/plans.md @@ -4,3 +4,41 @@ Projects listed below have been approve

[FFmpeg-devel] [PATCH 1/2] doc/plans: add a file to list approved projects

2022-08-17 Thread Nicolas George
This file makes it easier to engage in ambitious and/or long-term projects for enhancing FFmpeg by removing earlier the uncertainty of acceptance on principle. Signed-off-by: Nicolas George --- doc/plans.md | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 doc/plans.md Reference

Re: [FFmpeg-devel] [PATCH 2/2] checkasm: sw_scale: Reduce range of test data in the yuv2yuvX test to get closer to real data

2022-08-17 Thread Ronald S. Bultje
Hi, On Wed, Aug 17, 2022 at 4:32 PM Martin Storsjö wrote: > This avoids overflows on some inputs in the x86 case, where the > assembly version would clip/overflow differently from the > C reference function. > > This doesn't seem to be a real issue with actual input data, but > only with the pre

Re: [FFmpeg-devel] API enhancements / broken promises

2022-08-17 Thread Nicolas George
Hi. Michael Niedermayer (12022-08-17): > As i said elsewhere i think replacing BPrint by AVWriter is a good idea. > and also that the TC does to the best of my knowledge have no power in > this case. We first need some patch and disagreement the TC could vote > on. ATM there is no public disagreem

[FFmpeg-devel] [PATCH 2/2] checkasm: sw_scale: Reduce range of test data in the yuv2yuvX test to get closer to real data

2022-08-17 Thread Martin Storsjö
This avoids overflows on some inputs in the x86 case, where the assembly version would clip/overflow differently from the C reference function. This doesn't seem to be a real issue with actual input data, but only with the previous fully random input data. This also makes the test produce a bit m

[FFmpeg-devel] [PATCH 1/2] checkasm: sw_scale: Fix the difference printing for approximate functions

2022-08-17 Thread Martin Storsjö
Don't stop directly at the first differing pixel, but find the one that differs by more than the expected accuracy. Also print the failing value in check_yuv2yuvX. Signed-off-by: Martin Storsjö --- tests/checkasm/sw_scale.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)

Re: [FFmpeg-devel] API enhancements / broken promises

2022-08-17 Thread Michael Niedermayer
Hi On Mon, Aug 15, 2022 at 06:47:34PM +0200, Nicolas George wrote: > Hi. > > Over the years, I have promised quite a few enhancement to FFmpeg's API, > some of them connecting to user interface: stored error messages instead > of just logging, universal serialization of objects into various forma

[FFmpeg-devel] [PATCH 1/1] doc: fix binary values of SI prefixes

2022-08-17 Thread Chema Gonzalez
--- doc/utils.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/utils.texi b/doc/utils.texi index 232a0608b3..627b55d154 100644 --- a/doc/utils.texi +++ b/doc/utils.texi @@ -1073,13 +1073,13 @@ indication of the corresponding powers of 10 and of 2. @item T 10^1

[FFmpeg-devel] [PATCH 0/1] doc: fix binary values of SI prefixes

2022-08-17 Thread Chema Gonzalez
Simple SI/binary fixes. Chema Gonzalez (1): doc: fix binary values of SI prefixes doc/utils.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.37.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailm

[FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo: Allocate encoder-only tables in mpegvideo_enc.c

2022-08-17 Thread Andreas Rheinhardt
This commit moves the encoder-only allocations of the tables owned solely by the main encoder context to mpegvideo_enc.c. This avoids checks in mpegvideo.c for whether we are dealing with an encoder; it also improves modularity (if encoders are disabled, this code will no longer be included in the

Re: [FFmpeg-devel] [PATCH 3/8] avutil/mem: Add av_fast_realloc_array()

2022-08-17 Thread Anton Khirnov
Quoting Tomas Härdin (2022-07-21 23:23:25) > tis 2022-07-12 klockan 16:12 +0200 skrev Andreas Rheinhardt: > > > > Anton really dislikes the av_fast_* naming and instead wants this to > > be > > called av_realloc_array_reuse(). I don't care either way. Any more > > opinions on this (or on the patch

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-17 Thread Tomas Härdin
tor 2022-08-11 klockan 19:35 +0200 skrev Timo Rothenpieler: > On 11.08.2022 19:21, Mark Gaiser wrote: > > > > Here's the conversation requesting this very feature: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-March/293835.html > > I generally agree with the points brought up there. > But my

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: add wallclock option

2022-08-17 Thread Nicolas George
Michael Riedl (12022-08-17): > This is a good idea, I will look into that. Regarding vf_showinfo, I am > working on options to limit the output to certain frames (first N, last N, > only I-frames). I think this will be useful, what do you think? I strongly doubt it, but I will not object if the op

Re: [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles

2022-08-17 Thread Michael Niedermayer
On Tue, Aug 16, 2022 at 12:55:38PM -0700, Philip Langdale wrote: > On Tue, 16 Aug 2022 12:52:52 -0700 > Philip Langdale wrote: > > > On Tue, 16 Aug 2022 19:29:24 +0200 > > Michael Niedermayer wrote: > > > > > > > CClibavutil/hwcontext_vaapi.o > > > > > libavutil/hwcontext_vaapi.c:103:9: err

Re: [FFmpeg-devel] [PATCH 1/8] avutil/mem: Handle fast allocations near UINT_MAX properly

2022-08-17 Thread Tomas Härdin
Any update on this patchset? It's mostly fine as I recall /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subj

[FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Keep data_partitioning in sync between threads

2022-08-17 Thread Andreas Rheinhardt
Fixes frame-threaded decoding of samples created by concatting a video with data partitioning and a video not using it. (Only the MPEG-4 decoder sets this, so it is synced in mpeg4_update_thread_context() despite being a MpegEncContext-field.) Signed-off-by: Andreas Rheinhardt --- libavcodec/mpe

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Anton Khirnov
Quoting Gyan Doshi (2022-08-17 12:53:11) > > > On 2022-08-17 02:35 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-08-17 10:50:43) > >> > >> On 2022-08-17 01:48 pm, Anton Khirnov wrote: > >>> Quoting Thilo Borgmann (2022-08-16 20:48:57) > Am 16.08.22 um 16:10 schrieb Anton Khirnov: > >

Re: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-17 Thread Gyan Doshi
Pushed as d5544f6457ad06987311beda0e4b7c08bf52915c to master and 4e4cc6e56a899f6b4302e80dbcd6b4462f340905 to 5.1 On 2022-08-17 12:43 pm, Gyan Doshi wrote: On 2022-08-17 12:37 pm, Marton Balint wrote: On Wed, 17 Aug 2022, Gyan Doshi wrote: On 2022-08-17 04:36 am, Stefano Sabatini wrote:

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Gyan Doshi
On 2022-08-17 02:35 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-17 10:50:43) On 2022-08-17 01:48 pm, Anton Khirnov wrote: Quoting Thilo Borgmann (2022-08-16 20:48:57) Am 16.08.22 um 16:10 schrieb Anton Khirnov: Quoting Thilo Borgmann (2022-08-15 22:02:09) $subject -Thilo From

Re: [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext

2022-08-17 Thread Andreas Rheinhardt
Alan Kelly: > --- > Remove yuv2yuvX_mmx as it is no longer used. > libswscale/x86/swscale.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 32d441245d..89ef9f5d2b 100644 > --- a/libswscale/x86/swscale.c >

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: add wallclock option

2022-08-17 Thread Nicolas George
Andreas Rheinhardt (12022-08-17): > Basically already exists: > https://ffmpeg.org/pipermail/ffmpeg-devel/2021-August/283434.html Lacks subsecond precision and timezone information, but a good start. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: add wallclock option

2022-08-17 Thread Andreas Rheinhardt
Nicolas George: > Michael Riedl (12022-08-17): >> Signed-off-by: Michael Riedl >> --- >> libavfilter/vf_showinfo.c | 11 +++ >> 1 file changed, 11 insertions(+) > > What is the intended use case? It seems to me very ad-hoc. A fftools > option to add a timestamp to each log line seems a m

[FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext

2022-08-17 Thread Alan Kelly
--- Remove yuv2yuvX_mmx as it is no longer used. libswscale/x86/swscale.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 32d441245d..89ef9f5d2b 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.

Re: [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext

2022-08-17 Thread Andreas Rheinhardt
Alan Kelly: > --- > Call yuv2yuvX_mmxext on line 208 also. > libswscale/x86/swscale.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 32d441245d..e0f90d5c58 100644 > --- a/libswscale/x86/swscale.c > +++ b/li

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Anton Khirnov
Quoting Gyan Doshi (2022-08-17 10:50:43) > > > On 2022-08-17 01:48 pm, Anton Khirnov wrote: > > Quoting Thilo Borgmann (2022-08-16 20:48:57) > >> Am 16.08.22 um 16:10 schrieb Anton Khirnov: > >>> Quoting Thilo Borgmann (2022-08-15 22:02:09) > $subject > > -Thilo > From fe2ff

[FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext

2022-08-17 Thread Alan Kelly
--- Call yuv2yuvX_mmxext on line 208 also. libswscale/x86/swscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 32d441245d..e0f90d5c58 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -205

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: add wallclock option

2022-08-17 Thread Michael Riedl
On 17.08.2022 10:43, Nicolas George wrote: Michael Riedl (12022-08-17): Signed-off-by: Michael Riedl --- libavfilter/vf_showinfo.c | 11 +++ 1 file changed, 11 insertions(+) What is the intended use case? It seems to me very ad-hoc. A fftools option to add a timestamp to each log l

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Nicolas George
Gyan Doshi (12022-08-17): > It's not based on ffmpeg's 'internal representation'. All transform > attributes are stored as a composite in one mathematical object. > Evaluating the matrix values will need to look at all sources of > contribution. So gathering and presenting all these attributes in a

Re: [FFmpeg-devel] [PATCH] avcodec/me_cmp: Remove now incorrect av_assert2()

2022-08-17 Thread Martin Storsjö
On Wed, 17 Aug 2022, Andreas Rheinhardt wrote: Since d69d12a5b9236b9d2f1fd247ea452f84cdd1aaf9 these av_assert2() (or more exactly, the ones in hadamard8_diff8x8_c() and hadamard8_intra8x8_c()) are hit. So just remove all of these asserts. (If the test were improved to know which functions expect

Re: [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext

2022-08-17 Thread Andreas Rheinhardt
Alan Kelly: > --- > libswscale/x86/swscale.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 32d441245d..881a4b7798 100644 > --- a/libswscale/x86/swscale.c > +++ b/libswscale/x86/swscale.c > @@ -211,7 +211,7 @@ s

[FFmpeg-devel] [PATCH] avcodec/me_cmp: Remove now incorrect av_assert2()

2022-08-17 Thread Andreas Rheinhardt
Since d69d12a5b9236b9d2f1fd247ea452f84cdd1aaf9 these av_assert2() (or more exactly, the ones in hadamard8_diff8x8_c() and hadamard8_intra8x8_c()) are hit. So just remove all of these asserts. (If the test were improved to know which functions expect h == 8 and which support any value, the asserts c

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Gyan Doshi
On 2022-08-17 01:48 pm, Anton Khirnov wrote: Quoting Thilo Borgmann (2022-08-16 20:48:57) Am 16.08.22 um 16:10 schrieb Anton Khirnov: Quoting Thilo Borgmann (2022-08-15 22:02:09) $subject -Thilo From fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20

[FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext

2022-08-17 Thread Alan Kelly
--- libswscale/x86/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 32d441245d..881a4b7798 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -211,7 +211,7 @@ static void yuv2yuvX_ ##opt(con

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: add wallclock option

2022-08-17 Thread Nicolas George
Michael Riedl (12022-08-17): > Signed-off-by: Michael Riedl > --- > libavfilter/vf_showinfo.c | 11 +++ > 1 file changed, 11 insertions(+) What is the intended use case? It seems to me very ad-hoc. A fftools option to add a timestamp to each log line seems a more generic and cleaner appr

[FFmpeg-devel] [PATCH v2] avfilter/vf_showinfo: add wallclock option

2022-08-17 Thread Michael Riedl
Signed-off-by: Michael Riedl --- libavfilter/vf_showinfo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 2c8514fc80..1953f777c7 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -43,6 +43,7 @@

Re: [FFmpeg-devel] [PATCH] lavu/tx: implement aarch64 NEON SIMD

2022-08-17 Thread Anton Khirnov
Quoting Paul B Mahol (2022-08-16 18:33:59) > On Tue, Aug 16, 2022 at 1:07 PM Anton Khirnov wrote: > > > Quoting Lynne (2022-08-14 06:31:50) > > > New - Total for len 131072 reps 4096 = 1.942836 s > > > Old - Segfaults > > > > ??? > > > > It is trivial. The fft code in lavc crashes in such case

Re: [FFmpeg-devel] [PATCH v2 2/4] ffmpeg: Add display_matrix option

2022-08-17 Thread Anton Khirnov
Quoting Thilo Borgmann (2022-08-16 20:48:57) > Am 16.08.22 um 16:10 schrieb Anton Khirnov: > > Quoting Thilo Borgmann (2022-08-15 22:02:09) > >> $subject > >> > >> -Thilo > >> From fe2ff114cb004f897c7774753d9cf28298eba82d Mon Sep 17 00:00:00 2001 > >> From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= > >> Dat

Re: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-17 Thread Gyan Doshi
On 2022-08-17 12:37 pm, Marton Balint wrote: On Wed, 17 Aug 2022, Gyan Doshi wrote: On 2022-08-17 04:36 am, Stefano Sabatini wrote:  On date Tuesday 2022-08-16 00:04:10 +0530, Gyan Doshi wrote:  c11fb46731 led to a regression whereby the return code for missing  input or input probe is

[FFmpeg-devel] [PATCH] libavcodec/qsvenc: Add adaptive_i/b to hevc_qsv

2022-08-17 Thread Wenbin Chen
Add adaptive_i/b feature to hevc_qsv. Adaptive_i allows changing of frame type from P and B to I. Adaptive_b allows changing of frame type frome B to P. Signed-off-by: Wenbin Chen --- doc/encoders.texi| 7 +++ libavcodec/qsvenc.c | 9 - libavcodec/qsvenc_hevc.c | 2 ++ 3

Re: [FFmpeg-devel] [PATCH] ffprobe: restore reporting error code for failed inputs

2022-08-17 Thread Marton Balint
On Wed, 17 Aug 2022, Gyan Doshi wrote: On 2022-08-17 04:36 am, Stefano Sabatini wrote: On date Tuesday 2022-08-16 00:04:10 +0530, Gyan Doshi wrote: c11fb46731 led to a regression whereby the return code for missing input or input probe is overridden by writer close return code and hen