On Sun, Dec 12, 2021 at 7:15 AM Soft Works wrote:
> Good Morning,
>
> yesterday, it happened for the 4th and 5th times that another developer
> called my patchset a “hack”.
>
> One time I didn’t ask, but in all other four cases I had distinctly and
> insistingly asked for specifics about how the
Good Morning,
yesterday, it happened for the 4th and 5th times that another developer
called my patchset a “hack”.
One time I didn’t ask, but in all other four cases I had distinctly and
insistingly asked for specifics about how the one has come to that
conclusion and what would be the reasons fo
>
> I'm afraid, the only reply that I have to this is:
>
> - Take my patchset
> - Remove subtitle_pts
> - Get everything working
> (all example command lines in filters.texi)
>
> => THEN start talking
>
> The same goes out to everybody else who keeps telling it can be
> removed and that it's an
> -Original Message-
> From: ffmpeg-devel On Behalf Of Daniel
> Cantarín
> Sent: Sunday, December 12, 2021 12:39 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame\n
> for subtitle handling
>
> > One of the important points to
On 12/9/2021 7:01 AM, Andreas Rheinhardt wrote:
This is an updated and extended version of [1] by Ho Ming Shun
together with some additions by me. Notice that I am unable
to test these patches (not even compilation), so I hope that
others (Ho Ming Shun) do so.
[1]: https://ffmpeg.org/pipermail/f
> -Original Message-
> From: ffmpeg-devel On Behalf Of Daniel
> Cantarín
> Sent: Sunday, December 12, 2021 12:39 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame\n
> for subtitle handling
>
> > One of the important points to
> One of the important points to understand is that - in case of subtitles,
> the AVFrame IS NOT the subtitle event. The subtitle event is actually
> a different and separate entity. (...)
Wouldn't it qualify then as a different abstraction?
I mean: instead of avframe.subtitle_property, perhaps
Thilo Borgmann:
>
>
> On 10 Dec 2021, at 17:46, Michael Niedermayer wrote:
>
>> On Fri, Dec 10, 2021 at 12:36:21PM +0100, Thilo Borgmann wrote:
>>>
>>>
>>> On 10 Dec 2021, at 3:47, zhilizhao(赵志立) wrote:
>>>
> On Dec 10, 2021, at 3:11 AM, Thilo Borgmann
> wrote:
>
> Hi,
>
>>>
On 10 Dec 2021, at 17:46, Michael Niedermayer wrote:
On Fri, Dec 10, 2021 at 12:36:21PM +0100, Thilo Borgmann wrote:
On 10 Dec 2021, at 3:47, zhilizhao(赵志立) wrote:
On Dec 10, 2021, at 3:11 AM, Thilo Borgmann
wrote:
Hi,
add %{localtime_ms}, %{gmtime_ms} functions to the drawtext filter
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, December 11, 2021 6:21 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame\n
> for subtitle handling
>
> On Fri,
> -Original Message-
> From: ffmpeg-devel On Behalf Of Daniel
> Cantarín
> Sent: Saturday, December 11, 2021 9:24 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v23 19/21] avfilter/graphicsub2text: Add
> new graphicsub2text filter (OCR)
>
> > Basically, this is li
Hi Daniel,
I don't think that any of that will be necessary. For the generic ocr
filter, this might make sense, because it is meant to work in
many different situations, different text sizes, different (not
necessarily uniform) backgrounds, static or moving, a wide spectrum
of colours, and no
Signed-off-by: Andreas Rheinhardt
---
libavcodec/decode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index afe2c0c3c1..0912f86a14 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -862,8 +862,8 @@ int avcodec_decod
Improves readability and slightly reduces codesize.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/xsubdec.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c
index b483699d0a..85cd7d1c20 100644
This is possible by incrementing the counter of allocated rects
directly after said allocation succeeded.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/xsubdec.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c
inde
Do this by actually incrementing the counter for the number
of rects at the right time.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ass.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/ass.c b/libavcodec/ass.c
index 907e2d7b88..725e4d42ba 100644
Up until now, various subtitle decoders have not cleaned up
the AVSubtitle on error; this task must not be left to the user
because the documentation explicitly states that the AVSubtitle
"must be freed with avsubtitle_free if *got_sub_ptr is set"
(which it isn't on error).
Leaks happen upon failur
Improves readability and decreases codesize.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/pgssubdec.c | 66 --
1 file changed, 32 insertions(+), 34 deletions(-)
diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssubdec.c
index d2824f5bbf..8a200aa01b
The caller of display_end_segment() frees the AVSubtitle on error
in case ENOMEM is returned or err_recognition is set to explode,
so display_end_segment() doesn't have to.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/pgssubdec.c | 17 -
1 file changed, 4 insertions(+), 13 de
Signed-off-by: Andreas Rheinhardt
---
libavcodec/pgssubdec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssubdec.c
index 388639a110..2d5700a51e 100644
--- a/libavcodec/pgssubdec.c
+++ b/libavcodec/pgssubdec.c
@@ -677,7 +677,8 @@ stat
This piece of code has been added as FFmpeg's answer to
infinite loops in try_decode_frame() in commit
6072a19b4f311cb172d45e90daad90824e40e4b6. There is no loop
around try_decode_frame() any more, so this code can be removed.
This code is only triggered in case a) the codec parameter could
not be
When flushing, try_decode_frame() itself loops until the desired
properties have been found or the decoder is drained.
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/libavformat/demux.c b/libavformat/demux.c
i
This puts it directly near the NALU type which is more natural
and furthermore reduces the size of the structure because it
can be placed in padding (on 64-bit systems).
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h2645_parse.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
Forgotten in 03b82b3ab9883cef017e513c7d0b3b986b3b3e7b.
(Moving data to the front is only done to make existing
initializations like H2645NAL nal = { NULL } not emit int->pointer
conversion warnings.)
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h2645_parse.c | 3 +--
libavcodec/h2645_parse.
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, December 11, 2021 6:03 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v23 16/21] avfilter/textmod: Add textmod,
> censor and show_speaker filters
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, December 11, 2021 6:21 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Prepare AVFrame\n
> for subtitle handling
>
> On Fri,
> -Original Message-
> From: ffmpeg-devel On Behalf Of Daniel
> Cantarín
> Sent: Saturday, December 11, 2021 4:18 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v23 19/21] avfilter/graphicsub2text: Add
> new graphicsub2text filter (OCR)
>
> Hi there softworkz.
>
On Fri, Dec 10, 2021 at 03:02:32PM +, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Daniel
> > Cantarín
> > Sent: Thursday, December 9, 2021 10:33 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v20 02/20] avutil/frame: Pre
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, December 11, 2021 6:03 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v23 16/21] avfilter/textmod: Add textmod,
> censor and show_speaker filters
>
On Sat, Dec 11, 2021 at 04:24:14PM +, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Michael
> > Niedermayer
> > Sent: Saturday, December 11, 2021 4:33 PM
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] [PATCH v23
Niklas Haas:
> From: Niklas Haas
>
> Signed-off-by: Niklas Haas
> ---
> doc/APIchanges| 3 ++
> libavutil/dovi_meta.h | 116 ++
> libavutil/frame.c | 1 +
> libavutil/frame.h | 9 +++-
> libavutil/version.h | 2 +-
> 5 files chan
On Fri, Dec 10, 2021 at 09:37:53PM +, Soft Works wrote:
> - textmod {S -> S)
> Modify subtitle text in a number of ways
>
> - censor {S -> S)
> Censor subtitles using a word list
>
> - show_speaker {S -> S)
> Prepend speaker names from ASS subtitles to the visible text lines
>
> Signed
Niklas Haas:
> On Sat, 11 Dec 2021 15:02:14 +0100 Andreas Rheinhardt
> wrote:
>> verification
>
> Fixed
>
>> lavu
>
> Fixed
>
>> Why is this always compiled when only the HEVC decoder needs it?
>> (The way it is now will cause linking errors when CONFIG_GOLOMB is false.)
>
> In principle, pa
Hi there softworkz.
Having worked before with OCR filter output, I suggest you a
modification for your new filter.
It's not something that should delay the patch, but just a nice addenum.
Could be done in another patch, or could even do it myself in the
future. But I let the comment here anywa
On Sat, 11 Dec 2021 15:02:14 +0100 Andreas Rheinhardt
wrote:
> verification
Fixed
> lavu
Fixed
> Why is this always compiled when only the HEVC decoder needs it?
> (The way it is now will cause linking errors when CONFIG_GOLOMB is false.)
In principle, parsing the RPU contents is orthogonal
Derek Buitenhuis:
> On 12/11/2021 2:47 PM, Andreas Rheinhardt wrote:
>> 11200 lines for the fate ref file. Don't you think that is a bit excessive?
>
> That would be my fault - it is an existing test.
>
Thanks for the info. Didn't notice that (just saw that there was no
deletion at all).
> I su
On 12/11/2021 2:47 PM, Andreas Rheinhardt wrote:
> 11200 lines for the fate ref file. Don't you think that is a bit excessive?
That would be my fault - it is an existing test.
I supposed there could be a separte commit to limit it?
- Derek
___
ffmpeg-d
Niklas Haas:
> From: Niklas Haas
>
> And expose the parsed values as frame side data. Update FATE results to
> match.
>
> It's worth documenting that this relies on the dovi configuration record
> being present on the first AVPacket fed to the decoder, which in
> practice is the case if if the A
On Sat, 11 Dec 2021 13:58:53 +0100 Andreas Rheinhardt
wrote:
> Why are you using so many av_log calls? Every one of them poses the risk
> of the output being torn apart by other av_log calls (with a different
> logctx); and of course, it also leads to lower performance and bigger
> binary size.
Niklas Haas:
> From: Niklas Haas
>
> Based on a mixture of guesswork, partial documentation in patents, and
> reverse engineering of real-world samples. Confirmed working for all the
> samples I've thrown at it.
>
> Contains some annoying machinery to persist these values in between
> frames, wh
Niklas Haas:
> From: Niklas Haas
>
> Signed-off-by: Niklas Haas
> ---
> libavfilter/vf_showinfo.c | 108 ++
> 1 file changed, 108 insertions(+)
>
> diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
> index 62c7833247..8a7efc15b7 100644
> ---
From: Niklas Haas
Based on a mixture of guesswork, partial documentation in patents, and
reverse engineering of real-world samples. Confirmed working for all the
samples I've thrown at it.
Contains some annoying machinery to persist these values in between
frames, which is needed in theory even
From: Jan Ekström
Co-authored-by: Niklas Haas
---
fftools/ffprobe.c | 173 +-
1 file changed, 170 insertions(+), 3 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 0711e02922..75263cd3a9 100644
--- a/fftools/ffprobe.c
+++ b/fftoo
From: Niklas Haas
Signed-off-by: Niklas Haas
---
libavfilter/vf_showinfo.c | 108 ++
1 file changed, 108 insertions(+)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 62c7833247..8a7efc15b7 100644
--- a/libavfilter/vf_showinfo.c
+++
From: Niklas Haas
Signed-off-by: Niklas Haas
---
doc/APIchanges| 3 ++
libavutil/dovi_meta.h | 116 ++
libavutil/frame.c | 1 +
libavutil/frame.h | 9 +++-
libavutil/version.h | 2 +-
5 files changed, 129 insertions(+), 2 deletio
On Fri, 10 Dec 2021 19:06:15 +0100 Marton Balint wrote:
> Don't we already have av_format_inject_global_side_data() for something
> like this? It is not enabled by default however, only for ffplay, but I am
> not sure why.
Indeed, that seems to do exactly what we need - while testing though I
n
will apply soon
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On Sat, Dec 11, 2021 at 4:47 AM wrote:
>
> On Sat, Dec 11, 2021 at 03:06:42AM +, Guo, Yejun wrote:
> >
> >
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > lance.lmw...@gmail.com
> > Sent: 2021年12月9日 22:37
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Limin Wang
> > Subject:
48 matches
Mail list logo
