On Sat, 11 Dec 2021 13:58:53 +0100 Andreas Rheinhardt <andreas.rheinha...@outlook.com> wrote: > Why are you using so many av_log calls? Every one of them poses the risk > of the output being torn apart by other av_log calls (with a different > logctx); and of course, it also leads to lower performance and bigger > binary size.
I copied the style that I observed in the rest of the file, Compare dump_dynamic_hdr_plus or dump_sei_film_grain_params_metadata. They all use the same pattern of one av_log call per fragment of text. I agree that it's poor style, but it appears to be the status quo. Ps. With the inclusion of ffprobe support, I no longer particularly care about the vf_showinfo patch making it in. Maybe that filter ought to be deleted and replaced by some common mechanism based on the ffprobe code? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
