[FFmpeg-devel] [PATCH v2] avformat/libsrt: add snddropdelay parameter for srt

2021-10-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 9 + libavformat/libsrt.c | 7 +++ 2 files changed, 16 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 726e5f1..7951abb 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1496,6

Re: [FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

2021-10-09 Thread lance . lmwang
On Sun, Oct 10, 2021 at 01:22:49AM +0800, "zhilizhao(赵志立)" wrote: > > > > On Sep 30, 2021, at 9:14 AM, lance.lmw...@gmail.com wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/protocols.texi | 10 ++ > > libavformat/libsrt.c | 7 +++ > > 2 files ch

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_lut3d: add x86-optimized tetrahedral interpolation

2021-10-09 Thread Mark Reid
On Sat, Oct 9, 2021 at 4:11 AM Paul B Mahol wrote: > will test and apply shortly, why 8bit is not covered? > Thanks for taking the time to test. I didn't do 8bit yet because I was trying to limit my testing matrix, and these happen to be my main use cases. I hope to try and incrementally add oth

Re: [FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

2021-10-09 Thread zhilizhao(赵志立)
> On Sep 30, 2021, at 9:14 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 10 ++ > libavformat/libsrt.c | 7 +++ > 2 files changed, 17 insertions(+) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > inde

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mux: Avoid overhead of packet list in case of single streams

2021-10-09 Thread Andreas Rheinhardt
Hendrik Leppkes: > On Sat, Oct 9, 2021 at 5:14 PM Andreas Rheinhardt > wrote: >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/internal.h | 7 +++ >> libavformat/mux.c | 11 ++- >> 2 files changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/inte

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mux: Avoid overhead of packet list in case of single streams

2021-10-09 Thread Hendrik Leppkes
On Sat, Oct 9, 2021 at 5:14 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/internal.h | 7 +++ > libavformat/mux.c | 11 ++- > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavformat/internal.h b/libavformat/internal

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mpegts: use named constants for stream_id types

2021-10-09 Thread Marton Balint
On Wed, 22 Sep 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mpegts.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) Will apply the series. Regards, Marton diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414..fc

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mux: Avoid overhead of packet list in case of single streams

2021-10-09 Thread James Almer
On 10/9/2021 12:14 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/internal.h | 7 +++ libavformat/mux.c | 11 ++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 223befdbc0

Re: [FFmpeg-devel] [PATCH 3/3] avformat/nullenc: Use ff_interleave_packet_passthrough()

2021-10-09 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mux: Avoid overhead of packet list in case of single streams

2021-10-09 Thread Paul B Mahol
lgtm, nice ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] avformat/nullenc: Use ff_interleave_packet_passthrough()

2021-10-09 Thread Andreas Rheinhardt
It avoids the overhead of the packet list; furthermore, using ff_interleave_packet_per_dts() is wrong for the null muxer anyway, because said muxer accepts packets without timestamps, which ff_interleave_packet_per_dts() can't handle. Signed-off-by: Andreas Rheinhardt --- libavformat/nullenc.c |

[FFmpeg-devel] [PATCH 2/3] avformat/mux: Avoid overhead of packet list in case of single streams

2021-10-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/internal.h | 7 +++ libavformat/mux.c | 11 ++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 223befdbc0..867b5de514 100644 --- a/libavformat/internal.h +++ b

[FFmpeg-devel] [PATCH 1/3] avformat/mux: Store pointer to interleavement func in FFFormatContext

2021-10-09 Thread Andreas Rheinhardt
It avoids branches lateron and will allow to easily avoid the overhead of the linked list currently in use in case there is only one stream. Signed-off-by: Andreas Rheinhardt --- libavformat/internal.h | 6 ++ libavformat/mux.c | 17 +++-- 2 files changed, 9 insertions(+),

Re: [FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

2021-10-09 Thread lance . lmwang
On Thu, Sep 30, 2021 at 09:14:00AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 10 ++ > libavformat/libsrt.c | 7 +++ > 2 files changed, 17 insertions(+) > > diff --git a/doc/protocols.texi b/doc/protocols.te

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/tests/filtfmts: Replace macro by ordinary function

2021-10-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This is possible now that AVFilterFormatsConfig exists. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/tests/filtfmts.c | 77 > 1 file changed, 42 insertions(+), 35 deletions(-) > > diff --git a/libavfilter/tests/filtfmts.c b

Re: [FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-09 Thread James Almer
On 10/9/2021 12:07 AM, Xiang, Haihao wrote: On Fri, 2021-10-08 at 10:32 -0300, James Almer wrote: Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can be used in

Re: [FFmpeg-devel] [PATCH 5/8] avfilter/asrc_flite: Don't segfault when using list_voices option

2021-10-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Could also happen if initializing flite failed* or if an unknown voice > has been selected or if registering the voice failed. > > *: which it currently can't, because it is a no-op. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/asrc_flite.c | 10 ++ >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Reset state also on failure in matroska_reset_status()

2021-10-09 Thread Michael Niedermayer
On Thu, Jun 24, 2021 at 10:57:22PM +0200, Michael Niedermayer wrote: > The calling code does not handle failures and will fail with assertion > failures later. > Seeking can always fail even when the position was previously read. > > Fixes: Assertion failure > Fixes: > 35253/clusterfuzz-testcase

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/caca: Make deinit function out of write_trailer

2021-10-09 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avdevice/caca: Don't free AVOpt-enabled string manually

2021-10-09 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] ARM Hardware Request

2021-10-09 Thread Michael Niedermayer
On Fri, Oct 08, 2021 at 09:38:53PM +0200, J. Dekker wrote: > > > On 8 Oct 2021, at 10:25, Thilo Borgmann wrote: > >> Hi, > >> > >> I'm writing ARM64 ASM and testing on Apple M1 and Graviton2 N1 devices. > >> This, however, is not a good spread of micro-architectures among commonly > >> used ARM

Re: [FFmpeg-devel] [PATCH] avdevice/xv: Increase array size

2021-10-09 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: add audio signal to distortion ratio filter

2021-10-09 Thread Paul B Mahol
Will apply improved version with documentation additions shortly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

[FFmpeg-devel] [PATCH] avdevice/xv: Increase array size

2021-10-09 Thread Andreas Rheinhardt
av_image_copy() expects an array of four pointers according to its declaration; although it currently only touches pointers that are actually in use (depending upon the pixel format) this might change at any time (as has already happened for the linesizes in d7bc52bf456deba0f32d9fe5c288ec441f1ebef5

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_lut3d: add x86-optimized tetrahedral interpolation

2021-10-09 Thread Paul B Mahol
will test and apply shortly, why 8bit is not covered? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscr

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/af_atilt: Constify filter

2021-10-09 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Add AVFILTER_FLAG_SUPPORT_COMMANDS

2021-10-09 Thread Nicolas George
Andreas Rheinhardt (12021-10-09): > Quite a lot of these process_command callbacks are actually quite > boilerplate; lots of them are just ff_filter_process_command(). I > actually intended to factor out this common part in a subsequent patch: > https://github.com/mkver/FFmpeg/commits/process_comma

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Add AVFILTER_FLAG_SUPPORT_COMMANDS

2021-10-09 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-10-09): >> Currently an API user has no easy way that always works to know >> whether an AVFilter supports commands. One can check for whether >> the filter has any AVOption with AV_OPT_FLAG_RUNTIME_PARAM set, >> but this is a bit of extra work and more i

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Add AVFILTER_FLAG_SUPPORT_COMMANDS

2021-10-09 Thread Nicolas George
Andreas Rheinhardt (12021-10-09): > Currently an API user has no easy way that always works to know > whether an AVFilter supports commands. One can check for whether > the filter has any AVOption with AV_OPT_FLAG_RUNTIME_PARAM set, > but this is a bit of extra work and more importantly it doesn't

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h274: Fix signed left shift

2021-10-09 Thread Michael Niedermayer
On Tue, Oct 05, 2021 at 12:23:49AM +0200, Michael Niedermayer wrote: > Fixes: > 39463/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5736517629247488 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 3/3] avformat/wavdec: Check smv_block_size

2021-10-09 Thread Michael Niedermayer
On Tue, Oct 05, 2021 at 12:23:50AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 39554/clusterfuzz-testcase-minimized-ffmpeg_dem_WAV_fuzzer-4915221701984256 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rmdec: Check for multiple audio_stream_info

2021-10-09 Thread Michael Niedermayer
On Wed, Sep 29, 2021 at 09:16:27PM +0200, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 39166/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-5153276690038784 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_slice: Check idr_pic_id

2021-10-09 Thread Michael Niedermayer
On Wed, Sep 29, 2021 at 09:16:29PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 39223/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5498831521841152 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/

[FFmpeg-devel] [PATCH 2/2] avdevice/caca: Don't free AVOpt-enabled string manually

2021-10-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavdevice/caca.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavdevice/caca.c b/libavdevice/caca.c index 90afb3b02d..5536fd036e 100644 --- a/libavdevice/caca.c +++ b/libavdevice/caca.c @@ -45,8 +45,6 @@ static void caca_deinit(AVFormatContext *s)

[FFmpeg-devel] [PATCH 1/2] avdevice/caca: Make deinit function out of write_trailer

2021-10-09 Thread Andreas Rheinhardt
Fixes memleaks in case the trailer is never written. Signed-off-by: Andreas Rheinhardt --- libavdevice/caca.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/libavdevice/caca.c b/libavdevice/caca.c index 5e8d40a748..90afb3b02d 100644 --- a/libavdevice/caca.

[FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Add AVFILTER_FLAG_SUPPORT_COMMANDS

2021-10-09 Thread Andreas Rheinhardt
Currently an API user has no easy way that always works to know whether an AVFilter supports commands. One can check for whether the filter has any AVOption with AV_OPT_FLAG_RUNTIME_PARAM set, but this is a bit of extra work and more importantly it doesn't work for all filters: anequalizer, ladspa,

[FFmpeg-devel] [PATCH 3/3] fftools/cmdutils: Don't read internal AVFilter process_command field

2021-10-09 Thread Andreas Rheinhardt
Instead use the new AVFILTER_FLAG_SUPPORT_COMMANDS for this. Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 2c8e98982f..4b464a2f87 100644 --- a/fftools/cmdutils.c +++ b/fft

[FFmpeg-devel] [PATCH 1/3] avfilter/af_atilt: Constify filter

2021-10-09 Thread Andreas Rheinhardt
(It is actually UB if a declaration and its definition differ wrt their types like they do in this case (the declaration in allfilters is const).) Signed-off-by: Andreas Rheinhardt --- libavfilter/af_atilt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_atilt