Andreas Rheinhardt (12021-10-09):
> Quite a lot of these process_command callbacks are actually quite
> boilerplate; lots of them are just ff_filter_process_command(). I
> actually intended to factor out this common part in a subsequent patch:
> https://github.com/mkver/FFmpeg/commits/process_command This would make
> the flag non-redundant, because then quite a lot of filters supporting
> commands would no longer have a process_command callback at all.

If they are just ff_filter_process_command(), then the best course of
action is to just make them ff_filter_process_command(), directly in the
callback. No flag required.

> And adding a getter for something that is essentially a flag is IMO very
> inelegant.

Maintaining an information manually when it can be derived from a more
authoritative source is worse.

Regards,

-- 
  Nicolas George

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to