Re: [FFmpeg-devel] [PATCH 15/23] dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation

2021-03-11 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: 2021年3月11日 5:55 To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt Subject: [FFmpeg-devel] [PATCH 15/23] dnn/dnn_backend_nati

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

2021-03-11 Thread Xiang, Haihao
On Wed, 2021-02-24 at 09:41 +0800, Fei Wang wrote: > The option allow user to set diffenent scaling mode from > auto/low-power/high-quality. > > More details: > https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#mfxExtVPPScaling > > Signed-off-by: Fei Wang > --- > liba

Re: [FFmpeg-devel] [PATCH V2] libavcodec/qsvdec.c: using queue count to unref frame

2021-03-11 Thread Xiang, Haihao
On Fri, 2021-03-12 at 10:44 +0800, wenbin.c...@intel.com wrote: > From: "Chen,Wenbin" > > MSDK vc1 and av1 sometimes output frame into the same suface, but > ffmpeg-qsv assume the surface will be used only once, so it will > unref the frame when it receives the output surface. Now change > it to

Re: [FFmpeg-devel] [PATCH v1] lavfi/qsvvpp: support async depth

2021-03-11 Thread Xiang, Haihao
On Wed, 2021-01-27 at 09:42 +0800, Fei Wang wrote: > Async depth will allow qsv filter cache few frames, and avoid force > switch and end filter task frame by frame. This change will improve > performance for some multi-task case, for example 1:N transcode( > decode + vpp + encode) with all QSV plu

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-11 Thread Suji Velupillai
Thank you for the review, please see inline. On Thu, Mar 11, 2021 at 2:56 PM Lynne wrote: > Mar 11, 2021, 23:09 by suji.velupil...@broadcom.com: > > > From: Suji Velupillai > > > > Initial commit to add VKAPI hardware accelerator implementation. > > The depedency component vkil source code can

[FFmpeg-devel] [PATCH V2] libavcodec/qsvdec.c: using queue count to unref frame

2021-03-11 Thread wenbin . chen
From: "Chen,Wenbin" MSDK vc1 and av1 sometimes output frame into the same suface, but ffmpeg-qsv assume the surface will be used only once, so it will unref the frame when it receives the output surface. Now change it to unref frame according to queue count. Signed-off-by Wenbin Chen --- libav

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-11 Thread Lynne
Mar 12, 2021, 02:04 by suji.velupil...@broadcom.com: > Thank you for the review, please see inline. > > On Thu, Mar 11, 2021 at 2:56 PM Lynne wrote: > >> > +/** >> > + * Convert AVPixelFormat to VKAPI equivalent pixel format >> > + */ >> > +int (*av2vk_fmt)(enum AVPixelFormat pixe

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: using queue count to unref frame

2021-03-11 Thread Xiang, Haihao
On Thu, 2021-03-11 at 08:44 +, Chen, Wenbin wrote: > > -Original Message- > > From: Xiang, Haihao > > Sent: Thursday, March 11, 2021 4:39 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Chen, Wenbin > > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: using queue count > > to unref

[FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-11 Thread suji . velupillai
From: Suji Velupillai Initial commit to add VKAPI hardware accelerator implementation. The depedency component vkil source code can be obtained from github https://github.com/Broadcom/vkil Signed-off-by: Suji Velupillai --- configure | 8 +- doc/APIchanges

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-11 Thread James Almer
On 3/11/2021 7:09 PM, suji.velupil...@broadcom.com wrote: From: Suji Velupillai Initial commit to add VKAPI hardware accelerator implementation. The depedency component vkil source code can be obtained from github https://github.com/Broadcom/vkil Signed-off-by: Suji Velupillai --- configure

Re: [FFmpeg-devel] [PATCH 15/23] dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation

2021-03-11 Thread Guo, Yejun
> -Original Message- > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Andreas Rheinhardt > >> Sent: 2021年3月11日 5:55 > >> To: ffmpeg-devel@ffmpeg.org > >> Cc: Andreas Rheinhardt > >> Subject: [FFmpeg-devel] [PATCH 15/23] > >> dnn/dnn_backend_native_layer_conv2d:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 7:40 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated a

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-11 Thread Marton Balint
On Sun, 7 Mar 2021, Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: > On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: > >> On 3/6/2021 9:51 PM, Paul B Mahol wrote: >> > On Sun,

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2021-03-11 Thread Lynne
Mar 11, 2021, 23:09 by suji.velupil...@broadcom.com: > From: Suji Velupillai > > Initial commit to add VKAPI hardware accelerator implementation. > The depedency component vkil source code can be obtained from github > https://github.com/Broadcom/vkil > Is this code for hardware that no one will

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not correctl

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add missing include for buffer_size_t

2021-03-11 Thread James Almer
On 3/11/2021 5:37 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:40 PM, James Almer wrote: Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer ---   libavdevice/decklink_dec.cpp | 1 +   libavdevice/decklink

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-11 Thread James Almer
On 3/11/2021 4:54 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 09:42:03AM -0300, James Almer wrote: In addition to the fact that av_image_copy() cannot handle hardware pixel formats, h->short_ref[0]->f may not be writable at this point. Based on a patch by Hendrik Leppkes. Signed-of

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Michael Niedermayer
On Thu, Mar 11, 2021 at 07:01:21PM +0100, Anton Khirnov wrote: > Quoting Derek Buitenhuis (2021-03-11 12:50:03) > > > the API user should receive valid timestamps and not need to handle that. > > > it cannot be expected that every API user carries around workarounds for > > > random > > > muxer bu

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 5:08 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 3:26 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 2:48 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add missing include for buffer_size_t

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: On 3/11/2021 1:40 PM, James Almer wrote: Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + 2 files changed, 2 insertion

Re: [FFmpeg-devel] [PATCH] avcodec/gifenc: Actually use the shrunk palette

2021-03-11 Thread Derek Buitenhuis
On 10/03/2021 15:20, Derek Buitenhuis wrote: > I have no idea how nobody, including myself, noticed this. > > Signed-off-by: Derek Buitenhuis > --- > libavcodec/gif.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Will push in a few hours if nobody objects. - Derek _

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Andreas Rheinhardt
James Almer: > On 3/11/2021 3:26 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/11/2021 2:48 PM, Andreas Rheinhardt wrote: James Almer: > On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: James Almer

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-11 Thread Michael Niedermayer
On Thu, Mar 11, 2021 at 09:42:03AM -0300, James Almer wrote: > In addition to the fact that av_image_copy() cannot handle hardware pixel > formats, > h->short_ref[0]->f may not be writable at this point. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > This versio

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add missing include for buffer_size_t

2021-03-11 Thread James Almer
On 3/11/2021 1:40 PM, James Almer wrote: Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/libavdevice/decklink_dec.

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 3:26 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 2:48 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:11 PM, Marton Balint wrote:

[FFmpeg-devel] [WANTED] Fix incorrect audio duration reporting

2021-03-11 Thread Paul B Mahol
Hi, With latest master and with any audio only file, using "ffmpeg -i file -f null -" reports incorrect duration. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Andreas Rheinhardt
James Almer: > On 3/11/2021 2:48 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: James Almer: > On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/11/2021 1:11 PM, Marton Balint wrote: >>>

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Paul B Mahol
On Thu, Mar 11, 2021 at 7:01 PM Anton Khirnov wrote: > Quoting Derek Buitenhuis (2021-03-11 12:50:03) > > > the API user should receive valid timestamps and not need to handle > that. > > > it cannot be expected that every API user carries around workarounds > for random > > > muxer bugs. That wo

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 2:48 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Anton Khirnov
Quoting Derek Buitenhuis (2021-03-11 12:50:03) > > the API user should receive valid timestamps and not need to handle that. > > it cannot be expected that every API user carries around workarounds for > > random > > muxer bugs. That would be really alot of duplicated code > > This is a HARD disa

Re: [FFmpeg-devel] DRM decryption with FFmpeg

2021-03-11 Thread Reimar Döffinger
> On 9 Mar 2021, at 10:44, zsugabubus > wrote: > > Hi all, > > I was not able to find any patches or mails, only two open tickets that > mention DRM decryption in some way: > > https://trac.ffmpeg.org/ticket/1793 > https://trac.ffmpeg.org/ticket/1800 > > ...however there were no updates for

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Andreas Rheinhardt
James Almer: > On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: James Almer: > On 3/11/2021 1:11 PM, Marton Balint wrote: >> >> >> On Thu, 11 Mar 2021, James Almer wrote: >> >>> This function acts as a r

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 2:27 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet()

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Andreas Rheinhardt
James Almer: > On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: > This function acts as a replacement for both av_grow_packet() and > av_shrink_packet(), the latter whic

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-11 Thread James Almer
On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: On 3/10/2021 5:18 PM, Michael Niedermayer wrote: On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thomp

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 1:56 PM, Andreas Rheinhardt wrote: James Almer: On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Andreas Rheinhardt
James Almer: > On 3/11/2021 1:11 PM, Marton Balint wrote: >> >> >> On Thu, 11 Mar 2021, James Almer wrote: >> >>> This function acts as a replacement for both av_grow_packet() and >>> av_shrink_packet(), the latter which is now deprecated and will be >>> removed as >>> it does not correctly handle

[FFmpeg-devel] [PATCH] avdevice/decklink: add missing include for buffer_size_t

2021-03-11 Thread James Almer
Should fix compilation broken in f7abb53cb427515faac582f114ab97cbbd590280. Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 1 + libavdevice/decklink_enc.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 6c0a3

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
On 3/11/2021 1:11 PM, Marton Balint wrote: On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not correctly handle non-writable packets. I don't thi

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-11 Thread Michael Niedermayer
On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: > On 3/10/2021 5:18 PM, Michael Niedermayer wrote: > > On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote: > > > On 2/21/2021 6:04 PM, James Almer wrote: > > > > On 2/21/2021 5:29 PM, Mark Thompson wrote: > > > > > On 21/02/2021

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread Marton Balint
On Thu, 11 Mar 2021, James Almer wrote: This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not correctly handle non-writable packets. I don't think this is a good idea, av_shrink_packet canno

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Derek Buitenhuis
On 11/03/2021 15:38, Michael Niedermayer wrote: > You explicitly asked me to comment, and also stated that all options you > listed suck: Indeed, I was hoping for an insight that wasn't even worse hacks, though, or an opinion on which was Least Bad. Maybe I should have been more clear in my inten

[FFmpeg-devel] [PATCH 3/3] avformat: replace all uses of av_shrink_packet() with av_packet_resize()

2021-03-11 Thread James Almer
Signed-off-by: James Almer --- libavformat/4xm.c | 2 +- libavformat/adp.c | 2 +- libavformat/adxdec.c | 2 +- libavformat/asfdec_f.c | 2 +- libavformat/cdxl.c | 2 +- libavformat/dsicin.c | 2 +- libavformat/mxfdec.c | 4 ++-- libavformat/nutdec.c | 2 +- libavformat/nuv.

[FFmpeg-devel] [PATCH 2/3] avcodec: replace all uses of av_shrink_packet() with av_packet_resize()

2021-03-11 Thread James Almer
Signed-off-by: James Almer --- libavcodec/aliaspixenc.c| 2 +- libavcodec/cfhdenc.c| 2 +- libavcodec/exrenc.c | 2 +- libavcodec/hapenc.c | 2 +- libavcodec/libopenjpegenc.c | 2 +- libavcodec/libopusenc.c | 2 +- libavcodec/libtwolame.c | 2 +- libavcodec/rpz

[FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-11 Thread James Almer
This function acts as a replacement for both av_grow_packet() and av_shrink_packet(), the latter which is now deprecated and will be removed as it does not correctly handle non-writable packets. Signed-off-by: James Almer --- libavcodec/avpacket.c | 19 +++ libavcodec/packet.h

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Michael Niedermayer
On Thu, Mar 11, 2021 at 11:50:03AM +, Derek Buitenhuis wrote: > On 11/03/2021 08:36, Michael Niedermayer wrote: > > These are not enough to unambigously reverse engeneer the bug in the muxer > > is it true for every output of the muxer, does it always happen at the > > same position ? > > is th

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/4xm: Check pre_gb in decode_i_block()

2021-03-11 Thread Michael Niedermayer
On Wed, Mar 10, 2021 at 07:31:55PM +0100, Paul B Mahol wrote: > while there fix style issue will apply with the whitespace added between ){ thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excelle

Re: [FFmpeg-devel] [PATCH] avutil/frame: ensure the frame is writable in av_frame_copy()

2021-03-11 Thread James Almer
On 3/11/2021 10:56 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavutil/frame.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index eab51b6a32..ec79d053e1 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -8

Re: [FFmpeg-devel] [PATCH] avutil/frame: ensure the frame is writable in av_frame_copy()

2021-03-11 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavutil/frame.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index eab51b6a32..ec79d053e1 100644 > --- a/libavutil/frame.c > +++ b/libavutil/frame.c > @@ -800,6 +800,8 @@ int av_frame_copy(A

Re: [FFmpeg-devel] [PATCH 19/23] dnn/dnn_backend_native_layer_conv2d: Check allocation

2021-03-11 Thread Guo, Yejun
> -Original Message- > From: Pedro Arthur > Sent: 2021年3月11日 20:43 > To: Guo, Yejun > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 19/23] > dnn/dnn_backend_native_layer_conv2d: Check allocation > > Em qui., 11 de mar. de 2021 às 04:29, Guo, Yejun

Re: [FFmpeg-devel] [PATCH 45/48] doc/examples/vaapi_encode: use av_packet_alloc() to allocate packets

2021-03-11 Thread Michael Niedermayer
On Wed, Mar 10, 2021 at 06:25:58PM -0300, James Almer wrote: > On 3/10/2021 5:22 PM, Michael Niedermayer wrote: > > On Sat, Mar 06, 2021 at 06:45:57PM -0300, James Almer wrote: > > > On 3/6/2021 6:35 PM, Michael Niedermayer wrote: > > > > On Fri, Mar 05, 2021 at 01:33:36PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH 15/23] dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation

2021-03-11 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2021年3月11日 5:55 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Andreas Rheinhardt >> Subject: [FFmpeg-devel] [PATCH 15/23] >> dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid alloca

Re: [FFmpeg-devel] [PATCH] lavfi: add a libplacebo filter

2021-03-11 Thread Lynne
Mar 11, 2021, 12:34 by ffm...@haasn.xyz: > On Tue, 09 Mar 2021 23:55:36 +0100 Lynne wrote: > >> It's simpler because it makes no effort to integrate with anything >> we use. >> > > To be clear, I agree that integration with the hwcontext is the ultimate > goal. I'm just arguing about the usefulne

Re: [FFmpeg-devel] [PATCH 19/23] dnn/dnn_backend_native_layer_conv2d: Check allocation

2021-03-11 Thread Pedro Arthur
Em qui., 11 de mar. de 2021 às 04:29, Guo, Yejun escreveu: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Andreas Rheinhardt > > Sent: 2021年3月11日 5:55 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Andreas Rheinhardt > > Subject: [FFmpeg-devel] [PATCH 19/23] > > dnn/dnn_ba

[FFmpeg-devel] [PATCH v2] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-11 Thread James Almer
In addition to the fact that av_image_copy() cannot handle hardware pixel formats, h->short_ref[0]->f may not be writable at this point. Based on a patch by Hendrik Leppkes. Signed-off-by: James Almer --- This version fixes the fuzzed sample Michael talked about. libavcodec/h264_slice.c | 15

Re: [FFmpeg-devel] [PATCH] avutil/buffer_internal: Include internal for buffer_size_t

2021-03-11 Thread James Almer
On 3/11/2021 7:40 AM, Andreas Rheinhardt wrote: Fixes checkheaders. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavutil/buffer_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/buffer_internal.h b/libavutil/buffer_internal.h index 0b549e3a53..d902772

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Paul B Mahol
On Thu, Mar 11, 2021 at 12:58 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 11/03/2021 08:36, Michael Niedermayer wrote: > > These are not enough to unambigously reverse engeneer the bug in the > muxer > > is it true for every output of the muxer, does it always happen at the > > s

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Derek Buitenhuis
On 11/03/2021 08:36, Michael Niedermayer wrote: > These are not enough to unambigously reverse engeneer the bug in the muxer > is it true for every output of the muxer, does it always happen at the > same position ? > is the runaway delta always 8 ? > does it always coincide with the 2nd entry of s

Re: [FFmpeg-devel] [PATCH] lavfi: add a libplacebo filter

2021-03-11 Thread Niklas Haas
On Tue, 09 Mar 2021 23:55:36 +0100 Lynne wrote: > It's simpler because it makes no effort to integrate with anything > we use. To be clear, I agree that integration with the hwcontext is the ultimate goal. I'm just arguing about the usefulness of allowing vf_libplacebo to exist as-is until then.

[FFmpeg-devel] [PATCH] avutil/buffer_internal: Include internal for buffer_size_t

2021-03-11 Thread Andreas Rheinhardt
Fixes checkheaders. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavutil/buffer_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/buffer_internal.h b/libavutil/buffer_internal.h index 0b549e3a53..d902772ed3 100644 --- a/libavutil/buffer_internal.h +++ b/l

Re: [FFmpeg-devel] GSoC 2021

2021-03-11 Thread Thilo Borgmann
Hi! > Most people probably already know but just to be sure everyone knows > GSoC 2021 is 175h not 350h > https://groups.google.com/g/google-summer-of-code-discuss/c/GgvbLrFBcUQ?pli=1 > > Some project ideas may need to be adjusted accordingly FFmpeg has been accepted for GSoC this year [1]! Tha

Re: [FFmpeg-devel] [PATCH] libavformat/movenc: Support encryption of H265 stream in AnnexB format

2021-03-11 Thread Вадим Бездушный
Ping. вт, 9 мар. 2021 г. в 00:05, Вадим Бездушный : > Ping. > > This change is quite simple and should be quick to review. Feel free to > ask any questions > > On Mon, 1 Mar 2021, 14:54 Vadym Bezdushnyi, > wrote: > >> Add an ability to accept H265 AnnexB stream at encryption >> similar to how it

[FFmpeg-devel] Re: [PATCH] cmdutils: replace strncpy() with direct assignment

2021-03-11 Thread Anton Khirnov
Quoting Gregor Riepl (2021-03-09 18:54:11) > > // Change all the ' --' strings to '~--' so that > > // they can be identified as tokens. > > while ((conflist = strstr(str, " --")) != NULL) { > > -strncpy(conflist, "~--", 3); > > +conflist[0] = '~'; > > } > > Doe

Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_create

2021-03-11 Thread Xu, Guangxin
> -Original Message- > From: ffmpeg-devel On Behalf Of > Guangxin Xu > Sent: Friday, March 5, 2021 9:46 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source > device in qsv_device_create > > On T

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: using queue count to unref frame

2021-03-11 Thread Chen, Wenbin
> -Original Message- > From: Xiang, Haihao > Sent: Thursday, March 11, 2021 4:39 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Chen, Wenbin > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: using queue count > to unref frame > > On Thu, 2021-03-11 at 13:26 +0800, wenbin.c...@intel.co

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: using queue count to unref frame

2021-03-11 Thread Xiang, Haihao
On Thu, 2021-03-11 at 13:26 +0800, wenbin.c...@intel.com wrote: > From: "Chen,Wenbin" > > MSDK vc1 and av1 sometimes output frame into the same suface, but > ffmpeg-qsv assume the surface will be used only once, so it will > unref the frame when it receives the outpur surface. Now change typo? s

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-11 Thread Michael Niedermayer
On Wed, Mar 10, 2021 at 05:49:45PM +, Derek Buitenhuis wrote: > On 10/03/2021 17:24, Michael Niedermayer wrote: > > what does the muxer exactly do ? > > I provided an explanation of what is happening during the broken muxing > in my original email, as well as a sample, and a text dump of the

Re: [FFmpeg-devel] [PATCH 22/23] dnn/dnn_backend_native_layer_mathbinary: Fix leak upon error

2021-03-11 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年3月11日 5:55 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH 22/23] > dnn/dnn_backend_native_layer_mathbinary: Fix leak upon error > > Fixes Coverity issue #14